Francesco Romani has posted comments on this change.
Change subject: safelease: Increase spmprotect timeouts
..
Patch Set 2: Continuous-Integration+1
run "make check" locally
--
To view, visit https://gerrit.ovirt.org/46485
T
Francesco Romani has posted comments on this change.
Change subject: safelease: Unbreak safelease on systemd
..
Patch Set 2: Continuous-Integration+1
run "make check" locally
--
To view, visit https://gerrit.ovirt.org/46484
T
Francesco Romani has posted comments on this change.
Change subject: v2v: Fix getExternalVMs if getting disk size failed
..
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/46540
To unsubscribe, visit http
automat...@ovirt.org has posted comments on this change.
Change subject: tests: Fix and simplify cleanup after failures
..
Patch Set 3:
* Update tracker::IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no Bug-Url found.
--
T
Dan Kenigsberg has submitted this change and it was merged.
Change subject: tests: Fix and simplify cleanup after failures
..
tests: Fix and simplify cleanup after failures
If mount or umount failed, temporary images were not r
automat...@ovirt.org has posted comments on this change.
Change subject: netinfo: rework reporting of DHCPv4/6 on network devices
..
Patch Set 4:
* Update tracker::#1184497::OK
* Check Bug-Url::OK
* Check Public Bug::#1184497::
automat...@ovirt.org has posted comments on this change.
Change subject: v2v: Fix getExternalVMs if getting disk size failed
..
Patch Set 1:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, ma
Nir Soffer has uploaded a new change for review.
Change subject: v2v: Fix getExternalVMs if getting disk size failed
..
v2v: Fix getExternalVMs if getting disk size failed
In getExternalVMs we try to report the disk size, but if
Allon Mureinik has posted comments on this change.
Change subject: safelease: Unbreak safelease on systemd
..
Patch Set 2: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/46484
To unsubscribe, visit https://gerrit.ovi
Allon Mureinik has posted comments on this change.
Change subject: safelease: Increase spmprotect timeouts
..
Patch Set 2: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/46485
To unsubscribe, visit https://gerrit.ovi
automat...@ovirt.org has posted comments on this change.
Change subject: VolumeMetadata: Move instance validation
..
Patch Set 3:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure hea
automat...@ovirt.org has posted comments on this change.
Change subject: VolumeMetadata: Introduce class structure
..
Patch Set 20:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure h
automat...@ovirt.org has posted comments on this change.
Change subject: VolumeMetadata: Move oop to FileVolumeManifest
..
Patch Set 3:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make su
automat...@ovirt.org has posted comments on this change.
Change subject: VolumeMetadata: Move volumePath and validation
..
Patch Set 3:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make su
automat...@ovirt.org has posted comments on this change.
Change subject: ImageManifest: introduce ImageManifest class
..
Patch Set 12:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sur
automat...@ovirt.org has posted comments on this change.
Change subject: VolumeMetadata: Move imagePath and validation
..
Patch Set 3:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sur
automat...@ovirt.org has posted comments on this change.
Change subject: VolumeMetadata: Move voltype property
..
Patch Set 3:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
automat...@ovirt.org has posted comments on this change.
Change subject: safelease: Unbreak safelease on systemd
..
Patch Set 2: -Verified
* Update tracker::#1265177::OK
* Check Bug-Url::OK
* Check Public Bug::#1265177::OK, pub
automat...@ovirt.org has posted comments on this change.
Change subject: safelease: Increase spmprotect timeouts
..
Patch Set 2:
* Update tracker::#1265177::OK
* Check Bug-Url::OK
* Check Public Bug::#1265177::OK, public bug
*
Francesco Romani has submitted this change and it was merged.
Change subject: hostdev: change ownership for passthrough USB devices
..
hostdev: change ownership for passthrough USB devices
In order co correctly passthrough an U
automat...@ovirt.org has posted comments on this change.
Change subject: hostdev: change ownership for passthrough USB devices
..
Patch Set 2:
* Update tracker::#1248105::OK
* Set MODIFIED::bug 1248105#1248105IGNORE, no
Francesco Romani has posted comments on this change.
Change subject: hostdev: change ownership for passthrough USB devices
..
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/46527
To unsubscribe, visit ht
automat...@ovirt.org has posted comments on this change.
Change subject: network: add ifcfg write hook
..
Patch Set 2:
* update_tracker: OK
* Set MODIFIED::bug 965929#965929IGNORE, not oVirt prod but
--
To view, visit
Francesco Romani has posted comments on this change.
Change subject: network: add ifcfg write hook
..
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/46372
To unsubscribe, visit https://gerrit.ovirt.org/s
Francesco Romani has submitted this change and it was merged.
Change subject: network: add ifcfg write hook
..
network: add ifcfg write hook
Added a new hook point which is executed before and after
an ifcfg file is writen on t
automat...@ovirt.org has posted comments on this change.
Change subject: blockVolume: Fail if metadata overflows
..
Patch Set 2:
* Update tracker::#1258097::OK
* Set MODIFIED::bug 1258097#1258097IGNORE, not oVirt prod b
automat...@ovirt.org has posted comments on this change.
Change subject: volume: Support older engine or disks with long description
..
Patch Set 2:
* Update tracker::#1258097::OK
* Set MODIFIED::bug 1258097#1258097IGNO
Francesco Romani has posted comments on this change.
Change subject: blockVolume: Fail if metadata overflows
..
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/46329
To unsubscribe, visit https://gerrit.o
Francesco Romani has submitted this change and it was merged.
Change subject: blockVolume: Fail if metadata overflows
..
blockVolume: Fail if metadata overflows
We used to truncate silently volume metadata if it was too long, s
Francesco Romani has submitted this change and it was merged.
Change subject: volume: Support older engine or disks with long description
..
volume: Support older engine or disks with long description
New engine will limit the
automat...@ovirt.org has posted comments on this change.
Change subject: storage_exception: Show data in MetadataOverflowError
..
Patch Set 3:
* Update tracker::#1258097::OK
* Set MODIFIED::bug 1258097#1258097IGNORE, no
Francesco Romani has posted comments on this change.
Change subject: volume: Support older engine or disks with long description
..
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/46330
To unsubscribe, vi
Francesco Romani has submitted this change and it was merged.
Change subject: storage_exception: Show data in MetadataOverflowError
..
storage_exception: Show data in MetadataOverflowError
This should help to debug such issues.
Francesco Romani has posted comments on this change.
Change subject: storage_exception: Show data in MetadataOverflowError
..
Patch Set 2: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/45736
To unsubscribe, visit ht
Francesco Romani has posted comments on this change.
Change subject: vm: graphics: fix settings after restore
..
Patch Set 1: Verified+1
works, just deployed on the wrong host :)
--
To view, visit https://gerrit.ovirt.org/465
Francesco Romani has posted comments on this change.
Change subject: vm: graphics: fix settings after restore
..
Patch Set 1: Verified-1
failed verification
--
To view, visit https://gerrit.ovirt.org/46524
To unsubscribe, vis
automat...@ovirt.org has posted comments on this change.
Change subject: netinfo: rework reporting of DHCPv4/6 on network devices
..
Patch Set 3:
* Update tracker::#1184497::OK
* Check Bug-Url::OK
* Check Public Bug::#1184497::
automat...@ovirt.org has posted comments on this change.
Change subject: supervdsm: only trigger 'vfio' subsystem for VFIO devices
..
Patch Set 3:
* Update tracker::#1248105::OK
* Set MODIFIED::bug 1248105#1248105IGNORE
Francesco Romani has submitted this change and it was merged.
Change subject: supervdsm: only trigger 'vfio' subsystem for VFIO devices
..
supervdsm: only trigger 'vfio' subsystem for VFIO devices
In order to avoid triggering o
Francesco Romani has posted comments on this change.
Change subject: supervdsm: only trigger 'vfio' subsystem for VFIO devices
..
Patch Set 2: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/46508
To unsubscribe, visi
Francesco Romani has submitted this change and it was merged.
Change subject: supervdsm: rename appropriateDevice to
appropriateMultipathDevice
..
supervdsm: rename appropriateDevice to appropriateMultipathDevice
The appropria
Francesco Romani has posted comments on this change.
Change subject: supervdsm: rename appropriateDevice to
appropriateMultipathDevice
..
Patch Set 2: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/46507
To unsubscr
automat...@ovirt.org has posted comments on this change.
Change subject: supervdsm: rename appropriateDevice to
appropriateMultipathDevice
..
Patch Set 3:
* Update tracker::#1248105::OK
* Set MODIFIED::bug 1248105#1248105:
Francesco Romani has submitted this change and it was merged.
Change subject: supervdsm: move udevadm methods to udevadm module
..
supervdsm: move udevadm methods to udevadm module
udevadm module already exists, so there is no
automat...@ovirt.org has posted comments on this change.
Change subject: supervdsm: move udevadm methods to udevadm module
..
Patch Set 3:
* Update tracker::#1248105::OK
* Set MODIFIED::bug 1248105#1248105IGNORE, not oV
Francesco Romani has posted comments on this change.
Change subject: supervdsm: move udevadm methods to udevadm module
..
Patch Set 2: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/46506
To unsubscribe, visit https:
Francesco Romani has submitted this change and it was merged.
Change subject: supervdsm: generalize udevTrigger method
..
supervdsm: generalize udevTrigger method
udevTrigger in it's current state is tied to storage code as it
automat...@ovirt.org has posted comments on this change.
Change subject: supervdsm: generalize udevTrigger method
..
Patch Set 3:
* Update tracker::#1248105::OK
* Set MODIFIED::bug 1248105#1248105IGNORE, not oVirt prod
Francesco Romani has posted comments on this change.
Change subject: supervdsm: generalize udevTrigger method
..
Patch Set 2: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/46505
To unsubscribe, visit https://gerrit.
automat...@ovirt.org has posted comments on this change.
Change subject: supervdsm: remove guid from __udevReloadRules
..
Patch Set 3:
* Update tracker::#1248105::OK
* Set MODIFIED::bug 1248105#1248105IGNORE, not oVirt
Francesco Romani has submitted this change and it was merged.
Change subject: supervdsm: remove guid from __udevReloadRules
..
supervdsm: remove guid from __udevReloadRules
__udevReloadRules required 'guid' argument, but due to
Francesco Romani has posted comments on this change.
Change subject: supervdsm: remove guid from __udevReloadRules
..
Patch Set 2: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/46504
To unsubscribe, visit https://ge
automat...@ovirt.org has posted comments on this change.
Change subject: supervdsm: remove unneeded version check
..
Patch Set 3:
* Update tracker::#1248105::OK
* Set MODIFIED::bug 1248105#1248105IGNORE, not oVirt prod
Francesco Romani has posted comments on this change.
Change subject: supervdsm: remove unneeded version check
..
Patch Set 2: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/46503
To unsubscribe, visit https://gerrit.
Francesco Romani has submitted this change and it was merged.
Change subject: supervdsm: remove unneeded version check
..
supervdsm: remove unneeded version check
We now require higher version of systemd than 181, therefore che
automat...@ovirt.org has posted comments on this change.
Change subject: VolumeMetadata: Move volumePath and validation
..
Patch Set 2:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make su
automat...@ovirt.org has posted comments on this change.
Change subject: VolumeMetadata: Introduce class structure
..
Patch Set 19:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure h
automat...@ovirt.org has posted comments on this change.
Change subject: VolumeMetadata: Move imagePath and validation
..
Patch Set 2:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sur
automat...@ovirt.org has posted comments on this change.
Change subject: tests: Generalize sdm_indirection_tests
..
Patch Set 3:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure head
automat...@ovirt.org has posted comments on this change.
Change subject: VolumeMetadata: Move oop to FileVolumeManifest
..
Patch Set 2:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make su
automat...@ovirt.org has posted comments on this change.
Change subject: VolumeMetadata: Move voltype property
..
Patch Set 2:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
automat...@ovirt.org has posted comments on this change.
Change subject: ImageManifest: introduce ImageManifest class
..
Patch Set 11:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sur
automat...@ovirt.org has posted comments on this change.
Change subject: VolumeMetadata: Move instance validation
..
Patch Set 2:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure hea
Dan Kenigsberg has submitted this change and it was merged.
Change subject: net: mark test_getVdsStats as broken
..
net: mark test_getVdsStats as broken
Change-Id: I41a2023ea5821d0cb8e05ef74f0b60a6cd7498e1
Related-To: https://b
automat...@ovirt.org has posted comments on this change.
Change subject: supervdsm: only trigger 'vfio' subsystem for VFIO devices
..
Patch Set 2:
* Update tracker::#1248105::OK
* Check Bug-Url::OK
* Check Public Bug::#1248105:
automat...@ovirt.org has posted comments on this change.
Change subject: supervdsm: rename appropriateDevice to
appropriateMultipathDevice
..
Patch Set 2:
* Update tracker::#1248105::OK
* Check Bug-Url::OK
* Check Public Bug::
automat...@ovirt.org has posted comments on this change.
Change subject: Revert "network: bridge inherits DHCP unique identifier from
its DHCP-enabled port"
..
Patch Set 1:
* Update tracker::IGNORE, no Bug-Url found
--
To vi
automat...@ovirt.org has posted comments on this change.
Change subject: supervdsm: generalize udevTrigger method
..
Patch Set 2:
* Update tracker::#1248105::OK
* Check Bug-Url::OK
* Check Public Bug::#1248105::OK, public bug
*
Dan Kenigsberg has posted comments on this change.
Change subject: net: mark test_getVdsStats as broken
..
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/46240
To unsubscribe, visit https://gerrit.ovirt.
automat...@ovirt.org has posted comments on this change.
Change subject: net: mark test_getVdsStats as broken
..
Patch Set 2:
* Update tracker::IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no Bug-Url found.
--
To view, vi
automat...@ovirt.org has posted comments on this change.
Change subject: supervdsm: move udevadm methods to udevadm module
..
Patch Set 2:
* Update tracker::#1248105::OK
* Check Bug-Url::OK
* Check Public Bug::#1248105::OK, pub
automat...@ovirt.org has posted comments on this change.
Change subject: supervdsm: remove guid from __udevReloadRules
..
Patch Set 2:
* Update tracker::#1248105::OK
* Check Bug-Url::OK
* Check Public Bug::#1248105::OK, public
Dan Kenigsberg has abandoned this change.
Change subject: Revert "network: bridge inherits DHCP unique identifier from
its DHCP-enabled port"
..
Abandoned
--
To view, visit https://gerrit.ovirt.org/45686
To unsubscribe, visit
automat...@ovirt.org has posted comments on this change.
Change subject: supervdsm: remove unneeded version check
..
Patch Set 2:
* Update tracker::#1248105::OK
* Check Bug-Url::OK
* Check Public Bug::#1248105::OK, public bug
*
automat...@ovirt.org has posted comments on this change.
Change subject: Revert "net/api: drop support for legacy mgmt networks"
..
Patch Set 2:
* Update tracker::#1259000::OK
* Set MODIFIED::bug 1259000#1259000IGNORE,
automat...@ovirt.org has posted comments on this change.
Change subject: hostdev: fix addressing
..
Patch Set 2:
* Update tracker::#1248105::OK
* Check Bug-Url::OK
* Check Public Bug::#1248105::OK, public bug
* Check Product::#
Dan Kenigsberg has submitted this change and it was merged.
Change subject: Revert "net/api: drop support for legacy mgmt networks"
..
Revert "net/api: drop support for legacy mgmt networks"
This reverts commit d1e8f872b913e4b0
Martin Polednik has posted comments on this change.
Change subject: hostdev: fix addressing
..
Patch Set 1: Verified+1
--
To view, visit https://gerrit.ovirt.org/46528
To unsubscribe, visit https://gerrit.ovirt.org/settings
G
Martin Polednik has posted comments on this change.
Change subject: hostdev: change ownership for passthrough USB devices
..
Patch Set 1: Verified+1
--
To view, visit https://gerrit.ovirt.org/46527
To unsubscribe, visit https:
Martin Polednik has posted comments on this change.
Change subject: supervdsm: generalize udevTrigger method
..
Patch Set 1: Verified+1
--
To view, visit https://gerrit.ovirt.org/46505
To unsubscribe, visit https://gerrit.ovir
automat...@ovirt.org has posted comments on this change.
Change subject: net: fix test_setupNetworks_on_external_bond
..
Patch Set 3:
* Update tracker::IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no Bug-Url found.
--
To
Martin Polednik has posted comments on this change.
Change subject: supervdsm: only trigger 'vfio' subsystem for VFIO devices
..
Patch Set 1: Verified+1
--
To view, visit https://gerrit.ovirt.org/46508
To unsubscribe, visit ht
Martin Polednik has posted comments on this change.
Change subject: supervdsm: remove guid from __udevReloadRules
..
Patch Set 1: Verified+1
--
To view, visit https://gerrit.ovirt.org/46504
To unsubscribe, visit https://gerrit
Martin Polednik has posted comments on this change.
Change subject: supervdsm: rename appropriateDevice to
appropriateMultipathDevice
..
Patch Set 1: Verified+1
--
To view, visit https://gerrit.ovirt.org/46507
To unsubscribe,
Dan Kenigsberg has submitted this change and it was merged.
Change subject: net: fix test_setupNetworks_on_external_bond
..
net: fix test_setupNetworks_on_external_bond
In this test we manualy write slave names to bond's BONDIN
Martin Polednik has posted comments on this change.
Change subject: supervdsm: move udevadm methods to udevadm module
..
Patch Set 1: Verified+1
--
To view, visit https://gerrit.ovirt.org/46506
To unsubscribe, visit https://ge
Martin Polednik has posted comments on this change.
Change subject: supervdsm: remove unneeded version check
..
Patch Set 1: Verified+1
--
To view, visit https://gerrit.ovirt.org/46503
To unsubscribe, visit https://gerrit.ovir
automat...@ovirt.org has posted comments on this change.
Change subject: hostdev: fix addressing
..
Patch Set 1:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-
automat...@ovirt.org has posted comments on this change.
Change subject: hostdev: change ownership for passthrough USB devices
..
Patch Set 1:
* Update tracker::#1248105::OK
* Check Bug-Url::OK
* Check Public Bug::#1248105::OK,
Martin Polednik has uploaded a new change for review.
Change subject: hostdev: change ownership for passthrough USB devices
..
hostdev: change ownership for passthrough USB devices
In order co correctly passthrough an USB device
Hello Francesco Romani,
I'd like you to do a code review. Please visit
https://gerrit.ovirt.org/46528
to review the following change.
Change subject: hostdev: fix addressing
..
hostdev: fix addressing
HOSTDEV:
Libvirt (d
Ondřej Svoboda has posted comments on this change.
Change subject: netinfo: rework reporting of DHCPv4/6 on network devices
..
Patch Set 2: Code-Review-1
(1 comment)
https://gerrit.ovirt.org/#/c/46430/2/lib/vdsm/netinfo.py
Fil
Nir Soffer has posted comments on this change.
Change subject: debug: Add virt-alignment-scan.debug tool
..
Patch Set 4:
This version fixes the fork bomb that was the previous version.
--
To view, visit https://gerrit.ovirt.o
automat...@ovirt.org has posted comments on this change.
Change subject: debug: Add virt-alignment-scan.debug tool
..
Patch Set 4:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure he
Francesco Romani has posted comments on this change.
Change subject: volume: Support older engine or disks with long description
..
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/46330
To unsubscribe, vi
automat...@ovirt.org has posted comments on this change.
Change subject: vm: Workaround for libvirt bug in el7.2
..
Patch Set 2:
* Update tracker::#1251008::OK
--
To view, visit https://gerrit.ovirt.org/44489
To unsubscribe,
Nir Soffer has abandoned this change.
Change subject: vm: Workaround for libvirt bug in el7.2
..
Abandoned
Replaced by https://gerrit.ovirt.org/4834
--
To view, visit https://gerrit.ovirt.org/44489
To unsubscribe, visit https
Francesco Romani has posted comments on this change.
Change subject: blockVolume: Fail if metadata overflows
..
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/46329
To unsubscribe, visit https://gerrit.o
Francesco Romani has posted comments on this change.
Change subject: storage_exception: Show data in MetadataOverflowError
..
Patch Set 2: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/45736
To unsubscribe, visit ht
Dan Kenigsberg has submitted this change and it was merged.
Change subject: net: fix vdsmd service start
..
net: fix vdsmd service start
When one of VDSM networks is manually set DOWN and `service vdsmd
restart` is called, it f
1 - 100 of 192 matches
Mail list logo
