Change in vdsm[master]: tools: do not panic with sanlock empty groups

2015-09-27 Thread automation
automat...@ovirt.org has posted comments on this change. Change subject: tools: do not panic with sanlock empty groups .. Patch Set 1: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sur

Change in vdsm[master]: netinfo: make getNicsVlanAndBondingForNetwork more readable, ...

2015-09-27 Thread automation
automat...@ovirt.org has posted comments on this change. Change subject: netinfo: make getNicsVlanAndBondingForNetwork more readable, drop asserts .. Patch Set 7: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WAR

Change in vdsm[master]: netinfo: stop using getVlanID() in network.api

2015-09-27 Thread automation
automat...@ovirt.org has posted comments on this change. Change subject: netinfo: stop using getVlanID() in network.api .. Patch Set 2: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make su

Change in vdsm[master]: netinfo: Replace getVlanDevice/ID in bootstrap with ipwrappe...

2015-09-27 Thread osvoboda
Ondřej Svoboda has abandoned this change. Change subject: netinfo: Replace getVlanDevice/ID in bootstrap with ipwrapper.getLink .. Abandoned vdsm_reg has been removed and there are patches such as 45095 that take into conside

Change in vdsm[master]: netinfo: Replace getVlanDevice/ID in bootstrap with ipwrappe...

2015-09-27 Thread automation
automat...@ovirt.org has posted comments on this change. Change subject: netinfo: Replace getVlanDevice/ID in bootstrap with ipwrapper.getLink .. Patch Set 1: * Update tracker::IGNORE, no Bug-Url found -- To view, visit http

Change in vdsm[master]: netinfo: stop using getVlanID() in network.api

2015-09-27 Thread automation
automat...@ovirt.org has posted comments on this change. Change subject: netinfo: stop using getVlanID() in network.api .. Patch Set 1: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make su

Change in vdsm[master]: netinfo: stop using getVlanID() in network.api

2015-09-27 Thread osvoboda
Ondřej Svoboda has uploaded a new change for review. Change subject: netinfo: stop using getVlanID() in network.api .. netinfo: stop using getVlanID() in network.api The same information is already present in _netinfo. Change-I

Change in vdsm[master]: netinfo: make getNicsVlanAndBondingForNetwork more readable, ...

2015-09-27 Thread automation
automat...@ovirt.org has posted comments on this change. Change subject: netinfo: make getNicsVlanAndBondingForNetwork more readable, drop asserts .. Patch Set 6: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WAR

Change in vdsm[master]: netinfo: make getNicsVlanAndBondingForNetwork more readable, ...

2015-09-27 Thread osvoboda
Ondřej Svoboda has posted comments on this change. Change subject: netinfo: make getNicsVlanAndBondingForNetwork more readable, drop asserts .. Patch Set 5: (2 comments) https://gerrit.ovirt.org/#/c/45095/5/lib/vdsm/netinfo.p

Change in vdsm[master]: netinfoTests: add a test for getNicsVlanAndBondingForNetwork

2015-09-27 Thread automation
automat...@ovirt.org has posted comments on this change. Change subject: netinfoTests: add a test for getNicsVlanAndBondingForNetwork .. Patch Set 4: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url

Change in vdsm[master]: netinfoTests: add a test for getNicsVlanAndBondingForNetwork

2015-09-27 Thread osvoboda
Ondřej Svoboda has posted comments on this change. Change subject: netinfoTests: add a test for getNicsVlanAndBondingForNetwork .. Patch Set 3: (1 comment) https://gerrit.ovirt.org/#/c/45112/3/tests/netinfoTests.py File tests/

Change in vdsm[master]: netinfo: remove unused functions and make some private

2015-09-27 Thread osvoboda
Ondřej Svoboda has posted comments on this change. Change subject: netinfo: remove unused functions and make some private .. Patch Set 5: Verified+1 Once again I explored history of all affected functions and claim that the re

Change in vdsm[master]: netinfo: remove unused functions and make some private

2015-09-27 Thread automation
automat...@ovirt.org has posted comments on this change. Change subject: netinfo: remove unused functions and make some private .. Patch Set 5: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found,

Change in vdsm[master]: tests: Improve utils.retry tests

2015-09-27 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: tests: Improve utils.retry tests .. Patch Set 4: (1 comment) https://gerrit.ovirt.org/#/c/46399/4/tests/utilsTests.py File tests/utilsTests.py: Line 100:

Change in vdsm[master]: tests: Improve utils.retry tests

2015-09-27 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: tests: Improve utils.retry tests .. Patch Set 4: (1 comment) https://gerrit.ovirt.org/#/c/46399/4/tests/utilsTests.py File tests/utilsTests.py: Line 100:

Change in vdsm[master]: tests: Improve utils.retry tests

2015-09-27 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: tests: Improve utils.retry tests .. Patch Set 4: Verified+1 -- To view, visit https://gerrit.ovirt.org/46399 To unsubscribe, visit https://gerrit.ovirt.org/setting

Change in vdsm[master]: tests: Improve utils.retry tests

2015-09-27 Thread automation
automat...@ovirt.org has posted comments on this change. Change subject: tests: Improve utils.retry tests .. Patch Set 4: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matc

Change in vdsm[master]: utils: Consider sleep time in deadline calculation

2015-09-27 Thread automation
automat...@ovirt.org has posted comments on this change. Change subject: utils: Consider sleep time in deadline calculation .. Patch Set 4: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, mak

Change in vdsm[master]: tests: Improve utils.retry tests

2015-09-27 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: tests: Improve utils.retry tests .. Patch Set 2: (1 comment) https://gerrit.ovirt.org/#/c/46399/2/tests/utilsTests.py File tests/utilsTests.py: Line 121: def

Change in vdsm[master]: utils: Consider sleep time in deadline calculation

2015-09-27 Thread automation
automat...@ovirt.org has posted comments on this change. Change subject: utils: Consider sleep time in deadline calculation .. Patch Set 3: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, mak

Change in vdsm[master]: tests: Improve utils.retry tests

2015-09-27 Thread automation
automat...@ovirt.org has posted comments on this change. Change subject: tests: Improve utils.retry tests .. Patch Set 3: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matc

Change in vdsm[master]: tests: Improve utils.retry tests

2015-09-27 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: tests: Improve utils.retry tests .. Patch Set 2: (1 comment) https://gerrit.ovirt.org/#/c/46399/2/tests/utilsTests.py File tests/utilsTests.py: Line 121: def

Change in vdsm[master]: tests: Improve utils.retry tests

2015-09-27 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: tests: Improve utils.retry tests .. Patch Set 2: Verified+1 This version makes monotonic time monkeypatching more clear. -- To view, visit https://gerrit.ovirt.or

Change in vdsm[master]: utils: Consider sleep time in deadline calculation

2015-09-27 Thread automation
automat...@ovirt.org has posted comments on this change. Change subject: utils: Consider sleep time in deadline calculation .. Patch Set 2: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, mak

Change in vdsm[master]: tests: Improve utils.retry tests

2015-09-27 Thread automation
automat...@ovirt.org has posted comments on this change. Change subject: tests: Improve utils.retry tests .. Patch Set 2: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matc

Change in vdsm[master]: tests: Improve utils.retry tests

2015-09-27 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: tests: Improve utils.retry tests .. Patch Set 1: Code-Review-1 (2 comments) Needs more obvious monkeypatching. https://gerrit.ovirt.org/#/c/46399/1//COMMIT_MSG Co

Change in vdsm[master]: tests: Improve utils.retry tests

2015-09-27 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: tests: Improve utils.retry tests .. Patch Set 1: (3 comments) https://gerrit.ovirt.org/#/c/46399/1//COMMIT_MSG Commit Message: Line 11: This patch adds 4 test

Change in vdsm[master]: automation: Disable tests requiring tun device

2015-09-27 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: automation: Disable tests requiring tun device .. Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/46641 To unsubscribe, visit https://ger