Nir Soffer has posted comments on this change. Change subject: tests: Improve utils.retry tests ......................................................................
Patch Set 4: (1 comment) https://gerrit.ovirt.org/#/c/46399/4/tests/utilsTests.py File tests/utilsTests.py: Line 100: # Make sure we had the proper amount of iterations before failing Line 101: self.assertEquals(counter[0], limit) Line 102: Line 103: @brokentest("deadline is not respected") Line 104: def testTimeoutDeadlineReached(self): > Nir, I don't understand the broken condition. Are you referring to us not u Yes Line 105: # time action Line 106: # 0 first attempt Line 107: # 1 sleep Line 108: # 2 second attempt -- To view, visit https://gerrit.ovirt.org/46399 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I62062f36e20d263b1aed64135345d496cb7cfd61 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer <[email protected]> Gerrit-Reviewer: Adam Litke <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Edward Haas <[email protected]> Gerrit-Reviewer: Francesco Romani <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer <[email protected]> Gerrit-Reviewer: Piotr Kliczewski <[email protected]> Gerrit-Reviewer: Yaniv Bronhaim <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
