Nir Soffer has posted comments on this change.
Change subject: qemuimg: add support for convert progress
..
Patch Set 15: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/33910
To unsubscribe, visit https://gerrit.ovir
Nir Soffer has posted comments on this change.
Change subject: misc: remove cp parameter
..
Patch Set 2: Code-Review-1
(1 comment)
https://gerrit.ovirt.org/#/c/45613/2/vdsm/storage/misc.py
File vdsm/storage/misc.py:
Line 448:
Nir Soffer has posted comments on this change.
Change subject: storage: Initial size for thin provisioning disk
..
Patch Set 6: Code-Review-1
(15 comments)
This is full of nice things. Just need to fix validateSize and cleanup
Adam Litke has posted comments on this change.
Change subject: qemuimg: add support for convert progress
..
Patch Set 15: Verified+1
--
To view, visit https://gerrit.ovirt.org/33910
To unsubscribe, visit https://gerrit.ovirt.o
automat...@ovirt.org has posted comments on this change.
Change subject: utils: split out execCmd wrapping logic
..
Patch Set 4:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure head
automat...@ovirt.org has posted comments on this change.
Change subject: qemuimg: add support for convert progress
..
Patch Set 15:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure h
Adam Litke has posted comments on this change.
Change subject: utils: split out execCmd wrapping logic
..
Patch Set 4: Verified+1
--
To view, visit https://gerrit.ovirt.org/47107
To unsubscribe, visit https://gerrit.ovirt.org/
Nir Soffer has posted comments on this change.
Change subject: qemuimg: add support for convert progress
..
Patch Set 14: Code-Review+2
Adam, is this rebased on current master? That error in the ci should be fixed
now.
--
To
Adam Litke has posted comments on this change.
Change subject: qemuimg: add support for convert progress
..
Patch Set 14:
Ahh, love the spurious CI failures always happening at the perfect time.
--
To view, visit https://gerr
automat...@ovirt.org has posted comments on this change.
Change subject: qemuimg: add support for convert progress
..
Patch Set 14:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure h
Nir Soffer has posted comments on this change.
Change subject: vdsm-tool: Do not panic with sanlock empty groups
..
Patch Set 2: -Code-Review
For some reason the CI won't run and I cannot even trigger a build manually.
--
To
Nir Soffer has posted comments on this change.
Change subject: vdsm-tool: Do not panic with sanlock empty groups
..
Patch Set 2: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/47105
To unsubscribe, visit https://gerr
Nir Soffer has posted comments on this change.
Change subject: vdsm-tool: Do not panic with sanlock empty groups
..
Patch Set 2: Verified+1
Tested on rhel 6.7 and rhel 7.1
--
To view, visit https://gerrit.ovirt.org/47105
To u
Nir Soffer has posted comments on this change.
Change subject: utils: split out execCmd wrapping logic
..
Patch Set 3: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/47107
To unsubscribe, visit https://gerrit.ovirt.o
automat...@ovirt.org has posted comments on this change.
Change subject: utils: split out execCmd wrapping logic
..
Patch Set 3:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure head
automat...@ovirt.org has posted comments on this change.
Change subject: qemuimg: add support for convert progress
..
Patch Set 13:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure h
Adam Litke has posted comments on this change.
Change subject: utils: split out execCmd wrapping logic
..
Patch Set 1:
(3 comments)
https://gerrit.ovirt.org/#/c/47107/1/lib/vdsm/utils.py
File lib/vdsm/utils.py:
Line 666
Line
Ondřej Svoboda has posted comments on this change.
Change subject: hooks: ovs: move libvirt configuration into a separate module
..
Patch Set 4: Code-Review-1
(6 comments)
Thank you for the previous round of improvements – and
Nir Soffer has posted comments on this change.
Change subject: utils: split out execCmd wrapping logic
..
Patch Set 2: Code-Review+1
Nice! lets have Francesco and Piotr review.
--
To view, visit https://gerrit.ovirt.org/47107
Nir Soffer has posted comments on this change.
Change subject: qemuimg: add support for convert progress
..
Patch Set 12: Code-Review-1
Adam, please check my comments from version 11.
--
To view, visit https://gerrit.ovirt.or
automat...@ovirt.org has posted comments on this change.
Change subject: utils: split out execCmd wrapping logic
..
Patch Set 2:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure head
automat...@ovirt.org has posted comments on this change.
Change subject: qemuimg: add support for convert progress
..
Patch Set 12:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure h
Petr Horáček has uploaded a new change for review.
Change subject: hooks: ovs: use six.iteritems
..
hooks: ovs: use six.iteritems
Change-Id: I3d098a3142f61e927e047058424d2bd6f6955145
Signed-off-by: Petr Horáček
---
M vdsm_hooks
automat...@ovirt.org has posted comments on this change.
Change subject: hooks: ovs: use six.iteritems
..
Patch Set 1:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches
Petr Horáček has posted comments on this change.
Change subject: hooks: ovs: move libvirt configuration into a separate module
..
Patch Set 3:
(4 comments)
https://gerrit.ovirt.org/#/c/46910/3/vdsm_hooks/ovs/ovs_before_network
automat...@ovirt.org has posted comments on this change.
Change subject: hooks: ovs: move libvirt configuration into a separate module
..
Patch Set 4:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url
Petr Horáček has posted comments on this change.
Change subject: automation: add build_artifacts
..
Patch Set 3: Verified+1
../jenkins/mock_configs/mock_runner.sh --mock-confs-dir
../jenkins/mock_configs --build-only fc21
Petr Horáček has posted comments on this change.
Change subject: automation: enable pep8
..
Patch Set 3: Verified+1
../jenkins/mock_configs/mock_runner.sh --mock-confs-dir
../jenkins/mock_configs --build-only fc21 fc22 el7
automat...@ovirt.org has posted comments on this change.
Change subject: fix pep8 errors
..
Patch Set 3:
* Update tracker::#1268229::OK
* Check Bug-Url::OK
* Check Public Bug::#1268229::OK, public bug
* Check Product::#1268229:
Petr Horáček has posted comments on this change.
Change subject: fix pep8 errors
..
Patch Set 3: Verified+1
Passed inside a mock runner.
--
To view, visit https://gerrit.ovirt.org/46930
To unsubscribe, visit https://gerrit.ov
Petr Horáček has posted comments on this change.
Change subject: tests: fixed mangled names in crossImportTests
..
Patch Set 1: Verified+1
Test passed inside a mock runner.
--
To view, visit https://gerrit.ovirt.org/47132
To
automat...@ovirt.org has posted comments on this change.
Change subject: fix pep8 errors
..
Patch Set 2:
* Update tracker::#1268229::OK
* Check Bug-Url::OK
* Check Public Bug::#1268229::OK, public bug
* Check Product::#1268229:
Hello Francesco Romani,
I'd like you to do a code review. Please visit
https://gerrit.ovirt.org/47132
to review the following change.
Change subject: tests: fixed mangled names in crossImportTests
..
tests: fixed mangled
automat...@ovirt.org has posted comments on this change.
Change subject: tests: fixed mangled names in crossImportTests
..
Patch Set 1:
* Update tracker::#1268229::OK
* Check Bug-Url::OK
* Check Public Bug::#1268229::OK, public
automat...@ovirt.org has posted comments on this change.
Change subject: automation: enable pep8
..
Patch Set 3:
* Update tracker::#1268229::OK
* Check Bug-Url::OK
* Check Public Bug::#1268229::OK, public bug
* Check Product::#
automat...@ovirt.org has posted comments on this change.
Change subject: automation: add build_artifacts
..
Patch Set 3:
* Update tracker::#1268229::OK
* Check Bug-Url::OK
* Check Public Bug::#1268229::OK, public bug
* Check Pr
automat...@ovirt.org has posted comments on this change.
Change subject: vdsm: extract arch-dependent details
..
Patch Set 2:
* Update tracker::IGNORE, no Bug-Url found
--
To view, visit https://gerrit.ovirt.org/31297
To unsu
Allon Mureinik has abandoned this change.
Change subject: vdsm: extract arch-dependent details
..
Abandoned
outdated, feel free to reopen if you want to revive it.
--
To view, visit https://gerrit.ovirt.org/31297
To unsubscri
automat...@ovirt.org has posted comments on this change.
Change subject: vdsm: require kernel-2.6.32-465 on for NFSv4 fixes
..
Patch Set 2:
* Update tracker::IGNORE, no Bug-Url found
--
To view, visit https://gerrit.ovirt.org
Allon Mureinik has abandoned this change.
Change subject: vdsm: require kernel-2.6.32-465 on for NFSv4 fixes
..
Abandoned
We no longer support EL6, EL7 uses 3.x kernels
--
To view, visit https://gerrit.ovirt.org/33810
To unsu
automat...@ovirt.org has posted comments on this change.
Change subject: tests: added NFS support to functional tests
..
Patch Set 2:
* Update tracker::IGNORE, no Bug-Url found
--
To view, visit https://gerrit.ovirt.org/32990
automat...@ovirt.org has posted comments on this change.
Change subject: tests: new functional tests for vdsm storage
..
Patch Set 9:
* Update tracker::IGNORE, no Bug-Url found
--
To view, visit https://gerrit.ovirt.org/32496
automat...@ovirt.org has posted comments on this change.
Change subject: tests: introducing whitebox tests
..
Patch Set 5:
* Update tracker::IGNORE, no Bug-Url found
--
To view, visit https://gerrit.ovirt.org/29745
To unsubsc
Allon Mureinik has abandoned this change.
Change subject: tests: introducing whitebox tests
..
Abandoned
outdated, feel free to reopen if you want to revive it.
--
To view, visit https://gerrit.ovirt.org/29745
To unsubscribe,
Allon Mureinik has abandoned this change.
Change subject: tests: added NFS support to functional tests
..
Abandoned
outdated, feel free to reopen if you want to revive it.
--
To view, visit https://gerrit.ovirt.org/32990
To u
Allon Mureinik has abandoned this change.
Change subject: tests: new functional tests for vdsm storage
..
Abandoned
outdated, feel free to reopen if you want to revive it.
--
To view, visit https://gerrit.ovirt.org/32496
To u
automat...@ovirt.org has posted comments on this change.
Change subject: tests: use 'localhost' explicitly in test
..
Patch Set 1:
* Update tracker::IGNORE, no Bug-Url found
--
To view, visit https://gerrit.ovirt.org/28107
To
Allon Mureinik has abandoned this change.
Change subject: tests: use 'localhost' explicitly in test
..
Abandoned
outdated, feel free to reopen if you want to revive it.
--
To view, visit https://gerrit.ovirt.org/28107
To unsu
Ido Barkan has posted comments on this change.
Change subject: hooks: ovs: move libvirt configuration into a separate module
..
Patch Set 3:
(2 comments)
https://gerrit.ovirt.org/#/c/46910/3/vdsm_hooks/ovs/ovs_before_network_s
Ido Barkan has posted comments on this change.
Change subject: tests: net: use new veth_pair in networkTestsOVS.py
..
Patch Set 2: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/46914
To unsubscribe, visit https://ge
Allon Mureinik has posted comments on this change.
Change subject: vdsm-tool: Do not panic with sanlock empty groups
..
Patch Set 2:
Fixed bug url for 3.5 clone
--
To view, visit https://gerrit.ovirt.org/47105
To unsubscribe,
automat...@ovirt.org has posted comments on this change.
Change subject: vdsm-tool: Do not panic with sanlock empty groups
..
Patch Set 2:
* update_tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1269886::ERROR, private bu
Ido Barkan has posted comments on this change.
Change subject: netinfoTests: add a test for getNicsVlanAndBondingForNetwork
..
Patch Set 7: -Code-Review
ok, so removing +1 for now...
--
To view, visit https://gerrit.ovirt.org
Freddy Rolland has posted comments on this change.
Change subject: storage: Initial size for thin provisioning disk
..
Patch Set 5:
(7 comments)
https://gerrit.ovirt.org/#/c/46417/5/client/vdsClient.py
File client/vdsClient.py
automat...@ovirt.org has posted comments on this change.
Change subject: storage: Initial size for thin provisioning disk
..
Patch Set 6:
* Update tracker::#1221603::OK
* Check Bug-Url::OK
* Check Public Bug::#1221603::OK, publ
Ondřej Svoboda has posted comments on this change.
Change subject: netinfoTests: add a test for getNicsVlanAndBondingForNetwork
..
Patch Set 7:
Ido, I am adding more tests to this patch (for getVlansForIface and
importantly, g
Allon Mureinik has posted comments on this change.
Change subject: vdsm-tool: Do not panic with sanlock empty groups
..
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/47104
To unsubscribe, visit https://
Ondřej Svoboda has posted comments on this change.
Change subject: netinfo: stop using getVlanID() in network.api
..
Patch Set 4:
(1 comment)
https://gerrit.ovirt.org/#/c/46741/4/vdsm/network/api.py
File vdsm/network/api.py:
Allon Mureinik has posted comments on this change.
Change subject: spec: Require newer kernel version on Fedora
..
Patch Set 5: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/44851
To unsubscribe, visit https://gerri
Amit Aviram has posted comments on this change.
Change subject: vm.py: State saving in hotunplugDisk.
..
Patch Set 3:
nsoffer: I'm waiting for https://gerrit.ovirt.org/#/c/47039/ to get in, as the
patch you asked about relies
Amit Aviram has posted comments on this change.
Change subject: vm.py: State saving in hotunplugDisk.
..
Patch Set 3: Verified+1
--
To view, visit https://gerrit.ovirt.org/45928
To unsubscribe, visit https://gerrit.ovirt.org/s
61 matches
Mail list logo
