Yaniv Bronhaim has posted comments on this change.
Change subject: Adding toolTests.py to python3 check modules
..
Patch Set 7:
(1 comment)
https://gerrit.ovirt.org/#/c/48052/7/lib/vdsm/tool/configfile.py
File lib/vdsm/tool/co
Ido Barkan has posted comments on this change.
Change subject: netinfo: rework reporting of DHCPv4/6 on network devices
..
Patch Set 2: Code-Review-1
(4 comments)
just for answering my paranoid questions so I am sure I underst
Ido Barkan has posted comments on this change.
Change subject: netinfo: rework reporting of DHCPv4/6 on network devices
..
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/48513
To unsubscribe, visit https
Yaniv Bronhaim has posted comments on this change.
Change subject: Adding python3 run for nosetests
..
Patch Set 10: Verified+1
--
To view, visit https://gerrit.ovirt.org/48051
To unsubscribe, visit https://gerrit.ovirt.org/se
gerrit-hooks has posted comments on this change.
Change subject: Adding python3 run for nosetests
..
Patch Set 10:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bu
Ido Barkan has posted comments on this change.
Change subject: net: ifup ignores invalid gateway settings
..
Patch Set 1:
can you please print the output of 'ip r' after you ifup such device? is there
a difference between el6
Idan Shaby has uploaded a new change for review.
Change subject: clusterlock: Remove unneeded workaround
..
clusterlock: Remove unneeded workaround
Sanlock 2.8 had a off-by-one bug when calling get_hosts with a host id,
returnin
gerrit-hooks has posted comments on this change.
Change subject: clusterlock: Remove unneeded workaround
..
Patch Set 1:
* #1131192::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1131192::OK, public bug
* Check Pr
Idan Shaby has posted comments on this change.
Change subject: clusterlock: Remove unneeded workaround
..
Patch Set 1: Verified+1
--
To view, visit https://gerrit.ovirt.org/48574
To unsubscribe, visit https://gerrit.ovirt.org/
Allon Mureinik has posted comments on this change.
Change subject: clusterlock: Remove unneeded workaround
..
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/48574
To unsubscribe, visit https://gerrit.ovi
Dan Kenigsberg has posted comments on this change.
Change subject: vm: Support for non-ascii vm name
..
Patch Set 1: Code-Review-1
I am really surprised that Engine passes non-unicode vmName. The ancient
virt/vm.py code assume
Allon Mureinik has posted comments on this change.
Change subject: spec: fix requirement version
..
Patch Set 3: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/47554
To unsubscribe, visit https://gerrit.ovirt.org/set
Yeela Kaplan has posted comments on this change.
Change subject: janitorial: bindingxmlrpc: remove Python-2.6 specific code
..
Patch Set 1: Verified+1
Verified on ovirt-3.6 branch.
--
To view, visit https://gerrit.ovirt.org/4
Yeela Kaplan has posted comments on this change.
Change subject: janitorial: drop python-2.6-specific code
..
Patch Set 1: Verified+1
Verified on ovirt-3.6 branch.
--
To view, visit https://gerrit.ovirt.org/47995
To unsubscri
Yeela Kaplan has posted comments on this change.
Change subject: Remove unused sd setMetadata and rotateFiles
..
Patch Set 5:
Done
--
To view, visit https://gerrit.ovirt.org/45613
To unsubscribe, visit https://gerrit.ovirt.or
gerrit-hooks has posted comments on this change.
Change subject: misc: remove rotateFiles
..
Patch Set 1:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: '
Yeela Kaplan has uploaded a new change for review.
Change subject: misc: remove rotateFiles
..
misc: remove rotateFiles
After removing the last usage of rotateFiles
that was in sd setMetadata we can
now remove this unused method
gerrit-hooks has posted comments on this change.
Change subject: sd: Remove unused setMetadata
..
Patch Set 6:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Ur
Ondřej Svoboda has posted comments on this change.
Change subject: netinfo: rework reporting of DHCPv4/6 on network devices
..
Patch Set 2:
(4 comments)
https://gerrit.ovirt.org/#/c/48399/2/lib/vdsm/netinfo.py
File lib/vdsm/ne
gerrit-hooks has posted comments on this change.
Change subject: misc: remove rotateFiles
..
Patch Set 2:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: '
gerrit-hooks has posted comments on this change.
Change subject: misc: remove rotateFiles
..
Patch Set 1:
* propagate_review_values: OK
--
To view, visit https://gerrit.ovirt.org/48577
To unsubscribe, visit https://gerrit.ovi
Ido Barkan has posted comments on this change.
Change subject: netinfo: rework reporting of DHCPv4/6 on network devices
..
Patch Set 2: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/48399
To unsubscribe, visit https
Allon Mureinik has posted comments on this change.
Change subject: fileUtils: Convert unhelpful warnings to debug messages
..
Patch Set 7:
___ _____ _
|\ /|( \( \ ( \ ( ___
gerrit-hooks has posted comments on this change.
Change subject: hsm : Do not resize on Disconnect Storage Server
..
Patch Set 1:
* #1281909::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1281909::OK, public bug
*
Barak Korren has posted comments on this change.
Change subject: build: Cleanup conditionals in the build system
..
Patch Set 6:
If I understand correctly we don't need "--enable-hooks --disable-gluster-mgmt"
for RHEV since th
Nir Soffer has posted comments on this change.
Change subject: vm: Support for non-ascii vm name
..
Patch Set 1:
Dan, engine sends unicode name, the code you quote proves that
vdsm expect to get unicode name, so what can we fix
Nir Soffer has posted comments on this change.
Change subject: build: Cleanup conditionals in the build system
..
Patch Set 6: Code-Review-1
(1 comment)
Need to remove redundant --enable-hooks under rhev_build
https://gerrit.
Ido Barkan has uploaded a new change for review.
Change subject: net: remove mac address from ifcfg
..
net: remove mac address from ifcfg
In el7, the HWADDR field in ifcfg files is no longer needed by udev
and is considered a ba
gerrit-hooks has posted comments on this change.
Change subject: net: remove mac address from ifcfg
..
Patch Set 1:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'B
Nir Soffer has posted comments on this change.
Change subject: build: Cleanup conditionals in the build system
..
Patch Set 6:
Barak, --disable-gluster-mgmt is separate from rehv, and so it --enable-hooks.
enabling hooks was a
Barak Korren has posted comments on this change.
Change subject: build: Cleanup conditionals in the build system
..
Patch Set 6:
(1 comment)
https://gerrit.ovirt.org/#/c/48446/6/vdsm.spec.in
File vdsm.spec.in:
Line 626: %if %
Nir Soffer has posted comments on this change.
Change subject: hsm : Do not resize on Disconnect Storage Server
..
Patch Set 1: Code-Review+2
(1 comment)
Please test.
https://gerrit.ovirt.org/#/c/48578/1/vdsm/storage/sdc.py
F
Nir Soffer has posted comments on this change.
Change subject: build: Cleanup conditionals in the build system
..
Patch Set 6:
(1 comment)
https://gerrit.ovirt.org/#/c/48446/6/vdsm.spec.in
File vdsm.spec.in:
Line 626: %if %{w
Nir Soffer has posted comments on this change.
Change subject: misc: remove rotateFiles
..
Patch Set 2: Code-Review-1
Please reverse the order of the patches.
1. remove rotateFiles - we can merge it now since it does not do an
Ido Barkan has posted comments on this change.
Change subject: net: remove mac address from ifcfg
..
Patch Set 1: Verified+1
--
To view, visit https://gerrit.ovirt.org/48579
To unsubscribe, visit https://gerrit.ovirt.org/setti
Nir Soffer has restored this change.
Change subject: lvm: Fail loudly if called with unexpected input
..
Restored
Still needed
--
To view, visit https://gerrit.ovirt.org/37329
To unsubscribe, visit https://gerrit.ovirt.org/se
Nir Soffer has restored this change.
Change subject: lvm: Exclude faulty devices from lvm long filter
..
Restored
Not fixed yet, until we have a better solution, this patch should be here.
--
To view, visit https://gerrit.ovi
Barak Korren has posted comments on this change.
Change subject: build: Cleanup conditionals in the build system
..
Patch Set 6:
Your last comment makes no sense. --enable-rhev-build is NOT building for a
particular distro, it
Nir Soffer has posted comments on this change.
Change subject: clusterlock: Remove unneeded workaround
..
Patch Set 1: Code-Review-1
Please backport the patch from master, the metadata added by gerrit when a
patch is merged is
Dan Kenigsberg has posted comments on this change.
Change subject: net: remove mac address from ifcfg
..
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/48579
To unsubscribe, visit https://gerrit.ovirt.or
gerrit-hooks has posted comments on this change.
Change subject: janitorial: bindingxmlrpc: remove Python-2.6 specific code
..
Patch Set 2:
* Update tracker: IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no Bug-Url found.
-
Dan Kenigsberg has submitted this change and it was merged.
Change subject: janitorial: bindingxmlrpc: remove Python-2.6 specific code
..
janitorial: bindingxmlrpc: remove Python-2.6 specific code
Change-Id: I4f296c8fb57c196bff
Hello Fred Rolland,
I'd like you to do a code review. Please visit
https://gerrit.ovirt.org/48578
to review the following change.
Change subject: hsm : Do not resize on Disconnect Storage Server
..
hsm : Do not resize on
Nir Soffer has posted comments on this change.
Change subject: build: Cleanup conditionals in the build system
..
Patch Set 6:
Barak, it does not matter how do you use particular build. Vdsm upstream code
does not care about a
gerrit-hooks has posted comments on this change.
Change subject: clusterlock: Remove unneeded workaround
..
Patch Set 2:
* #1131192::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1131192::OK, public bug
* Check Pr
Nir Soffer has posted comments on this change.
Change subject: clusterlock: Remove unneeded workaround
..
Patch Set 2: -Code-Review
Thanks
--
To view, visit https://gerrit.ovirt.org/48574
To unsubscribe, visit https://gerrit.
Idan Shaby has posted comments on this change.
Change subject: clusterlock: Remove unneeded workaround
..
Patch Set 2:
This patch was verified the same way patch [1] was verified. For details,
please see the comment in [1].
[
Yaniv Bronhaim has posted comments on this change.
Change subject: build: Cleanup conditionals in the build system
..
Patch Set 6:
(1 comment)
https://gerrit.ovirt.org/#/c/48446/6/vdsm.spec.in
File vdsm.spec.in:
Line 626: %if
Ondřej Svoboda has posted comments on this change.
Change subject: net: remove mac address from ifcfg
..
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/48579
To unsubscribe, visit https://gerrit.ovirt.or
Freddy Rolland has posted comments on this change.
Change subject: hsm : Do not resize on Disconnect Storage Server
..
Patch Set 1: Verified+1
Tested above patch https://gerrit.ovirt.org/#/c/48483/3
No errors as mentioned in bu
Allon Mureinik has posted comments on this change.
Change subject: hsm : Do not resize on Disconnect Storage Server
..
Patch Set 1:
(4 comments)
https://gerrit.ovirt.org/#/c/48578/1//COMMIT_MSG
Commit Message:
Line 8:
Line 9
Edward Haas has posted comments on this change.
Change subject: net: remove mac address from ifcfg
..
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/48579
To unsubscribe, visit https://gerrit.ovirt.org/s
Nir Soffer has posted comments on this change.
Change subject: hsm : Do not resize on Disconnect Storage Server
..
Patch Set 1: Code-Review+1
(1 comment)
Please address Allon comments on the commit message.
https://gerrit.ovi
Nir Soffer has posted comments on this change.
Change subject: clusterlock: Remove unneeded workaround
..
Patch Set 2: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/48574
To unsubscribe, visit https://gerrit.ovirt.o
Nir Soffer has posted comments on this change.
Change subject: clusterlock: Remove unneeded workaround
..
Patch Set 2:
Francesco, the jenkinks failure are not relevant, please fix the CI score.
--
To view, visit https://gerri
Nir Soffer has posted comments on this change.
Change subject: sd: Remove unused setMetadata
..
Patch Set 6: Code-Review-1
(4 comments)
https://gerrit.ovirt.org/#/c/45613/6//COMMIT_MSG
Commit Message:
Line 5: CommitDate: 2015
Nir Soffer has posted comments on this change.
Change subject: Remove usage of deathSignal
..
Patch Set 3: Code-Review-1
(9 comments)
The current code is not ready for this change.
https://gerrit.ovirt.org/#/c/48121/3//COMMIT
Nir Soffer has posted comments on this change.
Change subject: storage: perform image deletion in task
..
Patch Set 3: Code-Review-1
(7 comments)
https://gerrit.ovirt.org/#/c/48477/3/vdsm/storage/blockSD.py
File vdsm/storage/b
gerrit-hooks has posted comments on this change.
Change subject: build: Cleanup conditionals in the build system
..
Patch Set 7:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure head
Nir Soffer has posted comments on this change.
Change subject: build: Cleanup conditionals in the build system
..
Patch Set 7: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/48446
To unsubscribe, visit https://gerrit
Nir Soffer has posted comments on this change.
Change subject: build: Cleanup conditionals in the build system
..
Patch Set 7:
Jenkins failure should be fixed now on master, can you rebase?
--
To view, visit https://gerrit.ov
Nir Soffer has posted comments on this change.
Change subject: monitor: Add udev monitor
..
Patch Set 7:
(2 comments)
https://gerrit.ovirt.org/#/c/47729/7/lib/vdsm/udev/monitor.py
File lib/vdsm/udev/monitor.py:
Line 34: m
gerrit-hooks has posted comments on this change.
Change subject: rwlock: Replace misc.RWLock
..
Patch Set 18:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url
gerrit-hooks has posted comments on this change.
Change subject: rwlock: Support non-blocking acquire
..
Patch Set 25:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches
gerrit-hooks has posted comments on this change.
Change subject: rwlock: Support timed acquire
..
Patch Set 28:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-U
gerrit-hooks has posted comments on this change.
Change subject: rwlock: Add simpler RWLock
..
Patch Set 22:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url:
Yaniv Kaul has posted comments on this change.
Change subject: block: add blkdiscard on zero image
..
Patch Set 1:
(1 comment)
https://gerrit.ovirt.org/#/c/35631/1/vdsm/storage/blockSD.py
File vdsm/storage/blockSD.py:
Line 21
Yaniv Kaul has posted comments on this change.
Change subject: block: add blkdiscard on zero image
..
Patch Set 3:
(1 comment)
https://gerrit.ovirt.org/#/c/35631/3/vdsm/storage/blockVolume.py
File vdsm/storage/blockVolume.py:
Nir Soffer has posted comments on this change.
Change subject: block: add blkdiscard on zero image
..
Patch Set 1:
(1 comment)
https://gerrit.ovirt.org/#/c/35631/1/vdsm/storage/blockSD.py
File vdsm/storage/blockSD.py:
Line 21
gerrit-hooks has posted comments on this change.
Change subject: hsm: Report vg name in getDeviceList
..
Patch Set 4:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches
Yaniv Kaul has posted comments on this change.
Change subject: block: add blkdiscard on zero image
..
Patch Set 1:
(1 comment)
https://gerrit.ovirt.org/#/c/35631/1/vdsm/storage/blockSD.py
File vdsm/storage/blockSD.py:
Line 21
gerrit-hooks has posted comments on this change.
Change subject: hsm: Reformat device info dict
..
Patch Set 3:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-U
Nir Soffer has posted comments on this change.
Change subject: hsm: Reformat device info dict
..
Patch Set 3: Verified+1
--
To view, visit https://gerrit.ovirt.org/45845
To unsubscribe, visit https://gerrit.ovirt.org/settings
Nir Soffer has posted comments on this change.
Change subject: utils: Consider sleep time in deadline calculation
..
Patch Set 4: Verified+1
--
To view, visit https://gerrit.ovirt.org/46400
To unsubscribe, visit https://gerrit
gerrit-hooks has posted comments on this change.
Change subject: lib: Use new concurrent.thread() utility
..
Patch Set 6:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matc
gerrit-hooks has posted comments on this change.
Change subject: v2v: Use new concurrent.thread() utility
..
Patch Set 3:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matc
gerrit-hooks has posted comments on this change.
Change subject: network: Use new concurrent.thread() utility
..
Patch Set 3:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
gerrit-hooks has posted comments on this change.
Change subject: infra: Use new concurrent.thread() utility
..
Patch Set 3:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header ma
gerrit-hooks has posted comments on this change.
Change subject: virt: Use new concurrent.thread() utility
..
Patch Set 4:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header mat
gerrit-hooks has posted comments on this change.
Change subject: storage: Use new concurrent.thread() utility
..
Patch Set 3:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
gerrit-hooks has posted comments on this change.
Change subject: v2v: add fake virt-v2v process for testing without virt-v2v
..
Patch Set 10:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, m
gerrit-hooks has posted comments on this change.
Change subject: tests: Test only fake-virt-v2v tool
..
Patch Set 1:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches '
Nir Soffer has posted comments on this change.
Change subject: v2v: add fake virt-v2v process for testing without virt-v2v
..
Patch Set 10:
(1 comment)
Shahahr, I rebased this on the thread-names branch, trying to verify the
Nir Soffer has posted comments on this change.
Change subject: v2v: add fake virt-v2v process for testing without virt-v2v
..
Patch Set 10: Code-Review-1
--
To view, visit https://gerrit.ovirt.org/47738
To unsubscribe, visit h
Nir Soffer has posted comments on this change.
Change subject: v2v: add fake virt-v2v process for testing without virt-v2v
..
Patch Set 10:
(1 comment)
https://gerrit.ovirt.org/#/c/47738/10/tests/v2vTests.py
File tests/v2vTest
Nir Soffer has posted comments on this change.
Change subject: v2v: add fake virt-v2v process for testing without virt-v2v
..
Patch Set 10:
(1 comment)
https://gerrit.ovirt.org/#/c/47738/10/tests/v2vTests.py
File tests/v2vTest
Nir Soffer has posted comments on this change.
Change subject: lib: Use new concurrent.thread() utility
..
Patch Set 6: Verified+1
--
To view, visit https://gerrit.ovirt.org/44895
To unsubscribe, visit https://gerrit.ovirt.org
Nir Soffer has posted comments on this change.
Change subject: storage: Use new concurrent.thread() utility
..
Patch Set 3: Verified+1
--
To view, visit https://gerrit.ovirt.org/45552
To unsubscribe, visit https://gerrit.ovirt
Nir Soffer has posted comments on this change.
Change subject: network: Use new concurrent.thread() utility
..
Patch Set 3: Verified+1
--
To view, visit https://gerrit.ovirt.org/45553
To unsubscribe, visit https://gerrit.ovirt
Nir Soffer has posted comments on this change.
Change subject: virt: Use new concurrent.thread() utility
..
Patch Set 4: Verified+1
--
To view, visit https://gerrit.ovirt.org/4
To unsubscribe, visit https://gerrit.ovirt.or
Nir Soffer has posted comments on this change.
Change subject: infra: Use new concurrent.thread() utility
..
Patch Set 3: Verified+1
--
To view, visit https://gerrit.ovirt.org/45554
To unsubscribe, visit https://gerrit.ovirt.o
Nir Soffer has posted comments on this change.
Change subject: v2v: Use new concurrent.thread() utility
..
Patch Set 3:
I cannot test this, as the unitests do not start the import thread, and finding
out how to perform an ova
Nir Soffer has posted comments on this change.
Change subject: tests: Test only fake-virt-v2v tool
..
Patch Set 1: Verified+1
--
To view, visit https://gerrit.ovirt.org/48581
To unsubscribe, visit https://gerrit.ovirt.org/sett
Nir Soffer has posted comments on this change.
Change subject: hsm: Report vg name in getDeviceList
..
Patch Set 4: Verified+1
--
To view, visit https://gerrit.ovirt.org/45823
To unsubscribe, visit https://gerrit.ovirt.org/set
Nir Soffer has posted comments on this change.
Change subject: hsm: Report vg name in getDeviceList
..
Patch Set 3:
(1 comment)
https://gerrit.ovirt.org/#/c/45823/3/vdsm/rpc/vdsmapi-schema.json
File vdsm/rpc/vdsmapi-schema.jso
gerrit-hooks has posted comments on this change.
Change subject: hsm: Report vg name in getDeviceList
..
Patch Set 5:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches
Nir Soffer has posted comments on this change.
Change subject: hsm: Report vg name in getDeviceList
..
Patch Set 5: Verified+1
This version improve the description of the new vgname key in the schema and
update the (new in vve
Ido Barkan has posted comments on this change.
Change subject: network: Use new concurrent.thread() utility
..
Patch Set 3: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/45553
To unsubscribe, visit https://gerrit.ov
Piotr Kliczewski has posted comments on this change.
Change subject: infra: Use new concurrent.thread() utility
..
Patch Set 3: Code-Review+1
(1 comment)
https://gerrit.ovirt.org/#/c/45554/3//COMMIT_MSG
Commit Message:
Line 1
gerrit-hooks has posted comments on this change.
Change subject: hsm : Do not resize on Disconnect Storage Server
..
Patch Set 2:
* #1281909::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1281909::OK, public bug
*
1 - 100 of 103 matches
Mail list logo
