Ido Barkan has posted comments on this change.
Change subject: hooks: ovs: install ovs hook only with --enable-hooks
..
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/48671
To unsubscribe, visit https://
Ido Barkan has posted comments on this change.
Change subject: net: fix systemd race in exec_ifup
..
Patch Set 3:
I don't believe so.
--
To view, visit https://gerrit.ovirt.org/47627
To unsubscribe, visit https://gerrit.ovirt
Ido Barkan has posted comments on this change.
Change subject: daemonAdapter: remove redundant os.nice
..
Patch Set 1:
no, we should figure out what niceness do we want first ;-)
--
To view, visit https://gerrit.ovirt.org/486
Yaniv Bronhaim has posted comments on this change.
Change subject: daemonAdapter: remove redundant os.nice
..
Patch Set 1: Code-Review+1
is the next patch already submitted?
--
To view, visit https://gerrit.ovirt.org/48664
To
Nir Soffer has posted comments on this change.
Change subject: net: fix systemd race in exec_ifup
..
Patch Set 3:
Guys,this code is used by gluster mounts - did you verify that gluster mount
works after this?
--
To view, vis
Shahar Havivi has posted comments on this change.
Change subject: v2v: add import thread as a member
..
Patch Set 4:
(1 comment)
https://gerrit.ovirt.org/#/c/48600/4//COMMIT_MSG
Commit Message:
Line 5: CommitDate: 2015-11-17
Nir Soffer has posted comments on this change.
Change subject: Hook: ide2sata: To switch IDE disks to SATA
..
Patch Set 4:
(1 comment)
https://gerrit.ovirt.org/#/c/48450/4/vdsm_hooks/ide2sata/before_vm_start.py
File vdsm_hooks
Nir Soffer has posted comments on this change.
Change subject: vm: check operation result for vm nic hotunplug
..
Patch Set 2:
(1 comment)
https://gerrit.ovirt.org/#/c/48473/2//COMMIT_MSG
Commit Message:
Line 14: can also be
Nir Soffer has posted comments on this change.
Change subject: vm: check operation result for vm nic hotunplug
..
Patch Set 2: Code-Review-1
(3 comments)
Please write tests for this code before you change it.
https://gerrit.o
Nir Soffer has posted comments on this change.
Change subject: misc: remove rotateFiles
..
Patch Set 3:
Ping?
--
To view, visit https://gerrit.ovirt.org/48577
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-Me
Nir Soffer has posted comments on this change.
Change subject: hsm : Do not resize on disconnectStorageServer
..
Patch Set 5:
Fred, can you backport this to 3.6?
--
To view, visit https://gerrit.ovirt.org/48578
To unsubscribe
Nir Soffer has abandoned this change.
Change subject: storageServer: Avoid bogus warnings from createdir
..
Abandoned
Replaced by https://gerrit.ovirt.org/#/q/topic:warnings-cleanup
--
To view, visit https://gerrit.ovirt.org/
gerrit-hooks has posted comments on this change.
Change subject: storageServer: Avoid bogus warnings from createdir
..
Patch Set 2:
* Update tracker: IGNORE, no Bug-Url found
--
To view, visit https://gerrit.ovirt.org/36372
T
Nir Soffer has posted comments on this change.
Change subject: udevadm: Report time spent waiting for udev events
..
Patch Set 1: Code-Review-1
Should use stopwatch() context manager.
--
To view, visit https://gerrit.ovirt.or
Nir Soffer has abandoned this change.
Change subject: v2v: Use new concurrent.thread() utility
..
Abandoned
Replaced by https://gerrit.ovirt.org/48600
--
To view, visit https://gerrit.ovirt.org/45616
To unsubscribe, visit htt
gerrit-hooks has posted comments on this change.
Change subject: v2v: Use new concurrent.thread() utility
..
Patch Set 3:
* Update tracker: IGNORE, no Bug-Url found
--
To view, visit https://gerrit.ovirt.org/45616
To unsubscr
gerrit-hooks has posted comments on this change.
Change subject: mount: Perform mount and umount in supervdsm
..
Patch Set 7:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
gerrit-hooks has posted comments on this change.
Change subject: mount: Log info message when mounting or unmounting
..
Patch Set 6:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure
gerrit-hooks has posted comments on this change.
Change subject: mount: Remove unneeded return
..
Patch Set 6:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Ur
Nir Soffer has posted comments on this change.
Change subject: logging: Don't crash on non-ASCII in SimpleLogAdapter
..
Patch Set 3:
Milan, this issue should be fixed by https://gerrit.ovirt.org/48661
Please review.
--
To vi
Nir Soffer has posted comments on this change.
Change subject: lib: cmdutils: add command to cmdutils.Error
..
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/48628
To unsubscribe, visit https://gerrit.ov
Nir Soffer has posted comments on this change.
Change subject: lib: utils: consolidate Error class in one place
..
Patch Set 6: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/47964
To unsubscribe, visit https://gerri
gerrit-hooks has posted comments on this change.
Change subject: compat: Use simplejson instead of json
..
Patch Set 5:
* #1281940::Update tracker: OK
--
To view, visit https://gerrit.ovirt.org/48565
To unsubscribe, visit htt
Nir Soffer has abandoned this change.
Change subject: compat: Use simplejson instead of json
..
Abandoned
https://gerrit.ovirt.org/48661 is a better approach.
--
To view, visit https://gerrit.ovirt.org/48565
To unsubscribe, v
Nir Soffer has posted comments on this change.
Change subject: vm: Support for non-ascii vm name
..
Patch Set 1: -Code-Review
Discussed again, with Dan, regardless of the unicode, supporting vm with
unicode name until libvirt
gerrit-hooks has posted comments on this change.
Change subject: hsm: Refine error handling in getDevicesVisibility
..
Patch Set 2:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure h
gerrit-hooks has posted comments on this change.
Change subject: hsm: Pep8ize function name
..
Patch Set 2:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url:
Nir Soffer has posted comments on this change.
Change subject: tests: v2v: add test for commit f8127d8
..
Patch Set 6:
(1 comment)
https://gerrit.ovirt.org/#/c/47367/6/tests/v2vTests.py
File tests/v2vTests.py:
Line 186:
gerrit-hooks has posted comments on this change.
Change subject: lvm: Fail loudly if called with unexpected input
..
Patch Set 4:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure hea
gerrit-hooks has posted comments on this change.
Change subject: libvirtconnection: Replace assert with AssertionError
..
Patch Set 2:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sur
gerrit-hooks has posted comments on this change.
Change subject: schema: Fix asserts that had side effect
..
Patch Set 2:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matc
gerrit-hooks has posted comments on this change.
Change subject: fileUtils: Warn about callers of fileUtils.createdir()
..
Patch Set 4:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make su
gerrit-hooks has posted comments on this change.
Change subject: fileUtils: Convert unhelpful warnings to debug messages
..
Patch Set 8:
* update_tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1129587::ERROR, private bug
Nir Soffer has posted comments on this change.
Change subject: sp: Allow attaching hosted engine sd
..
Patch Set 1:
Roy?
--
To view, visit https://gerrit.ovirt.org/48217
To unsubscribe, visit https://gerrit.ovirt.org/settings
Nir Soffer has submitted this change and it was merged.
Change subject: hsm: Reformat device info dict
..
hsm: Reformat device info dict
Reformat device info dict in getDeviceList using one item per line and
sorted. This make i
gerrit-hooks has posted comments on this change.
Change subject: hsm: Reformat device info dict
..
Patch Set 5:
* Update tracker: IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no Bug-Url found.
--
To view, visit https://ge
Nir Soffer has posted comments on this change.
Change subject: utils: Consider sleep time in deadline calculation
..
Patch Set 4:
Ping - who wants to approve this?
--
To view, visit https://gerrit.ovirt.org/46400
To unsubscri
gerrit-hooks has posted comments on this change.
Change subject: hsm: Reformat device info dict
..
Patch Set 4:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-U
Nir Soffer has posted comments on this change.
Change subject: logUtils: Process SimpleLogAdapter's context once
..
Patch Set 4:
Piotr, I think this is your domain - who should approve this?
--
To view, visit https://gerrit.o
Nir Soffer has posted comments on this change.
Change subject: v2v: add fake virt-v2v process for testing without virt-v2v
..
Patch Set 16: Code-Review+1
I like this, but waiting for Francesco review.
--
To view, visit https:
Nir Soffer has posted comments on this change.
Change subject: v2v: add import thread as a member
..
Patch Set 4:
(1 comment)
https://gerrit.ovirt.org/#/c/48600/4//COMMIT_MSG
Commit Message:
Line 5: CommitDate: 2015-11-17 16:
Nir Soffer has posted comments on this change.
Change subject: gluster: Fixing connection when server is not one of the bricks
..
Patch Set 9: Code-Review+2
Thanks Sahina!
Ala, would you verify this?
--
To view, visit https:
gerrit-hooks has posted comments on this change.
Change subject: issci: Fix equality and hash when username or password are None
..
Patch Set 2:
* Update tracker: IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no Bug-Url foun
gerrit-hooks has posted comments on this change.
Change subject: iscsi: Fix credentials initialization when not using CHAP
..
Patch Set 4:
* #1279485::Update tracker: OK
* Set MODIFIED::bug 1279485#1279485OK
--
To vie
Nir Soffer has submitted this change and it was merged.
Change subject: issci: Fix equality and hash when username or password are None
..
issci: Fix equality and hash when username or password are None
When fetching iscsi sess
Nir Soffer has submitted this change and it was merged.
Change subject: iscsi: Fix credentials initialization when not using CHAP
..
iscsi: Fix credentials initialization when not using CHAP
There was a mismatch between the way
Nir Soffer has posted comments on this change.
Change subject: storagetestlib: create images directory in the right place
..
Patch Set 2:
Can you verify?
--
To view, visit https://gerrit.ovirt.org/48694
To unsubscribe, visit
gerrit-hooks has posted comments on this change.
Change subject: hsm : Do not resize on disconnectStorageServer
..
Patch Set 5:
* #1281909::Update tracker: OK
* Set MODIFIED::bug 1281909#1281909OK
--
To view, visit ht
Nir Soffer has submitted this change and it was merged.
Change subject: hsm : Do not resize on disconnectStorageServer
..
hsm : Do not resize on disconnectStorageServer
When a host is moved to maintenance state, it will
disconn
gerrit-hooks has posted comments on this change.
Change subject: hsm : Do not resize on disconnectStorageServer
..
Patch Set 4:
* #1281909::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1281909::OK, public bug
* C
Nir Soffer has posted comments on this change.
Change subject: hsm : Do not resize on disconnectStorageServer
..
Patch Set 3:
Fred, can you get the CI to run your patch?
--
To view, visit https://gerrit.ovirt.org/48578
To uns
Adam Litke has posted comments on this change.
Change subject: hsm : Do not resize on disconnectStorageServer
..
Patch Set 3: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/48578
To unsubscribe, visit https://gerrit.
Adam Litke has posted comments on this change.
Change subject: hsm : Do not resize on disconnectStorageServer
..
Patch Set 3: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/48578
To unsubscribe, visit https://gerrit.
Nir Soffer has posted comments on this change.
Change subject: tests: Set common StorageDomainManifest fields automatically
..
Patch Set 2: Code-Review-1
(1 comment)
https://gerrit.ovirt.org/#/c/48693/2/tests/storagetestlib.py
Adam Litke has posted comments on this change.
Change subject: tests: Set common StorageDomainManifest fields automatically
..
Patch Set 1:
(1 comment)
https://gerrit.ovirt.org/#/c/48693/1/tests/storagetestlib.py
File tests/st
gerrit-hooks has posted comments on this change.
Change subject: tests: FakeLVM test command failure
..
Patch Set 11:
* Update tracker: IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no Bug-Url found.
--
To view, visit http
Nir Soffer has submitted this change and it was merged.
Change subject: tests: FakeLVM test command failure
..
tests: FakeLVM test command failure
Change-Id: I954b750d744df0dbd9b7ac13138731d80db54bb8
Signed-off-by: Adam Litke
gerrit-hooks has posted comments on this change.
Change subject: storagetestlib: use a real metadata file for FileSD manifests
..
Patch Set 2:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found,
gerrit-hooks has posted comments on this change.
Change subject: storagetestlib: create images directory in the right place
..
Patch Set 2:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, mak
Nir Soffer has posted comments on this change.
Change subject: tests: FakeLVM test command failure
..
Patch Set 10: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/47864
To unsubscribe, visit https://gerrit.ovirt.org/
gerrit-hooks has posted comments on this change.
Change subject: tests: Set common StorageDomainManifest fields automatically
..
Patch Set 2:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, m
Nir Soffer has posted comments on this change.
Change subject: stomp: slow data read when connected from localhost
..
Patch Set 2:
Piotr, not sure what do you mean by polling again - asyncore.loop is doing the
polling.
Can yo
Nir Soffer has posted comments on this change.
Change subject: v2v: externalVMList Xen+Kvm support
..
Patch Set 1:
(1 comment)
https://gerrit.ovirt.org/#/c/48672/1//COMMIT_MSG
Commit Message:
Line 14:
Line 15: As well as for
Nir Soffer has posted comments on this change.
Change subject: storagetestlib: use a real metadata file for FileSD manifests
..
Patch Set 1: Code-Review-1
(1 comment)
https://gerrit.ovirt.org/#/c/48695/1//COMMIT_MSG
Commit Mes
Nir Soffer has posted comments on this change.
Change subject: tests: Set common StorageDomainManifest fields automatically
..
Patch Set 1: Code-Review-1
(1 comment)
https://gerrit.ovirt.org/#/c/48693/1/tests/storagetestlib.py
Piotr Kliczewski has posted comments on this change.
Change subject: stomp: slow data read when connected from localhost
..
Patch Set 2:
I tried to poll again. This was my first thought.
It is poller method do not see that the
Nir Soffer has posted comments on this change.
Change subject: storagetestlib: create images directory in the right place
..
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/48694
To unsubscribe, visit htt
Nir Soffer has posted comments on this change.
Change subject: stomp: slow data read when connected from localhost
..
Patch Set 1:
(1 comment)
https://gerrit.ovirt.org/#/c/48608/1/lib/yajsonrpc/stomp.py
File lib/yajsonrpc/stom
gerrit-hooks has posted comments on this change.
Change subject: storagetestlib: use a real metadata file for FileSD manifests
..
Patch Set 1:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found,
gerrit-hooks has posted comments on this change.
Change subject: storagetestlib: create images directory in the right place
..
Patch Set 1:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, mak
Adam Litke has uploaded a new change for review.
Change subject: storagetestlib: create images directory in the right place
..
storagetestlib: create images directory in the right place
When building the images path, we do not n
Adam Litke has uploaded a new change for review.
Change subject: storagetestlib: use a real metadata file for FileSD manifests
..
storagetestlib: use a real metadata file for FileSD manifests
When building a fake FileStorageDoma
Adam Litke has uploaded a new change for review.
Change subject: tests: Set common StorageDomainManifest fields automatically
..
tests: Set common StorageDomainManifest fields automatically
When creating storage domains it is co
gerrit-hooks has posted comments on this change.
Change subject: tests: Set common StorageDomainManifest fields automatically
..
Patch Set 1:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, m
gerrit-hooks has posted comments on this change.
Change subject: VolumeMetadata: Move imagePath and validation
..
Patch Set 6:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
gerrit-hooks has posted comments on this change.
Change subject: VolumeMetadata: Move volumePath and validation
..
Patch Set 6:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure heade
gerrit-hooks has posted comments on this change.
Change subject: VolumeMetadata: Move instance validation
..
Patch Set 6:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matc
gerrit-hooks has posted comments on this change.
Change subject: spec: zombiereaper is not removed on vdsm upgrade
..
Patch Set 2: Verified-1
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::ERROR, At least one bug-
Yaniv Bronhaim has posted comments on this change.
Change subject: spec: zombiereaper is not removed on vdsm upgrade
..
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/48452
To unsubscribe, visit https://
Yaniv Bronhaim has posted comments on this change.
Change subject: spec: zombiereaper is not removed on vdsm upgrade
..
Patch Set 1: Continuous-Integration+1
--
To view, visit https://gerrit.ovirt.org/48452
To unsubscribe, vis
Yaniv Bronhaim has posted comments on this change.
Change subject: hooks: remove directlun hook
..
Patch Set 2: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/48637
To unsubscribe, visit https://gerrit.ovirt.org/sett
Francesco Romani has posted comments on this change.
Change subject: stomp: message tracking do not clean properly
..
Patch Set 2:
(1 comment)
https://gerrit.ovirt.org/#/c/48616/2/lib/yajsonrpc/stompreactor.py
File lib/yajsonr
Piotr Kliczewski has posted comments on this change.
Change subject: stomp: message tracking do not clean properly
..
Patch Set 2:
(2 comments)
https://gerrit.ovirt.org/#/c/48616/2/lib/yajsonrpc/stompreactor.py
File lib/yajson
Francesco Romani has posted comments on this change.
Change subject: stomp: message tracking do not clean properly
..
Patch Set 2:
(1 comment)
https://gerrit.ovirt.org/#/c/48616/2/lib/yajsonrpc/stompreactor.py
File lib/yajsonr
Yeela Kaplan has posted comments on this change.
Change subject: stomp: message tracking do not clean properly
..
Patch Set 2: Code-Review-1
(1 comment)
https://gerrit.ovirt.org/#/c/48616/2/lib/yajsonrpc/stompreactor.py
File l
Francesco Romani has posted comments on this change.
Change subject: v2v: externalVMList Xen+Kvm support
..
Patch Set 1: Code-Review-1
--
To view, visit https://gerrit.ovirt.org/48672
To unsubscribe, visit https://gerrit.ovirt
Francesco Romani has posted comments on this change.
Change subject: v2v: externalVMList Xen+Kvm support
..
Patch Set 1:
(3 comments)
one request and two questions inside, -1 for visibility
https://gerrit.ovirt.org/#/c/48672/
Francesco Romani has posted comments on this change.
Change subject: startup: Change system default encoding to utf8
..
Patch Set 4: Code-Review+1
After some investigation, I also believe that this patch will not make our
futu
Yaniv Bronhaim has posted comments on this change.
Change subject: startup: Change system default encoding to utf8
..
Patch Set 4: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/48661
To unsubscribe, visit https://ge
Francesco Romani has posted comments on this change.
Change subject: periodic: add __str__ methods
..
Patch Set 8: Verified+1
verified again using patched VDSM
--
To view, visit https://gerrit.ovirt.org/48193
To unsubscribe,
Piotr Kliczewski has posted comments on this change.
Change subject: logUtils: Process SimpleLogAdapter's context once
..
Patch Set 4: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/48552
To unsubscribe, visit https:
Piotr Kliczewski has posted comments on this change.
Change subject: stomp: message tracking do not clean properly
..
Patch Set 2: Verified+1
Verified by running vdsm and seeing that there are no issues during
communication.
gerrit-hooks has posted comments on this change.
Change subject: stomp: message tracking do not clean properly
..
Patch Set 2:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
Dan Kenigsberg has posted comments on this change.
Change subject: hooks: after_network_setup_fail
..
Patch Set 24: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/45085
To unsubscribe, visit https://gerrit.ovirt.org/
Dan Kenigsberg has submitted this change and it was merged.
Change subject: hooks: after_network_setup_fail
..
hooks: after_network_setup_fail
When an exception occurs during network setup, rollback is executed
and after_networ
gerrit-hooks has posted comments on this change.
Change subject: hooks: after_network_setup_fail
..
Patch Set 25:
* Update tracker: IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no Bug-Url found.
--
To view, visit https://
Petr Horáček has uploaded a new change for review.
Change subject: hooks: ovs: install ovs hook only with --enable-hooks
..
hooks: ovs: install ovs hook only with --enable-hooks
Change-Id: I9e6aeb4bf3c72ef515f57b153a98f504e04e4e
gerrit-hooks has posted comments on this change.
Change subject: hooks: ovs: install ovs hook only with --enable-hooks
..
Patch Set 1:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sur
gerrit-hooks has posted comments on this change.
Change subject: v2v: externalVMList Xen+Kvm support
..
Patch Set 1:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches '
Shahar Havivi has posted comments on this change.
Change subject: v2v: externalVMList Xen+Kvm support
..
Patch Set 1: Verified+1
--
To view, visit https://gerrit.ovirt.org/48672
To unsubscribe, visit https://gerrit.ovirt.org/s
1 - 100 of 219 matches
Mail list logo