Change in vdsm[ovirt-3.5]: vm: add support for "Crashed" event

2015-12-03 Thread mzamazal
Milan Zamazal has posted comments on this change. Change subject: vm: add support for "Crashed" event .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/49674 To unsubscribe, visit https://gerrit.ovirt.or

Change in vdsm[ovirt-3.5]: vm: more robust support of event strings

2015-12-03 Thread mzamazal
Milan Zamazal has posted comments on this change. Change subject: vm: more robust support of event strings .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/49675 To unsubscribe, visit https://gerrit.ovi

Change in vdsm[ovirt-3.5]: vm: reformat _EVENT_STRINGS

2015-12-03 Thread mzamazal
Milan Zamazal has posted comments on this change. Change subject: vm: reformat _EVENT_STRINGS .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/49673 To unsubscribe, visit https://gerrit.ovirt.org/settin

Change in vdsm[master]: VolumeMetadata: Move isLeaf, setLeaf and dependencies

2015-12-03 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: VolumeMetadata: Move isLeaf, setLeaf and dependencies .. Patch Set 23: This version adds most of the missing redirection tests, and change static method to class m

Change in vdsm[master]: VolumeMetadata: Move isLeaf, setLeaf and dependencies

2015-12-03 Thread automation
gerrit-hooks has posted comments on this change. Change subject: VolumeMetadata: Move isLeaf, setLeaf and dependencies .. Patch Set 23: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make su

Change in vdsm[ovirt-3.6]: hooks: ovs: fix getVdsCaps and getVdsStats

2015-12-03 Thread automation
gerrit-hooks has posted comments on this change. Change subject: hooks: ovs: fix getVdsCaps and getVdsStats .. Patch Set 1: * #1234867::Update tracker: OK * Check Bug-Url::OK * Check Public Bug::#1234867::OK, public bug * Check

Change in vdsm[ovirt-3.6]: hooks: ovs: use six.iteritems and six.itervalues

2015-12-03 Thread automation
gerrit-hooks has posted comments on this change. Change subject: hooks: ovs: use six.iteritems and six.itervalues .. Patch Set 1: * #1234867::Update tracker: OK * Check Bug-Url::OK * Check Public Bug::#1234867::OK, public bug *

Change in vdsm[ovirt-3.6]: hooks: ovs: add script name to log

2015-12-03 Thread automation
gerrit-hooks has posted comments on this change. Change subject: hooks: ovs: add script name to log .. Patch Set 1: * #1234867::Update tracker: OK * Check Bug-Url::OK * Check Public Bug::#1234867::OK, public bug * Check Product

Change in vdsm[ovirt-3.6]: hooks: ovs: pass ip configuration as a namedtuple

2015-12-03 Thread automation
gerrit-hooks has posted comments on this change. Change subject: hooks: ovs: pass ip configuration as a namedtuple .. Patch Set 1: * #1234867::Update tracker: OK * Check Bug-Url::OK * Check Public Bug::#1234867::OK, public bug

Change in vdsm[ovirt-3.6]: net: ovs: remove initial nic ip, dont touch unchanged networks

2015-12-03 Thread automation
gerrit-hooks has posted comments on this change. Change subject: net: ovs: remove initial nic ip, dont touch unchanged networks .. Patch Set 1: * #1234867::Update tracker: OK * Check Bug-Url::OK * Check Public Bug::#1234867::OK

Change in vdsm[ovirt-3.6]: hooks: ovs: better rollback

2015-12-03 Thread automation
gerrit-hooks has posted comments on this change. Change subject: hooks: ovs: better rollback .. Patch Set 1: * #1234867::Update tracker: OK * Check Bug-Url::OK * Check Public Bug::#1234867::OK, public bug * Check Product::#1234

Change in vdsm[ovirt-3.6]: hooks: ovs: remove unused parameter

2015-12-03 Thread automation
gerrit-hooks has posted comments on this change. Change subject: hooks: ovs: remove unused parameter .. Patch Set 1: * #1234867::Update tracker: OK * Check Bug-Url::OK * Check Public Bug::#1234867::OK, public bug * Check Produc

Change in vdsm[ovirt-3.6]: hooks: Open vSwitch configurator

2015-12-03 Thread automation
gerrit-hooks has posted comments on this change. Change subject: hooks: Open vSwitch configurator .. Patch Set 1: * #1234867::Update tracker: OK * Check Bug-Url::OK * Check Public Bug::#1234867::OK, public bug * Check Product::

Change in vdsm[ovirt-3.6]: hooks: ovs: move libvirt configuration into a separate module

2015-12-03 Thread automation
gerrit-hooks has posted comments on this change. Change subject: hooks: ovs: move libvirt configuration into a separate module .. Patch Set 1: * #1234867::Update tracker: OK * Check Bug-Url::OK * Check Public Bug::#1234867::OK,

Change in vdsm[ovirt-3.6]: net: multicast snooping is not supported by ovs until 2.4.0

2015-12-03 Thread automation
gerrit-hooks has posted comments on this change. Change subject: net: multicast snooping is not supported by ovs until 2.4.0 .. Patch Set 1: * #1234867::Update tracker: OK * Check Bug-Url::OK * Check Public Bug::#1234867::OK, p

Change in vdsm[ovirt-3.6]: hooks: ovs: move libvirt configuration into a separate module

2015-12-03 Thread phoracek
Hello Ido Barkan, Ondřej Svoboda, Dan Kenigsberg, I'd like you to do a code review. Please visit https://gerrit.ovirt.org/49691 to review the following change. Change subject: hooks: ovs: move libvirt configuration into a separate module

Change in vdsm[ovirt-3.6]: hooks: ovs: fix getVdsCaps and getVdsStats

2015-12-03 Thread phoracek
Hello Ido Barkan, Dan Kenigsberg, I'd like you to do a code review. Please visit https://gerrit.ovirt.org/49698 to review the following change. Change subject: hooks: ovs: fix getVdsCaps and getVdsStats .. hooks: ovs: fix

Change in vdsm[ovirt-3.6]: hooks: ovs: use six.iteritems and six.itervalues

2015-12-03 Thread phoracek
Hello Ido Barkan, Dan Kenigsberg, I'd like you to do a code review. Please visit https://gerrit.ovirt.org/49697 to review the following change. Change subject: hooks: ovs: use six.iteritems and six.itervalues .. hooks: ov

Change in vdsm[ovirt-3.6]: hooks: after_network_setup_fail

2015-12-03 Thread automation
gerrit-hooks has posted comments on this change. Change subject: hooks: after_network_setup_fail .. Patch Set 1: * #1234867::Update tracker: OK * Check Bug-Url::OK * Check Public Bug::#1234867::OK, public bug * Check Product::#

Change in vdsm[ovirt-3.6]: net: sysctl: enable ipv6

2015-12-03 Thread phoracek
Hello Dan Kenigsberg, I'd like you to do a code review. Please visit https://gerrit.ovirt.org/49687 to review the following change. Change subject: net: sysctl: enable ipv6 .. net: sysctl: enable ipv6 Enable sysctl.py:di

Change in vdsm[ovirt-3.6]: net: ovs: remove initial nic ip, dont touch unchanged networks

2015-12-03 Thread phoracek
Hello Ido Barkan, Dan Kenigsberg, I'd like you to do a code review. Please visit https://gerrit.ovirt.org/49695 to review the following change. Change subject: net: ovs: remove initial nic ip, dont touch unchanged networks ...

Change in vdsm[ovirt-3.6]: hooks: ovs: add script name to log

2015-12-03 Thread phoracek
Hello Dan Kenigsberg, I'd like you to do a code review. Please visit https://gerrit.ovirt.org/49696 to review the following change. Change subject: hooks: ovs: add script name to log .. hooks: ovs: add script name to log

Change in vdsm[ovirt-3.6]: hooks: ovs: better rollback

2015-12-03 Thread phoracek
Hello Ido Barkan, Dan Kenigsberg, I'd like you to do a code review. Please visit https://gerrit.ovirt.org/49693 to review the following change. Change subject: hooks: ovs: better rollback .. hooks: ovs: better rollback U

Change in vdsm[ovirt-3.6]: hooks: ovs: remove unused parameter

2015-12-03 Thread phoracek
Hello Ido Barkan, Dan Kenigsberg, I'd like you to do a code review. Please visit https://gerrit.ovirt.org/49692 to review the following change. Change subject: hooks: ovs: remove unused parameter .. hooks: ovs: remove unu

Change in vdsm[ovirt-3.6]: net: sysctl: enable ipv6

2015-12-03 Thread automation
gerrit-hooks has posted comments on this change. Change subject: net: sysctl: enable ipv6 .. Patch Set 1: * #1234867::Update tracker: OK * Check Bug-Url::OK * Check Public Bug::#1234867::OK, public bug * Check Product::#1234867

Change in vdsm[ovirt-3.6]: net: multicast snooping is not supported by ovs until 2.4.0

2015-12-03 Thread phoracek
Hello Ido Barkan, Dan Kenigsberg, I'd like you to do a code review. Please visit https://gerrit.ovirt.org/49690 to review the following change. Change subject: net: multicast snooping is not supported by ovs until 2.4.0 ..

Change in vdsm[ovirt-3.6]: hooks: after_network_setup_fail

2015-12-03 Thread phoracek
Hello Ido Barkan, Dan Kenigsberg, I'd like you to do a code review. Please visit https://gerrit.ovirt.org/49688 to review the following change. Change subject: hooks: after_network_setup_fail .. hooks: after_network_setup

Change in vdsm[ovirt-3.6]: hooks: ovs: pass ip configuration as a namedtuple

2015-12-03 Thread phoracek
Hello Ido Barkan, Dan Kenigsberg, I'd like you to do a code review. Please visit https://gerrit.ovirt.org/49694 to review the following change. Change subject: hooks: ovs: pass ip configuration as a namedtuple .. hooks: o

Change in vdsm[master]: sdm: Create the storage/sdm directory

2015-12-03 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: sdm: Create the storage/sdm directory .. Patch Set 1: Code-Review-1 (1 comment) https://gerrit.ovirt.org/#/c/49686/1/vdsm/storage/sdm/__init__.py File vdsm/storage

Change in vdsm[master]: tests: add FakeSanlock.init_resource

2015-12-03 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: tests: add FakeSanlock.init_resource .. Patch Set 3: Continuous-Integration+1 CI not need for this change. -- To view, visit https://gerrit.ovirt.org/49542 To uns

Change in vdsm[master]: tests: add FakeSanlock.init_resource

2015-12-03 Thread nsoffer
Nir Soffer has submitted this change and it was merged. Change subject: tests: add FakeSanlock.init_resource .. tests: add FakeSanlock.init_resource init_resource is called by VolumeMetadata.newVolumeLease. When unit testing w

Change in vdsm[master]: tests: add FakeSanlock.init_resource

2015-12-03 Thread automation
gerrit-hooks has posted comments on this change. Change subject: tests: add FakeSanlock.init_resource .. Patch Set 4: * Update tracker: IGNORE, no Bug-Url found * Set MODIFIED::IGNORE, no Bug-Url found. -- To view, visit http

Change in vdsm[master]: StorageDomainManifest: Manifest objects produce VolumeMetada...

2015-12-03 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: StorageDomainManifest: Manifest objects produce VolumeMetadata objects .. Patch Set 7: (1 comment) https://gerrit.ovirt.org/#/c/44040/7//COMMIT_MSG Commit Message

Change in vdsm[master]: StorageDomainManifest: Manifest objects produce VolumeMetada...

2015-12-03 Thread alitke
Adam Litke has posted comments on this change. Change subject: StorageDomainManifest: Manifest objects produce VolumeMetadata objects .. Patch Set 7: (1 comment) https://gerrit.ovirt.org/#/c/44040/7//COMMIT_MSG Commit Message

Change in vdsm[master]: StorageDomainManifest: Manifest objects produce VolumeMetada...

2015-12-03 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: StorageDomainManifest: Manifest objects produce VolumeMetadata objects .. Patch Set 7: Code-Review-1 (1 comment) https://gerrit.ovirt.org/#/c/44040/7//COMMIT_MSG

Change in vdsm[master]: guest-agent: desktopLock exception on EBADF should be ignored

2015-12-03 Thread Jenkins CI
Jenkins CI has posted comments on this change. Change subject: guest-agent: desktopLock exception on EBADF should be ignored .. Patch Set 8: Propagate review hook: Continuous Integration value inherited from patch 7 -- To vie

Change in vdsm[master]: tests: add FakeSanlock.init_resource

2015-12-03 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: tests: add FakeSanlock.init_resource .. Patch Set 3: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/49542 To unsubscribe, visit https://gerrit.ovirt.org/

Change in vdsm[master]: tests: add FakeSanlock.init_resource

2015-12-03 Thread alitke
Adam Litke has posted comments on this change. Change subject: tests: add FakeSanlock.init_resource .. Patch Set 3: Verified+1 Verified with 'make check'. New function isn't being called yet. -- To view, visit https://gerrit

Change in vdsm[master]: StorageDomainManifest: Manifest objects produce VolumeMetada...

2015-12-03 Thread automation
gerrit-hooks has posted comments on this change. Change subject: StorageDomainManifest: Manifest objects produce VolumeMetadata objects .. Patch Set 7: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug u

Change in vdsm[master]: tests: add FakeSanlock.init_resource

2015-12-03 Thread automation
gerrit-hooks has posted comments on this change. Change subject: tests: add FakeSanlock.init_resource .. Patch Set 3: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches

Change in vdsm[master]: tests: add FakeSanlock.init_resource

2015-12-03 Thread automation
gerrit-hooks has posted comments on this change. Change subject: tests: add FakeSanlock.init_resource .. Patch Set 2: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches

Change in vdsm[master]: sdm: Create the storage/sdm directory

2015-12-03 Thread alitke
Adam Litke has posted comments on this change. Change subject: sdm: Create the storage/sdm directory .. Patch Set 1: Verified+1 Verified with 'make check' and 'make rpm' -- To view, visit https://gerrit.ovirt.org/49686 To uns

Change in vdsm[master]: sdm: Create the storage/sdm directory

2015-12-03 Thread alitke
Adam Litke has uploaded a new change for review. Change subject: sdm: Create the storage/sdm directory .. sdm: Create the storage/sdm directory New SDM code including the verbs and supporting utility functions need an organized

Change in vdsm[master]: sdm: Create the storage/sdm directory

2015-12-03 Thread automation
gerrit-hooks has posted comments on this change. Change subject: sdm: Create the storage/sdm directory .. Patch Set 1: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches

Change in vdsm[ovirt-3.6]: vm: check operation result for vm nic hotunplug

2015-12-03 Thread fromani
Francesco Romani has posted comments on this change. Change subject: vm: check operation result for vm nic hotunplug .. Patch Set 1: Code-Review+1 I need to make sure this is OK for stable branch (seems so, but I want to do a

Change in vdsm[ovirt-3.6]: vm: unit test for vm._waitForDriveRemoval

2015-12-03 Thread fromani
Francesco Romani has posted comments on this change. Change subject: vm: unit test for vm._waitForDriveRemoval .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/49668 To unsubscribe, visit https://gerrit

Change in vdsm[master]: getAllImages: Use manifest attributes when constructing glob...

2015-12-03 Thread alitke
Adam Litke has posted comments on this change. Change subject: getAllImages: Use manifest attributes when constructing glob pattern .. Patch Set 2: Verified+1 Verified with make check and the included test case. -- To view,

Change in vdsm[master]: vm: adding xpath property to device Base class

2015-12-03 Thread fromani
Francesco Romani has posted comments on this change. Change subject: vm: adding xpath property to device Base class .. Patch Set 2: Code-Review-1 no longer needed in this form, as per my previous comment. -- To view, visit ht

Change in vdsm[ovirt-3.5]: spec: clean up selinux requirement

2015-12-03 Thread automation
gerrit-hooks has posted comments on this change. Change subject: spec: clean up selinux requirement .. Patch Set 3: * Update tracker: IGNORE, no Bug-Url found * Set MODIFIED::IGNORE, no Bug-Url found. -- To view, visit https:

Change in vdsm[ovirt-3.5]: spec: clean up selinux requirement

2015-12-03 Thread fromani
Francesco Romani has posted comments on this change. Change subject: spec: clean up selinux requirement .. Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/49088 To unsubscribe, visit https://gerrit.ovirt.

Change in vdsm[ovirt-3.5]: spec: clean up selinux requirement

2015-12-03 Thread fromani
Francesco Romani has submitted this change and it was merged. Change subject: spec: clean up selinux requirement .. spec: clean up selinux requirement While spec files support the syntax of package_name >= package_name-version,

Change in vdsm[ovirt-3.5]: spec: clean up selinux requirement

2015-12-03 Thread fromani
Francesco Romani has posted comments on this change. Change subject: spec: clean up selinux requirement .. Patch Set 2: Continuous-Integration+1 Verified+1 verified manually building and installing packages on centos 7 and rhel

Change in vdsm[ovirt-3.5]: spec: clean up selinux requirement

2015-12-03 Thread fromani
Francesco Romani has posted comments on this change. Change subject: spec: clean up selinux requirement .. Patch Set 2: since this is a cleanup (which actually helps for me, not sure why was not spotted before), I'm making an

Change in vdsm[master]: vm: adding xpath property to device Base class

2015-12-03 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: vm: adding xpath property to device Base class .. Patch Set 2: Code-Review-1 Marcin, Francesco agrees that this is not needed, so you can abandon this patch. -- T

Change in vdsm[master]: getAllImages: Use manifest attributes when constructing glob...

2015-12-03 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: getAllImages: Use manifest attributes when constructing glob pattern .. Patch Set 2: Verify (with a flow that use this code) and we can merge this. -- To view, v

Change in vdsm[master]: getAllImages: Use manifest attributes when constructing glob...

2015-12-03 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: getAllImages: Use manifest attributes when constructing glob pattern .. Patch Set 2: Code-Review+2 It looks better with the test, and I agree that we don't testing

Change in vdsm[master]: getAllImages: Use manifest attributes when constructing glob...

2015-12-03 Thread automation
gerrit-hooks has posted comments on this change. Change subject: getAllImages: Use manifest attributes when constructing glob pattern .. Patch Set 2: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url

Change in vdsm[master]: getAllImages: Use manifest attributes when constructing glob...

2015-12-03 Thread alitke
Adam Litke has posted comments on this change. Change subject: getAllImages: Use manifest attributes when constructing glob pattern .. Patch Set 1: The test you are asking for doesn't make sense. You're asking me to monkeypa

Change in vdsm[master]: network: Use new concurrent.thread() utility

2015-12-03 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: network: Use new concurrent.thread() utility .. Patch Set 3: ping -- To view, visit https://gerrit.ovirt.org/45553 To unsubscribe, visit https://gerrit.ovirt.org/

Change in vdsm[master]: getAllImages: Use manifest attributes when constructing glob...

2015-12-03 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: getAllImages: Use manifest attributes when constructing glob pattern .. Patch Set 1: Code-Review-1 Looks good, but I would like a test in a previous patch before w

Change in vdsm[master]: getAllImages: Use manifest attributes when constructing glob...

2015-12-03 Thread automation
gerrit-hooks has posted comments on this change. Change subject: getAllImages: Use manifest attributes when constructing glob pattern .. Patch Set 1: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url

Change in vdsm[master]: getAllImages: Use manifest attributes when constructing glob...

2015-12-03 Thread alitke
Adam Litke has uploaded a new change for review. Change subject: getAllImages: Use manifest attributes when constructing glob pattern .. getAllImages: Use manifest attributes when constructing glob pattern getAllImages searches

Change in vdsm[master]: Adding compatibility for ovirt-engine 4.0 support

2015-12-03 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: Adding compatibility for ovirt-engine 4.0 support .. Patch Set 2: Waiting for Dan -- To view, visit https://gerrit.ovirt.org/49060 To unsubscribe, visit https://g

Change in vdsm[master]: Adding compatibility for ovirt-engine 4.0 support

2015-12-03 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: Adding compatibility for ovirt-engine 4.0 support .. Patch Set 2: Code-Review+2 We need it now for storage, sdm mode will required this cluster version. -- To vie

Change in vdsm[ovirt-3.6]: vm: unit test for vm._waitForDriveRemoval

2015-12-03 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: vm: unit test for vm._waitForDriveRemoval .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/49668 To unsubscribe, visit https://gerrit.ovirt

Change in vdsm[ovirt-3.6]: vm: move device attached check to device itself

2015-12-03 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: vm: move device attached check to device itself .. Patch Set 1: Code-Review-1 This patch is not required for 3.6, but it will be nicer to have it so we have the sa

Change in vdsm[ovirt-3.6]: vm: add test for nic unplug wait

2015-12-03 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: vm: add test for nic unplug wait .. Patch Set 1: Code-Review-1 Please reorder this patch before the previous one, like it was merged into master. -- To view, vis

Change in vdsm[master]: modpobe: Remove EL6 path

2015-12-03 Thread nsoffer
Nir Soffer has submitted this change and it was merged. Change subject: modpobe: Remove EL6 path .. modpobe: Remove EL6 path Removed the reference to /sbin/modprobe (which is used in EL6), as we no longer support this platform.

Change in vdsm[master]: modpobe: Remove EL6 path

2015-12-03 Thread automation
gerrit-hooks has posted comments on this change. Change subject: modpobe: Remove EL6 path .. Patch Set 2: * Update tracker: IGNORE, no Bug-Url found * Set MODIFIED::IGNORE, no Bug-Url found. -- To view, visit https://gerrit.o

Change in vdsm[master]: Adding to vdsm automation lago env setup for functional tests

2015-12-03 Thread automation
gerrit-hooks has posted comments on this change. Change subject: Adding to vdsm automation lago env setup for functional tests .. Patch Set 16: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found,

Change in vdsm[master]: hooks: ovs: use a class instead of NamedTuple for IPConfig

2015-12-03 Thread automation
gerrit-hooks has posted comments on this change. Change subject: hooks: ovs: use a class instead of NamedTuple for IPConfig .. Patch Set 4: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, mak

Change in vdsm[master]: hooks: ovs: use a class instead of NamedTuple for IPConfig

2015-12-03 Thread phoracek
Petr Horáček has posted comments on this change. Change subject: hooks: ovs: use a class instead of NamedTuple for IPConfig .. Patch Set 3: (1 comment) https://gerrit.ovirt.org/#/c/49235/3/vdsm_hooks/ovs/ovs_before_network_set

Change in vdsm[master]: hooks: ovs: set OVS devices UP

2015-12-03 Thread phoracek
Petr Horáček has posted comments on this change. Change subject: hooks: ovs: set OVS devices UP .. Patch Set 6: now it's ready -- To view, visit https://gerrit.ovirt.org/48388 To unsubscribe, visit https://gerrit.ovirt.org/se

Change in vdsm[master]: hooks: ovs: set OVS devices UP

2015-12-03 Thread automation
gerrit-hooks has posted comments on this change. Change subject: hooks: ovs: set OVS devices UP .. Patch Set 6: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-U

Change in vdsm[master]: hooks: ovs: skip non-vNic device's XML

2015-12-03 Thread automation
gerrit-hooks has posted comments on this change. Change subject: hooks: ovs: skip non-vNic device's XML .. Patch Set 6: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matche

Change in vdsm[master]: hooks: ovs: skip non-vNic device's XML

2015-12-03 Thread phoracek
Petr Horáček has posted comments on this change. Change subject: hooks: ovs: skip non-vNic device's XML .. Patch Set 6: Verified+1 Just changed the test, it passes now. -- To view, visit https://gerrit.ovirt.org/49183 To unsu

Change in vdsm[master]: hooks: ovs: skip non-vNic device's XML

2015-12-03 Thread automation
gerrit-hooks has posted comments on this change. Change subject: hooks: ovs: skip non-vNic device's XML .. Patch Set 5: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matche

Change in vdsm[master]: virt: run hook before_device_create on every device

2015-12-03 Thread phoracek
Petr Horáček has posted comments on this change. Change subject: virt: run hook before_device_create on every device .. Patch Set 2: we need this in 3.6 as well. but we could just use a custom vNIC property in Engine which wil

Change in vdsm[master]: hooks: ovs: run ovs _configure only if there are changes to do

2015-12-03 Thread phoracek
Petr Horáček has posted comments on this change. Change subject: hooks: ovs: run ovs _configure only if there are changes to do .. Patch Set 2: Verified+1 passed ovs tests without a regression when rebased on the too of I73ab5

Change in vdsm[ovirt-3.5]: vm: more robust support of event strings

2015-12-03 Thread automation
gerrit-hooks has posted comments on this change. Change subject: vm: more robust support of event strings .. Patch Set 1: * #1284564::Update tracker: OK * Check Bug-Url::OK * Check Public Bug::#1284564::OK, public bug * Check P

Change in vdsm[ovirt-3.5]: spec: clean up selinux requirement

2015-12-03 Thread automation
gerrit-hooks has posted comments on this change. Change subject: spec: clean up selinux requirement .. Patch Set 2: Verified-1 * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::ERROR, At least one bug-url is required

Change in vdsm[ovirt-3.5]: vm: reformat _EVENT_STRINGS

2015-12-03 Thread fromani
Hello Dan Kenigsberg, Milan Zamazal, I'd like you to do a code review. Please visit https://gerrit.ovirt.org/49673 to review the following change. Change subject: vm: reformat _EVENT_STRINGS .. vm: reformat _EVENT_STRINGS

Change in vdsm[ovirt-3.5]: vm: more robust support of event strings

2015-12-03 Thread fromani
Hello Dan Kenigsberg, Milan Zamazal, I'd like you to do a code review. Please visit https://gerrit.ovirt.org/49675 to review the following change. Change subject: vm: more robust support of event strings .. vm: more robus

Change in vdsm[ovirt-3.5]: vm: reformat _EVENT_STRINGS

2015-12-03 Thread automation
gerrit-hooks has posted comments on this change. Change subject: vm: reformat _EVENT_STRINGS .. Patch Set 1: * #1284564::Update tracker: OK * Check Bug-Url::OK * Check Public Bug::#1284564::OK, public bug * Check Product::#1284

Change in vdsm[ovirt-3.5]: vm: add support for "Crashed" event

2015-12-03 Thread automation
gerrit-hooks has posted comments on this change. Change subject: vm: add support for "Crashed" event .. Patch Set 1: * #1284564::Update tracker: OK * Check Bug-Url::OK * Check Public Bug::#1284564::OK, public bug * Check Produc

Change in vdsm[ovirt-3.5]: vm: add support for "Crashed" event

2015-12-03 Thread fromani
Hello Dan Kenigsberg, Milan Zamazal, I'd like you to do a code review. Please visit https://gerrit.ovirt.org/49674 to review the following change. Change subject: vm: add support for "Crashed" event .. vm: add support for

Change in vdsm[master]: hooks: ovs: run ovs _configure only if there are changes to do

2015-12-03 Thread automation
gerrit-hooks has posted comments on this change. Change subject: hooks: ovs: run ovs _configure only if there are changes to do .. Patch Set 2: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found,

Change in vdsm[master]: exception: Gather exceptions in vdsm.exception

2015-12-03 Thread piotr . kliczewski
Piotr Kliczewski has posted comments on this change. Change subject: exception: Gather exceptions in vdsm.exception .. Patch Set 3: Code-Review+1 So for that we need to have code which will be shared by the client (code runnin

Change in vdsm[master]: migration: make status field private

2015-12-03 Thread fromani
Francesco Romani has posted comments on this change. Change subject: migration: make status field private .. Patch Set 2: Verified+1 -- To view, visit https://gerrit.ovirt.org/49522 To unsubscribe, visit https://gerrit.ovirt.o

Change in vdsm[master]: migration: make status field private

2015-12-03 Thread automation
gerrit-hooks has posted comments on this change. Change subject: migration: make status field private .. Patch Set 2: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches

Change in vdsm[master]: migration: don't mess up with _status fields

2015-12-03 Thread automation
gerrit-hooks has posted comments on this change. Change subject: migration: don't mess up with _status fields .. Patch Set 2: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header

Change in vdsm[master]: migration: track and report abort reason

2015-12-03 Thread automation
gerrit-hooks has posted comments on this change. Change subject: migration: track and report abort reason .. Patch Set 2: * #1154397::Update tracker: OK * Check Bug-Url::OK * Check Public Bug::#1154397::OK, public bug * Check P

Change in vdsm[master]: virt: do not use status after getStat()

2015-12-03 Thread automation
gerrit-hooks has posted comments on this change. Change subject: virt: do not use status after getStat() .. Patch Set 12: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matc

Change in vdsm[master]: migration: return copy of internal status

2015-12-03 Thread automation
gerrit-hooks has posted comments on this change. Change subject: migration: return copy of internal status .. Patch Set 2: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header mat

Change in vdsm[master]: virt: enhance migration.SourceThread.stop()

2015-12-03 Thread automation
gerrit-hooks has posted comments on this change. Change subject: virt: enhance migration.SourceThread.stop() .. Patch Set 14: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header

Change in vdsm[master]: virt: enhance migration.SourceThread.stop()

2015-12-03 Thread fromani
Francesco Romani has posted comments on this change. Change subject: virt: enhance migration.SourceThread.stop() .. Patch Set 13: Verified+1 verified succesfully migrating a VM over patched VDSM, and succesfully canceling migr

Change in vdsm[master]: migration: make status field private

2015-12-03 Thread fromani
Francesco Romani has posted comments on this change. Change subject: migration: make status field private .. Patch Set 1: verified succesfully migrating a VM over patched VDSM, and succesfully canceling migration. -- To view

Change in vdsm[master]: virt: do not use status after getStat()

2015-12-03 Thread fromani
Francesco Romani has posted comments on this change. Change subject: virt: do not use status after getStat() .. Patch Set 11: Verified+1 verified succesfully migrating a VM over patched VDSM, and succesfully canceling migratio

Change in vdsm[ovirt-3.6]: vm: move device attached check to device itself

2015-12-03 Thread automation
gerrit-hooks has posted comments on this change. Change subject: vm: move device attached check to device itself .. Patch Set 1: * #1134256::Update tracker: OK * Check Bug-Url::OK * Check Public Bug::#1134256::OK, public bug *

Change in vdsm[ovirt-3.6]: lib: daemon: autodetect online cpus for affinity

2015-12-03 Thread piotr . kliczewski
Piotr Kliczewski has posted comments on this change. Change subject: lib: daemon: autodetect online cpus for affinity .. Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/49612 To unsubscribe, visit https:/

  1   2   3   4   >