Milan Zamazal has posted comments on this change.
Change subject: vm: add support for "Crashed" event
..
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/49674
To unsubscribe, visit https://gerrit.ovirt.or
Milan Zamazal has posted comments on this change.
Change subject: vm: more robust support of event strings
..
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/49675
To unsubscribe, visit https://gerrit.ovi
Milan Zamazal has posted comments on this change.
Change subject: vm: reformat _EVENT_STRINGS
..
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/49673
To unsubscribe, visit https://gerrit.ovirt.org/settin
Nir Soffer has posted comments on this change.
Change subject: VolumeMetadata: Move isLeaf, setLeaf and dependencies
..
Patch Set 23:
This version adds most of the missing redirection tests, and change static
method to class m
gerrit-hooks has posted comments on this change.
Change subject: VolumeMetadata: Move isLeaf, setLeaf and dependencies
..
Patch Set 23:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make su
gerrit-hooks has posted comments on this change.
Change subject: hooks: ovs: fix getVdsCaps and getVdsStats
..
Patch Set 1:
* #1234867::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1234867::OK, public bug
* Check
gerrit-hooks has posted comments on this change.
Change subject: hooks: ovs: use six.iteritems and six.itervalues
..
Patch Set 1:
* #1234867::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1234867::OK, public bug
*
gerrit-hooks has posted comments on this change.
Change subject: hooks: ovs: add script name to log
..
Patch Set 1:
* #1234867::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1234867::OK, public bug
* Check Product
gerrit-hooks has posted comments on this change.
Change subject: hooks: ovs: pass ip configuration as a namedtuple
..
Patch Set 1:
* #1234867::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1234867::OK, public bug
gerrit-hooks has posted comments on this change.
Change subject: net: ovs: remove initial nic ip, dont touch unchanged networks
..
Patch Set 1:
* #1234867::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1234867::OK
gerrit-hooks has posted comments on this change.
Change subject: hooks: ovs: better rollback
..
Patch Set 1:
* #1234867::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1234867::OK, public bug
* Check Product::#1234
gerrit-hooks has posted comments on this change.
Change subject: hooks: ovs: remove unused parameter
..
Patch Set 1:
* #1234867::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1234867::OK, public bug
* Check Produc
gerrit-hooks has posted comments on this change.
Change subject: hooks: Open vSwitch configurator
..
Patch Set 1:
* #1234867::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1234867::OK, public bug
* Check Product::
gerrit-hooks has posted comments on this change.
Change subject: hooks: ovs: move libvirt configuration into a separate module
..
Patch Set 1:
* #1234867::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1234867::OK,
gerrit-hooks has posted comments on this change.
Change subject: net: multicast snooping is not supported by ovs until 2.4.0
..
Patch Set 1:
* #1234867::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1234867::OK, p
Hello Ido Barkan, Ondřej Svoboda, Dan Kenigsberg,
I'd like you to do a code review. Please visit
https://gerrit.ovirt.org/49691
to review the following change.
Change subject: hooks: ovs: move libvirt configuration into a separate module
Hello Ido Barkan, Dan Kenigsberg,
I'd like you to do a code review. Please visit
https://gerrit.ovirt.org/49698
to review the following change.
Change subject: hooks: ovs: fix getVdsCaps and getVdsStats
..
hooks: ovs: fix
Hello Ido Barkan, Dan Kenigsberg,
I'd like you to do a code review. Please visit
https://gerrit.ovirt.org/49697
to review the following change.
Change subject: hooks: ovs: use six.iteritems and six.itervalues
..
hooks: ov
gerrit-hooks has posted comments on this change.
Change subject: hooks: after_network_setup_fail
..
Patch Set 1:
* #1234867::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1234867::OK, public bug
* Check Product::#
Hello Dan Kenigsberg,
I'd like you to do a code review. Please visit
https://gerrit.ovirt.org/49687
to review the following change.
Change subject: net: sysctl: enable ipv6
..
net: sysctl: enable ipv6
Enable sysctl.py:di
Hello Ido Barkan, Dan Kenigsberg,
I'd like you to do a code review. Please visit
https://gerrit.ovirt.org/49695
to review the following change.
Change subject: net: ovs: remove initial nic ip, dont touch unchanged networks
...
Hello Dan Kenigsberg,
I'd like you to do a code review. Please visit
https://gerrit.ovirt.org/49696
to review the following change.
Change subject: hooks: ovs: add script name to log
..
hooks: ovs: add script name to log
Hello Ido Barkan, Dan Kenigsberg,
I'd like you to do a code review. Please visit
https://gerrit.ovirt.org/49693
to review the following change.
Change subject: hooks: ovs: better rollback
..
hooks: ovs: better rollback
U
Hello Ido Barkan, Dan Kenigsberg,
I'd like you to do a code review. Please visit
https://gerrit.ovirt.org/49692
to review the following change.
Change subject: hooks: ovs: remove unused parameter
..
hooks: ovs: remove unu
gerrit-hooks has posted comments on this change.
Change subject: net: sysctl: enable ipv6
..
Patch Set 1:
* #1234867::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1234867::OK, public bug
* Check Product::#1234867
Hello Ido Barkan, Dan Kenigsberg,
I'd like you to do a code review. Please visit
https://gerrit.ovirt.org/49690
to review the following change.
Change subject: net: multicast snooping is not supported by ovs until 2.4.0
..
Hello Ido Barkan, Dan Kenigsberg,
I'd like you to do a code review. Please visit
https://gerrit.ovirt.org/49688
to review the following change.
Change subject: hooks: after_network_setup_fail
..
hooks: after_network_setup
Hello Ido Barkan, Dan Kenigsberg,
I'd like you to do a code review. Please visit
https://gerrit.ovirt.org/49694
to review the following change.
Change subject: hooks: ovs: pass ip configuration as a namedtuple
..
hooks: o
Nir Soffer has posted comments on this change.
Change subject: sdm: Create the storage/sdm directory
..
Patch Set 1: Code-Review-1
(1 comment)
https://gerrit.ovirt.org/#/c/49686/1/vdsm/storage/sdm/__init__.py
File vdsm/storage
Nir Soffer has posted comments on this change.
Change subject: tests: add FakeSanlock.init_resource
..
Patch Set 3: Continuous-Integration+1
CI not need for this change.
--
To view, visit https://gerrit.ovirt.org/49542
To uns
Nir Soffer has submitted this change and it was merged.
Change subject: tests: add FakeSanlock.init_resource
..
tests: add FakeSanlock.init_resource
init_resource is called by VolumeMetadata.newVolumeLease. When unit
testing w
gerrit-hooks has posted comments on this change.
Change subject: tests: add FakeSanlock.init_resource
..
Patch Set 4:
* Update tracker: IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no Bug-Url found.
--
To view, visit http
Nir Soffer has posted comments on this change.
Change subject: StorageDomainManifest: Manifest objects produce VolumeMetadata
objects
..
Patch Set 7:
(1 comment)
https://gerrit.ovirt.org/#/c/44040/7//COMMIT_MSG
Commit Message
Adam Litke has posted comments on this change.
Change subject: StorageDomainManifest: Manifest objects produce VolumeMetadata
objects
..
Patch Set 7:
(1 comment)
https://gerrit.ovirt.org/#/c/44040/7//COMMIT_MSG
Commit Message
Nir Soffer has posted comments on this change.
Change subject: StorageDomainManifest: Manifest objects produce VolumeMetadata
objects
..
Patch Set 7: Code-Review-1
(1 comment)
https://gerrit.ovirt.org/#/c/44040/7//COMMIT_MSG
Jenkins CI has posted comments on this change.
Change subject: guest-agent: desktopLock exception on EBADF should be ignored
..
Patch Set 8:
Propagate review hook: Continuous Integration value inherited from patch 7
--
To vie
Nir Soffer has posted comments on this change.
Change subject: tests: add FakeSanlock.init_resource
..
Patch Set 3: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/49542
To unsubscribe, visit https://gerrit.ovirt.org/
Adam Litke has posted comments on this change.
Change subject: tests: add FakeSanlock.init_resource
..
Patch Set 3: Verified+1
Verified with 'make check'. New function isn't being called yet.
--
To view, visit https://gerrit
gerrit-hooks has posted comments on this change.
Change subject: StorageDomainManifest: Manifest objects produce VolumeMetadata
objects
..
Patch Set 7:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug u
gerrit-hooks has posted comments on this change.
Change subject: tests: add FakeSanlock.init_resource
..
Patch Set 3:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches
gerrit-hooks has posted comments on this change.
Change subject: tests: add FakeSanlock.init_resource
..
Patch Set 2:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches
Adam Litke has posted comments on this change.
Change subject: sdm: Create the storage/sdm directory
..
Patch Set 1: Verified+1
Verified with 'make check' and 'make rpm'
--
To view, visit https://gerrit.ovirt.org/49686
To uns
Adam Litke has uploaded a new change for review.
Change subject: sdm: Create the storage/sdm directory
..
sdm: Create the storage/sdm directory
New SDM code including the verbs and supporting utility functions need
an organized
gerrit-hooks has posted comments on this change.
Change subject: sdm: Create the storage/sdm directory
..
Patch Set 1:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches
Francesco Romani has posted comments on this change.
Change subject: vm: check operation result for vm nic hotunplug
..
Patch Set 1: Code-Review+1
I need to make sure this is OK for stable branch (seems so, but I want to do a
Francesco Romani has posted comments on this change.
Change subject: vm: unit test for vm._waitForDriveRemoval
..
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/49668
To unsubscribe, visit https://gerrit
Adam Litke has posted comments on this change.
Change subject: getAllImages: Use manifest attributes when constructing glob
pattern
..
Patch Set 2: Verified+1
Verified with make check and the included test case.
--
To view,
Francesco Romani has posted comments on this change.
Change subject: vm: adding xpath property to device Base class
..
Patch Set 2: Code-Review-1
no longer needed in this form, as per my previous comment.
--
To view, visit ht
gerrit-hooks has posted comments on this change.
Change subject: spec: clean up selinux requirement
..
Patch Set 3:
* Update tracker: IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no Bug-Url found.
--
To view, visit https:
Francesco Romani has posted comments on this change.
Change subject: spec: clean up selinux requirement
..
Patch Set 2: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/49088
To unsubscribe, visit https://gerrit.ovirt.
Francesco Romani has submitted this change and it was merged.
Change subject: spec: clean up selinux requirement
..
spec: clean up selinux requirement
While spec files support the syntax of
package_name >= package_name-version,
Francesco Romani has posted comments on this change.
Change subject: spec: clean up selinux requirement
..
Patch Set 2: Continuous-Integration+1 Verified+1
verified manually building and installing packages on centos 7 and rhel
Francesco Romani has posted comments on this change.
Change subject: spec: clean up selinux requirement
..
Patch Set 2:
since this is a cleanup (which actually helps for me, not sure why was not
spotted before), I'm making an
Nir Soffer has posted comments on this change.
Change subject: vm: adding xpath property to device Base class
..
Patch Set 2: Code-Review-1
Marcin, Francesco agrees that this is not needed, so you can abandon this patch.
--
T
Nir Soffer has posted comments on this change.
Change subject: getAllImages: Use manifest attributes when constructing glob
pattern
..
Patch Set 2:
Verify (with a flow that use this code) and we can merge this.
--
To view, v
Nir Soffer has posted comments on this change.
Change subject: getAllImages: Use manifest attributes when constructing glob
pattern
..
Patch Set 2: Code-Review+2
It looks better with the test, and I agree that we don't testing
gerrit-hooks has posted comments on this change.
Change subject: getAllImages: Use manifest attributes when constructing glob
pattern
..
Patch Set 2:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url
Adam Litke has posted comments on this change.
Change subject: getAllImages: Use manifest attributes when constructing glob
pattern
..
Patch Set 1:
The test you are asking for doesn't make sense. You're asking me to
monkeypa
Nir Soffer has posted comments on this change.
Change subject: network: Use new concurrent.thread() utility
..
Patch Set 3:
ping
--
To view, visit https://gerrit.ovirt.org/45553
To unsubscribe, visit https://gerrit.ovirt.org/
Nir Soffer has posted comments on this change.
Change subject: getAllImages: Use manifest attributes when constructing glob
pattern
..
Patch Set 1: Code-Review-1
Looks good, but I would like a test in a previous patch before w
gerrit-hooks has posted comments on this change.
Change subject: getAllImages: Use manifest attributes when constructing glob
pattern
..
Patch Set 1:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url
Adam Litke has uploaded a new change for review.
Change subject: getAllImages: Use manifest attributes when constructing glob
pattern
..
getAllImages: Use manifest attributes when constructing glob pattern
getAllImages searches
Nir Soffer has posted comments on this change.
Change subject: Adding compatibility for ovirt-engine 4.0 support
..
Patch Set 2:
Waiting for Dan
--
To view, visit https://gerrit.ovirt.org/49060
To unsubscribe, visit https://g
Nir Soffer has posted comments on this change.
Change subject: Adding compatibility for ovirt-engine 4.0 support
..
Patch Set 2: Code-Review+2
We need it now for storage, sdm mode will required this cluster version.
--
To vie
Nir Soffer has posted comments on this change.
Change subject: vm: unit test for vm._waitForDriveRemoval
..
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/49668
To unsubscribe, visit https://gerrit.ovirt
Nir Soffer has posted comments on this change.
Change subject: vm: move device attached check to device itself
..
Patch Set 1: Code-Review-1
This patch is not required for 3.6, but it will be nicer to have it so we have
the sa
Nir Soffer has posted comments on this change.
Change subject: vm: add test for nic unplug wait
..
Patch Set 1: Code-Review-1
Please reorder this patch before the previous one, like it was merged into
master.
--
To view, vis
Nir Soffer has submitted this change and it was merged.
Change subject: modpobe: Remove EL6 path
..
modpobe: Remove EL6 path
Removed the reference to /sbin/modprobe (which is used in EL6), as we no
longer support this platform.
gerrit-hooks has posted comments on this change.
Change subject: modpobe: Remove EL6 path
..
Patch Set 2:
* Update tracker: IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no Bug-Url found.
--
To view, visit https://gerrit.o
gerrit-hooks has posted comments on this change.
Change subject: Adding to vdsm automation lago env setup for functional tests
..
Patch Set 16:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found,
gerrit-hooks has posted comments on this change.
Change subject: hooks: ovs: use a class instead of NamedTuple for IPConfig
..
Patch Set 4:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, mak
Petr Horáček has posted comments on this change.
Change subject: hooks: ovs: use a class instead of NamedTuple for IPConfig
..
Patch Set 3:
(1 comment)
https://gerrit.ovirt.org/#/c/49235/3/vdsm_hooks/ovs/ovs_before_network_set
Petr Horáček has posted comments on this change.
Change subject: hooks: ovs: set OVS devices UP
..
Patch Set 6:
now it's ready
--
To view, visit https://gerrit.ovirt.org/48388
To unsubscribe, visit https://gerrit.ovirt.org/se
gerrit-hooks has posted comments on this change.
Change subject: hooks: ovs: set OVS devices UP
..
Patch Set 6:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-U
gerrit-hooks has posted comments on this change.
Change subject: hooks: ovs: skip non-vNic device's XML
..
Patch Set 6:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matche
Petr Horáček has posted comments on this change.
Change subject: hooks: ovs: skip non-vNic device's XML
..
Patch Set 6: Verified+1
Just changed the test, it passes now.
--
To view, visit https://gerrit.ovirt.org/49183
To unsu
gerrit-hooks has posted comments on this change.
Change subject: hooks: ovs: skip non-vNic device's XML
..
Patch Set 5:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matche
Petr Horáček has posted comments on this change.
Change subject: virt: run hook before_device_create on every device
..
Patch Set 2:
we need this in 3.6 as well. but we could just use a custom vNIC property in
Engine which wil
Petr Horáček has posted comments on this change.
Change subject: hooks: ovs: run ovs _configure only if there are changes to do
..
Patch Set 2: Verified+1
passed ovs tests without a regression when rebased on the too of
I73ab5
gerrit-hooks has posted comments on this change.
Change subject: vm: more robust support of event strings
..
Patch Set 1:
* #1284564::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1284564::OK, public bug
* Check P
gerrit-hooks has posted comments on this change.
Change subject: spec: clean up selinux requirement
..
Patch Set 2: Verified-1
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::ERROR, At least one bug-url is required
Hello Dan Kenigsberg, Milan Zamazal,
I'd like you to do a code review. Please visit
https://gerrit.ovirt.org/49673
to review the following change.
Change subject: vm: reformat _EVENT_STRINGS
..
vm: reformat _EVENT_STRINGS
Hello Dan Kenigsberg, Milan Zamazal,
I'd like you to do a code review. Please visit
https://gerrit.ovirt.org/49675
to review the following change.
Change subject: vm: more robust support of event strings
..
vm: more robus
gerrit-hooks has posted comments on this change.
Change subject: vm: reformat _EVENT_STRINGS
..
Patch Set 1:
* #1284564::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1284564::OK, public bug
* Check Product::#1284
gerrit-hooks has posted comments on this change.
Change subject: vm: add support for "Crashed" event
..
Patch Set 1:
* #1284564::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1284564::OK, public bug
* Check Produc
Hello Dan Kenigsberg, Milan Zamazal,
I'd like you to do a code review. Please visit
https://gerrit.ovirt.org/49674
to review the following change.
Change subject: vm: add support for "Crashed" event
..
vm: add support for
gerrit-hooks has posted comments on this change.
Change subject: hooks: ovs: run ovs _configure only if there are changes to do
..
Patch Set 2:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found,
Piotr Kliczewski has posted comments on this change.
Change subject: exception: Gather exceptions in vdsm.exception
..
Patch Set 3: Code-Review+1
So for that we need to have code which will be shared by the client (code
runnin
Francesco Romani has posted comments on this change.
Change subject: migration: make status field private
..
Patch Set 2: Verified+1
--
To view, visit https://gerrit.ovirt.org/49522
To unsubscribe, visit https://gerrit.ovirt.o
gerrit-hooks has posted comments on this change.
Change subject: migration: make status field private
..
Patch Set 2:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches
gerrit-hooks has posted comments on this change.
Change subject: migration: don't mess up with _status fields
..
Patch Set 2:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
gerrit-hooks has posted comments on this change.
Change subject: migration: track and report abort reason
..
Patch Set 2:
* #1154397::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1154397::OK, public bug
* Check P
gerrit-hooks has posted comments on this change.
Change subject: virt: do not use status after getStat()
..
Patch Set 12:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matc
gerrit-hooks has posted comments on this change.
Change subject: migration: return copy of internal status
..
Patch Set 2:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header mat
gerrit-hooks has posted comments on this change.
Change subject: virt: enhance migration.SourceThread.stop()
..
Patch Set 14:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
Francesco Romani has posted comments on this change.
Change subject: virt: enhance migration.SourceThread.stop()
..
Patch Set 13: Verified+1
verified succesfully migrating a VM over patched VDSM, and succesfully
canceling migr
Francesco Romani has posted comments on this change.
Change subject: migration: make status field private
..
Patch Set 1:
verified succesfully migrating a VM over patched VDSM, and succesfully
canceling migration.
--
To view
Francesco Romani has posted comments on this change.
Change subject: virt: do not use status after getStat()
..
Patch Set 11: Verified+1
verified succesfully migrating a VM over patched VDSM, and succesfully
canceling migratio
gerrit-hooks has posted comments on this change.
Change subject: vm: move device attached check to device itself
..
Patch Set 1:
* #1134256::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1134256::OK, public bug
*
Piotr Kliczewski has posted comments on this change.
Change subject: lib: daemon: autodetect online cpus for affinity
..
Patch Set 2: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/49612
To unsubscribe, visit https:/
1 - 100 of 331 matches
Mail list logo