Francesco Romani has posted comments on this change.
Change subject: lib: executor: report worker status in __repr__
..
Patch Set 3:
(1 comment)
https://gerrit.ovirt.org/#/c/49722/3/lib/vdsm/executor.py
File lib/vdsm/executor.
Francesco Romani has posted comments on this change.
Change subject: vm: enabling memory snapshot without disks
..
Patch Set 1: Code-Review+1
looks fine, I see the BZ targeted for 3.6.2. Will merge once the 3.6.1 branch
is cre
Francesco Romani has posted comments on this change.
Change subject: executor: Rename self._callabale to self._task
..
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/50228
To unsubscribe, visit https://g
Francesco Romani has posted comments on this change.
Change subject: vm: enabling memory snapshot without disks
..
Patch Set 1:
the flow should be identical in master and 3.6.
--
To view, visit https://gerrit.ovirt.org/50199
Francesco Romani has posted comments on this change.
Change subject: vm: enabling memory snapshot without disks
..
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/50199
To unsubscribe, visit https://gerri
Dan Kenigsberg has posted comments on this change.
Change subject: Adding to vdsm automation lago env setup for functional tests
..
Patch Set 17: Code-Review-1
(1 comment)
https://gerrit.ovirt.org/#/c/48268/17/automation/check
Nir Soffer has posted comments on this change.
Change subject: sdm: Add create_volume_container job
..
Patch Set 1:
(1 comment)
https://gerrit.ovirt.org/#/c/50221/1/vdsm/storage/sdm/jobs/Makefile.am
File vdsm/storage/sdm/jobs/
Nir Soffer has posted comments on this change.
Change subject: executor: Rename self._callabale to self._task
..
Patch Set 1: Verified+1
Verified using the tests.
--
To view, visit https://gerrit.ovirt.org/50228
To unsubscrib
Nir Soffer has posted comments on this change.
Change subject: lib: executor: report worker status in __repr__
..
Patch Set 3:
(1 comment)
https://gerrit.ovirt.org/#/c/49722/3/lib/vdsm/executor.py
File lib/vdsm/executor.py:
L
gerrit-hooks has posted comments on this change.
Change subject: executor: Rename self._callabale to self._task
..
Patch Set 1:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure heade
Nir Soffer has uploaded a new change for review.
Change subject: executor: Rename self._callabale to self._task
..
executor: Rename self._callabale to self._task
We are using this term in this module, so lets be consistent.
Cha
Nir Soffer has posted comments on this change.
Change subject: lib: executor: report worker status in __repr__
..
Patch Set 3:
(1 comment)
https://gerrit.ovirt.org/#/c/49722/3/lib/vdsm/executor.py
File lib/vdsm/executor.py:
L
Nir Soffer has posted comments on this change.
Change subject: gluster: Warn instead of failing for unsupported gluster
replica modes
..
Patch Set 8: Code-Review-1
(1 comment)
https://gerrit.ovirt.org/#/c/50119/8/vdsm/storage
Nir Soffer has posted comments on this change.
Change subject: Introduce VolumeArtifacts
..
Patch Set 4:
(1 comment)
https://gerrit.ovirt.org/#/c/48097/4/vdsm/storage/sdm/volumeartifacts.py
File vdsm/storage/sdm/volumeartifact
Nir Soffer has posted comments on this change.
Change subject: sdm: Add create_volume_container job
..
Patch Set 1:
(3 comments)
https://gerrit.ovirt.org/#/c/50221/1/vdsm/storage/sdm/jobs/createVolumeContainer.py
File vdsm/sto
Nir Soffer has posted comments on this change.
Change subject: sdm: Add create_volume_container job
..
Patch Set 1:
(6 comments)
https://gerrit.ovirt.org/#/c/50221/1/vdsm/storage/sdm/Makefile.am
File vdsm/storage/sdm/Makefile.
Nir Soffer has posted comments on this change.
Change subject: storage: Introduction to transfer.py
..
Patch Set 2:
Partial review, we should first decided on the api, and later we can review the
implementation.
--
To view,
Nir Soffer has posted comments on this change.
Change subject: storage: Introduction to transfer.py
..
Patch Set 2:
(21 comments)
https://gerrit.ovirt.org/#/c/50014/2/vdsm/storage/Makefile.am
File vdsm/storage/Makefile.am:
Li
Adam Litke has posted comments on this change.
Change subject: sdm: Add create_volume_container job
..
Patch Set 1:
(4 comments)
https://gerrit.ovirt.org/#/c/50221/1/vdsm/storage/sdm/jobs/sdmJob.py
File vdsm/storage/sdm/jobs/s
Adam Litke has posted comments on this change.
Change subject: sdm: Add create_volume_container job
..
Patch Set 1:
(12 comments)
https://gerrit.ovirt.org/#/c/50221/1/vdsm/storage/sdm/Makefile.am
File vdsm/storage/sdm/Makefile
Nir Soffer has posted comments on this change.
Change subject: storage: Introduction to transfer.py
..
Patch Set 2:
(3 comments)
https://gerrit.ovirt.org/#/c/50014/2/lib/api/vdsmapi-schema.json
File lib/api/vdsmapi-schema.json
Nir Soffer has posted comments on this change.
Change subject: sdm: add create_volume_container API stub
..
Patch Set 1: Code-Review-1
(10 comments)
https://gerrit.ovirt.org/#/c/50220/1/client/vdsClient.py
File client/vdsClien
Nir Soffer has posted comments on this change.
Change subject: sdm: Add create_volume_container job
..
Patch Set 1: Code-Review-1
(25 comments)
I like it
https://gerrit.ovirt.org/#/c/50221/1/tests/sdm_verbs_test.py
File tests
Adam Litke has posted comments on this change.
Change subject: storage: Introduction to transfer.py
..
Patch Set 2:
(3 comments)
https://gerrit.ovirt.org/#/c/50014/2/lib/api/vdsmapi-schema.json
File lib/api/vdsmapi-schema.json
Nir Soffer has posted comments on this change.
Change subject: Remove koji build flag and use specific one for vhostmd
..
Patch Set 3: Code-Review+1
Piotr, can you ack this?
--
To view, visit https://gerrit.ovirt.org/49427
To
Nir Soffer has posted comments on this change.
Change subject: storage: Introduction to transfer.py
..
Patch Set 2:
(9 comments)
https://gerrit.ovirt.org/#/c/50014/2/lib/api/vdsmapi-schema.json
File lib/api/vdsmapi-schema.json
Nir Soffer has posted comments on this change.
Change subject: API: Add api for getting host jobs info
..
Patch Set 1:
(2 comments)
https://gerrit.ovirt.org/#/c/49451/1/lib/api/vdsmapi-schema.json
File lib/api/vdsmapi-schema.j
Daniel Erez has posted comments on this change.
Change subject: vm: enabling memory snapshot without disks
..
Patch Set 1: Verified+1
--
To view, visit https://gerrit.ovirt.org/50199
To unsubscribe, visit https://gerrit.ovirt.
Adam Litke has posted comments on this change.
Change subject: sdm: Add create_volume_container job
..
Patch Set 1:
(1 comment)
https://gerrit.ovirt.org/#/c/50221/1/tests/storagefakelib.py
File tests/storagefakelib.py:
Line 2
gerrit-hooks has posted comments on this change.
Change subject: sdm: Add create_volume_container job
..
Patch Set 1:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches
Adam Litke has uploaded a new change for review.
Change subject: sdm: add create_volume_container API stub
..
sdm: add create_volume_container API stub
Change-Id: I1ff2656f2dd427812e557e6587429759a9c0a845
Signed-off-by: Adam Lit
gerrit-hooks has posted comments on this change.
Change subject: Introduce VolumeArtifacts
..
Patch Set 6:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: '
Adam Litke has uploaded a new change for review.
Change subject: storage: Add _getDeletedImagePath until patch merged
..
storage: Add _getDeletedImagePath until patch merged
Waiting on: https://gerrit.ovirt.org/#/c/48477/4
Chan
Adam Litke has uploaded a new change for review.
Change subject: sdm: Add create_volume_container job
..
sdm: Add create_volume_container job
XXX: Update packaging scripts
Change-Id: Ia614059f52c9625da7841ea9fbca2b2f2375cd75
Si
Adam Litke has uploaded a new change for review.
Change subject: sdm: Create the storage/sdm directory
..
sdm: Create the storage/sdm directory
New SDM code including the verbs and supporting utility functions need
an organized
gerrit-hooks has posted comments on this change.
Change subject: sdm: add create_volume_container API stub
..
Patch Set 1:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header mat
gerrit-hooks has posted comments on this change.
Change subject: sdm: Create the storage/sdm directory
..
Patch Set 1:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches
gerrit-hooks has posted comments on this change.
Change subject: storage: Add _getDeletedImagePath until patch merged
..
Patch Set 1:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure
gerrit-hooks has posted comments on this change.
Change subject: fileVolume: refactor _putMetadata to support volume artifacts
..
Patch Set 3:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found,
Nir Soffer has posted comments on this change.
Change subject: stomp: make sure that subscriptions use uniqe id
..
Patch Set 3: -Code-Review
Waiting for reviews from Yaniv and Yeela.
--
To view, visit https://gerrit.ovirt.org
Nir Soffer has posted comments on this change.
Change subject: virt: vm: Update time on VM after resume
..
Patch Set 7:
(1 comment)
https://gerrit.ovirt.org/#/c/48860/7/vdsm/virt/vm.py
File vdsm/virt/vm.py:
Line 1204:
Nir Soffer has posted comments on this change.
Change subject: virt: Add support for vgamem attribute
..
Patch Set 2: Code-Review-1
(1 comment)
Looks good, needs more info in the schema.
https://gerrit.ovirt.org/#/c/50091/2/l
Nir Soffer has posted comments on this change.
Change subject: v2v: Use tarfile instead of running tar process
..
Patch Set 4: Code-Review+1
Shahar, please get ack from Francesco and other reviewer.
--
To view, visit https://
Nir Soffer has posted comments on this change.
Change subject: v2v: add test to v2v._read_ovf_from_tar_ova
..
Patch Set 3:
(1 comment)
Nice!
https://gerrit.ovirt.org/#/c/50158/3/tests/v2vTests.py
File tests/v2vTests.py:
Line
Nir Soffer has posted comments on this change.
Change subject: Makefile: use tox to run make pep8 and pyflakes
..
Patch Set 1:
(2 comments)
https://gerrit.ovirt.org/#/c/49952/1/Makefile.am
File Makefile.am:
Line 47:py
Nir Soffer has submitted this change and it was merged.
Change subject: avoid running pep8 and pyflakes on py.in files
..
avoid running pep8 and pyflakes on py.in files
Change-Id: I76d5e555455d1b4acc568a42b864e220c79ab6fa
Signe
gerrit-hooks has posted comments on this change.
Change subject: avoid running pep8 and pyflakes on py.in files
..
Patch Set 4:
* Update tracker: IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no Bug-Url found.
--
To view,
gerrit-hooks has posted comments on this change.
Change subject: avoid running pep8 and pyflakes on py.in files
..
Patch Set 3:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure heade
Nir Soffer has posted comments on this change.
Change subject: avoid running pep8 and pyflakes on py.in files
..
Patch Set 3: Code-Review+2 Continuous-Integration+1 Verified+1
Added whitespace, copying flags.
--
To view, visi
Nir Soffer has posted comments on this change.
Change subject: avoid running pep8 and pyflakes on py.in files
..
Patch Set 2: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/50101
To unsubscribe, visit https://gerrit.
Nir Soffer has posted comments on this change.
Change subject: jsonrpcvdscli: improve functional network tests duration time
..
Patch Set 3: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/48356
To unsubscribe, visit
gerrit-hooks has posted comments on this change.
Change subject: migration: return copy of internal status
..
Patch Set 5:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header mat
gerrit-hooks has posted comments on this change.
Change subject: virt: do not use status after getStat()
..
Patch Set 15:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matc
gerrit-hooks has posted comments on this change.
Change subject: migration: make status field private
..
Patch Set 5:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches
gerrit-hooks has posted comments on this change.
Change subject: migration: don't mess up with _status fields
..
Patch Set 5:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
gerrit-hooks has posted comments on this change.
Change subject: migration: track and report abort reason
..
Patch Set 5:
* #1154397::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1154397::OK, public bug
* Check P
gerrit-hooks has posted comments on this change.
Change subject: virt: enhance migration.SourceThread.stop()
..
Patch Set 17:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
Petr Horáček has posted comments on this change.
Change subject: sourceroute: move exception handling to the respective
configurator
..
Patch Set 5: Code-Review-1
(1 comment)
https://gerrit.ovirt.org/#/c/41594/5//COMMIT_MSG
C
Petr Horáček has posted comments on this change.
Change subject: sourceroute: split gathering of routes and rules off
configure() and remove()
..
Patch Set 4: Code-Review-1
(1 comment)
just a question, -1 for attention
https
Petr Horáček has posted comments on this change.
Change subject: api: support multiple 'ipv6addrs' per network
..
Patch Set 10:
(1 comment)
just a nit, the rest is good
https://gerrit.ovirt.org/#/c/39307/10/vdsm/network/api.p
gerrit-hooks has posted comments on this change.
Change subject: migration: make status field private
..
Patch Set 4:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches
gerrit-hooks has posted comments on this change.
Change subject: virt: enhance migration.SourceThread.stop()
..
Patch Set 16:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
gerrit-hooks has posted comments on this change.
Change subject: virt: do not use status after getStat()
..
Patch Set 14:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matc
gerrit-hooks has posted comments on this change.
Change subject: migration: track and report abort reason
..
Patch Set 4:
* #1154397::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1154397::OK, public bug
* Check P
gerrit-hooks has posted comments on this change.
Change subject: migration: don't mess up with _status fields
..
Patch Set 4:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
gerrit-hooks has posted comments on this change.
Change subject: migration: return copy of internal status
..
Patch Set 4:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header mat
Petr Horáček has posted comments on this change.
Change subject: api: support multiple 'ipv6addrs' per network
..
Patch Set 10: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/39307
To unsubscribe, visit https://gerri
Francesco Romani has posted comments on this change.
Change subject: virt: sampling: reduce host averaging window
..
Patch Set 1:
verification:
- run patched VDSM
- fetch stats using vdsClient (OK)
- inspected logs looking for
Francesco Romani has posted comments on this change.
Change subject: virt: sampling: reduce host averaging window
..
Patch Set 1: Verified+1
--
To view, visit https://gerrit.ovirt.org/50148
To unsubscribe, visit https://gerrit
gerrit-hooks has posted comments on this change.
Change subject: Revert "Include vmfex-dev-hook in vdsm install"
..
Patch Set 1:
* Update tracker: IGNORE, no Bug-Url found
--
To view, visit https://gerrit.ovirt.org/50132
To u
Nir Soffer has posted comments on this change.
Change subject: vm: enabling memory snapshot without disks
..
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/50199
To unsubscribe, visit https://gerrit.ovir
Nir Soffer has abandoned this change.
Change subject: Revert "Include vmfex-dev-hook in vdsm install"
..
Abandoned
Seems to be needed, we need to an easy way to install it for developers.
--
To view, visit https://gerrit.ovir
gerrit-hooks has posted comments on this change.
Change subject: vm: enabling memory snapshot without disks
..
Patch Set 1:
* #1287066::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1287066::OK, public bug
* Check
Daniel Erez has uploaded a new change for review.
Change subject: vm: enabling memory snapshot without disks
..
vm: enabling memory snapshot without disks
Taking a memory snapshot of a VM without disks should be
supported (or me
Yeela Kaplan has posted comments on this change.
Change subject: Makefile: use tox to run make pep8 and pyflakes
..
Patch Set 1:
(10 comments)
https://gerrit.ovirt.org/#/c/49952/1/Makefile.am
File Makefile.am:
Line 73:
Petr Horáček has posted comments on this change.
Change subject: hooks: support ipv6addrs in IPv6 hook and Open vSwitch hook
..
Patch Set 9: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/39359
To unsubscribe, visit
gerrit-hooks has posted comments on this change.
Change subject: vm: enabling memory snapshot without disks
..
Patch Set 4:
* #1287066::Update tracker: OK
* Set MODIFIED::bug 1287066#1287066OK
--
To view, visit https:
Nir Soffer has submitted this change and it was merged.
Change subject: vm: enabling memory snapshot without disks
..
vm: enabling memory snapshot without disks
Taking a memory snapshot of a VM without disks should be
supported
Nir Soffer has posted comments on this change.
Change subject: vm: enabling memory snapshot without disks
..
Patch Set 3: Code-Review+2
Thanks for the reviews!
--
To view, visit https://gerrit.ovirt.org/49535
To unsubscribe,
gerrit-hooks has posted comments on this change.
Change subject: virt: devices: watchdog: use 'continue'
..
Patch Set 1:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header match
Francesco Romani has uploaded a new change for review.
Change subject: vm: add generic getUnderlyingDeviceInfo
..
vm: add generic getUnderlyingDeviceInfo
add generic method to replace redundant code.
Change-Id: I10405b03bdb4b64
Francesco Romani has uploaded a new change for review.
Change subject: virt: devices: memory: reorganize getUnderlying
..
virt: devices: memory: reorganize getUnderlying
reorder (independent) operations in getUnderlyingMemoryDev
Francesco Romani has uploaded a new change for review.
Change subject: virt: devices: video: reorganize getUnderlying
..
virt: devices: video: reorganize getUnderlying
reorder (independent) operations in getUnderlyingVideoDevice
gerrit-hooks has posted comments on this change.
Change subject: vm: devices: replace Smartcard device info
..
Patch Set 1:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header ma
Francesco Romani has uploaded a new change for review.
Change subject: virt: devices: sound: reorganize getUnderlying
..
virt: devices: sound: reorganize getUnderlying
reorder (independent) operations in getUnderlyingSoundDevice
Francesco Romani has uploaded a new change for review.
Change subject: vm: devices: replace Smartcard device info
..
vm: devices: replace Smartcard device info
use generic method instead of almost-identical clone.
Change-Id: I3
gerrit-hooks has posted comments on this change.
Change subject: virt: devices: smartcard: warn if missing address
..
Patch Set 1:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure he
Francesco Romani has uploaded a new change for review.
Change subject: virt: devices: watchdog: use 'continue'
..
virt: devices: watchdog: use 'continue'
Use 'continue' in getUnderlyingWatchdogDeviceInfo
to skip devices with no
Francesco Romani has uploaded a new change for review.
Change subject: vm: devices: replace Memory device info
..
vm: devices: replace Memory device info
Change-Id: Ib84395d01736223d2a1c1f45ec48334cebcb5240
Signed-off-by: France
gerrit-hooks has posted comments on this change.
Change subject: vm: devices: replace Watchdog device info
..
Patch Set 1:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header mat
Francesco Romani has uploaded a new change for review.
Change subject: virt: devices: smartcard: warn if missing address
..
virt: devices: smartcard: warn if missing address
Emit debug log if address is missing.
This patch enab
gerrit-hooks has posted comments on this change.
Change subject: vm: add generic getUnderlyingDeviceInfo
..
Patch Set 1:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header match
Francesco Romani has uploaded a new change for review.
Change subject: vm: devices: replace Video device info
..
vm: devices: replace Video device info
Change-Id: I72e1607f43856d700184dce023cb702a12b3c0ce
Signed-off-by: Francesc
gerrit-hooks has posted comments on this change.
Change subject: virt: devices: memory: reorganize getUnderlying
..
Patch Set 1:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure head
gerrit-hooks has posted comments on this change.
Change subject: virt: devices: video: reorganize getUnderlying
..
Patch Set 1:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure heade
gerrit-hooks has posted comments on this change.
Change subject: vm: devices: replace Video device info
..
Patch Set 1:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matche
gerrit-hooks has posted comments on this change.
Change subject: virt: devices: sound: reorganize getUnderlying
..
Patch Set 1:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure heade
gerrit-hooks has posted comments on this change.
Change subject: vm: devices: replace Memory device info
..
Patch Set 1:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header match
gerrit-hooks has posted comments on this change.
Change subject: vm: devices: replace Sound device info
..
Patch Set 1:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matche
Francesco Romani has uploaded a new change for review.
Change subject: vm: devices: replace Watchdog device info
..
vm: devices: replace Watchdog device info
Change-Id: I2939babe4d55ebd4f8611233b1041167cef8054d
Signed-off-by: Fr
1 - 100 of 214 matches
Mail list logo