Yaniv Bronhaim has posted comments on this change.
Change subject: Makefile: use tox to run make pep8 and pyflakes
..
Patch Set 4:
(6 comments)
https://gerrit.ovirt.org/#/c/49952/4/tox.ini
File tox.ini:
Line 3: skipsdist = tr
Yaniv Bronhaim has posted comments on this change.
Change subject: Makefile: use tox to run make pep8 and pyflakes
..
Patch Set 4: Code-Review-1
for visibility
--
To view, visit https://gerrit.ovirt.org/49952
To unsubscribe,
Milan Zamazal has posted comments on this change.
Change subject: v2v: add try/except to get_external_vms
..
Patch Set 4: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/49438
To unsubscribe, visit https://gerrit.ovir
Francesco Romani has posted comments on this change.
Change subject: clientIF: add logs during the recovery
..
Patch Set 4: Verified+1
we can merge now
--
To view, visit https://gerrit.ovirt.org/49140
To unsubscribe, visit ht
Fabian Deutsch has posted comments on this change.
Change subject: vdsm.conf: Add drop-in dir
..
Patch Set 6:
(8 comments)
https://gerrit.ovirt.org/#/c/48317/6/lib/vdsm/config.py.in
File lib/vdsm/config.py.in:
Line 21: from _
Francesco Romani has posted comments on this change.
Change subject: vm: unit test for vm._waitForDriveRemoval
..
Patch Set 1: Code-Review+2
raising (my) score
--
To view, visit https://gerrit.ovirt.org/49668
To unsubscribe,
gerrit-hooks has posted comments on this change.
Change subject: vdsm.conf: Add drop-in dir
..
Patch Set 7:
* #1279555::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1279555::OK, public bug
* Check Product::#12795
Francesco Romani has posted comments on this change.
Change subject: vm: move device attached check to device itself
..
Patch Set 2: Code-Review+1
I agree, we should try to make things easier to maintain. I also want it.
--
T
Francesco Romani has posted comments on this change.
Change subject: vm: check operation result for vm nic hotunplug
..
Patch Set 1: Code-Review+2
raising (my) score
--
To view, visit https://gerrit.ovirt.org/49669
To unsubsc
Francesco Romani has posted comments on this change.
Change subject: vm: add test for nic unplug wait
..
Patch Set 2: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/49671
To unsubscribe, visit https://gerrit.ovirt.or
Francesco Romani has posted comments on this change.
Change subject: spec: Align RHEL and CentOS qemu* requiments
..
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/50368
To unsubscribe, visit https://ger
Francesco Romani has submitted this change and it was merged.
Change subject: spec: Align RHEL and CentOS qemu* requiments
..
spec: Align RHEL and CentOS qemu* requiments
Since qemu-kvm-ev-2.3 is now build by the oVirt project,
gerrit-hooks has posted comments on this change.
Change subject: clientIF: add logs during the recovery
..
Patch Set 5:
* #1285236::Update tracker: OK
* Set MODIFIED::bug 1285236#1285236OK
--
To view, visit https://ge
gerrit-hooks has posted comments on this change.
Change subject: spec: Align RHEL and CentOS qemu* requiments
..
Patch Set 2:
* #1248400::Update tracker: OK
* Set MODIFIED::bug 1248400#1248400OK
--
To view, visit http
Francesco Romani has submitted this change and it was merged.
Change subject: clientIF: add logs during the recovery
..
clientIF: add logs during the recovery
The recovery flow is supposed to be sporadic, but it
is nevertheless
Francesco Romani has posted comments on this change.
Change subject: v2v: add try/except to get_external_vms
..
Patch Set 4: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/49438
To unsubscribe, visit https://gerrit.o
gerrit-hooks has posted comments on this change.
Change subject: v2v: add try/except to get_external_vms
..
Patch Set 5:
* #1284412::Update tracker: OK
* Set MODIFIED::bug 1284412#1284412OK
--
To view, visit https://g
Francesco Romani has submitted this change and it was merged.
Change subject: v2v: add try/except to get_external_vms
..
v2v: add try/except to get_external_vms
Single domain error causes get_external_vms to fail.
Bug-Url: htt
gerrit-hooks has posted comments on this change.
Change subject: Add vmfex-dev hook to default RPMs for install
..
Patch Set 3:
* #1286997::Update tracker: OK
* Set MODIFIED::bug 1286997#1286997IGNORE, not all related p
Francesco Romani has posted comments on this change.
Change subject: Add vmfex-dev hook to default RPMs for install
..
Patch Set 2: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/50270
To unsubscribe, visit https://g
Francesco Romani has submitted this change and it was merged.
Change subject: Add vmfex-dev hook to default RPMs for install
..
Add vmfex-dev hook to default RPMs for install
Add vmfex-dev hook RPM to default ones in shell_help
gerrit-hooks has posted comments on this change.
Change subject: Include vmfex-dev-hook in vdsm install
..
Patch Set 2:
* #1286997::Update tracker: OK
* Set MODIFIED::bug 1286997#1286997OK
--
To view, visit https://ge
Francesco Romani has posted comments on this change.
Change subject: Include vmfex-dev-hook in vdsm install
..
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/50378
To unsubscribe, visit https://gerrit.ov
Francesco Romani has submitted this change and it was merged.
Change subject: Include vmfex-dev-hook in vdsm install
..
Include vmfex-dev-hook in vdsm install
Force installation of vmfex-dev hook
together with VDSM main package
Francesco Romani has posted comments on this change.
Change subject: vm: enabling memory snapshot without disks
..
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/50199
To unsubscribe, visit https://gerri
Francesco Romani has submitted this change and it was merged.
Change subject: vm: enabling memory snapshot without disks
..
vm: enabling memory snapshot without disks
Taking a memory snapshot of a VM without disks should be
sup
gerrit-hooks has posted comments on this change.
Change subject: vm: enabling memory snapshot without disks
..
Patch Set 2:
* #1287066::Update tracker: OK
* Set MODIFIED::bug 1287066#1287066OK
--
To view, visit https:
Francesco Romani has submitted this change and it was merged.
Change subject: gluster: Warn instead of failing for unsupported gluster
replica modes
..
gluster: Warn instead of failing for unsupported gluster replica modes
A p
Francesco Romani has posted comments on this change.
Change subject: gluster: Warn instead of failing for unsupported gluster
replica modes
..
Patch Set 2: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/50258
To uns
gerrit-hooks has posted comments on this change.
Change subject: gluster: Warn instead of failing for unsupported gluster
replica modes
..
Patch Set 3:
* #1286565::Update tracker: OK
* Set MODIFIED::bug 1286565#1286565
Francesco Romani has submitted this change and it was merged.
Change subject: vm: unit test for vm._waitForDriveRemoval
..
vm: unit test for vm._waitForDriveRemoval
Added unit tests for vm._waitForDriveRemoval, in
preparation t
gerrit-hooks has posted comments on this change.
Change subject: vm: unit test for vm._waitForDriveRemoval
..
Patch Set 2:
* #1134256::Update tracker: OK
* Set MODIFIED::bug 1134256#1134256IGNORE, not oVirt classificati
Piotr Kliczewski has posted comments on this change.
Change subject: schema: Fix asserts that had side effect
..
Patch Set 3: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/34362
To unsubscribe, visit https://gerrit.
Francesco Romani has submitted this change and it was merged.
Change subject: vm: check operation result for vm nic hotunplug
..
vm: check operation result for vm nic hotunplug
After detaching a device we need to verify that th
gerrit-hooks has posted comments on this change.
Change subject: vm: check operation result for vm nic hotunplug
..
Patch Set 2:
* #1134256::Update tracker: OK
* #1199782::Update tracker: OK
* Set MODIFIED::bug 1134256#1134
Francesco Romani has posted comments on this change.
Change subject: vm: move device attached check to device itself
..
Patch Set 2:
please verify
--
To view, visit https://gerrit.ovirt.org/49670
To unsubscribe, visit https:/
Francesco Romani has submitted this change and it was merged.
Change subject: vm: add test for nic unplug wait
..
vm: add test for nic unplug wait
Change-Id: I4603efa0739c9bd50777a157c946da3ba8544729
Signed-off-by: Marcin Mirec
gerrit-hooks has posted comments on this change.
Change subject: vm: add test for nic unplug wait
..
Patch Set 3:
* #1134256::Update tracker: OK
* Set MODIFIED::bug 1134256#1134256IGNORE, not oVirt classification but
R
Francesco Romani has submitted this change and it was merged.
Change subject: Handle empty QoS section with no cpu limit information
..
Handle empty QoS section with no cpu limit information
The 3.5 stats collecting code expect
Francesco Romani has submitted this change and it was merged.
Change subject: Add an empty metadata qos element to the created domain
..
Add an empty metadata qos element to the created domain
Libvirt reports an error every tim
gerrit-hooks has posted comments on this change.
Change subject: Handle empty QoS section with no cpu limit information
..
Patch Set 3:
* #1289007::Update tracker: OK
* Set MODIFIED::bug 1289007#1289007IGNORE, not oVirt
gerrit-hooks has posted comments on this change.
Change subject: Add an empty metadata qos element to the created domain
..
Patch Set 4:
* #1289007::Update tracker: OK
* Set MODIFIED::bug 1289007#1289007IGNORE, not oVir
Francesco Romani has submitted this change and it was merged.
Change subject: ifcfg: remove files properly on the node
..
ifcfg: remove files properly on the node
Since change-id I02ae28c345 we are always persisting ifcfg files
gerrit-hooks has posted comments on this change.
Change subject: ifcfg: remove files properly on the node
..
Patch Set 2:
* #1283628::Update tracker: OK
* Set MODIFIED::bug 1283628#1283628FAILED, illegal change from VER
gerrit-hooks has posted comments on this change.
Change subject: gluster: Handle missing glusterfs-cli package
..
Patch Set 5:
* #1290997::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1290997::OK, public bug
* Ch
Ala Hino has posted comments on this change.
Change subject: gluster: Handle missing glusterfs-cli package
..
Patch Set 4:
(4 comments)
https://gerrit.ovirt.org/#/c/50363/4//COMMIT_MSG
Commit Message:
Line 3: AuthorDate: 2015
Martin Polednik has posted comments on this change.
Change subject: caps/lib: move CPU architecture details to lib/cpuarch
..
Patch Set 2:
(12 comments)
A lot of suggestions make sense for different patch series - the removal
gerrit-hooks has posted comments on this change.
Change subject: gluster: Handle missing glusterfs-cli package
..
Patch Set 6:
* #1290997::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1290997::OK, public bug
* Ch
gerrit-hooks has posted comments on this change.
Change subject: gluster: Handle missing glusterfs-cli package
..
Patch Set 7:
* #1290997::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1290997::OK, public bug
* Ch
Francesco Romani has posted comments on this change.
Change subject: lib: daemon: autodetect online cpus for affinity
..
Patch Set 2: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/49612
To unsubscribe, visit https:/
Francesco Romani has posted comments on this change.
Change subject: lib: daemon: autodetect online cpus for affinity
..
Patch Set 2: Verified+1
re-verified on branch, subset of tests of master patch.
--
To view, visit https:
Francesco Romani has submitted this change and it was merged.
Change subject: lib: daemon: autodetect online cpus for affinity
..
lib: daemon: autodetect online cpus for affinity
In commit a1d4e23 we enabled by default the cpu
gerrit-hooks has posted comments on this change.
Change subject: lib: daemon: autodetect online cpus for affinity
..
Patch Set 3:
* #1286462::Update tracker: OK
* #1279431::Update tracker: OK
* Set MODIFIED::bug 1286462#128
gerrit-hooks has posted comments on this change.
Change subject: daemon: reformat __set_cpu_affinity
..
Patch Set 3:
* #1286462::Update tracker: OK
* #1279431::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1286462
Francesco Romani has posted comments on this change.
Change subject: daemon: keep running without affinity.
..
Patch Set 2: Verified+1
re-verified on branch, subset of tests done for master patch
--
To view, visit https://ger
gerrit-hooks has posted comments on this change.
Change subject: gluster: Handle missing glusterfs-cli package
..
Patch Set 8:
* #1290997::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1290997::OK, public bug
* Ch
gerrit-hooks has posted comments on this change.
Change subject: net: Mapping bonding option value names to numerics
..
Patch Set 24:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure
Nir Soffer has restored this change.
Change subject: automation: Enable xunit report
..
Restored
--
To view, visit https://gerrit.ovirt.org/46640
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: res
Edward Haas has posted comments on this change.
Change subject: net: Correctly apply MTU values on networks
..
Patch Set 1:
Eliminating the default MTU from engine:
https://gerrit.ovirt.org/#/c/28097/
Therefore setupNetwork wi
Edward Haas has posted comments on this change.
Change subject: net: Correctly apply MTU values on networks
..
Patch Set 1:
IMO, having independent guards on both Engine and VDSM is preferred.
Either handle defaults at the VDSM
Milan Zamazal has posted comments on this change.
Change subject: virt: Correct VM state before vm.cont() in _recover()
..
Patch Set 2:
AFAICT it should help recovery from stuck paused states and I couldn't identify
any risks
Francesco Romani has posted comments on this change.
Change subject: daemon: reformat __set_cpu_affinity
..
Patch Set 3: Verified+1
verified like (and with) 49614
--
To view, visit https://gerrit.ovirt.org/49613
To unsubscrib
Francesco Romani has posted comments on this change.
Change subject: net: sysctl: enable ipv6
..
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/49687
To unsubscribe, visit https://gerrit.ovirt.org/settin
Francesco Romani has submitted this change and it was merged.
Change subject: net: sysctl: enable ipv6
..
net: sysctl: enable ipv6
Enable sysctl.py:disable_ipv6(dev) to set /pro/sys/.../disable_ipv6
also to '0'. This is needed
gerrit-hooks has posted comments on this change.
Change subject: net: sysctl: enable ipv6
..
Patch Set 2:
* #1234867::Update tracker: OK
* Set MODIFIED::bug 1234867#1234867IGNORE, not all related patches are
closed, ch
Francesco Romani has posted comments on this change.
Change subject: hooks: after_network_setup_fail
..
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/49688
To unsubscribe, visit https://gerrit.ovirt.org
gerrit-hooks has posted comments on this change.
Change subject: hooks: after_network_setup_fail
..
Patch Set 2:
* #1234867::Update tracker: OK
* Set MODIFIED::bug 1234867#1234867IGNORE, not all related patches are
clo
Francesco Romani has submitted this change and it was merged.
Change subject: hooks: after_network_setup_fail
..
hooks: after_network_setup_fail
When an exception occurs during network setup, rollback is executed
and after_netw
Francesco Romani has posted comments on this change.
Change subject: hooks: Open vSwitch configurator
..
Patch Set 2: Code-Review+2
huge patch, trusting you guys!
--
To view, visit https://gerrit.ovirt.org/49689
To unsubscrib
Francesco Romani has posted comments on this change.
Change subject: net: multicast snooping is not supported by ovs until 2.4.0
..
Patch Set 2: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/49690
To unsubscribe, vi
Francesco Romani has posted comments on this change.
Change subject: hooks: ovs: remove unused parameter
..
Patch Set 2: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/49692
To unsubscribe, visit https://gerrit.ovirt
Francesco Romani has posted comments on this change.
Change subject: hooks: ovs: move libvirt configuration into a separate module
..
Patch Set 2: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/49691
To unsubscribe,
Francesco Romani has posted comments on this change.
Change subject: hooks: ovs: better rollback
..
Patch Set 2: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/49693
To unsubscribe, visit https://gerrit.ovirt.org/set
Francesco Romani has posted comments on this change.
Change subject: hooks: ovs: better rollback
..
Patch Set 2:
Rerun-Hooks: all
--
To view, visit https://gerrit.ovirt.org/49693
To unsubscribe, visit https://gerrit.ovirt.org
gerrit-hooks has posted comments on this change.
Change subject: hooks: ovs: better rollback
..
Patch Set 2:
* #1234867::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1234867::OK, public bug
* Check Product::#1234
Francesco Romani has posted comments on this change.
Change subject: hooks: ovs: use six.iteritems and six.itervalues
..
Patch Set 2: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/49697
To unsubscribe, visit https:/
Francesco Romani has posted comments on this change.
Change subject: hooks: ovs: run ovs _configure only if there are changes to do
..
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/49977
To unsubscribe,
Francesco Romani has posted comments on this change.
Change subject: hooks: ovs: fix getVdsCaps and getVdsStats
..
Patch Set 2: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/49698
To unsubscribe, visit https://gerri
Nir Soffer has posted comments on this change.
Change subject: daemon: reformat __set_cpu_affinity
..
Patch Set 3: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/49613
To unsubscribe, visit https://gerrit.ovirt.org/s
Milan Zamazal has posted comments on this change.
Change subject: daemon: reformat __set_cpu_affinity
..
Patch Set 3: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/49613
To unsubscribe, visit https://gerrit.ovirt.or
Nir Soffer has posted comments on this change.
Change subject: daemon: keep running without affinity.
..
Patch Set 2: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/49614
To unsubscribe, visit https://gerrit.ovirt.or
Francesco Romani has posted comments on this change.
Change subject: daemon: reformat __set_cpu_affinity
..
Patch Set 3: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/49613
To unsubscribe, visit https://gerrit.ovirt
Francesco Romani has submitted this change and it was merged.
Change subject: daemon: reformat __set_cpu_affinity
..
daemon: reformat __set_cpu_affinity
Reformat the code to use the 'early return' idiom.
No intended changes in
gerrit-hooks has posted comments on this change.
Change subject: daemon: reformat __set_cpu_affinity
..
Patch Set 4:
* #1286462::Update tracker: OK
* #1279431::Update tracker: OK
* Set MODIFIED::bug 1286462#1286462FAILE
Francesco Romani has posted comments on this change.
Change subject: daemon: keep running without affinity.
..
Patch Set 2: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/49614
To unsubscribe, visit https://gerrit.ov
gerrit-hooks has posted comments on this change.
Change subject: daemon: keep running without affinity.
..
Patch Set 3:
* #1279431::Update tracker: OK
* Set MODIFIED::bug 1279431#1279431OK
--
To view, visit https://ge
Francesco Romani has submitted this change and it was merged.
Change subject: daemon: keep running without affinity.
..
daemon: keep running without affinity.
The cpu affinity is one (important) performance setting,
but Vdsm sh
Francesco Romani has posted comments on this change.
Change subject: gluster: Added VDSM verb to stop gluster related processes
..
Patch Set 2: Code-Review+1
looks OK, waiting for one more review (Dan?)
--
To view, visit http
Martin Polednik has posted comments on this change.
Change subject: caps/lib: move CPU architecture details to lib/cpuarch
..
Patch Set 2:
(1 comment)
https://gerrit.ovirt.org/#/c/49972/2/lib/vdsm/cpuarch.py
File lib/vdsm/cpua
Francesco Romani has posted comments on this change.
Change subject: virt: add run_async helper
..
Patch Set 5: Code-Review-1
(1 comment)
will simplify a bit more, let's save changes for the next patches.
https://gerrit.ovirt
Ido Barkan has posted comments on this change.
Change subject: net: Correctly apply MTU values on networks
..
Patch Set 1:
(12 comments)
-1 for code, +1 for this approach.
We cannot change the API. If we currently allow MTU to
Ido Barkan has posted comments on this change.
Change subject: net: Correctly apply MTU values on networks
..
Patch Set 1: Code-Review-1
--
To view, visit https://gerrit.ovirt.org/50397
To unsubscribe, visit https://gerrit.ovi
Francesco Romani has posted comments on this change.
Change subject: guest-agent: desktopLock exception on EBADF should be ignored
..
Patch Set 8: Code-Review+1
gerrit hides Nir's score, temporary changing mine (but I don't hav
Nir Soffer has posted comments on this change.
Change subject: caps/lib: move CPU architecture details to lib/cpuarch
..
Patch Set 2:
(6 comments)
https://gerrit.ovirt.org/#/c/49972/2/lib/vdsm/cpuarch.py
File lib/vdsm/cpuarch.
Ido Barkan has posted comments on this change.
Change subject: net: support hot(un)plugNic for SRIOV network devices.
..
Patch Set 1:
(2 comments)
https://gerrit.ovirt.org/#/c/50372/1/vdsm/virt/vm.py
File vdsm/virt/vm.py:
Lin
gerrit-hooks has posted comments on this change.
Change subject: net: support hot(un)plugNic for SRIOV network devices.
..
Patch Set 2:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make su
Francesco Romani has posted comments on this change.
Change subject: virt: vm: Update time on VM after resume
..
Patch Set 10: Code-Review+2
nicer this way, next time I'll push a bit more in this direction :)
--
To view, visi
Francesco Romani has submitted this change and it was merged.
Change subject: hooks: Open vSwitch configurator
..
hooks: Open vSwitch configurator
This patch introduces new hook which allows us to configure OVS network
instead
gerrit-hooks has posted comments on this change.
Change subject: hooks: Open vSwitch configurator
..
Patch Set 3:
* #1234867::Update tracker: OK
* Set MODIFIED::bug 1234867#1234867IGNORE, not all related patches are
cl
gerrit-hooks has posted comments on this change.
Change subject: lib: executor: report worker status in __repr__
..
Patch Set 4:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure head
1 - 100 of 242 matches
Mail list logo
