gerrit-hooks has posted comments on this change.
Change subject: net: Canonize persistent and running net config
..
Patch Set 1:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure head
Edward Haas has uploaded a new change for review.
Change subject: net: Canonize persistent and running net config
..
net: Canonize persistent and running net config
In order to support persistent configuration which has been sav
Edward Haas has uploaded a new change for review.
Change subject: net: Move canonize_networks to its own module
..
net: Move canonize_networks to its own module
Created netcanonize module to allow re-use of canonize_networks.
C
gerrit-hooks has posted comments on this change.
Change subject: net: Move canonize_networks to its own module
..
Patch Set 1:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
Francesco Romani has posted comments on this change.
Change subject: health: Introduce Vdsm health monitoring
..
Patch Set 4: Verified+1
verified running patched VDSM on el6 (52700, 52701)
health thread is independent from all
Francesco Romani has posted comments on this change.
Change subject: health: Report resource usage
..
Patch Set 4: Verified+1
verified running patched VDSM on el6 (52700, 52701)
health thread is independent from all existing fl
Francesco Romani has posted comments on this change.
Change subject: health: Introduce Vdsm health monitoring
..
Patch Set 4: Continuous-Integration+1
v4 is a reupload of v2.
run tests manually on el6 and el7
--
To view, visi
Francesco Romani has posted comments on this change.
Change subject: health: Report resource usage
..
Patch Set 4: Continuous-Integration+1
run tests manually on el6 and el7
--
To view, visit https://gerrit.ovirt.org/52701
To
gerrit-hooks has posted comments on this change.
Change subject: health: Report resource usage
..
Patch Set 4:
* #1299491::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1299491::OK, public bug
* Check Product::#12
gerrit-hooks has posted comments on this change.
Change subject: health: Introduce Vdsm health monitoring
..
Patch Set 4:
* #1299491::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1299491::OK, public bug
* Check P
Francesco Romani has submitted this change and it was merged.
Change subject: concurrent: Introduce concurrent.thread() utility
..
concurrent: Introduce concurrent.thread() utility
We are repeating this boilerplate code everywh
gerrit-hooks has posted comments on this change.
Change subject: concurrent: Introduce concurrent.thread() utility
..
Patch Set 3:
* #1299491::Update tracker: OK
* Set MODIFIED::bug 1299491#1299491IGNORE, not oVirt clas
Francesco Romani has posted comments on this change.
Change subject: concurrent: Introduce concurrent.thread() utility
..
Patch Set 2: Verified+1
verified running the tests and with 52700 and 52701. Outside health.py this
code
Francesco Romani has posted comments on this change.
Change subject: concurrent: Introduce concurrent.thread() utility
..
Patch Set 2: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/52699
To unsubscribe, visit https:
Francesco Romani has posted comments on this change.
Change subject: concurrent: Introduce concurrent.thread() utility
..
Patch Set 2:
run tests manually on el6 and el7
--
To view, visit https://gerrit.ovirt.org/52699
To unsu
Francesco Romani has posted comments on this change.
Change subject: concurrent: Introduce concurrent.thread() utility
..
Patch Set 2:
jenkins failure is bogus
--
To view, visit https://gerrit.ovirt.org/52699
To unsubscribe,
Francesco Romani has posted comments on this change.
Change subject: concurrent: Introduce concurrent.thread() utility
..
Patch Set 2: Continuous-Integration+1
--
To view, visit https://gerrit.ovirt.org/52699
To unsubscribe, v
Francesco Romani has posted comments on this change.
Change subject: health: Introduce Vdsm health monitoring
..
Patch Set 3:
v3 bundled concurrent.thread into health.py.
I missed the ACKs. I'll re-upload v2 unchanged as v4 onc
gerrit-hooks has posted comments on this change.
Change subject: health: Report resource usage
..
Patch Set 3:
* #1299491::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1299491::OK, public bug
* Check Product::#12
gerrit-hooks has posted comments on this change.
Change subject: health: Introduce Vdsm health monitoring
..
Patch Set 3:
* #1299491::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1299491::OK, public bug
* Check P
gerrit-hooks has posted comments on this change.
Change subject: imagetickets: Support image tickets
..
Patch Set 16:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches
Amit Aviram has posted comments on this change.
Change subject: imagetickets: Support image tickets
..
Patch Set 15: Verified+1
--
To view, visit https://gerrit.ovirt.org/50014
To unsubscribe, visit https://gerrit.ovirt.org/se
Nir Soffer has posted comments on this change.
Change subject: imagetickets: Support image tickets
..
Patch Set 15: Code-Review+2
Amit, can you verify?
--
To view, visit https://gerrit.ovirt.org/50014
To unsubscribe, visit ht
Nir Soffer has posted comments on this change.
Change subject: imagetickets: Support image tickets
..
Patch Set 15:
Amit, please rebase on master, the build fail because of pyflakes
issues that do not fail on master.
--
To vi
Nir Soffer has posted comments on this change.
Change subject: health: Report resource usage
..
Patch Set 2:
I don't see any issue, but I also never tested this on el6.
--
To view, visit https://gerrit.ovirt.org/52701
To unsu
Nir Soffer has posted comments on this change.
Change subject: health: Report resource usage
..
Patch Set 2: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/52701
To unsubscribe, visit https://gerrit.ovirt.org/setting
Nir Soffer has posted comments on this change.
Change subject: health: Introduce Vdsm health monitoring
..
Patch Set 2: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/52700
To unsubscribe, visit https://gerrit.ovirt.
Nir Soffer has posted comments on this change.
Change subject: concurrent: Introduce concurrent.thread() utility
..
Patch Set 2: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/52699
To unsubscribe, visit https://gerr
Francesco Romani has submitted this change and it was merged.
Change subject: migration: set timeout to 10 mins
..
migration: set timeout to 10 mins
On heavily loaded environments createMigration call can take a lot of
time so
Francesco Romani has posted comments on this change.
Change subject: migration: set timeout to 10 mins
..
Patch Set 2:
I am, hence my +2
--
To view, visit https://gerrit.ovirt.org/52548
To unsubscribe, visit https://gerrit.ov
gerrit-hooks has posted comments on this change.
Change subject: migration: set timeout to 10 mins
..
Patch Set 3:
* #1188543::Update tracker: OK
* Set MODIFIED::bug 1188543#1188543IGNORE, not oVirt classification but
Piotr Kliczewski has posted comments on this change.
Change subject: concurrent: Introduce concurrent.thread() utility
..
Patch Set 2: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/52699
To unsubscribe, visit https:
Piotr Kliczewski has posted comments on this change.
Change subject: health: Report resource usage
..
Patch Set 2: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/52701
To unsubscribe, visit https://gerrit.ovirt.org/s
Piotr Kliczewski has posted comments on this change.
Change subject: health: Introduce Vdsm health monitoring
..
Patch Set 2: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/52700
To unsubscribe, visit https://gerrit.
gerrit-hooks has posted comments on this change.
Change subject: health: Report resource usage
..
Patch Set 2:
* #1299491::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1299491::OK, public bug
* Check Product::#12
Jenkins CI has posted comments on this change.
Change subject: concurrent: Introduce concurrent.thread() utility
..
Patch Set 2: Continuous-Integration-1
Propagate review hook: Continuous Integration value inherited from patch
gerrit-hooks has posted comments on this change.
Change subject: concurrent: Introduce concurrent.thread() utility
..
Patch Set 2:
* #1299491::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1299491::OK, public bug
gerrit-hooks has posted comments on this change.
Change subject: health: Introduce Vdsm health monitoring
..
Patch Set 2:
* #1299491::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1299491::OK, public bug
* Check P
gerrit-hooks has posted comments on this change.
Change subject: health: Report resource usage
..
Patch Set 1:
* #1269424::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1269424::OK, public bug
* Check Product::#12
gerrit-hooks has posted comments on this change.
Change subject: health: Introduce Vdsm health monitoring
..
Patch Set 1:
* #1269424::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1269424::OK, public bug
* Check P
gerrit-hooks has posted comments on this change.
Change subject: concurrent: Introduce concurrent.thread() utility
..
Patch Set 1:
* #1269424::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1269424::OK, public bug
Hello Piotr Kliczewski, Nir Soffer,
I'd like you to do a code review. Please visit
https://gerrit.ovirt.org/52701
to review the following change.
Change subject: health: Report resource usage
..
health: Report resource us
Hello Piotr Kliczewski, Nir Soffer,
I'd like you to do a code review. Please visit
https://gerrit.ovirt.org/52700
to review the following change.
Change subject: health: Introduce Vdsm health monitoring
..
health: Introdu
Hello Piotr Kliczewski, Nir Soffer,
I'd like you to do a code review. Please visit
https://gerrit.ovirt.org/52699
to review the following change.
Change subject: concurrent: Introduce concurrent.thread() utility
..
concur
Piotr Kliczewski has posted comments on this change.
Change subject: migration: set timeout to 10 mins
..
Patch Set 2:
Francesco are you ok with merging this patch?
--
To view, visit https://gerrit.ovirt.org/52548
To unsubscr
Francesco Romani has submitted this change and it was merged.
Change subject: health: Introduce Vdsm health monitoring
..
health: Introduce Vdsm health monitoring
Debugging Vdsm in the field is very hard, because we don't have
gerrit-hooks has posted comments on this change.
Change subject: health: Introduce Vdsm health monitoring
..
Patch Set 3:
* #1269424::Update tracker: OK
* Set MODIFIED::bug 1269424#1269424IGNORE, not oVirt classificatio
Francesco Romani has submitted this change and it was merged.
Change subject: health: Report resource usage
..
health: Report resource usage
Report cpu usage in the last interval, memory size, memory delta, and
number of thread
gerrit-hooks has posted comments on this change.
Change subject: health: Report resource usage
..
Patch Set 3:
* #1269424::Update tracker: OK
* Set MODIFIED::bug 1269424#1269424IGNORE, not oVirt classification but
Red
gerrit-hooks has posted comments on this change.
Change subject: concurrent: Introduce concurrent.thread() utility
..
Patch Set 3:
* #1269424::Update tracker: OK
* Set MODIFIED::bug 1269424#1269424IGNORE, not oVirt clas
Francesco Romani has submitted this change and it was merged.
Change subject: concurrent: Introduce concurrent.thread() utility
..
concurrent: Introduce concurrent.thread() utility
We are repeating this boilerplate code everywh
gerrit-hooks has posted comments on this change.
Change subject: network: native Open vSwitch support
..
Patch Set 9:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches
gerrit-hooks has posted comments on this change.
Change subject: vdsm: move fake_kvm code into faqemu
..
Patch Set 21:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches
Martin Polednik has posted comments on this change.
Change subject: vdsm: move fake_kvm code into faqemu
..
Patch Set 21: Verified+1
--
To view, visit https://gerrit.ovirt.org/46897
To unsubscribe, visit https://gerrit.ovirt.o
Nir Soffer has posted comments on this change.
Change subject: tests: lib: add tests for utils.weakmethod
..
Patch Set 3: Code-Review+1
Lets get more reviews.
--
To view, visit https://gerrit.ovirt.org/52408
To unsubscribe, v
Dan Kenigsberg has submitted this change and it was merged.
Change subject: Introducing context manager to terminate async processes on
internal fail
..
Introducing context manager to terminate async processes on internal fail
gerrit-hooks has posted comments on this change.
Change subject: Introducing context manager to terminate async processes on
internal fail
..
Patch Set 19:
* Update tracker: IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no
gerrit-hooks has posted comments on this change.
Change subject: vm: delete recovery file only after destroy()
..
Patch Set 3:
* #1253043::Update tracker: OK
* Set MODIFIED::bug 1253043#1253043IGNORE, not oVirt classifi
Francesco Romani has posted comments on this change.
Change subject: vm: make _deleteVm() more robust
..
Patch Set 2: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/52516
To unsubscribe, visit https://gerrit.ovirt.or
Francesco Romani has submitted this change and it was merged.
Change subject: vm: make _deleteVm() more robust
..
vm: make _deleteVm() more robust
Use else: clause in a try: block to make
deleteVm() more robust and a bit nicer.
Francesco Romani has submitted this change and it was merged.
Change subject: vm: delete recovery file only after destroy()
..
vm: delete recovery file only after destroy()
We must not re-create a recovery file after it
is canc
Francesco Romani has posted comments on this change.
Change subject: vm: delete recovery file only after destroy()
..
Patch Set 2: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/52517
To unsubscribe, visit https://ge
gerrit-hooks has posted comments on this change.
Change subject: vm: make _deleteVm() more robust
..
Patch Set 3:
* #1253043::Update tracker: OK
* Set MODIFIED::bug 1253043#1253043IGNORE, not oVirt classification but
R
Francesco Romani has posted comments on this change.
Change subject: vm: safer removal of the recovery file
..
Patch Set 2: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/52515
To unsubscribe, visit https://gerrit.ov
Francesco Romani has posted comments on this change.
Change subject: Hook: ide2sata: To switch IDE disks to SATA
..
Patch Set 7:
Javier, could you please share how verification was done, to address the good
point Nir raised?
O
gerrit-hooks has posted comments on this change.
Change subject: vm: safer removal of the recovery file
..
Patch Set 3:
* #1253043::Update tracker: OK
* Set MODIFIED::bug 1253043#1253043IGNORE, not oVirt classification
Francesco Romani has submitted this change and it was merged.
Change subject: vm: safer removal of the recovery file
..
vm: safer removal of the recovery file
If a user shutdowns a VM from inside the guest, Vdsm leaves
a stale
gerrit-hooks has posted comments on this change.
Change subject: network: native Open vSwitch support
..
Patch Set 8:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches
Dan Kenigsberg has posted comments on this change.
Change subject: vm: delete recovery file only after destroy()
..
Patch Set 2: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/52517
To unsubscribe, visit https://gerr
Dan Kenigsberg has posted comments on this change.
Change subject: vm: make _deleteVm() more robust
..
Patch Set 2: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/52516
To unsubscribe, visit https://gerrit.ovirt.org/
Dan Kenigsberg has posted comments on this change.
Change subject: vm: safer removal of the recovery file
..
Patch Set 2: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/52515
To unsubscribe, visit https://gerrit.ovir
Francesco Romani has posted comments on this change.
Change subject: vdsm: move fake_kvm code into faqemu
..
Patch Set 20: Code-Review+2
(1 comment)
thanks for adding the tests.
We could perhaps improve the test a bit more, bu
Francesco Romani has posted comments on this change.
Change subject: health: Report resource usage
..
Patch Set 2: Code-Review+2
agreement almost reached. will merge at the end of the day unless anyone objects
--
To view, vis
Francesco Romani has posted comments on this change.
Change subject: health: Introduce Vdsm health monitoring
..
Patch Set 2: Code-Review+2
agreement almost reached. will merge at the end of the day unless anyone objects
--
T
Francesco Romani has posted comments on this change.
Change subject: concurrent: Introduce concurrent.thread() utility
..
Patch Set 2:
agreement almost reached. will merge at the end of the day unless anyone objects
--
To vie
gerrit-hooks has posted comments on this change.
Change subject: vdsm: move fake_kvm code into faqemu
..
Patch Set 20:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches
Francesco Romani has posted comments on this change.
Change subject: concurrent: Introduce concurrent.thread() utility
..
Patch Set 2: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/52624
To unsubscribe, visit https:
Francesco Romani has posted comments on this change.
Change subject: tests: lib: add tests for utils.weakmethod
..
Patch Set 3: Verified+1
tests still pass as expected -> V+1
--
To view, visit https://gerrit.ovirt.org/52408
T
gerrit-hooks has posted comments on this change.
Change subject: tests: lib: add tests for utils.weakmethod
..
Patch Set 3:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header ma
Francesco Romani has posted comments on this change.
Change subject: tests: lib: add tests for utils.weakmethod
..
Patch Set 2:
I'll just squash your cleanups (thanks!) in this patch
--
To view, visit https://gerrit.ovirt.or
Javier Coscia has posted comments on this change.
Change subject: Hook: ide2sata: To switch IDE disks to SATA
..
Patch Set 7: Verified+1
--
To view, visit https://gerrit.ovirt.org/48450
To unsubscribe, visit https://gerrit.ovi
Amador Pahim has posted comments on this change.
Change subject: Hook: ide2sata: To switch IDE disks to SATA
..
Patch Set 7: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/48450
To unsubscribe, visit https://gerrit.o
Yaniv Bronhaim has posted comments on this change.
Change subject: Kill and report asyncProc if fails on first write to stdin
..
Patch Set 5:
(1 comment)
https://gerrit.ovirt.org/#/c/51763/5/lib/vdsm/commands.py
File lib/vdsm/
Piotr Kliczewski has posted comments on this change.
Change subject: Kill and report asyncProc if fails on first write to stdin
..
Patch Set 5:
(1 comment)
Will fix the test
https://gerrit.ovirt.org/#/c/51763/5/lib/vdsm/comma
Francesco Romani has posted comments on this change.
Change subject: faqemu: refactor and update
..
Patch Set 21:
(1 comment)
partial review, looks ok, hence partial ACK. Suggestions inside, please look at
them. It is fine if
Francesco Romani has posted comments on this change.
Change subject: vdsm: move fake_kvm code into faqemu
..
Patch Set 19: Code-Review+1
(1 comment)
looks ok, suggestions inside. Partial ACK.
https://gerrit.ovirt.org/#/c/4689
Yaniv Bronhaim has posted comments on this change.
Change subject: Move hooking.py to vdsm/lib
..
Patch Set 1:
but I assume its on purpose , if later they will want to use different
implementation of execCmd... I don't know. I
Yaniv Bronhaim has posted comments on this change.
Change subject: Kill and report asyncProc if fails on first write to stdin
..
Patch Set 5: Verified+1
(1 comment)
if you already here - can you check why test_echo(16384, Fals
gerrit-hooks has posted comments on this change.
Change subject: vdsm: move fake_kvm code into faqemu
..
Patch Set 19:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches
gerrit-hooks has posted comments on this change.
Change subject: faqemu: refactor and update
..
Patch Set 21:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url
Milan Zamazal has posted comments on this change.
Change subject: vm: delete recovery file only after destroy()
..
Patch Set 2: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/52517
To unsubscribe, visit https://gerri
Milan Zamazal has posted comments on this change.
Change subject: vm: make _deleteVm() more robust
..
Patch Set 2: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/52516
To unsubscribe, visit https://gerrit.ovirt.org/s
Piotr Kliczewski has posted comments on this change.
Change subject: concurrent: Introduce concurrent.thread() utility
..
Patch Set 2: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/52624
To unsubscribe, visit https:
Piotr Kliczewski has posted comments on this change.
Change subject: health: Introduce Vdsm health monitoring
..
Patch Set 2: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/52625
To unsubscribe, visit https://gerrit.
Piotr Kliczewski has posted comments on this change.
Change subject: health: Report resource usage
..
Patch Set 2: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/52626
To unsubscribe, visit https://gerrit.ovirt.org/s
Nir Soffer has posted comments on this change.
Change subject: health: Report resource usage
..
Patch Set 2: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/52626
To unsubscribe, visit https://gerrit.ovirt.org/setting
Nir Soffer has posted comments on this change.
Change subject: health: Introduce Vdsm health monitoring
..
Patch Set 2: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/52625
To unsubscribe, visit https://gerrit.ovirt.
Nir Soffer has posted comments on this change.
Change subject: concurrent: Introduce concurrent.thread() utility
..
Patch Set 2: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/52624
To unsubscribe, visit https://gerr
Francesco Romani has posted comments on this change.
Change subject: health: Report resource usage
..
Patch Set 2: Verified+1
waiting to reach agreement about this backport. Codewise is fine.
--
To view, visit https://gerrit.
Francesco Romani has posted comments on this change.
Change subject: health: Introduce Vdsm health monitoring
..
Patch Set 2: Verified+1
waiting to reach agreement about this backport. Codewise is fine.
--
To view, visit http
1 - 100 of 143 matches
Mail list logo
