Francesco Romani has posted comments on this change. Change subject: vdsm: move fake_kvm code into faqemu ......................................................................
Patch Set 19: Code-Review+1 (1 comment) looks ok, suggestions inside. Partial ACK. https://gerrit.ovirt.org/#/c/46897/19/vdsm_hooks/faqemu/after_get_caps.py File vdsm_hooks/faqemu/after_get_caps.py: Line 82: raise cpuarch.UnsupportedArchitecture(arch) Line 83: Line 84: Line 85: if __name__ == '__main__': Line 86: if config.getboolean('vars', 'fake_kvm_support'): looks good. To make this better: - perhaps move all config.get*() outside _fake_caps_arch, pass parameters to it - add test like other hooks do (just pick other recent hooks for examples) both could be done in followup patches if verification is already ongoing, even though I don't think this invalidates existing verification. Line 87: caps = hooking.read_json() Line 88: _fake_caps_arch(caps) -- To view, visit https://gerrit.ovirt.org/46897 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I178e0c1d5a9a8ffca2bf28b2fb404b42729dfff4 Gerrit-PatchSet: 19 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Polednik <mpoled...@redhat.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Francesco Romani <from...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Polednik <mpoled...@redhat.com> Gerrit-Reviewer: Nir Soffer <nsof...@redhat.com> Gerrit-Reviewer: Yaniv Bronhaim <ybron...@redhat.com> Gerrit-Reviewer: gerrit-hooks <automat...@ovirt.org> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
