Yaniv Bronhaim has posted comments on this change.
Change subject: net: Adding network api module to supervdsm
..
Patch Set 4:
(1 comment)
https://gerrit.ovirt.org/#/c/53496/4/vdsm/supervdsm_api/network.py
File
gerrit-hooks has posted comments on this change.
Change subject: net hostQos: maintain default class ls value
..
Patch Set 1:
* #1302020::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1302020::OK, public bug
*
Edward Haas has uploaded a new change for review.
Change subject: net hostQos: maintain default class ls value
..
net hostQos: maintain default class ls value
Devices (bond or nic) with tc settings, have default classes defined
gerrit-hooks has posted comments on this change.
Change subject: virt: Move _getUnderlyingHostDeviceInfo() out of Vm
..
Patch Set 1:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure
gerrit-hooks has posted comments on this change.
Change subject: virt: Most Vm._getUnderlying*() method of core devices moved
out of Vm
..
Patch Set 1:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug
gerrit-hooks has posted comments on this change.
Change subject: virt: _getUnderlyingNetworkInterfaceInfo() moved out of Vm
..
Patch Set 1:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found,
gerrit-hooks has posted comments on this change.
Change subject: virt: _getUnderlyingGraphicsDeviceInfo() moved out of Vm
..
Patch Set 1:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make
gerrit-hooks has posted comments on this change.
Change subject: virt: _getUnderlyingMemoryDeviceInfo() moved out of Vm
..
Patch Set 1:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make
gerrit-hooks has posted comments on this change.
Change subject: virt: Move Vm._getUnderlyingDeviceAddress() to vmxml.py
..
Patch Set 1:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make
gerrit-hooks has posted comments on this change.
Change subject: virt: Don't use Vm device configuration in clientIF
..
Patch Set 2:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure
gerrit-hooks has posted comments on this change.
Change subject: virt: Move network legacy conf processing out of Vm
..
Patch Set 2:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure
gerrit-hooks has posted comments on this change.
Change subject: virt: Vm._getUnderlyingSoundDeviceInfo() moved to core.py
..
Patch Set 1:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found,
gerrit-hooks has posted comments on this change.
Change subject: virt: Move graphics legacy conf processing out of Vm
..
Patch Set 2:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make
gerrit-hooks has posted comments on this change.
Change subject: virt: Move video and controller legacy conf out of Vm
..
Patch Set 2:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make
gerrit-hooks has posted comments on this change.
Change subject: virt: Storage device legacy conf processing moved out of Vm
..
Patch Set 2:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found,
gerrit-hooks has posted comments on this change.
Change subject: virt: Move legacy sound conf from Vm to vmdevices
..
Patch Set 2:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure
gerrit-hooks has posted comments on this change.
Change subject: virt: Make Vm.devMapFromDevSpecMap() private
..
Patch Set 2:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
gerrit-hooks has posted comments on this change.
Change subject: virt: Make Vm.devSpecMapFromConf() private
..
Patch Set 2:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
gerrit-hooks has posted comments on this change.
Change subject: vmstats: from EAFP to LBYL
..
Patch Set 1:
* #1299480::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1299480::OK, public bug
* Check
gerrit-hooks has posted comments on this change.
Change subject: vmstats: remove _diff helper
..
Patch Set 1:
* #1299480::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1299480::OK, public bug
* Check
Francesco Romani has uploaded a new change for review.
Change subject: vmstats: from EAFP to LBYL
..
vmstats: from EAFP to LBYL
libvirt bulk stats' API allows to return partial result.
Hence, seems better to Look Before You
gerrit-hooks has posted comments on this change.
Change subject: periodic: ignore VIR_ERROR_OPERATION_UNSUPPORTED
..
Patch Set 5:
* #1299480::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1299480::OK, public bug
gerrit-hooks has posted comments on this change.
Change subject: virt: periodic: disable on migration destination
..
Patch Set 2:
* #1299480::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1299480::OK, public bug
Francesco Romani has uploaded a new change for review.
Change subject: vmstats: remove _diff helper
..
vmstats: remove _diff helper
the _diff helper is pretty pointless: makes the code
harder to follow, not easier.
This patch
Francesco Romani has abandoned this change.
Change subject: periodic: silence useless log
..
Abandoned
let's try with https://gerrit.ovirt.org/#/c/53539/1 before
--
To view, visit https://gerrit.ovirt.org/52895
To
gerrit-hooks has posted comments on this change.
Change subject: periodic: silence useless log
..
Patch Set 6:
* #1299480::Update tracker: OK
--
To view, visit https://gerrit.ovirt.org/52895
To unsubscribe, visit
Francesco Romani has posted comments on this change.
Change subject: virt: recovery: add constant for file extension
..
Patch Set 8: Verified+1
verified restarting Vdsm and triggering recovery flow (of course with 1+ VMs
Francesco Romani has posted comments on this change.
Change subject: virt: recovery: reduce code duplication
..
Patch Set 8: Verified+1
verified with 53405: created bogus recovery file, then restarted Vdsm.
--
To view, visit
Francesco Romani has posted comments on this change.
Change subject: recovery: reimplement clean_vm_files
..
Patch Set 6: Verified+1
verified creating bogus recovery file and restarting Vdsm.
--
To view, visit
gerrit-hooks has posted comments on this change.
Change subject: Skipping networkTests if alien bonds presents in the system
..
Patch Set 3:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found,
gerrit-hooks has posted comments on this change.
Change subject: Skipping networkTests if alien bonds presents in the system
..
Patch Set 2:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found,
gerrit-hooks has posted comments on this change.
Change subject: migration: Add incoming migration semaphore
..
Patch Set 26:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
Martin Betak has posted comments on this change.
Change subject: virt: add run_async helper
..
Patch Set 11:
(3 comments)
https://gerrit.ovirt.org/#/c/49570/11//COMMIT_MSG
Commit Message:
Line 11: support
> supportS
Done
gerrit-hooks has posted comments on this change.
Change subject: migration: Add retry on full capacity
..
Patch Set 8:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
gerrit-hooks has posted comments on this change.
Change subject: virt: add run_async helper
..
Patch Set 12:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches
gerrit-hooks has posted comments on this change.
Change subject: migration: Enable lazy setting of incoming/outgoing limits
..
Patch Set 3:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found,
gerrit-hooks has posted comments on this change.
Change subject: migration: Add DynamicThrottling semaphores
..
Patch Set 2:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
Ondřej Svoboda has posted comments on this change.
Change subject: vmfex hook: remove filter from directly-attached vnics
..
Patch Set 2: Code-Review+1
(1 comment)
Both in Python 2.7 and 3.5 the removals are safe.
gerrit-hooks has posted comments on this change.
Change subject: Apply storage QoS on running VM
..
Patch Set 11:
* #1201482::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1201482::OK, public bug
* Check
gerrit-hooks has posted comments on this change.
Change subject: Apply storage QoS on running VM
..
Patch Set 10:
* #1201482::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1201482::OK, public bug
* Check
Francesco Romani has posted comments on this change.
Change subject: virt: vm.py: Make _updateDomainDescriptor() return new XML
..
Patch Set 1:
Yes, we could probably abandon this direction.
For a future patch, we could
Francesco Romani has posted comments on this change.
Change subject: virt: Replace vm._dom.XMLDesc(0) with domain descriptor usage
..
Patch Set 3:
(1 comment)
https://gerrit.ovirt.org/#/c/52882/3/vdsm/virt/vm.py
File
gerrit-hooks has posted comments on this change.
Change subject: Apply storage QoS on running VM
..
Patch Set 9:
* #1201482::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1201482::OK, public bug
* Check
Ondřej Svoboda has posted comments on this change.
Change subject: vmfex hook: remove filter from directly-attached vnics
..
Patch Set 2: Code-Review-1
(1 comment)
Modify during iteration, just asking.
Piotr Kliczewski has posted comments on this change.
Change subject: contrib: schema converter
..
Patch Set 10:
(1 comment)
https://gerrit.ovirt.org/#/c/52864/10/lib/api/vdsm-api.yaml
File lib/api/vdsm-api.yaml:
Line 1:
Piotr Kliczewski has posted comments on this change.
Change subject: contrib: schema converter
..
Patch Set 10:
(1 comment)
https://gerrit.ovirt.org/#/c/52864/10/lib/api/vdsm-api.yaml
File lib/api/vdsm-api.yaml:
Line 4437:
Piotr Kliczewski has posted comments on this change.
Change subject: bridge: obtain method
..
Patch Set 2:
(2 comments)
https://gerrit.ovirt.org/#/c/53472/2/vdsm/rpc/Bridge.py
File vdsm/rpc/Bridge.py:
Line 68
Line 69
Line 70
Nir Soffer has posted comments on this change.
Change subject: bridge: obtain method
..
Patch Set 2:
(2 comments)
https://gerrit.ovirt.org/#/c/53472/2/vdsm/rpc/Bridge.py
File vdsm/rpc/Bridge.py:
Line 68
Line 69
Line 70
Line
Nir Soffer has posted comments on this change.
Change subject: gitreview: add file to make contribution easier
..
Patch Set 1:
(1 comment)
https://gerrit.ovirt.org/#/c/53589/1//COMMIT_MSG
Commit Message:
Line 7: gitreview:
Nir Soffer has posted comments on this change.
Change subject: virt: vm.py: Make _updateDomainDescriptor() return new XML
..
Patch Set 1: Code-Review-1
(1 comment)
https://gerrit.ovirt.org/#/c/53372/1//COMMIT_MSG
Commit
Nir Soffer has posted comments on this change.
Change subject: virt: Replace vm._dom.XMLDesc(0) with domain descriptor usage
..
Patch Set 3: Code-Review-1
(1 comment)
https://gerrit.ovirt.org/#/c/52882/3/vdsm/virt/vm.py
File
Nir Soffer has posted comments on this change.
Change subject: contrib: schema converter
..
Patch Set 10:
(1 comment)
https://gerrit.ovirt.org/#/c/52864/10/lib/api/vdsm-api.yaml
File lib/api/vdsm-api.yaml:
Line 1:
Nir Soffer has posted comments on this change.
Change subject: gitreview: add file to make contribution easier
..
Patch Set 1:
(1 comment)
https://gerrit.ovirt.org/#/c/53589/1//COMMIT_MSG
Commit Message:
Line 7: gitreview:
Piotr Kliczewski has posted comments on this change.
Change subject: contrib: schema converter
..
Patch Set 10:
(1 comment)
https://gerrit.ovirt.org/#/c/52864/10/lib/api/vdsm-api.yaml
File lib/api/vdsm-api.yaml:
Line 738:
Piotr Kliczewski has posted comments on this change.
Change subject: contrib: schema converter
..
Patch Set 10:
(60 comments)
https://gerrit.ovirt.org/#/c/52864/10/lib/api/vdsm-api.yaml
File lib/api/vdsm-api.yaml:
Line 2792:
Dan Kenigsberg has uploaded a new change for review.
Change subject: py3: modernize network tests
..
py3: modernize network tests
Run python-modernize on tests/net*.py to remove blunt python 3 errors
from them.
We do not run
gerrit-hooks has posted comments on this change.
Change subject: py3: modernize network tests
..
Patch Set 1:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches
Antoni Segura Puimedon has uploaded a new change for review.
Change subject: gitreview: add file to make contribution easier
..
gitreview: add file to make contribution easier
It is handy for people that check out the project
gerrit-hooks has posted comments on this change.
Change subject: gitreview: add file to make contribution easier
..
Patch Set 1:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure
Edward Haas has posted comments on this change.
Change subject: net: Fix internal setupNetworks api usage
..
Patch Set 1:
(1 comment)
https://gerrit.ovirt.org/#/c/53572/1/vdsm/API.py
File vdsm/API.py:
Line 1502:
Dan Kenigsberg has posted comments on this change.
Change subject: net: Fix internal setupNetworks api usage
..
Patch Set 1: Code-Review-1
(1 comment)
https://gerrit.ovirt.org/#/c/53572/1/vdsm/API.py
File vdsm/API.py:
Line
Francesco Romani has posted comments on this change.
Change subject: virt: add run_async helper
..
Patch Set 11:
(1 comment)
https://gerrit.ovirt.org/#/c/49570/11/tests/vmUtilsTests.py
File tests/vmUtilsTests.py:
Line 184:
Francesco Romani has posted comments on this change.
Change subject: virt: add run_async helper
..
Patch Set 11: Code-Review-1
(3 comments)
https://gerrit.ovirt.org/#/c/49570/11//COMMIT_MSG
Commit Message:
Line 11: support
Francesco Romani has posted comments on this change.
Change subject: virt: rng: Rng device should not depend on caps.py
..
Patch Set 1:
proof of concept not sure yet this is the best approach
--
To view, visit
Dan Kenigsberg has posted comments on this change.
Change subject: periodic: ignore VIR_ERROR_OPERATION_UNSUPPORTED
..
Patch Set 4: Code-Review-1
(1 comment)
https://gerrit.ovirt.org/#/c/53056/4/vdsm/virt/periodic.py
File
Dan Kenigsberg has posted comments on this change.
Change subject: virt: periodic: disable on migration destination
..
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/53539
To unsubscribe, visit
Francesco Romani has posted comments on this change.
Change subject: virt: periodic: disable on migration destination
..
Patch Set 1:
(1 comment)
https://gerrit.ovirt.org/#/c/53539/1/vdsm/virt/periodic.py
File
Francesco Romani has posted comments on this change.
Change subject: virt: periodic: disable on migration destination
..
Patch Set 1:
(1 comment)
https://gerrit.ovirt.org/#/c/53539/1/vdsm/virt/periodic.py
File
Michal Skrivanek has posted comments on this change.
Change subject: vmstats: remove useless short stacktrace
..
Patch Set 7:
Dan, in a sense it's common - any time around VM lifecycle changes we get a
bunch of errors from
Edward Haas has posted comments on this change.
Change subject: vmfex hook: remove filter from directly-attached vnics
..
Patch Set 2: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/53571
To unsubscribe, visit
Francesco Romani has posted comments on this change.
Change subject: virt: periodic: disable on migration destination
..
Patch Set 1:
(2 comments)
https://gerrit.ovirt.org/#/c/53539/1//COMMIT_MSG
Commit Message:
Line 9:
on
Francesco Romani has posted comments on this change.
Change subject: virt: periodic: disable on migration destination
..
Patch Set 1: Code-Review-1
PROOF OF CONCEPT - not sure yet this is a good approach
--
To view, visit
Dan Kenigsberg has posted comments on this change.
Change subject: vmstats: remove useless short stacktrace
..
Patch Set 7: Code-Review-1
if it's rare - it's not a real problem.
if it's common, we need to understand what
Dan Kenigsberg has posted comments on this change.
Change subject: virt: recovery: reduce code duplication
..
Patch Set 8: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/53053
To unsubscribe, visit
Dan Kenigsberg has submitted this change and it was merged.
Change subject: tests: start proper recovery.py tests
..
tests: start proper recovery.py tests
Change-Id: Ib09937448a04a6c10f33b7f23c0aed71eafc12d2
Signed-off-by:
gerrit-hooks has posted comments on this change.
Change subject: tests: start proper recovery.py tests
..
Patch Set 9:
* Update tracker: IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no Bug-Url found.
--
To view, visit
Dan Kenigsberg has posted comments on this change.
Change subject: tests: start proper recovery.py tests
..
Patch Set 8: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/52876
To unsubscribe, visit
Francesco Romani has posted comments on this change.
Change subject: periodic: silence useless log
..
Patch Set 6: Verified-1
Works. But better approach: https://gerrit.ovirt.org/#/c/53539/1
--
To view, visit
Anonymous Coward #1001177 has posted comments on this change.
Change subject: vmfex hook: remove filter from directly-attached vnics
..
Patch Set 2: Verified+1
--
To view, visit https://gerrit.ovirt.org/53571
To unsubscribe,
gerrit-hooks has posted comments on this change.
Change subject: vmfex hook: remove filter from directly-attached vnics
..
Patch Set 2:
* #1308839::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1308839::OK,
Edward Haas has posted comments on this change.
Change subject: net: Adding network api module to supervdsm
..
Patch Set 4: Verified+1
--
To view, visit https://gerrit.ovirt.org/53496
To unsubscribe, visit
Edward Haas has posted comments on this change.
Change subject: net: Fix internal setupNetworks api usage
..
Patch Set 1: Verified+1
--
To view, visit https://gerrit.ovirt.org/53572
To unsubscribe, visit
gerrit-hooks has posted comments on this change.
Change subject: WIP profiling: memory: port from dowser to tracemalloc
..
Patch Set 3:
* Update tracker: IGNORE, no Bug-Url found
--
To view, visit
Francesco Romani has posted comments on this change.
Change subject: json-rpc: export setLogLevel API
..
Patch Set 11: Verified+1
--
To view, visit https://gerrit.ovirt.org/38424
To unsubscribe, visit
gerrit-hooks has posted comments on this change.
Change subject: net: Adding network api module to supervdsm
..
Patch Set 4:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
gerrit-hooks has posted comments on this change.
Change subject: WIP profiling: memory: profile snapshots in vdsClient
..
Patch Set 2:
* Update tracker: IGNORE, no Bug-Url found
--
To view, visit
gerrit-hooks has posted comments on this change.
Change subject: profiling: move exceptions in a module
..
Patch Set 2:
* Update tracker: IGNORE, no Bug-Url found
--
To view, visit https://gerrit.ovirt.org/47593
To
gerrit-hooks has posted comments on this change.
Change subject: profiling: add support for memory profiling
..
Patch Set 2:
* Update tracker: IGNORE, no Bug-Url found
--
To view, visit https://gerrit.ovirt.org/47594
To
gerrit-hooks has posted comments on this change.
Change subject: profiling: disambiguate profile identifiers
..
Patch Set 2:
* Update tracker: IGNORE, no Bug-Url found
--
To view, visit https://gerrit.ovirt.org/47592
To
gerrit-hooks has posted comments on this change.
Change subject: profile: transform into a subpackage
..
Patch Set 2:
* Update tracker: IGNORE, no Bug-Url found
--
To view, visit https://gerrit.ovirt.org/47590
To
gerrit-hooks has posted comments on this change.
Change subject: profiling: import yappi outside lock
..
Patch Set 2:
* Update tracker: IGNORE, no Bug-Url found
--
To view, visit https://gerrit.ovirt.org/47591
To
gerrit-hooks has posted comments on this change.
Change subject: vm: do not call before_vm_start in dehibernation
..
Patch Set 4:
* Update tracker: IGNORE, no Bug-Url found
--
To view, visit https://gerrit.ovirt.org/45074
To
Francesco Romani has uploaded a new change for review.
Change subject: WIP profiling: memory: profile snapshots in vdsClient
..
WIP profiling: memory: profile snapshots in vdsClient
** WORK IN PROGRESS **
Add the ability to
Francesco Romani has abandoned this change.
Change subject: profiling: disambiguate profile identifiers
..
Abandoned
too old
--
To view, visit https://gerrit.ovirt.org/47592
To unsubscribe, visit
Francesco Romani has uploaded a new change for review.
Change subject: WIP profiling: memory: port from dowser to tracemalloc
..
WIP profiling: memory: port from dowser to tracemalloc
** WORK IN PROGRESS **
Change-Id:
Francesco Romani has abandoned this change.
Change subject: profiling: add support for memory profiling
..
Abandoned
too old
--
To view, visit https://gerrit.ovirt.org/47594
To unsubscribe, visit
Francesco Romani has abandoned this change.
Change subject: WIP profiling: memory: port from dowser to tracemalloc
..
Abandoned
too old
--
To view, visit https://gerrit.ovirt.org/47595
To unsubscribe, visit
Francesco Romani has abandoned this change.
Change subject: WIP profiling: memory: profile snapshots in vdsClient
..
Abandoned
too old
--
To view, visit https://gerrit.ovirt.org/47596
To unsubscribe, visit
Hello Dan Kenigsberg,
I'd like you to do a code review. Please visit
https://gerrit.ovirt.org/47594
to review the following change.
Change subject: profiling: add support for memory profiling
..
profiling: add support
Hello Dan Kenigsberg,
I'd like you to do a code review. Please visit
https://gerrit.ovirt.org/47592
to review the following change.
Change subject: profiling: disambiguate profile identifiers
..
profiling: disambiguate
1 - 100 of 179 matches
Mail list logo
