Piotr Kliczewski has posted comments on this change. Change subject: contrib: schema converter ......................................................................
Patch Set 10: (60 comments) https://gerrit.ovirt.org/#/c/52864/10/lib/api/vdsm-api.yaml File lib/api/vdsm-api.yaml: Line 2792: needs updating What is the default value? Line 2871: params Param list differs between schema and API.py Line 2890: (made optional in version 4.17.0) How it is going to work with older engines? Line 2953: needs updating What is the default value? Line 2954: (made optional : in version 4.17.0) How that works with older engines? Line 2958: needs updating what is the default value? Line 3084: needs updating What is the default value? Line 3091: needs updating What is the default value? Line 3095: needs updating What is the default value? Line 3152: needs updating What is the default value? Line 3157: needs updating What is the default value? Line 3177: needs updating What is the default value? Line 3195: needs updating What is the default value? Line 3205: needs updating What is the default value? Line 3213: needs updating What is the default value? Line 3217: needs updating What is the default value? Line 3221: needs updating What is the default value? Line 3258: needs updating What is the default value? Line 3355: needs updating What is the default value? Line 3359: needs updating What is the default value? Line 3369: needs updating What is the default value? Line 3374: needs updating What is the default value? Line 3468: needs updating What is the default value? Line 3474: needs updating What is the default value? Line 3486: needs updating What is the default value? Line 3507: needs updating What is the default value? Line 3513: needs updating What is the default value? Line 3524: needs updating What is the default value? Line 3566: needs updating What is the default value? Line 3658: needs updating What is the default value? Line 3738: needs updating What is the default value? Line 3796: needs updating What is the default value? Line 3852: needs updating What is the default value? Line 3910: needs updating What is the default value? Line 3945: needs updating What is the default value? Line 3996: needs updating What is the default value? Line 3997: (made : optional in version 4.17.0) How do it work with older engines? Line 4007: needs updating What is the default value? Line 4008: (made optional : in version 4.17.0) How do it work with older engines? Line 4061: needs updating What is the default value? Line 4062: (made optional in version 4.17.0) How do it work with older engines? Line 4065: needs updating what is the default value? Line 4081: needs updating What is the default value? Line 4112: needs updating What is the default value? Line 4113: (made : optional in version 4.17.0) How does it work with older engines? Line 4136: needs updating What is the default value? Line 4137: (made : optional in version 4.17.0) How does it work with older engines? Line 4179: needs updating What is the default value? Line 4181: (made optional in version 4.17.0) How does it work with older engines? Line 4487: needs updating What is the default value? Line 4491: needs updating What is the default value? Line 4525: needs updating What is the default value? Line 4534: needs updating What is the default value? Line 4706: needs updating What is the default value? Line 5007: needs updating What is the default value? Line 5015: needs updating What is the default value? Line 5027: needs updating What is the default value? Line 6150: (made optional in version 4.17.0) How do it work with older engines? Line 7113: needs updating What id the default value? Line 7117: needs updating What id the default value? -- To view, visit https://gerrit.ovirt.org/52864 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3921cebb7f550f63849f3bc5c80636b6e9495c92 Gerrit-PatchSet: 10 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski <[email protected]> Gerrit-Reviewer: Adam Litke <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Edward Haas <[email protected]> Gerrit-Reviewer: Francesco Romani <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Polednik <[email protected]> Gerrit-Reviewer: Milan Zamazal <[email protected]> Gerrit-Reviewer: Nir Soffer <[email protected]> Gerrit-Reviewer: Oved Ourfali <[email protected]> Gerrit-Reviewer: Piotr Kliczewski <[email protected]> Gerrit-Reviewer: Vinzenz Feenstra <[email protected]> Gerrit-Reviewer: Yaniv Bronhaim <[email protected]> Gerrit-Reviewer: gerrit-hooks <[email protected]> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
