Amit Aviram has posted comments on this change.
Change subject: imagetickets: add tests
..
Patch Set 10:
(2 comments)
https://gerrit.ovirt.org/#/c/52900/10/tests/imagetickets_test.py
File tests/imagetickets_test.py:
Line 121:
Piotr Kliczewski has posted comments on this change.
Change subject: bridge: obtain method
..
Patch Set 7:
(1 comment)
https://gerrit.ovirt.org/#/c/53472/7/tests/stompTests.py
File tests/stompTests.py:
Line 55: def unregi
Tomas Jelinek has posted comments on this change.
Change subject: migration: added support for convergence schedule
..
Patch Set 18: Verified+1
--
To view, visit https://gerrit.ovirt.org/46940
To unsubscribe, visit https://ger
Dan Kenigsberg has submitted this change and it was merged.
Change subject: move logUtils to lib
..
move logUtils to lib
Change-Id: I39b833ff5746db7a764ab9d9120e73a083d14365
Signed-off-by: Yaniv Bronhaim
Reviewed-on: https://g
gerrit-hooks has posted comments on this change.
Change subject: move logUtils to lib
..
Patch Set 4:
* Update tracker: IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no Bug-Url found.
--
To view, visit https://gerrit.ovirt
Nir Soffer has posted comments on this change.
Change subject: lib: executor: log pool status on discard
..
Patch Set 3: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/48417
To unsubscribe, visit https://gerrit.ovirt
Nir Soffer has posted comments on this change.
Change subject: imagetickets: add tests
..
Patch Set 10:
(2 comments)
https://gerrit.ovirt.org/#/c/52900/10/tests/imagetickets_test.py
File tests/imagetickets_test.py:
Line 121:
Nir Soffer has posted comments on this change.
Change subject: move logUtils to lib
..
Patch Set 3: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/53889
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit
Nir Soffer has posted comments on this change.
Change subject: bridge: obtain method
..
Patch Set 7:
(1 comment)
https://gerrit.ovirt.org/#/c/53472/7/tests/stompTests.py
File tests/stompTests.py:
Line 55: def unregister_s
Nir Soffer has uploaded a new change for review.
Change subject: fileUtils: Add atomic_symlink utility
..
fileUtils: Add atomic_symlink utility
This helper function creates or updates a symlink atomically. If the
symlink exists
Nir Soffer has posted comments on this change.
Change subject: fileUtils: Add atomic_symlink utility
..
Patch Set 1: Verified+1
Verified by the new tests.
--
To view, visit https://gerrit.ovirt.org/53680
To unsubscribe, visit
Adam Litke has posted comments on this change.
Change subject: fileUtils: Add atomic_symlink utility
..
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/53680
To unsubscribe, visit https://gerrit.ovirt.org
Nir Soffer has posted comments on this change.
Change subject: virt: stats: make _disk_iops_bytes more robust
..
Patch Set 2: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/53997
To unsubscribe, visit https://gerrit.
Nir Soffer has posted comments on this change.
Change subject: virt: stats: make compute_latency more robust
..
Patch Set 2: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/53996
To unsubscribe, visit https://gerrit.o
Nir Soffer has posted comments on this change.
Change subject: virt: stats: make disk_rate more robust
..
Patch Set 2: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/53995
To unsubscribe, visit https://gerrit.ovirt.o
Piotr Kliczewski has posted comments on this change.
Change subject: jsonrpc: provide more info when method not found
..
Patch Set 4:
(2 comments)
https://gerrit.ovirt.org/#/c/53714/4/lib/yajsonrpc/__init__.py
File lib/yajsonr
Piotr Kliczewski has posted comments on this change.
Change subject: spec: Add a dependency to vdsm on vdsm-cli
..
Patch Set 1:
(1 comment)
https://gerrit.ovirt.org/#/c/54006/1/vdsm.spec.in
File vdsm.spec.in:
Line 255: Requir
Piotr Kliczewski has posted comments on this change.
Change subject: json: use forzenset for filtered methods
..
Patch Set 1:
(1 comment)
https://gerrit.ovirt.org/#/c/54160/1/lib/yajsonrpc/__init__.py
File lib/yajsonrpc/__init
Nir Soffer has posted comments on this change.
Change subject: json: use forzenset for filtered methods
..
Patch Set 1: Code-Review+1
(1 comment)
https://gerrit.ovirt.org/#/c/54160/1/lib/yajsonrpc/__init__.py
File lib/yajsonrp
Nir Soffer has posted comments on this change.
Change subject: move alignmentScan.py to lib
..
Patch Set 6: Code-Review-1
(1 comment)
https://gerrit.ovirt.org/#/c/53758/6/tests/alignmentScanTests.py
File tests/alignmentScanTes
Nir Soffer has posted comments on this change.
Change subject: move blkid to lib
..
Patch Set 2: Code-Review+1
Looks safe, but we need to verify the flow when preparing a UUID type drive. I
don't know how to trigger this flow,
Nir Soffer has posted comments on this change.
Change subject: gluster: Don't fail connect server when getting volume info
..
Patch Set 5:
(3 comments)
https://gerrit.ovirt.org/#/c/53785/5/vdsm/storage/storageServer.py
File vd
Nir Soffer has posted comments on this change.
Change subject: jsonrpc: provide more info when method not found
..
Patch Set 4:
(2 comments)
https://gerrit.ovirt.org/#/c/53714/4/lib/yajsonrpc/__init__.py
File lib/yajsonrpc/__i
Dan Kenigsberg has posted comments on this change.
Change subject: net: use the correct dict with all the networks for
disable_ipv6 restoration
..
Patch Set 2:
(1 comment)
https://gerrit.ovirt.org/#/c/53942/2/vdsm/vdsm-restor
Francesco Romani has posted comments on this change.
Change subject: numa: add docstrings for public methods
..
Patch Set 3: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/54171
To unsubscribe, visit https://gerrit.o
Francesco Romani has posted comments on this change.
Change subject: numa: reorganize module
..
Patch Set 3: Code-Review-1
(1 comment)
-1 for visibility: looks fine but I'd like more context
https://gerrit.ovirt.org/#/c/54167
Francesco Romani has posted comments on this change.
Change subject: caps/numa: move autonuma status to sitelib
..
Patch Set 5: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/54166
To unsubscribe, visit https://gerri
Francesco Romani has posted comments on this change.
Change subject: numa: refactor to single pass caps parse
..
Patch Set 8:
(1 comment)
partial review, I need to do another pass later
https://gerrit.ovirt.org/#/c/53288/8/li
Francesco Romani has posted comments on this change.
Change subject: numa: move cpu topology (numa) related functionality to sitelib
..
Patch Set 8: Code-Review+2
(1 comment)
looks fine, but pretty please read inside comments
Francesco Romani has posted comments on this change.
Change subject: numa: move numa related functionality to sitelib
..
Patch Set 7: Code-Review-1
(2 comments)
looks fine, but we should take some (very cheap) preventive actio
Francesco Romani has posted comments on this change.
Change subject: numa: get distance information from libvirt
..
Patch Set 5:
+2 because is virt/sla flow
--
To view, visit https://gerrit.ovirt.org/53285
To unsubscribe, vis
Francesco Romani has posted comments on this change.
Change subject: numa: get distance information from libvirt
..
Patch Set 5: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/53285
To unsubscribe, visit https://gerr
Francesco Romani has posted comments on this change.
Change subject: migration: Add retry on full capacity
..
Patch Set 18: Code-Review-1
--
To view, visit https://gerrit.ovirt.org/52799
To unsubscribe, visit https://gerrit.ov
Francesco Romani has posted comments on this change.
Change subject: migration: Add retry on full capacity
..
Patch Set 18: Code-Review+1
(3 comments)
Looks good, but a couple of questions inside. Overall, -1 for visibility
h
Francesco Romani has posted comments on this change.
Change subject: vm: Move saveState() out of constructor
..
Patch Set 3: Code-Review-1
-1 for visibility, please read.
This change looks correct, but devil's in the details.
C
Francesco Romani has posted comments on this change.
Change subject: response: Add support for specific error checking in is_error
..
Patch Set 2: Code-Review+1
Looks fine, +2'd on hold:
please don't forget to add a comment on
Francesco Romani has posted comments on this change.
Change subject: response: Add support for specific error checking in is_error
..
Patch Set 2: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/54036
To unsubscribe,
Francesco Romani has posted comments on this change.
Change subject: Apply storage QoS on running VM
..
Patch Set 14: Code-Review-1
(3 comments)
Mostly OK, but please check iniline comments, especially about IDs.
-1 for visibl
Francesco Romani has posted comments on this change.
Change subject: virt: Add `vm' argument to underlying_device_info methods
..
Patch Set 1:
(1 comment)
https://gerrit.ovirt.org/#/c/53676/1//COMMIT_MSG
Commit Message:
Line
gerrit-hooks has posted comments on this change.
Change subject: WIP: vm: skip domDependentInit for containers
..
Patch Set 1:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
gerrit-hooks has posted comments on this change.
Change subject: WIP: add sudo permissions to run containers
..
Patch Set 1:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header m
gerrit-hooks has posted comments on this change.
Change subject: containers: always add emulator to XML
..
Patch Set 1:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matche
gerrit-hooks has posted comments on this change.
Change subject: virt: recovery: refactor entry points
..
Patch Set 2:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches
gerrit-hooks has posted comments on this change.
Change subject: containers: detect and report container support
..
Patch Set 3:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure head
gerrit-hooks has posted comments on this change.
Change subject: containers: make sure directory are ready
..
Patch Set 1:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header mat
gerrit-hooks has posted comments on this change.
Change subject: containers: initial support
..
Patch Set 4:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url:
gerrit-hooks has posted comments on this change.
Change subject: numa: add docstrings for public methods
..
Patch Set 3:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header match
gerrit-hooks has posted comments on this change.
Change subject: caps/numa: move autonuma status to sitelib
..
Patch Set 5:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header ma
gerrit-hooks has posted comments on this change.
Change subject: numa: reorganize module
..
Patch Set 3:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: '
gerrit-hooks has posted comments on this change.
Change subject: numa: add docstrings for public methods
..
Patch Set 2:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header match
gerrit-hooks has posted comments on this change.
Change subject: caps/numa: move autonuma status to sitelib
..
Patch Set 4:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header ma
gerrit-hooks has posted comments on this change.
Change subject: numa: reorganize module
..
Patch Set 2:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: '
Simone Tiraboschi has posted comments on this change.
Change subject: sync debian folder with supervdsm_api dir
..
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/54153
To unsubscribe, visit https://gerri
gerrit-hooks has posted comments on this change.
Change subject: numa: add docstrings for public methods
..
Patch Set 1:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header match
Martin Polednik has uploaded a new change for review.
Change subject: numa: add docstrings for public methods
..
numa: add docstrings for public methods
Change-Id: Id84872556a3f0699a738071ca7d3f9809bea305b
Signed-off-by: Martin
Simone Tiraboschi has posted comments on this change.
Change subject: createImageLinks: recreate if the link exists but it's broken
..
Patch Set 7:
(1 comment)
https://gerrit.ovirt.org/#/c/52937/7/vdsm/storage/fileSD.py
File v
gerrit-hooks has posted comments on this change.
Change subject: numa: reorganize module
..
Patch Set 1:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: '
gerrit-hooks has posted comments on this change.
Change subject: caps/numa: move autonuma status to sitelib
..
Patch Set 3:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header ma
Martin Polednik has uploaded a new change for review.
Change subject: numa: reorganize module
..
numa: reorganize module
Change-Id: I7e8ca3092d4c14827d0965a535ef3d0ac7ba4b0a
Signed-off-by: Martin Polednik
---
M lib/vdsm/numa.py
gerrit-hooks has posted comments on this change.
Change subject: numa: move numa related functionality to sitelib
..
Patch Set 7:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure hea
gerrit-hooks has posted comments on this change.
Change subject: numa: move cpu topology (numa) related functionality to sitelib
..
Patch Set 8:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found
gerrit-hooks has posted comments on this change.
Change subject: numa: refactor to single pass caps parse
..
Patch Set 8:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matc
gerrit-hooks has posted comments on this change.
Change subject: caps/numa: move autonuma status to sitelib
..
Patch Set 2:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header ma
gerrit-hooks has posted comments on this change.
Change subject: caps/numa: move autonuma status to sitelib
..
Patch Set 1:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header ma
Martin Polednik has uploaded a new change for review.
Change subject: caps/numa: move autonuma status to sitelib
..
caps/numa: move autonuma status to sitelib
Change-Id: I42e7eae743d319b0afd9653a9d6f1f2701856ca9
Signed-off-by: M
Ala Hino has posted comments on this change.
Change subject: gluster: Don't fail connect server when getting volume info
..
Patch Set 5:
Tried the following:
Provided this dummy path: test:/vol1
And provide these mount options:
Piotr Kliczewski has posted comments on this change.
Change subject: api: remove unused methods
..
Patch Set 3: Verified+1
Verified by running local build.
--
To view, visit https://gerrit.ovirt.org/53673
To unsubscribe, visi
gerrit-hooks has posted comments on this change.
Change subject: api: remove unused methods
..
Patch Set 3:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url:
gerrit-hooks has posted comments on this change.
Change subject: numa: get distance information from libvirt
..
Patch Set 5:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header m
gerrit-hooks has posted comments on this change.
Change subject: numa: move cpu topology (numa) related functionality to sitelib
..
Patch Set 7:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found
gerrit-hooks has posted comments on this change.
Change subject: numa: move numa related functionality to sitelib
..
Patch Set 6:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure hea
gerrit-hooks has posted comments on this change.
Change subject: numa: refactor to single pass caps parse
..
Patch Set 7:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matc
Piotr Kliczewski has posted comments on this change.
Change subject: [wip] bridge: usage of yaml schema
..
Patch Set 4: Verified+1
Verified by host deploying the host and seeing no issues.
Before I assume this patch to be read
Piotr Kliczewski has posted comments on this change.
Change subject: contrib: schema converter
..
Patch Set 16: Verified+1
Verified by host deploying the host and seeing no issues.
--
To view, visit https://gerrit.ovirt.org/5
Piotr Kliczewski has posted comments on this change.
Change subject: bridge: obtain method
..
Patch Set 7: Verified+1
Verified by host deploying the host and seeing no issues.
--
To view, visit https://gerrit.ovirt.org/53472
Piotr Kliczewski has posted comments on this change.
Change subject: json: use forzenset for filtered methods
..
Patch Set 1: Verified+1
Verified by host deploying the host and seeing no issues.
--
To view, visit https://gerr
Piotr Kliczewski has posted comments on this change.
Change subject: bridge: remove dead code
..
Patch Set 3: Verified+1
Verified by host deploying the host and seeing no issues.
--
To view, visit https://gerrit.ovirt.org/539
Piotr Kliczewski has posted comments on this change.
Change subject: jsonrpc: provide more info when method not found
..
Patch Set 4: Verified+1
Verified by host deploying the host and seeing no issues.
--
To view, visit http
Dan Kenigsberg has submitted this change and it was merged.
Change subject: net: api: move networks removal to a separate function
..
net: api: move networks removal to a separate function
As a part of preparation of network/ap
gerrit-hooks has posted comments on this change.
Change subject: net: api: move networks removal to a separate function
..
Patch Set 3:
* Update tracker: IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no Bug-Url found.
--
T
Dan Kenigsberg has posted comments on this change.
Change subject: net: api: move networks removal to a separate function
..
Patch Set 2: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/54086
To unsubscribe, visit htt
gerrit-hooks has posted comments on this change.
Change subject: bridge: remove dead code
..
Patch Set 3:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: '
gerrit-hooks has posted comments on this change.
Change subject: schema: remove unused types
..
Patch Set 6:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url:
gerrit-hooks has posted comments on this change.
Change subject: contrib: schema converter
..
Patch Set 16:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url:
gerrit-hooks has posted comments on this change.
Change subject: json: use forzenset for filtered methods
..
Patch Set 1:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matc
gerrit-hooks has posted comments on this change.
Change subject: [wip] bridge: usage of yaml schema
..
Patch Set 4:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'B
gerrit-hooks has posted comments on this change.
Change subject: gluster: fix schema
..
Patch Set 2:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: '
and
Piotr Kliczewski has uploaded a new change for review.
Change subject: json: use forzenset for filtered methods
..
json: use forzenset for filtered methods
Change-Id: I17becc319fb8e226f0badc883007900c8862a520
Signed-off-by: pkl
gerrit-hooks has posted comments on this change.
Change subject: jsonrpc: provide more info when method not found
..
Patch Set 4:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure hea
gerrit-hooks has posted comments on this change.
Change subject: bridge: obtain method
..
Patch Set 7:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: '
an
Dan Kenigsberg has submitted this change and it was merged.
Change subject: net: tests: cleanup net after test_rollback
..
net: tests: cleanup net after test_rollback
Without @cleanupNet decorator, failed test can leave
network
gerrit-hooks has posted comments on this change.
Change subject: net: tests: cleanup net after test_rollback
..
Patch Set 3:
* Update tracker: IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no Bug-Url found.
--
To view, vis
Dan Kenigsberg has posted comments on this change.
Change subject: net: tests: cleanup net after test_rollback
..
Patch Set 2: Code-Review+2
Edy's comment has been acted upon
--
To view, visit https://gerrit.ovirt.org/54010
T
Petr Horáček has posted comments on this change.
Change subject: net: tests: cleanup net after test_rollback
..
Patch Set 2: Verified+1
--
To view, visit https://gerrit.ovirt.org/54010
To unsubscribe, visit https://gerrit.ovir
gerrit-hooks has posted comments on this change.
Change subject: net: rename destroyOnMasterRemoval
..
Patch Set 4:
* Update tracker: IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no Bug-Url found.
--
To view, visit https:
Dan Kenigsberg has submitted this change and it was merged.
Change subject: net: rename destroyOnMasterRemoval
..
net: rename destroyOnMasterRemoval
destroyOnMasterRemoval parameter was needed to say whether bonding
should be r
Dan Kenigsberg has posted comments on this change.
Change subject: net: rename destroyOnMasterRemoval
..
Patch Set 3: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/54082
To unsubscribe, visit https://gerrit.ovirt.or
Ala Hino has posted comments on this change.
Change subject: gluster: Don't fail connect server when getting volume info
..
Patch Set 4:
(1 comment)
https://gerrit.ovirt.org/#/c/53785/4/vdsm/storage/storageServer.py
File vdsm/
gerrit-hooks has posted comments on this change.
Change subject: gluster: Don't fail connect server when getting volume info
..
Patch Set 5:
* #1303977::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1303977::OK, p
gerrit-hooks has posted comments on this change.
Change subject: Apply storage QoS on running VM
..
Patch Set 14:
* #1201482::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1201482::OK, public bug
* Check Product::
1 - 100 of 199 matches
Mail list logo