Change in vdsm[master]: net: Removing 'link' scoped addresses from the ip address list

gerrit-hooks has posted comments on this change. Change subject: net: Removing 'link' scoped addresses from the ip address list .. Patch Set 4: * Update tracker: IGNORE, no Bug-Url found * Set MODIFIED::IGNORE, no Bug-Url

Change in vdsm[master]: schema: add Rng and Tpm device to the device list

Dan Kenigsberg has posted comments on this change. Change subject: schema: add Rng and Tpm device to the device list .. Patch Set 7: Traceback (most recent call last): File

Change in vdsm[master]: ifcfg: re-enable IPv6 before device configuration, or disabl...

gerrit-hooks has posted comments on this change. Change subject: ifcfg: re-enable IPv6 before device configuration, or disable afterwards .. Patch Set 3: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no

Change in vdsm[master]: net: api: keep names and quotes consistent

gerrit-hooks has posted comments on this change. Change subject: net: api: keep names and quotes consistent .. Patch Set 9: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header

Change in vdsm[master]: net: api: replace custom logger with logging

gerrit-hooks has posted comments on this change. Change subject: net: api: replace custom logger with logging .. Patch Set 4: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header

Change in vdsm[master]: bridge: data verification

gerrit-hooks has posted comments on this change. Change subject: bridge: data verification .. Patch Set 8: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url:

Change in vdsm[master]: schema: add Rng and Tpm device to the device list

gerrit-hooks has posted comments on this change. Change subject: schema: add Rng and Tpm device to the device list .. Patch Set 7: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure

Change in vdsm[master]: bridge: obtain method

gerrit-hooks has posted comments on this change. Change subject: bridge: obtain method .. Patch Set 11: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: '

Change in vdsm[master]: json: use forzenset for filtered methods

gerrit-hooks has posted comments on this change. Change subject: json: use forzenset for filtered methods .. Patch Set 5: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header

Change in vdsm[master]: json: removal of old schemas

Piotr Kliczewski has posted comments on this change. Change subject: json: removal of old schemas .. Patch Set 3: Verified+1 Verified by host deploying vdsm and seeing that there are no issues with communication. -- To

Change in vdsm[master]: contrib: schema converter

gerrit-hooks has posted comments on this change. Change subject: contrib: schema converter .. Patch Set 20: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url:

Change in vdsm[master]: json: removal of old schemas

gerrit-hooks has posted comments on this change. Change subject: json: removal of old schemas .. Patch Set 3: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches

Change in vdsm[master]: bridge: usage of yaml schema

gerrit-hooks has posted comments on this change. Change subject: bridge: usage of yaml schema .. Patch Set 3: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches

Change in vdsm[master]: bridge: usage of yaml schema

Piotr Kliczewski has posted comments on this change. Change subject: bridge: usage of yaml schema .. Patch Set 3: Verified+1 Fixed issue in bridgeTests no code changes. -- To view, visit https://gerrit.ovirt.org/54528 To

Change in vdsm[master]: jsonrpc: provide more info when method not found

gerrit-hooks has posted comments on this change. Change subject: jsonrpc: provide more info when method not found .. Patch Set 8: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure

Change in vdsm[master]: bridge: remove dead code

gerrit-hooks has posted comments on this change. Change subject: bridge: remove dead code .. Patch Set 7: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: '

Change in vdsm[master]: Added fc23 packages to the automation scripts

gerrit-hooks has posted comments on this change. Change subject: Added fc23 packages to the automation scripts .. Patch Set 5: * Update tracker: IGNORE, no Bug-Url found -- To view, visit https://gerrit.ovirt.org/48180 To

Change in vdsm[master]: Added fc23 packages to the automation scripts

David Caro has abandoned this change. Change subject: Added fc23 packages to the automation scripts .. Abandoned reopen if needed -- To view, visit https://gerrit.ovirt.org/48180 To unsubscribe, visit

Change in vdsm[master]: storage: Move storage_exception module to lib

Nir Soffer has posted comments on this change. Change subject: storage: Move storage_exception module to lib .. Patch Set 8: Code-Review+2 Thanks! -- To view, visit https://gerrit.ovirt.org/54467 To unsubscribe, visit

Change in vdsm[master]: storage: Move storage_exception module to lib

Nir Soffer has posted comments on this change. Change subject: storage: Move storage_exception module to lib .. Patch Set 8: Waiting for jenkins -- To view, visit https://gerrit.ovirt.org/54467 To unsubscribe, visit

Change in vdsm[master]: ifcfg: re-enable IPv6 before device configuration, or disabl...

gerrit-hooks has posted comments on this change. Change subject: ifcfg: re-enable IPv6 before device configuration, or disable afterwards .. Patch Set 2: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no

Change in vdsm[master]: storage: Move storage_exception module to lib

gerrit-hooks has posted comments on this change. Change subject: storage: Move storage_exception module to lib .. Patch Set 8: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure

Change in vdsm[master]: storage: Move storage_exception module to lib

Freddy Rolland has posted comments on this change. Change subject: storage: Move storage_exception module to lib .. Patch Set 8: Verified+1 -- To view, visit https://gerrit.ovirt.org/54467 To unsubscribe, visit

Change in vdsm[master]: storage: Move storage_exception module to lib

Freddy Rolland has posted comments on this change. Change subject: storage: Move storage_exception module to lib .. Patch Set 7: (8 comments) https://gerrit.ovirt.org/#/c/54467/7/tests/blockVolumeTests.py File

Change in vdsm[master]: ifcfg: re-enable IPv6 before device configuration, or disabl...

gerrit-hooks has posted comments on this change. Change subject: ifcfg: re-enable IPv6 before device configuration, or disable afterwards .. Patch Set 1: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no

Change in vdsm[master]: ifcfg: re-enable IPv6 before device configuration, or disabl...

Ondřej Svoboda has uploaded a new change for review. Change subject: ifcfg: re-enable IPv6 before device configuration, or disable afterwards .. ifcfg: re-enable IPv6 before device configuration, or disable afterwards If a

Change in vdsm[master]: storage: Move storage_exception module to lib

Nir Soffer has posted comments on this change. Change subject: storage: Move storage_exception module to lib .. Patch Set 7: (8 comments) Some copyright years needs a fix.

Change in vdsm[master]: storage: Move storage_exception module to lib

Freddy Rolland has posted comments on this change. Change subject: storage: Move storage_exception module to lib .. Patch Set 7: Verified+1 -- To view, visit https://gerrit.ovirt.org/54467 To unsubscribe, visit

Change in vdsm[master]: register: Fix certificate validation

gerrit-hooks has posted comments on this change. Change subject: register: Fix certificate validation .. Patch Set 2: * Update tracker: IGNORE, no Bug-Url found -- To view, visit https://gerrit.ovirt.org/46981 To

Change in vdsm[master]: register: Simplify setting defaults

gerrit-hooks has posted comments on this change. Change subject: register: Simplify setting defaults .. Patch Set 2: * Update tracker: IGNORE, no Bug-Url found -- To view, visit https://gerrit.ovirt.org/46979 To unsubscribe,

Change in vdsm[master]: register: Drop CA path redundancies

Fabian Deutsch has abandoned this change. Change subject: register: Drop CA path redundancies .. Abandoned -- To view, visit https://gerrit.ovirt.org/46980 To unsubscribe, visit https://gerrit.ovirt.org/settings

Change in vdsm[master]: register: Fix certificate validation

Fabian Deutsch has abandoned this change. Change subject: register: Fix certificate validation .. Abandoned -- To view, visit https://gerrit.ovirt.org/46981 To unsubscribe, visit https://gerrit.ovirt.org/settings

Change in vdsm[master]: register: Simplify setting defaults

Fabian Deutsch has abandoned this change. Change subject: register: Simplify setting defaults .. Abandoned -- To view, visit https://gerrit.ovirt.org/46979 To unsubscribe, visit https://gerrit.ovirt.org/settings

Change in vdsm[master]: register: Drop CA path redundancies

gerrit-hooks has posted comments on this change. Change subject: register: Drop CA path redundancies .. Patch Set 2: * Update tracker: IGNORE, no Bug-Url found -- To view, visit https://gerrit.ovirt.org/46980 To unsubscribe,

Change in vdsm[master]: json: removal of old schemas

gerrit-hooks has posted comments on this change. Change subject: json: removal of old schemas .. Patch Set 2: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches

Change in vdsm[master]: schema: add Rng and Tpm device to the device list

Nir Soffer has posted comments on this change. Change subject: schema: add Rng and Tpm device to the device list .. Patch Set 6: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/54425 To unsubscribe, visit

Change in vdsm[master]: machinetype: document public functions

Dan Kenigsberg has posted comments on this change. Change subject: machinetype: document public functions .. Patch Set 4: Code-Review-1 (1 comment) silly nit from me, too.

Change in vdsm[master]: machinetype: split and slightly refactor cpu_models function

gerrit-hooks has posted comments on this change. Change subject: machinetype: split and slightly refactor cpu_models function .. Patch Set 6: * Update tracker: IGNORE, no Bug-Url found * Set MODIFIED::IGNORE, no Bug-Url found.

Change in vdsm[master]: machinetype: split and slightly refactor cpu_models function

Dan Kenigsberg has submitted this change and it was merged. Change subject: machinetype: split and slightly refactor cpu_models function .. machinetype: split and slightly refactor cpu_models function cpu_models has grown

Change in vdsm[master]: json: removal of old schemas

Nir Soffer has posted comments on this change. Change subject: json: removal of old schemas .. Patch Set 1: +226, -12738 - we need more patches like this :-) -- To view, visit https://gerrit.ovirt.org/54548 To unsubscribe,

Change in vdsm[master]: bridge: usage of yaml schema

Piotr Kliczewski has posted comments on this change. Change subject: bridge: usage of yaml schema .. Patch Set 2: Verified+1 Verification as for patch set #1 -- To view, visit https://gerrit.ovirt.org/54528 To unsubscribe,

Change in vdsm[master]: osinfo: avoid excepting *

Martin Polednik has posted comments on this change. Change subject: osinfo: avoid excepting * .. Patch Set 1: (3 comments) will try to be more specific in future ps https://gerrit.ovirt.org/#/c/54545/1/lib/vdsm/osinfo.py

Change in vdsm[master]: bridge: data verification

gerrit-hooks has posted comments on this change. Change subject: bridge: data verification .. Patch Set 7: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url:

Change in vdsm[master]: json: removal of old schemas

gerrit-hooks has posted comments on this change. Change subject: json: removal of old schemas .. Patch Set 1: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches

Change in vdsm[master]: bridge: remove dead code

gerrit-hooks has posted comments on this change. Change subject: bridge: remove dead code .. Patch Set 6: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: '

Change in vdsm[master]: osinfo: refactor package_versions function

Francesco Romani has posted comments on this change. Change subject: osinfo: refactor package_versions function .. Patch Set 1: Code-Review-1 (1 comment) partial review, mostly OK

Change in vdsm[master]: schema: add Rng and Tpm device to the device list

gerrit-hooks has posted comments on this change. Change subject: schema: add Rng and Tpm device to the device list .. Patch Set 6: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure

Change in vdsm[master]: contrib: schema converter

gerrit-hooks has posted comments on this change. Change subject: contrib: schema converter .. Patch Set 19: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url:

Change in vdsm[master]: bridge: obtain method

gerrit-hooks has posted comments on this change. Change subject: bridge: obtain method .. Patch Set 10: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: '

Change in vdsm[master]: bridge: usage of yaml schema

gerrit-hooks has posted comments on this change. Change subject: bridge: usage of yaml schema .. Patch Set 2: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches

Change in vdsm[master]: jsonrpc: provide more info when method not found

gerrit-hooks has posted comments on this change. Change subject: jsonrpc: provide more info when method not found .. Patch Set 7: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure

Change in vdsm[master]: json: removal of old schemas

Piotr Kliczewski has uploaded a new change for review. Change subject: json: removal of old schemas .. json: removal of old schemas Change-Id: I2d8a9d0837408ab727ecdeaa37d49efbca5bebdc Signed-off-by: pkliczewski

Change in vdsm[master]: json: use forzenset for filtered methods

gerrit-hooks has posted comments on this change. Change subject: json: use forzenset for filtered methods .. Patch Set 4: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header

Change in vdsm[master]: vdsm.spec: Require new libvirt on RHEL

gerrit-hooks has posted comments on this change. Change subject: vdsm.spec: Require new libvirt on RHEL .. Patch Set 1: * #1260131::Update tracker: OK * Check Bug-Url::OK * Check Public Bug::#1260131::OK, public bug * Check

Change in vdsm[master]: osinfo: avoid excepting *

Francesco Romani has posted comments on this change. Change subject: osinfo: avoid excepting * .. Patch Set 1: Code-Review-1 (6 comments) I like this patch, but -1 for visibility of the inline comments

Change in vdsm[master]: osinfo: pep8tify kdump_status

Francesco Romani has posted comments on this change. Change subject: osinfo: pep8tify kdump_status .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/54544 To unsubscribe, visit

Change in vdsm[master]: osinfo: use pep8 function names

Francesco Romani has posted comments on this change. Change subject: osinfo: use pep8 function names .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/54543 To unsubscribe, visit

Change in vdsm[master]: caps: move os-related information to osinfo module

Francesco Romani has posted comments on this change. Change subject: caps: move os-related information to osinfo module .. Patch Set 1: Code-Review-1 (1 comment) good idea! and osinfo is a pretty name. But please check whyw

Change in vdsm[master]: caps: use storage's getDefaultInitiatorName

Francesco Romani has posted comments on this change. Change subject: caps: use storage's getDefaultInitiatorName .. Patch Set 2: Code-Review+1 looks OK, but please get ACKs from storage devs. -- To view, visit

Change in vdsm[master]: caps: specialize and modernize _parseKeyVal

Francesco Romani has posted comments on this change. Change subject: caps: specialize and modernize _parseKeyVal .. Patch Set 1: Code-Review-1 nice, but I'd like some kind of tests here. Or is this code path already covered?

Change in vdsm[master]: storage: add copyright info

Nir Soffer has submitted this change and it was merged. Change subject: storage: add copyright info .. storage: add copyright info Add copyright info to missing files under storage. Change-Id:

Change in vdsm[master]: storage: add copyright info

gerrit-hooks has posted comments on this change. Change subject: storage: add copyright info .. Patch Set 3: * Update tracker: IGNORE, no Bug-Url found * Set MODIFIED::IGNORE, no Bug-Url found. -- To view, visit

Change in vdsm[master]: storage: add copyright info

Nir Soffer has posted comments on this change. Change subject: storage: add copyright info .. Patch Set 2: Thanks! -- To view, visit https://gerrit.ovirt.org/54508 To unsubscribe, visit https://gerrit.ovirt.org/settings

Change in vdsm[master]: storage: add copyright info

Nir Soffer has posted comments on this change. Change subject: storage: add copyright info .. Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/54508 To unsubscribe, visit https://gerrit.ovirt.org/settings

Change in vdsm[master]: osinfo: refactor package_versions function

gerrit-hooks has posted comments on this change. Change subject: osinfo: refactor package_versions function .. Patch Set 1: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header

Change in vdsm[master]: osinfo: use pep8 function names

gerrit-hooks has posted comments on this change. Change subject: osinfo: use pep8 function names .. Patch Set 1: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches

Change in vdsm[master]: osinfo: pep8tify kdump_status

Martin Polednik has uploaded a new change for review. Change subject: osinfo: pep8tify kdump_status .. osinfo: pep8tify kdump_status Change-Id: I989bee245d2ee1371750ab81265e146975989f06 Signed-off-by: Martin Polednik

Change in vdsm[master]: osinfo: pep8tify kdump_status

gerrit-hooks has posted comments on this change. Change subject: osinfo: pep8tify kdump_status .. Patch Set 1: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches

Change in vdsm[master]: caps: specialize and modernize _parseKeyVal

Martin Polednik has uploaded a new change for review. Change subject: caps: specialize and modernize _parseKeyVal .. caps: specialize and modernize _parseKeyVal _parseKeyVal was used as a very generic function to parse lines

Change in vdsm[master]: caps: move os-related information to osinfo module

gerrit-hooks has posted comments on this change. Change subject: caps: move os-related information to osinfo module .. Patch Set 1: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure

Change in vdsm[master]: osinfo: refactor package_versions function

Martin Polednik has uploaded a new change for review. Change subject: osinfo: refactor package_versions function .. osinfo: refactor package_versions function package_versions function is a large function that handles different

Change in vdsm[master]: osinfo: avoid excepting *

gerrit-hooks has posted comments on this change. Change subject: osinfo: avoid excepting * .. Patch Set 1: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url:

Change in vdsm[master]: osinfo: use pep8 function names

Martin Polednik has uploaded a new change for review. Change subject: osinfo: use pep8 function names .. osinfo: use pep8 function names Change-Id: I11e49e94e7bfbac08ba11da0ffa773925cca3ef0 Signed-off-by: Martin Polednik

Change in vdsm[master]: osinfo: avoid excepting *

Martin Polednik has uploaded a new change for review. Change subject: osinfo: avoid excepting * .. osinfo: avoid excepting * Using 'except:' can easily hide things such as syntax errors. This patch changes the code to except

Change in vdsm[master]: caps: move os-related information to osinfo module

Martin Polednik has uploaded a new change for review. Change subject: caps: move os-related information to osinfo module .. caps: move os-related information to osinfo module As a part of ongoing effort to strip caps.py the

Change in vdsm[master]: caps: use storage's getDefaultInitiatorName

gerrit-hooks has posted comments on this change. Change subject: caps: use storage's getDefaultInitiatorName .. Patch Set 2: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header

Change in vdsm[master]: caps: specialize and modernize _parseKeyVal

gerrit-hooks has posted comments on this change. Change subject: caps: specialize and modernize _parseKeyVal .. Patch Set 1: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header

Change in vdsm[master]: storage: add copyright info

Freddy Rolland has posted comments on this change. Change subject: storage: add copyright info .. Patch Set 2: Verified+1 -- To view, visit https://gerrit.ovirt.org/54508 To unsubscribe, visit

Change in vdsm[master]: storage: add copyright info

gerrit-hooks has posted comments on this change. Change subject: storage: add copyright info .. Patch Set 2: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches

Change in vdsm[master]: storage: add copyright info

Freddy Rolland has posted comments on this change. Change subject: storage: add copyright info .. Patch Set 1: (4 comments) https://gerrit.ovirt.org/#/c/54508/1/vdsm/storage/glusterSD.py File vdsm/storage/glusterSD.py: Line

Change in vdsm[master]: imagetickets: add tests

gerrit-hooks has posted comments on this change. Change subject: imagetickets: add tests .. Patch Set 13: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: '

Change in vdsm[master]: machinetype: pep8tify the module

Dan Kenigsberg has submitted this change and it was merged. Change subject: machinetype: pep8tify the module .. machinetype: pep8tify the module Change-Id: I5a641733f0e8e66c4be3b71872ec9967363914e2 Signed-off-by: Martin

Change in vdsm[master]: machinetype: pep8tify the module

gerrit-hooks has posted comments on this change. Change subject: machinetype: pep8tify the module .. Patch Set 3: * Update tracker: IGNORE, no Bug-Url found * Set MODIFIED::IGNORE, no Bug-Url found. -- To view, visit

Change in vdsm[master]: machinetype: update naming

gerrit-hooks has posted comments on this change. Change subject: machinetype: update naming .. Patch Set 3: * Update tracker: IGNORE, no Bug-Url found * Set MODIFIED::IGNORE, no Bug-Url found. -- To view, visit

Change in vdsm[master]: storage: add copyright info

Nir Soffer has posted comments on this change. Change subject: storage: add copyright info .. Patch Set 1: (4 comments) Thanks for this cleanup! Lets get the copyright years right.

Change in vdsm[master]: machinetype: update naming

Dan Kenigsberg has submitted this change and it was merged. Change subject: machinetype: update naming .. machinetype: update naming The old names of machinetype public functions were outdated, non-pep8-compilant. New names

Change in vdsm[master]: imagetickets: add tests

Nir Soffer has posted comments on this change. Change subject: imagetickets: add tests .. Patch Set 12: Amit, can you rebase and verify again? There is a path conflict, probably because of changes in the imagetickets in

Change in vdsm[master]: imagetickets: add tests

Nir Soffer has posted comments on this change. Change subject: imagetickets: add tests .. Patch Set 12: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/52900 To unsubscribe, visit https://gerrit.ovirt.org/settings

Change in vdsm[master]: vm: remove unused sendKeys verb

Sandro Bonazzola has posted comments on this change. Change subject: vm: remove unused sendKeys verb .. Patch Set 1: Code-Review+1 AFAIK neither host-deploy nor hosted engine are using that verb, so ok for removing it on my

Change in vdsm[master]: imagetickets: add tests

Amit Aviram has posted comments on this change. Change subject: imagetickets: add tests .. Patch Set 12: (1 comment) https://gerrit.ovirt.org/#/c/52900/12/vdsm/storage/imagetickets.py File vdsm/storage/imagetickets.py: > Is

Change in vdsm[master]: vm: remove not used monitorCommand

Francesco Romani has posted comments on this change. Change subject: vm: remove not used monitorCommand .. Patch Set 1: Code-Review+1 Verified-1 I like this (+1) but git grep in Engine reveals some apparent users. Cautionary

Change in vdsm[master]: vm: remove unused sendKeys verb

Francesco Romani has posted comments on this change. Change subject: vm: remove unused sendKeys verb .. Patch Set 1: Code-Review+1 Verified+1 I think this is OK. Adding more reviewers just in case I missed something.

Change in vdsm[master]: imagetickets: add tests

Freddy Rolland has posted comments on this change. Change subject: imagetickets: add tests .. Patch Set 12: Code-Review+1 (1 comment) https://gerrit.ovirt.org/#/c/52900/12/vdsm/storage/imagetickets.py File

Change in vdsm[master]: bridge: data verification

Piotr Kliczewski has posted comments on this change. Change subject: bridge: data verification .. Patch Set 6: Verified+1 Verified by host deploying vdsm and running bunch of verbs like creating, suspending vm and creating

Change in vdsm[master]: bridge: usage of yaml schema

Piotr Kliczewski has posted comments on this change. Change subject: bridge: usage of yaml schema .. Patch Set 1: Verified+1 Verified by host deploying vdsm and running bunch of verbs like creating, suspending vm and creating

Change in vdsm[master]: contrib: schema converter

Piotr Kliczewski has posted comments on this change. Change subject: contrib: schema converter .. Patch Set 18: Verified+1 Verified by host deploying vdsm and running bunch of verbs like creating, suspending vm and creating

Change in vdsm[master]: contrib: schema converter

gerrit-hooks has posted comments on this change. Change subject: contrib: schema converter .. Patch Set 18: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url:

Change in vdsm[master]: bridge: usage of yaml schema

gerrit-hooks has posted comments on this change. Change subject: bridge: usage of yaml schema .. Patch Set 1: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches

Change in vdsm[master]: bridge: obtain method

gerrit-hooks has posted comments on this change. Change subject: bridge: obtain method .. Patch Set 9: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: '

Change in vdsm[master]: jsonrpc: provide more info when method not found

gerrit-hooks has posted comments on this change. Change subject: jsonrpc: provide more info when method not found .. Patch Set 6: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure

<    1   2   3   >