gerrit-hooks has posted comments on this change.
Change subject: schema: add Rng and Tpm device to the device list
..
Patch Set 5:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure he
gerrit-hooks has posted comments on this change.
Change subject: bridge: data verification
..
Patch Set 6:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: '
Piotr Kliczewski has uploaded a new change for review.
Change subject: bridge: usage of yaml schema
..
bridge: usage of yaml schema
Change-Id: Ia76d8245568514d20e446237bd667d87fb4ad3e8
Signed-off-by: pkliczewski
---
M lib/api/
gerrit-hooks has posted comments on this change.
Change subject: bridge: remove dead code
..
Patch Set 5:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: '
gerrit-hooks has posted comments on this change.
Change subject: json: use forzenset for filtered methods
..
Patch Set 3:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matc
Francesco Romani has posted comments on this change.
Change subject: virt: Don't use Vm device configuration in clientIF
..
Patch Set 7: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/53482
To unsubscribe, visit http
Milan Zamazal has posted comments on this change.
Change subject: virt: Move Vm._getUnderlyingVmDevicesInfo() content out of Vm
..
Patch Set 8:
> please fix 53678 before
Done.
--
To view, visit https://gerrit.ovirt.org/53679
Piotr Kliczewski has posted comments on this change.
Change subject: moving protocoldetector under lib
..
Patch Set 3: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/54150
To unsubscribe, visit https://gerrit.ovirt.o
Yaniv Bronhaim has posted comments on this change.
Change subject: moving protocoldetector under lib
..
Patch Set 3: Verified+1
--
To view, visit https://gerrit.ovirt.org/54150
To unsubscribe, visit https://gerrit.ovirt.org/se
Piotr Kliczewski has posted comments on this change.
Change subject: contrib: schema converter
..
Patch Set 17:
(1 comment)
https://gerrit.ovirt.org/#/c/52864/17/lib/api/vdsm-api.yaml
File lib/api/vdsm-api.yaml:
Line 8600:
gerrit-hooks has posted comments on this change.
Change subject: vm: remove unused sendKeys verb
..
Patch Set 1:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-
Piotr Kliczewski has uploaded a new change for review.
Change subject: vm: remove not used monitorCommand
..
vm: remove not used monitorCommand
Change-Id: Iab244c568d10f1920599da418168e5d381f4b8a5
Signed-off-by: pkliczewski
--
Piotr Kliczewski has uploaded a new change for review.
Change subject: vm: remove unused sendKeys verb
..
vm: remove unused sendKeys verb
Change-Id: I709610a43cdf58464147ed6c7167d93558e29451
Signed-off-by: pkliczewski
---
M cl
gerrit-hooks has posted comments on this change.
Change subject: vm: remove not used monitorCommand
..
Patch Set 1:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'B
Milan Zamazal has posted comments on this change.
Change subject: virt: Move Vm._getUnderlyingUnknownDeviceInfo() out of Vm
..
Patch Set 7:
(1 comment)
https://gerrit.ovirt.org/#/c/53678/7/vdsm/virt/vmdevices/common.py
File vd
Milan Zamazal has posted comments on this change.
Change subject: virt: Move Vm._getUnderlyingUnknownDeviceInfo() out of Vm
..
Patch Set 7:
> if you add a new module you need to update also the Makefile.am, vdsm.spec.in
> and
Milan Zamazal has posted comments on this change.
Change subject: virt: Move Vm._getUnderlyingGraphicsDeviceInfo() out of Vm
..
Patch Set 8:
(1 comment)
https://gerrit.ovirt.org/#/c/53619/8/vdsm/virt/vmdevices/graphics.py
File
Milan Zamazal has abandoned this change.
Change subject: virt: New method Vm.get_devices
..
Abandoned
Not a good idea, discarded.
--
To view, visit https://gerrit.ovirt.org/54090
To unsubscribe, visit https://gerrit.ovirt.org
gerrit-hooks has posted comments on this change.
Change subject: virt: New method Vm.get_devices
..
Patch Set 1:
* Update tracker: IGNORE, no Bug-Url found
--
To view, visit https://gerrit.ovirt.org/54090
To unsubscribe, visi
Milan Zamazal has posted comments on this change.
Change subject: virt: Move Vm._getUnderlyingDeviceAddress() to vmxml.py
..
Patch Set 5:
(1 comment)
https://gerrit.ovirt.org/#/c/53615/5/vdsm/virt/vmxml.py
File vdsm/virt/vmxml
Milan Zamazal has posted comments on this change.
Change subject: virt: Make Vm.devMapFromDevSpecMap() private
..
Patch Set 7: Verified+1
Verified by running a VM from Engine, migrating it to another host and back and
shutting
Milan Zamazal has posted comments on this change.
Change subject: virt: Make Vm.devSpecMapFromConf() private
..
Patch Set 7: Verified+1
Verified by running a VM from Engine, migrating it to another host and back and
shutting i
Milan Zamazal has posted comments on this change.
Change subject: virt: Don't use Vm device configuration in clientIF
..
Patch Set 7: Verified+1
Verified by running a VM from Engine, migrating it to another host and back and
s
Francesco Romani has posted comments on this change.
Change subject: machinetype: document public functions
..
Patch Set 4: Code-Review+1
(1 comment)
please see inline nit
https://gerrit.ovirt.org/#/c/54302/4/lib/vdsm/machine
Francesco Romani has posted comments on this change.
Change subject: machinetype: reorganize and rename private functions
..
Patch Set 3: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/54300
To unsubscribe, visit htt
gerrit-hooks has posted comments on this change.
Change subject: virt: Move network legacy conf processing out of Vm
..
Patch Set 9:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure
gerrit-hooks has posted comments on this change.
Change subject: virt: Move graphics legacy conf processing out of Vm
..
Patch Set 9:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure
gerrit-hooks has posted comments on this change.
Change subject: virt: Move legacy sound conf from Vm to vmdevices
..
Patch Set 9:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure he
gerrit-hooks has posted comments on this change.
Change subject: virt: Move controller legacy conf out of Vm
..
Patch Set 6:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header m
gerrit-hooks has posted comments on this change.
Change subject: virt: Storage device legacy conf processing moved out of Vm
..
Patch Set 9:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, ma
Francesco Romani has posted comments on this change.
Change subject: machinetype: update naming
..
Patch Set 2: Code-Review+2
ok, let me be bold.
--
To view, visit https://gerrit.ovirt.org/54298
To unsubscribe, visit https://
gerrit-hooks has posted comments on this change.
Change subject: virt: Move video legacy conf out of Vm
..
Patch Set 9:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matche
gerrit-hooks has posted comments on this change.
Change subject: virt: Move Vm._getUnderlyingBalloonDeviceInfo() out of Vm
..
Patch Set 3:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make
gerrit-hooks has posted comments on this change.
Change subject: virt: Move Vm._getUnderlyingGraphicsDeviceInfo() out of Vm
..
Patch Set 9:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, mak
gerrit-hooks has posted comments on this change.
Change subject: virt: Move Vm._getUnderlyingControllerDeviceInfo() out of Vm
..
Patch Set 3:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, m
Francesco Romani has posted comments on this change.
Change subject: machinetype: split and slightly refactor cpu_models function
..
Patch Set 5: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/54301
To unsubscribe, v
gerrit-hooks has posted comments on this change.
Change subject: virt: Move Vm._getUnderlyingDriveInfo() out of Vm
..
Patch Set 8:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure he
Milan Zamazal has uploaded a new change for review.
Change subject: virt: Use PEP8 identifiers in vmxml.device_address
..
virt: Use PEP8 identifiers in vmxml.device_address
This is a trivial change just renaming two local variab
gerrit-hooks has posted comments on this change.
Change subject: virt: Move Vm._getUnderlyingWatchdogDeviceInfo() out of Vm
..
Patch Set 3:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, mak
gerrit-hooks has posted comments on this change.
Change subject: virt: Move Vm._getUnderlyingMemoryDeviceInfo() out of Vm
..
Patch Set 9:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make
gerrit-hooks has posted comments on this change.
Change subject: virt: Move Vm._getUnderlyingHostDeviceInfo() out of Vm
..
Patch Set 9:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make su
gerrit-hooks has posted comments on this change.
Change subject: virt: Move Vm._getUnderlyingRngDeviceInfo() out of Vm
..
Patch Set 3:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sur
gerrit-hooks has posted comments on this change.
Change subject: virt: Use PEP8 identifiers in vmxml.device_address
..
Patch Set 1:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure h
gerrit-hooks has posted comments on this change.
Change subject: virt: Move Vm._getUnderlyingVmDevicesInfo() content out of Vm
..
Patch Set 8:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found,
gerrit-hooks has posted comments on this change.
Change subject: virt: Move Vm._getUnderlyingUnknownDeviceInfo() out of Vm
..
Patch Set 8:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make
gerrit-hooks has posted comments on this change.
Change subject: virt: Move Vm._getUnderlyingConsoleDeviceInfo() out of Vm
..
Patch Set 8:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make
gerrit-hooks has posted comments on this change.
Change subject: virt: Move Vm._getUnderlyingSoundDeviceInfo() out of Vm
..
Patch Set 7:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make s
gerrit-hooks has posted comments on this change.
Change subject: virt: Move Vm._getUnderlyingSmartcardDeviceInfo() out of Vm
..
Patch Set 3:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, ma
gerrit-hooks has posted comments on this change.
Change subject: virt: Move Vm._getUnderlyingNetworkInterfaceInfo() out of Vm
..
Patch Set 9:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, m
gerrit-hooks has posted comments on this change.
Change subject: virt: Move Vm._getUnderlyingDeviceAddress() to vmxml.py
..
Patch Set 6:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make s
gerrit-hooks has posted comments on this change.
Change subject: virt: Move Vm._getUnderlyingVideoDeviceInfo() out of Vm
..
Patch Set 2:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make s
gerrit-hooks has posted comments on this change.
Change subject: virt: Make Vm.devSpecMapFromConf() private
..
Patch Set 7:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header ma
gerrit-hooks has posted comments on this change.
Change subject: virt: Don't use Vm device configuration in clientIF
..
Patch Set 7:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure
gerrit-hooks has posted comments on this change.
Change subject: virt: Make Vm.devMapFromDevSpecMap() private
..
Patch Set 7:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
Piotr Kliczewski has posted comments on this change.
Change subject: vm: rng: add TODO about schema cleanup
..
Patch Set 2: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/54506
To unsubscribe, visit https://gerrit.ov
Martin Polednik has abandoned this change.
Change subject: caps: move out parseKeyVal
..
Abandoned
Abandoning as this was not the nicest approach. Comments will be used as a base
for other patches.
--
To view, visit https://
gerrit-hooks has posted comments on this change.
Change subject: caps: move out parseKeyVal
..
Patch Set 1:
* Update tracker: IGNORE, no Bug-Url found
--
To view, visit https://gerrit.ovirt.org/54308
To unsubscribe, visit htt
Martin Polednik has uploaded a new change for review.
Change subject: caps: use storage's getDefaultInitiatorName
..
caps: use storage's getDefaultInitiatorName
Caps reimplemented the functionality to acquire host's scsi initiat
gerrit-hooks has posted comments on this change.
Change subject: caps: use storage's getDefaultInitiatorName
..
Patch Set 1:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header m
gerrit-hooks has posted comments on this change.
Change subject: vm: rng: add TODO about schema cleanup
..
Patch Set 2:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matche
Hello Fred Rolland,
I'd like you to do a code review. Please visit
https://gerrit.ovirt.org/54508
to review the following change.
Change subject: storage: add copyright info
..
storage: add copyright info
Add copyright i
gerrit-hooks has posted comments on this change.
Change subject: storage: add copyright info
..
Patch Set 1:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url:
Francesco Romani has posted comments on this change.
Change subject: network: skip non-existent devices in _restore_disable_ipv6
..
Patch Set 1: Code-Review+1
waiting for another ACK from network devs.
--
To view, visit https
Francesco Romani has posted comments on this change.
Change subject: restore-nets: disable IPv6 based on ifcfg files
..
Patch Set 3: Code-Review+1
Looks fine to me, but I'm not network expert :) Please convince Dan to change
h
Francesco Romani has posted comments on this change.
Change subject: supervdsm: move udev-related functions to udev.py
..
Patch Set 6: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/54458
To unsubscribe, visit https:
Martin Polednik has posted comments on this change.
Change subject: debian: add supervdsm_api
..
Patch Set 1: Verified+1
according to current codebase this should be fine and contains all files that
rpm specfile does
--
To v
Martin Polednik has posted comments on this change.
Change subject: supervdsm: move udev-related functions to udev.py
..
Patch Set 6: Verified+1
tested all flows separately, everything is exposed as it should be.
--
To view,
gerrit-hooks has posted comments on this change.
Change subject: tests: add tests for sampling.VMBulkSampler
..
Patch Set 44:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
gerrit-hooks has posted comments on this change.
Change subject: vmstats: reorder the calculations
..
Patch Set 5:
* Update tracker: IGNORE, no Bug-Url found
--
To view, visit https://gerrit.ovirt.org/54248
To unsubscribe, vi
Francesco Romani has abandoned this change.
Change subject: vmstats: reorder the calculations
..
Abandoned
Martin's right, the gains are minimal.
--
To view, visit https://gerrit.ovirt.org/54248
To unsubscribe, visit https://
Francesco Romani has posted comments on this change.
Change subject: vmstats: reorder the calculations
..
Patch Set 5:
on second thought, this is probably not worth the effort.
--
To view, visit https://gerrit.ovirt.org/54248
gerrit-hooks has posted comments on this change.
Change subject: storage: Move storage_exception module to lib
..
Patch Set 7:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
Freddy Rolland has posted comments on this change.
Change subject: storage: Move storage_exception module to lib
..
Patch Set 6:
(7 comments)
https://gerrit.ovirt.org/#/c/54467/6/debian/vdsm-python.install
File debian/vdsm-pyt
Piotr Kliczewski has posted comments on this change.
Change subject: vm: rng: add TODO about schema cleanup
..
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/54506
To unsubscribe, visit https://gerrit.ov
Piotr Kliczewski has posted comments on this change.
Change subject: schema: add Rng and Tpm device to the device list
..
Patch Set 4: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/54425
To unsubscribe, visit https:
Francesco Romani has uploaded a new change for review.
Change subject: vm: rng: add TODO about schema cleanup
..
vm: rng: add TODO about schema cleanup
The Rng device uses the data Engine sends,
documented in schema, in a pretty
gerrit-hooks has posted comments on this change.
Change subject: schema: add Rng and Tpm device to the device list
..
Patch Set 4:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure he
gerrit-hooks has posted comments on this change.
Change subject: vm: rng: add TODO about schema cleanup
..
Patch Set 1:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matche
Francesco Romani has posted comments on this change.
Change subject: schema: add Rng and Tpm device to the device list
..
Patch Set 3:
(2 comments)
https://gerrit.ovirt.org/#/c/54425/3/lib/api/vdsmapi-schema.json
File lib/api/
201 - 279 of 279 matches
Mail list logo
