gerrit-hooks has posted comments on this change.
Change subject: hooks:checkips: add checkips hook
..
Patch Set 3:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bu
Edward Haas has posted comments on this change.
Change subject: net: api: move rollback to network/api.py level
..
Patch Set 7:
(2 comments)
https://gerrit.ovirt.org/#/c/54751/7/lib/vdsm/network/api.py
File lib/vdsm/network/ap
Edward Haas has posted comments on this change.
Change subject: net tests: IPv6 autoconf with RA server
..
Patch Set 4:
(1 comment)
https://gerrit.ovirt.org/#/c/54668/4/tests/network/nettestlib.py
File tests/network/nettestlib
gerrit-hooks has posted comments on this change.
Change subject: net: Network caps now reports IPv6 autoconf state
..
Patch Set 11:
* Update tracker: IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no Bug-Url found.
--
To vi
Dan Kenigsberg has posted comments on this change.
Change subject: net: Network caps now reports IPv6 autoconf state
..
Patch Set 10: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/54475
To unsubscribe, visit https:/
Dan Kenigsberg has submitted this change and it was merged.
Change subject: net: Network caps now reports IPv6 autoconf state
..
net: Network caps now reports IPv6 autoconf state
'ipv6autoconf' current status is reported throug
Petr Horáček has posted comments on this change.
Change subject: net: Network caps now reports IPv6 autoconf state
..
Patch Set 10: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/54475
To unsubscribe, visit https://g
Petr Horáček has posted comments on this change.
Change subject: net tests: IPv6 autoconf with RA server
..
Patch Set 4:
(1 comment)
https://gerrit.ovirt.org/#/c/54668/4/tests/network/nettestlib.py
File tests/network/nettestli
Dan Kenigsberg has submitted this change and it was merged.
Change subject: tests: Do not skip test on dnsmasq_run failure
..
tests: Do not skip test on dnsmasq_run failure
Tests that used dnsmasq_run context manager could skip
gerrit-hooks has posted comments on this change.
Change subject: tests: Do not skip test on dnsmasq_run failure
..
Patch Set 3:
* Update tracker: IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no Bug-Url found.
--
To view,
Dan Kenigsberg has posted comments on this change.
Change subject: net: api: move rollback to network/api.py level
..
Patch Set 7: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/54751
To unsubscribe, visit https://ge
Dan Kenigsberg has posted comments on this change.
Change subject: net tests: IPv6 autoconf with RA server
..
Patch Set 4: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/54668
To unsubscribe, visit https://gerrit.ovi
gerrit-hooks has posted comments on this change.
Change subject: tests: Provide dnsmasq_run as a context manager
..
Patch Set 6:
* Update tracker: IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no Bug-Url found.
--
To view,
Dan Kenigsberg has submitted this change and it was merged.
Change subject: tests: Provide dnsmasq_run as a context manager
..
tests: Provide dnsmasq_run as a context manager
The functional tests are using dnsmasqDhcp as the dn
Dan Kenigsberg has posted comments on this change.
Change subject: tests: Provide dnsmasq_run as a context manager
..
Patch Set 5: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/54632
To unsubscribe, visit https://ge
Petr Horáček has posted comments on this change.
Change subject: net: api: move rollback to network/api.py level
..
Patch Set 7: Verified+1
Passed network tests OK
--
To view, visit https://gerrit.ovirt.org/54751
To unsubscri
Nir Soffer has posted comments on this change.
Change subject: WIP: POC: virt: common handling of exception
..
Patch Set 5: Code-Review+1
(4 comments)
Nice, minor comment about FINISH/ERROR log
https://gerrit.ovirt.org/#/c/54
Petr Horáček has posted comments on this change.
Change subject: tests: Provide dnsmasq_run as a context manager
..
Patch Set 5: Code-Review+1
(1 comment)
https://gerrit.ovirt.org/#/c/54632/5/tests/functional/networkTestsOVS.p
Nir Soffer has posted comments on this change.
Change subject: utils: Add changehash function for change detection
..
Patch Set 4:
(1 comment)
https://gerrit.ovirt.org/#/c/33045/4/lib/vdsm/utils.py
File lib/vdsm/utils.py:
Lin
gerrit-hooks has posted comments on this change.
Change subject: el7: require newly available python34-nose
..
Patch Set 2:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header ma
Piotr Kliczewski has posted comments on this change.
Change subject: rfh: Remove legacy remoteFileHandler
..
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/54703
To unsubscribe, visit https://gerrit.ovir
Adam Litke has posted comments on this change.
Change subject: storagetests: Create metadata storage area for block domains
..
Patch Set 4: Verified+1
--
To view, visit https://gerrit.ovirt.org/54568
To unsubscribe, visit http
Adam Litke has posted comments on this change.
Change subject: tests: Add test_overwrite_blocksize test
..
Patch Set 3: Verified+1
--
To view, visit https://gerrit.ovirt.org/54669
To unsubscribe, visit https://gerrit.ovirt.org
Adam Litke has posted comments on this change.
Change subject: storagetests: Add create_block_volume
..
Patch Set 4: Verified+1
--
To view, visit https://gerrit.ovirt.org/54570
To unsubscribe, visit https://gerrit.ovirt.org/se
Adam Litke has posted comments on this change.
Change subject: storagetests: Rename make_blocksd
..
Patch Set 4: Verified+1
--
To view, visit https://gerrit.ovirt.org/54569
To unsubscribe, visit https://gerrit.ovirt.org/settin
Adam Litke has posted comments on this change.
Change subject: storagetests: Create metadata storage area for block domains
..
Patch Set 4: Verified-1
--
To view, visit https://gerrit.ovirt.org/54568
To unsubscribe, visit http
Adam Litke has posted comments on this change.
Change subject: tests: refactor manifest_tests fake env setup
..
Patch Set 5: Verified+1
--
To view, visit https://gerrit.ovirt.org/50273
To unsubscribe, visit https://gerrit.ovir
Adam Litke has posted comments on this change.
Change subject: rfh: Remove legacy remoteFileHandler
..
Patch Set 1: Code-Review+1
Needs +2 from infra.
--
To view, visit https://gerrit.ovirt.org/54703
To unsubscribe, visit htt
Edward Haas has posted comments on this change.
Change subject: ifcfg: re-enable IPv6 before device configuration, or disable
afterwards
..
Patch Set 5:
(1 comment)
https://gerrit.ovirt.org/#/c/54555/5/lib/vdsm/network/config
gerrit-hooks has posted comments on this change.
Change subject: exception: Add exceptions for vdsm.define errors
..
Patch Set 18:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure he
gerrit-hooks has posted comments on this change.
Change subject: WIP: POC: virt: common handling of exception
..
Patch Set 5:
* #1316128::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1316128::OK, public bug
* Che
Edward Haas has posted comments on this change.
Change subject: tests: Do not skip test on dnsmasq_run failure
..
Patch Set 2:
It needs to be merged after its dependencies have been merged.
--
To view, visit https://gerrit.ov
Francesco Romani has posted comments on this change.
Change subject: WIP: POC: virt: common handling of exception
..
Patch Set 1:
(1 comment)
https://gerrit.ovirt.org/#/c/54664/1/vdsm/virt/vm.py
File vdsm/virt/vm.py:
Line 61:
Francesco Romani has posted comments on this change.
Change subject: WIP: POC: virt: common handling of exception
..
Patch Set 1:
(3 comments)
thanks for the reminders, I missed the comments before.
https://gerrit.ovirt.org/#
Edward Haas has posted comments on this change.
Change subject: net tests: IPv6 autoconf with RA server
..
Patch Set 4:
(2 comments)
https://gerrit.ovirt.org/#/c/54668/4/tests/network/nettestlib.py
File tests/network/nettestli
Edward Haas has posted comments on this change.
Change subject: tests: Provide dnsmasq_run as a context manager
..
Patch Set 5:
(1 comment)
https://gerrit.ovirt.org/#/c/54632/5/tests/functional/networkTestsOVS.py
File tests/fu
Francesco Romani has posted comments on this change.
Change subject: response: Add support for specific error checking in is_error
..
Patch Set 3:
Martin added the required statement, so it is fine now
--
To view, visit https
Francesco Romani has posted comments on this change.
Change subject: response: Add support for specific error checking in is_error
..
Patch Set 3: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/54036
To unsubscribe,
gerrit-hooks has posted comments on this change.
Change subject: response: Add support for specific error checking in is_error
..
Patch Set 3:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found,
Petr Horáček has posted comments on this change.
Change subject: net tests: IPv6 autoconf with RA server
..
Patch Set 4:
(2 comments)
https://gerrit.ovirt.org/#/c/54668/4/tests/network/nettestlib.py
File tests/network/nettestl
Martin Betak has posted comments on this change.
Change subject: response: Add support for specific error checking in is_error
..
Patch Set 2:
@fromani: Sure, verified by running tests and also by full e2e manual tests of
foll
Martin Polednik has posted comments on this change.
Change subject: osinfo: avoid excepting *
..
Patch Set 4:
(1 comment)
https://gerrit.ovirt.org/#/c/54545/4/lib/vdsm/osinfo.py
File lib/vdsm/osinfo.py:
Line 160: os.uname
> p
gerrit-hooks has posted comments on this change.
Change subject: net: api: move rollback to network/api.py level
..
Patch Set 7:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure head
Nir Soffer has posted comments on this change.
Change subject: exception: Add exceptions for vdsm.define errors
..
Patch Set 15:
(4 comments)
Lets try to merge this and leave additional work to later - this patch should
not c
gerrit-hooks has posted comments on this change.
Change subject: net: api: move rollback to network/api.py level
..
Patch Set 6:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure head
Nir Soffer has posted comments on this change.
Change subject: exception: Add exceptions for vdsm.define errors
..
Patch Set 17:
(1 comment)
Looks good expect the unneeded comments.
https://gerrit.ovirt.org/#/c/48871/17/tests
Nir Soffer has posted comments on this change.
Change subject: WIP: POC: virt: common handling of exception
..
Patch Set 4:
Franceso, did you see my comments in
https://gerrit.ovirt.org/#/c/54664/1/lib/vdsm/virt/utils.py ?
--
Nir Soffer has posted comments on this change.
Change subject: WIP: POC: virt: common handling of exception
..
Patch Set 2:
(2 comments)
https://gerrit.ovirt.org/#/c/54664/2/lib/vdsm/virt/utils.py
File lib/vdsm/virt/utils.py:
Ondřej Svoboda has posted comments on this change.
Change subject: ifcfg: re-enable IPv6 before device configuration, or disable
afterwards
..
Patch Set 5:
(1 comment)
https://gerrit.ovirt.org/#/c/54555/5/lib/vdsm/network/con
gerrit-hooks has posted comments on this change.
Change subject: net: api: move rollback to network/api.py level
..
Patch Set 5:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure head
Petr Horáček has posted comments on this change.
Change subject: tests: Provide dnsmasq_run as a context manager
..
Patch Set 5: Code-Review-1
(1 comment)
https://gerrit.ovirt.org/#/c/54632/5/tests/functional/networkTestsOVS.p
Dan Kenigsberg has posted comments on this change.
Change subject: osinfo: avoid excepting *
..
Patch Set 4: Code-Review-1
(1 comment)
nit
https://gerrit.ovirt.org/#/c/54545/4/lib/vdsm/osinfo.py
File lib/vdsm/osinfo.py:
Line
Dan Kenigsberg has submitted this change and it was merged.
Change subject: osinfo: pep8tify kdump_status
..
osinfo: pep8tify kdump_status
Change-Id: I989bee245d2ee1371750ab81265e146975989f06
Signed-off-by: Martin Polednik
Rev
gerrit-hooks has posted comments on this change.
Change subject: osinfo: pep8tify kdump_status
..
Patch Set 5:
* Update tracker: IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no Bug-Url found.
--
To view, visit https://ger
Dan Kenigsberg has posted comments on this change.
Change subject: osinfo: pep8tify kdump_status
..
Patch Set 4: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/54544
To unsubscribe, visit https://gerrit.ovirt.org/set
Yaniv Kaul has posted comments on this change.
Change subject: qemuimg: Make QCOW2_COMPAT configurable
..
Patch Set 1:
(1 comment)
https://gerrit.ovirt.org/#/c/54759/1/lib/vdsm/qemuimg.py
File lib/vdsm/qemuimg.py:
Line 39:
L
Nir Soffer has posted comments on this change.
Change subject: qemuimg: Make QCOW2_COMPAT configurable
..
Patch Set 1:
(1 comment)
https://gerrit.ovirt.org/#/c/54759/1/lib/vdsm/qemuimg.py
File lib/vdsm/qemuimg.py:
Line 39:
L
Yaniv Kaul has posted comments on this change.
Change subject: qemuimg: Make QCOW2_COMPAT configurable
..
Patch Set 1:
(1 comment)
https://gerrit.ovirt.org/#/c/54759/1/lib/vdsm/qemuimg.py
File lib/vdsm/qemuimg.py:
Line 39:
L
Dan Kenigsberg has posted comments on this change.
Change subject: tests: Do not skip test on dnsmasq_run failure
..
Patch Set 2: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/54744
To unsubscribe, visit https://ger
gerrit-hooks has posted comments on this change.
Change subject: net: api: move rollback to network/api.py level
..
Patch Set 4:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure head
Petr Horáček has abandoned this change.
Change subject: net: api: move rollback to network/api.py level
..
Abandoned
--
To view, visit https://gerrit.ovirt.org/54219
To unsubscribe, visit https://gerrit.ovirt.org/settings
Ger
gerrit-hooks has posted comments on this change.
Change subject: net: api: move rollback to network/api.py level
..
Patch Set 7:
* Update tracker: IGNORE, no Bug-Url found
--
To view, visit https://gerrit.ovirt.org/54219
To u
Nir Soffer has submitted this change and it was merged.
Change subject: fileUtils: Add atomic_symlink utility
..
fileUtils: Add atomic_symlink utility
This helper function creates or updates a symlink atomically. If the
symlink
gerrit-hooks has posted comments on this change.
Change subject: fileUtils: Add atomic_symlink utility
..
Patch Set 3:
* Update tracker: IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no Bug-Url found.
--
To view, visit htt
Nir Soffer has posted comments on this change.
Change subject: fileUtils: Add atomic_symlink utility
..
Patch Set 2:
No reply from Dan, so we will fix this later if needed.
--
To view, visit https://gerrit.ovirt.org/53680
To
Edward Haas has posted comments on this change.
Change subject: ifcfg: re-enable IPv6 before device configuration, or disable
afterwards
..
Patch Set 5:
(2 comments)
https://gerrit.ovirt.org/#/c/54555/5/lib/vdsm/network/confi
Nir Soffer has posted comments on this change.
Change subject: qemuimg: Make QCOW2_COMPAT configurable
..
Patch Set 1:
(1 comment)
https://gerrit.ovirt.org/#/c/54759/1/lib/vdsm/config.py.in
File lib/vdsm/config.py.in:
Line 23
Nir Soffer has uploaded a new change for review.
Change subject: qemuimg: Make QCOW2_COMPAT configurable
..
qemuimg: Make QCOW2_COMPAT configurable
It's worth to make QCOW2 compatibility version configurable. It would
allow to e
gerrit-hooks has posted comments on this change.
Change subject: qemuimg: Make QCOW2_COMPAT configurable
..
Patch Set 1:
* #1317850::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1317850::OK, public bug
* Check Pr
Dan Kenigsberg has submitted this change and it was merged.
Change subject: osinfo: use pep8 function names
..
osinfo: use pep8 function names
Change-Id: I11e49e94e7bfbac08ba11da0ffa773925cca3ef0
Signed-off-by: Martin Polednik
gerrit-hooks has posted comments on this change.
Change subject: osinfo: use pep8 function names
..
Patch Set 5:
* Update tracker: IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no Bug-Url found.
--
To view, visit https://g
gerrit-hooks has posted comments on this change.
Change subject: caps: move os-related information to osinfo module
..
Patch Set 5:
* Update tracker: IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no Bug-Url found.
--
To vi
Dan Kenigsberg has submitted this change and it was merged.
Change subject: caps: move os-related information to osinfo module
..
caps: move os-related information to osinfo module
As a part of ongoing effort to strip caps.py t
Petr Horáček has posted comments on this change.
Change subject: net: legacy: split bonds handling to removal and setup
..
Patch Set 3:
Passed network tests OK
--
To view, visit https://gerrit.ovirt.org/54352
To unsubscribe,
Petr Horáček has posted comments on this change.
Change subject: net: legacy: split bonds handling to removal and setup
..
Patch Set 3: Verified+1
--
To view, visit https://gerrit.ovirt.org/54352
To unsubscribe, visit https://
gerrit-hooks has posted comments on this change.
Change subject: check: Separate storage health monitoring
..
Patch Set 1:
* #1081962::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1081962::OK, public bug
* Check
Ondřej Svoboda has posted comments on this change.
Change subject: ifcfg: re-enable IPv6 before device configuration, or disable
afterwards
..
Patch Set 5:
(5 comments)
https://gerrit.ovirt.org/#/c/54555/5/lib/vdsm/network/co
Francesco Romani has posted comments on this change.
Change subject: caps: move os-related information to osinfo module
..
Patch Set 4: Code-Review+2
Let me copy my score.
--
To view, visit https://gerrit.ovirt.org/54542
To u
gerrit-hooks has posted comments on this change.
Change subject: agent: Guest agent reply capability support
..
Patch Set 6:
* #1298120::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1298120::OK, public bug
* Chec
gerrit-hooks has posted comments on this change.
Change subject: agent: Introduction of first_connect event
..
Patch Set 3:
* #1298120::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1298120::OK, public bug
* Check
gerrit-hooks has posted comments on this change.
Change subject: virt: Add the migration/hibernation event handling (GuestAgent)
..
Patch Set 7:
* #1298120::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1298120::O
Piotr Kliczewski has posted comments on this change.
Change subject: events: introduction of schema
..
Patch Set 1:
(3 comments)
https://gerrit.ovirt.org/#/c/54754/1/lib/api/vdsm-events.yaml
File lib/api/vdsm-events.yaml:
Lin
gerrit-hooks has posted comments on this change.
Change subject: net: api: move rollback to network/api.py level
..
Patch Set 3:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure head
Piotr Kliczewski has posted comments on this change.
Change subject: json: removal of old schemas
..
Patch Set 5: Verified+1
Set of patches verified by host deploying a host, configuring nfs data domain
and provision a vm base
Piotr Kliczewski has posted comments on this change.
Change subject: contrib: schema converter
..
Patch Set 22: Verified+1
I updated schema with recent networking changes and removed monitorCommand
verb. Set of patches verifie
gerrit-hooks has posted comments on this change.
Change subject: virt: Introduction of the GuestAgentEvents class
..
Patch Set 5:
* #1298120::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1298120::OK, public bug
*
gerrit-hooks has posted comments on this change.
Change subject: virt: Add the migration/hibernation event handling (GuestAgent)
..
Patch Set 6:
* #1298120::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1298120::O
gerrit-hooks has posted comments on this change.
Change subject: agent: Guest agent reply capability support
..
Patch Set 5:
* #1298120::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1298120::OK, public bug
* Chec
gerrit-hooks has posted comments on this change.
Change subject: agent: Introduction of first_connect event
..
Patch Set 2:
* #1298120::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1298120::OK, public bug
* Check
gerrit-hooks has posted comments on this change.
Change subject: bridge: data verification
..
Patch Set 10:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url:
gerrit-hooks has posted comments on this change.
Change subject: bridge: usage of yaml schema
..
Patch Set 5:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url
gerrit-hooks has posted comments on this change.
Change subject: events: introduction of schema
..
Patch Set 1:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-U
gerrit-hooks has posted comments on this change.
Change subject: net: api: move rollback to network/api.py level
..
Patch Set 2:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure head
gerrit-hooks has posted comments on this change.
Change subject: json: removal of old schemas
..
Patch Set 5:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url
gerrit-hooks has posted comments on this change.
Change subject: contrib: schema converter
..
Patch Set 22:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url:
Piotr Kliczewski has uploaded a new change for review.
Change subject: events: introduction of schema
..
events: introduction of schema
Change-Id: I43a9f1852b1459a2e905244049507704f0187201
Signed-off-by: pkliczewski
---
M lib/
gerrit-hooks has posted comments on this change.
Change subject: agent: Introduction of first_connect event
..
Patch Set 1:
* #1298120::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1298120::OK, public bug
* Check
gerrit-hooks has posted comments on this change.
Change subject: virt: Add the migration/hibernation event handling (GuestAgent)
..
Patch Set 5:
* #1298120::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1298120::O
Vinzenz Feenstra has uploaded a new change for review.
Change subject: agent: Introduction of first_connect event
..
agent: Introduction of first_connect event
In order to be able to at least attempt reliably that the first conn
Dan Kenigsberg has posted comments on this change.
Change subject: tests: Provide dnsmasq_run as a context manager
..
Patch Set 5: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/54632
To unsubscribe, visit https://ge
1 - 100 of 206 matches
Mail list logo