Dan Kenigsberg has posted comments on this change. Change subject: osinfo: avoid excepting * ......................................................................
Patch Set 4: Code-Review-1 (1 comment) nit https://gerrit.ovirt.org/#/c/54545/4/lib/vdsm/osinfo.py File lib/vdsm/osinfo.py: Line 160: os.uname please take out of try block, as this cannot raise a ValueError. -- To view, visit https://gerrit.ovirt.org/54545 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ice9171e64fb6b3879a33f5d9566e8aa2546c424f Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Polednik <mpoled...@redhat.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Francesco Romani <from...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Polednik <mpoled...@redhat.com> Gerrit-Reviewer: gerrit-hooks <automat...@ovirt.org> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
