gerrit-hooks has posted comments on this change.
Change subject: net: netinfo: report switch type
..
Patch Set 1:
* #1195208::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1195208::OK, public bug
* Check
Martin Sivák has posted comments on this change.
Change subject: Apply storage QoS on running VM
..
Patch Set 17: Code-Review+1
Ack, seems to be fine from the SLA perspective.
--
To view, visit https://gerrit.ovirt.org/52746
Dan Kenigsberg has submitted this change and it was merged.
Change subject: hostdev: use device setup instead of detach
..
hostdev: use device setup instead of detach
Host devices require action before VM is started. We rename
gerrit-hooks has posted comments on this change.
Change subject: hostdev: use device setup instead of detach
..
Patch Set 7:
* Update tracker: IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no Bug-Url found.
--
To view,
gerrit-hooks has posted comments on this change.
Change subject: travis: Improve Dockerfile formating
..
Patch Set 3:
* Update tracker: IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no Bug-Url found.
--
To view, visit
Dan Kenigsberg has submitted this change and it was merged.
Change subject: travis: Improve Dockerfile formating
..
travis: Improve Dockerfile formating
Sort packages to make it easier to work with, and separte the && line so
Petr Horáček has posted comments on this change.
Change subject: hooks: Add fcoe hook
..
Patch Set 18: Code-Review-1
(10 comments)
most of them are 'code typography', i won't fight for them
Shahar Havivi has posted comments on this change.
Change subject: kvmstream: tool for streaming images from libvirt
..
Patch Set 1:
(4 comments)
https://gerrit.ovirt.org/#/c/55797/1/kvmstream.py
File kvmstream.py:
PS1, Line
Dan Kenigsberg has posted comments on this change.
Change subject: hooks: Add fcoe hook
..
Patch Set 18: Code-Review-1
--
To view, visit https://gerrit.ovirt.org/55029
To unsubscribe, visit https://gerrit.ovirt.org/settings
Yaniv Kaul has posted comments on this change.
Change subject: kvmstream: tool for streaming images from libvirt
..
Patch Set 1:
(3 comments)
Few notes in the code, but generally I'd give -1 since I think it's critical to
gerrit-hooks has posted comments on this change.
Change subject: sr-iov: use device setup instead of detach
..
Patch Set 6:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
gerrit-hooks has posted comments on this change.
Change subject: hostdev: use device setup instead of detach
..
Patch Set 6:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
gerrit-hooks has posted comments on this change.
Change subject: virt: add device setup and teardown
..
Patch Set 6:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches
Nir Soffer has posted comments on this change.
Change subject: qemuimg: Remove EL6 comment
..
Patch Set 1:
(1 comment)
https://gerrit.ovirt.org/#/c/55794/1//COMMIT_MSG
Commit Message:
Line 6:
Line 7: qemuimg: Remove EL6
Nir Soffer has posted comments on this change.
Change subject: qemuimg: remove workaround for qemu-img --help rc
..
Patch Set 2:
(2 comments)
https://gerrit.ovirt.org/#/c/55795/2/lib/vdsm/qemuimg.py
File lib/vdsm/qemuimg.py:
Edward Haas has posted comments on this change.
Change subject: test: Use mock module for testing
..
Patch Set 6:
(1 comment)
https://gerrit.ovirt.org/#/c/55342/6/tests/network/netswitch_test.py
File
Nir Soffer has posted comments on this change.
Change subject: kvmstream: tool for streaming images from libvirt
..
Patch Set 1:
(1 comment)
https://gerrit.ovirt.org/#/c/55797/1/kvmstream.py
File kvmstream.py:
Line 57:
Francesco Romani has posted comments on this change.
Change subject: kvmstream: tool for streaming images from libvirt
..
Patch Set 1:
Feel free to borrow ideas and code (completely untested) from
http://fpaste.org/350936/
gerrit-hooks has posted comments on this change.
Change subject: Vm: conf: proper locking in the creation path
..
Patch Set 5:
* #1318550::Update tracker: OK
* Set MODIFIED::bug 1318550#1318550IGNORE, not oVirt
Dan Kenigsberg has submitted this change and it was merged.
Change subject: Vm: conf: proper locking in the creation path
..
Vm: conf: proper locking in the creation path
We are still getting the error
RuntimeError: dictionary
Dan Kenigsberg has submitted this change and it was merged.
Change subject: net: Libvirt hook that enables ovs-legacy migration
..
net: Libvirt hook that enables ovs-legacy migration
This hook allows VM/s to be migrated
gerrit-hooks has posted comments on this change.
Change subject: net: Libvirt hook that enables ovs-legacy migration
..
Patch Set 13:
* Update tracker: IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no Bug-Url found.
--
To
Dan Kenigsberg has posted comments on this change.
Change subject: net: Libvirt hook that enables ovs-legacy migration
..
Patch Set 12: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/55497
To unsubscribe, visit
gerrit-hooks has posted comments on this change.
Change subject: hooks:checkips: add checkips hook
..
Patch Set 2:
* update_tracker: OK
--
To view, visit https://gerrit.ovirt.org/55697
To unsubscribe, visit
Artyom Lukianov has abandoned this change.
Change subject: hooks:checkips: add checkips hook
..
Abandoned
--
To view, visit https://gerrit.ovirt.org/55697
To unsubscribe, visit https://gerrit.ovirt.org/settings
gerrit-hooks has posted comments on this change.
Change subject: storage: Move mount module to vdsm storage lib.
..
Patch Set 16:
* Update tracker: IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no Bug-Url found.
--
To
Dan Kenigsberg has submitted this change and it was merged.
Change subject: storage: Move mount module to vdsm storage lib.
..
storage: Move mount module to vdsm storage lib.
Move storage.mount to vdsm.storage.mount
Artyom Lukianov has uploaded a new change for review.
Change subject: hooks:checkips: add checkips hook
..
hooks:checkips: add checkips hook
Give possibilty to check connectivity between host and given addresses.
Update network
gerrit-hooks has posted comments on this change.
Change subject: hooks:checkips: add checkips hook
..
Patch Set 1: Verified-1
* update_tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#994170::ERROR, private bug
* Check
Francesco Romani has posted comments on this change.
Change subject: kvmstream: tool for streaming images from libvirt
..
Patch Set 1:
(1 comment)
https://gerrit.ovirt.org/#/c/55797/1//COMMIT_MSG
Commit Message:
PS1, Line 9:
Francesco Romani has posted comments on this change.
Change subject: kvmstream: tool for streaming images from libvirt
..
Patch Set 1:
(5 comments)
initial review.
The idea is neat and the logic seems fine, only comments
Francesco Romani has posted comments on this change.
Change subject: Vm: conf: proper locking in the creation path
..
Patch Set 4: Verified+1
verified running a few times a handful of VMs while performing
`watch -n 1 vdsClient
Martin Mucha has abandoned this change.
Change subject: marking test as broken
..
Abandoned
after updating to most recent master, build succeeds.
--
To view, visit https://gerrit.ovirt.org/55523
To unsubscribe, visit
gerrit-hooks has posted comments on this change.
Change subject: marking test as broken
..
Patch Set 1:
* Update tracker: IGNORE, no Bug-Url found
--
To view, visit https://gerrit.ovirt.org/55523
To unsubscribe, visit
Maor Lipchuk has posted comments on this change.
Change subject: storage: Move mount module to vdsm storage lib.
..
Patch Set 15: Verified+1
--
To view, visit https://gerrit.ovirt.org/55292
To unsubscribe, visit
gerrit-hooks has posted comments on this change.
Change subject: fileUtils: tarCopy - avoid extracting the file modified time
..
Patch Set 8:
* Update tracker: IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no Bug-Url found.
Dan Kenigsberg has submitted this change and it was merged.
Change subject: fileUtils: tarCopy - avoid extracting the file modified time
..
fileUtils: tarCopy - avoid extracting the file modified time
We using
gerrit-hooks has posted comments on this change.
Change subject: fileUtils: tarCopy - avoid extracting the file modified time
..
Patch Set 7:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found,
gerrit-hooks has posted comments on this change.
Change subject: kvmstream: tool for streaming images from libvirt
..
Patch Set 1:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure
Shahar Havivi has uploaded a new change for review.
Change subject: kvmstream: tool for streaming images from libvirt
..
kvmstream: tool for streaming images from libvirt
v2v is needed to a streaming/download tool for importing
gerrit-hooks has posted comments on this change.
Change subject: vm: conf: proper locking in status()
..
Patch Set 4:
* #1318550::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1318550::OK, public bug
* Check
gerrit-hooks has posted comments on this change.
Change subject: vm: conf: proper locking in onConnect()
..
Patch Set 4:
* #1318550::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1318550::OK, public bug
* Check
gerrit-hooks has posted comments on this change.
Change subject: vm: conf: proper locking in setNumberOfCpus()
..
Patch Set 4:
* #1318550::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1318550::OK, public bug
*
gerrit-hooks has posted comments on this change.
Change subject: Vm: conf: proper locking in the creation path
..
Patch Set 4:
* #1318550::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1318550::OK, public bug
*
gerrit-hooks has posted comments on this change.
Change subject: vm: conf: proper locking in onDisconnect()
..
Patch Set 4:
* #1318550::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1318550::OK, public bug
*
Nir Soffer has posted comments on this change.
Change subject: hsm: add untrusted image verification.
..
Patch Set 4:
(2 comments)
https://gerrit.ovirt.org/#/c/55746/4/vdsm/storage/hsm.py
File vdsm/storage/hsm.py:
Line 1505:
Nir Soffer has posted comments on this change.
Change subject: hsm: add untrusted image verification.
..
Patch Set 2:
(1 comment)
https://gerrit.ovirt.org/#/c/55746/2/vdsm/storage/hsm.py
File vdsm/storage/hsm.py:
Line 1562:
Jenkins CI has posted comments on this change.
Change subject: qemuimg: remove workaround for qemu-img --help rc
..
Patch Set 2: Continuous-Integration+1
Propagate review hook: Continuous Integration value inherited from patch
Francesco Romani has posted comments on this change.
Change subject: hostdev: add support for hotunplug
..
Patch Set 13: Verified-1
temporarily mark V-1 -> which is a lie, to avoid premature merge
--
To view, visit
Francesco Romani has posted comments on this change.
Change subject: hostdev: add support for hotunplug
..
Patch Set 13: Code-Review+1
(2 comments)
few questions inside, but looks good enough. Deeper review later.
Allon Mureinik has posted comments on this change.
Change subject: qemuimg: remove workaround for qemu-img --help rc
..
Patch Set 2: Verified+1
--
To view, visit https://gerrit.ovirt.org/55795
To unsubscribe, visit
Allon Mureinik has posted comments on this change.
Change subject: qemuimg: Remove EL6 comment
..
Patch Set 1: Verified+1
--
To view, visit https://gerrit.ovirt.org/55794
To unsubscribe, visit
gerrit-hooks has posted comments on this change.
Change subject: qemuimg: remove workaround for qemu-img --help rc
..
Patch Set 2:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure
gerrit-hooks has posted comments on this change.
Change subject: qemuimg: Remove EL6 comment
..
Patch Set 1:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches
Allon Mureinik has uploaded a new change for review.
Change subject: qemuimg: Remove EL6 comment
..
qemuimg: Remove EL6 comment
EL6 is no longer supported, no need to document where its qemu-img
binary is installed.
Change-Id:
Allon Mureinik has uploaded a new change for review.
Change subject: qemu-img: remove workaround for qemu-img --help rc
..
qemu-img: remove workaround for qemu-img --help rc
qemu-img --help should return 0 in any supported
gerrit-hooks has posted comments on this change.
Change subject: qemu-img: remove workaround for qemu-img --help rc
..
Patch Set 1:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure
Francesco Romani has posted comments on this change.
Change subject: migrations: change migration parameters
..
Patch Set 2: Code-Review+1
temporarily lowering score until 3.6.5 is out
--
To view, visit
Edward Haas has posted comments on this change.
Change subject: tests: Run unit tests using travis-ci and docker
..
Patch Set 8:
(1 comment)
https://gerrit.ovirt.org/#/c/54856/8/contrib/Dockerfile
File contrib/Dockerfile:
Francesco Romani has posted comments on this change.
Change subject: migrations: change migration parameters
..
Patch Set 2: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/55786
To unsubscribe, visit
Liron Aravot has posted comments on this change.
Change subject: fileUtils: tarCopy - avoid extracting the file modified time
..
Patch Set 6: Verified+1
--
To view, visit https://gerrit.ovirt.org/55163
To unsubscribe, visit
Liron Aravot has posted comments on this change.
Change subject: hsm: add untrusted image verification.
..
Patch Set 4:
(2 comments)
https://gerrit.ovirt.org/#/c/55746/4/vdsm/storage/hsm.py
File vdsm/storage/hsm.py:
Line
Piotr Kliczewski has posted comments on this change.
Change subject: migration: Enable lazy setting of incoming/outgoing limits
..
Patch Set 21:
(1 comment)
https://gerrit.ovirt.org/#/c/53305/21/vdsm/API.py
File vdsm/API.py:
Francesco Romani has posted comments on this change.
Change subject: hostdev: add vdsClient hotunplug command
..
Patch Set 11: Code-Review+1
looks fine, but not my domain -> "only" +1
--
To view, visit
Francesco Romani has posted comments on this change.
Change subject: hostdev: expose parameters needed to support hotunplug
..
Patch Set 11:
and tests (either new or document where is already exercised) are a nice plus :)
--
gerrit-hooks has posted comments on this change.
Change subject: fileUtils: tarCopy - avoid extracting the file modified time
..
Patch Set 6:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found,
Francesco Romani has posted comments on this change.
Change subject: hostdev: expose parameters needed to support hotunplug
..
Patch Set 11: Code-Review+1
(1 comment)
fine, but too hard to read, hence partial ACK.
please make
Francesco Romani has posted comments on this change.
Change subject: hostdev: expose hotplug via vdsClient
..
Patch Set 11: Code-Review-1
(1 comment)
I'm ok with everything, but the parsing function looks scary, and I'm
Martin Polednik has posted comments on this change.
Change subject: hostdev: add vdsClient hotunplug command
..
Patch Set 11: Verified+1
Tested at real vm with GPU passthrough.
--
To view, visit
Martin Polednik has posted comments on this change.
Change subject: hostdev: add support for hotunplug
..
Patch Set 13: Verified+1
--
To view, visit https://gerrit.ovirt.org/42747
To unsubscribe, visit
Martin Polednik has posted comments on this change.
Change subject: hostdev: expose parameters needed to support hotunplug
..
Patch Set 11: Verified+1
Tested at real vm with GPU passthrough.
--
To view, visit
Martin Polednik has posted comments on this change.
Change subject: hostdev: add support for hotunplug
..
Patch Set 13:
Tested at real vm with GPU passthrough.
--
To view, visit https://gerrit.ovirt.org/42747
To unsubscribe,
Edward Haas has posted comments on this change.
Change subject: travis: Add missing packages to Dockerfile
..
Patch Set 2: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/55738
To unsubscribe, visit
Jenkins CI has posted comments on this change.
Change subject: hsm: add untrusted image verification.
..
Patch Set 4: Continuous-Integration+1
Propagate review hook: Continuous Integration value inherited from patch 3
--
To
gerrit-hooks has posted comments on this change.
Change subject: spec: bump libguestfs-tools-c requirement again
..
Patch Set 4:
* #1292096::Update tracker: OK
* Set MODIFIED::bug 1292096#1292096OK
--
To view, visit
gerrit-hooks has posted comments on this change.
Change subject: spec: bump libguestfs-tools-c requirement again
..
Patch Set 2:
* #1292096::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1292096::OK, public bug
*
Francesco Romani has submitted this change and it was merged.
Change subject: spec: bump libguestfs-tools-c requirement again
..
spec: bump libguestfs-tools-c requirement again
I misread the virt-v2v changelog, and bumped the
gerrit-hooks has posted comments on this change.
Change subject: hostdev: add vdsClient hotunplug command
..
Patch Set 11:
* #1234283::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1234283::OK, public bug
* Check
Francesco Romani has posted comments on this change.
Change subject: spec: bump libguestfs-tools-c requirement again
..
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/55749
To unsubscribe, visit
Francesco Romani has submitted this change and it was merged.
Change subject: spec: bump libguestfs-tools-c requirement
..
spec: bump libguestfs-tools-c requirement
Consume fix to handle imports from vmware.
Change-Id:
gerrit-hooks has posted comments on this change.
Change subject: spec: bump libguestfs-tools-c requirement
..
Patch Set 4:
* #1292096::Update tracker: OK
* Set MODIFIED::bug 1292096#1292096IGNORE, not all related
Tomas Jelinek has posted comments on this change.
Change subject: spec: bump libguestfs-tools-c requirement again
..
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/55749
To unsubscribe, visit
gerrit-hooks has posted comments on this change.
Change subject: hsm: add untrusted image verification.
..
Patch Set 4:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
gerrit-hooks has posted comments on this change.
Change subject: hsm: add uploaded image verification
..
Patch Set 3:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches
gerrit-hooks has posted comments on this change.
Change subject: hostdev: expose hotplug via vdsClient
..
Patch Set 11:
* #1234283::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1234283::OK, public bug
* Check
gerrit-hooks has posted comments on this change.
Change subject: hostdev: expose parameters needed to support hotunplug
..
Patch Set 11:
* #1234283::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1234283::OK,
gerrit-hooks has posted comments on this change.
Change subject: hostdev: add support for hotunplug
..
Patch Set 13:
* #1234283::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1234283::OK, public bug
* Check
Edward Haas has posted comments on this change.
Change subject: net: Libvirt hook that enables ovs-legacy migration
..
Patch Set 12: Verified+1
Unit Tests pass and manually verified by migrating a VM from Engine (between
ovs
Amit Aviram has posted comments on this change.
Change subject: hsm: add uploaded image verification
..
Patch Set 2:
(9 comments)
https://gerrit.ovirt.org/#/c/55746/2/lib/api/vdsmapi-schema.json
File
Edward Haas has posted comments on this change.
Change subject: net: Libvirt hook that enables ovs-legacy migration
..
Patch Set 11:
(11 comments)
https://gerrit.ovirt.org/#/c/55497/11/tests/network/hook_ovs_test.py
File
gerrit-hooks has posted comments on this change.
Change subject: net: Libvirt hook that enables ovs-legacy migration
..
Patch Set 12:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make
Jenkins CI has posted comments on this change.
Change subject: migrations: change migration parameters
..
Patch Set 2: Continuous-Integration+1
Propagate review hook: Continuous Integration value inherited from patch 1
--
To
gerrit-hooks has posted comments on this change.
Change subject: migrations: change migration parameters
..
Patch Set 2:
* #1323952::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1323952::OK, public bug
* Check
Tomas Jelinek has posted comments on this change.
Change subject: migrations: change migration parameters
..
Patch Set 1: Verified+1
--
To view, visit https://gerrit.ovirt.org/55786
To unsubscribe, visit
Vinzenz Feenstra has posted comments on this change.
Change subject: migrations: change migration parameters
..
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/55786
To unsubscribe, visit
101 - 195 of 195 matches
Mail list logo