Change in vdsm[master]: ifcfg: write current DNS information to a management network...

2016-07-27 Thread edwardh
Edward Haas has posted comments on this change. Change subject: ifcfg: write current DNS information to a management network's ifcfg file .. Patch Set 5: Code-Review-1 (2 comments) Thank you for the patch, it looks good. We

Change in vdsm[master]: EXPERIMENT: move static files to their subfolder

2016-07-27 Thread fromani
Francesco Romani has posted comments on this change. Change subject: EXPERIMENT: move static files to their subfolder .. Patch Set 2: (1 comment) at first glance Makefile looks ok, but the logger configuration seems outdated

Change in vdsm[master]: modprobe: set bonding max_bonds to 0

2016-07-27 Thread fabiand
Fabian Deutsch has posted comments on this change. Change subject: modprobe: set bonding max_bonds to 0 .. Patch Set 4: … I tried it on NGN based on centos7 -- To view, visit https://gerrit.ovirt.org/61396 To unsubscribe, vis

Change in vdsm[master]: modprobe: set bonding max_bonds to 0

2016-07-27 Thread fabiand
Fabian Deutsch has posted comments on this change. Change subject: modprobe: set bonding max_bonds to 0 .. Patch Set 4: Verified+1 I just tested this on NGN using: 1. Boot NGN regularly 2. bond0 exists 3. Create /etc/modprobe.

Change in vdsm[master]: storage: Introduce guarded utilities

2016-07-27 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: storage: Introduce guarded utilities .. Patch Set 2: (10 comments) https://gerrit.ovirt.org/#/c/61435/2//COMMIT_MSG Commit Message: Line 23: Line 24: The followi

Change in vdsm[master]: storage: Sortable ResourceManager lock namespaces

2016-07-27 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: storage: Sortable ResourceManager lock namespaces .. Patch Set 2: (1 comment) https://gerrit.ovirt.org/#/c/61436/2/lib/vdsm/storage/constants.py File lib/vdsm/stor

Change in vdsm[master]: storage: Move IMAGE_NAMESPACE and VOLUME_NAMESPACE to consta...

2016-07-27 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: storage: Move IMAGE_NAMESPACE and VOLUME_NAMESPACE to constants.py .. Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/61434 To unsubscribe,

Change in vdsm[master]: storage: Move IMAGE_NAMESPACE and VOLUME_NAMESPACE to consta...

2016-07-27 Thread automation
gerrit-hooks has posted comments on this change. Change subject: storage: Move IMAGE_NAMESPACE and VOLUME_NAMESPACE to constants.py .. Patch Set 2: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url f

Change in vdsm[master]: storage: Introduce guarded utilities

2016-07-27 Thread automation
gerrit-hooks has posted comments on this change. Change subject: storage: Introduce guarded utilities .. Patch Set 2: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches

Change in vdsm[master]: storage: Sortable ResourceManager lock namespaces

2016-07-27 Thread automation
gerrit-hooks has posted comments on this change. Change subject: storage: Sortable ResourceManager lock namespaces .. Patch Set 2: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure he

Change in vdsm[ovirt-4.0]: mount: Support NFS4 mounts with double slash

2016-07-27 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: mount: Support NFS4 mounts with double slash .. Patch Set 1: Code-Review-1 More work needed to make normalize_path work with mounts like "proc". -- To view, visit

Change in vdsm[master]: mount: Support NFS4 mounts with double slash

2016-07-27 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: mount: Support NFS4 mounts with double slash .. Patch Set 1: Code-Review-1 normalize_path cannot handle "proc" or other special mounts. We need more work to make i

Change in vdsm[master]: storage: Introduce guarded utilities

2016-07-27 Thread alitke
Adam Litke has posted comments on this change. Change subject: storage: Introduce guarded utilities .. Patch Set 1: (1 comment) https://gerrit.ovirt.org/#/c/61435/1/lib/vdsm/storage/guarded.py File lib/vdsm/storage/guarded.py:

Change in vdsm[ovirt-4.0]: mount: Support NFS4 mounts with double slash

2016-07-27 Thread nsoffer
Nir Soffer has uploaded a new change for review. Change subject: mount: Support NFS4 mounts with double slash .. mount: Support NFS4 mounts with double slash With NFS4, the kernel may present fs_spec using double slashes [1]:

Change in vdsm[ovirt-4.0]: mount: Support NFS4 mounts with double slash

2016-07-27 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: mount: Support NFS4 mounts with double slash .. Patch Set 1: Francesco, this a backport for testing by the user reporting this issue. We will open a bug later. --

Change in vdsm[ovirt-4.0]: mount: Support NFS4 mounts with double slash

2016-07-27 Thread automation
gerrit-hooks has posted comments on this change. Change subject: mount: Support NFS4 mounts with double slash .. Patch Set 1: Verified-1 * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::ERROR, At least one bug-url i

Change in vdsm[ovirt-4.0]: fileUtils: Normalize initial double slashes

2016-07-27 Thread automation
gerrit-hooks has posted comments on this change. Change subject: fileUtils: Normalize initial double slashes .. Patch Set 1: Verified-1 * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::ERROR, At least one bug-url is

Change in vdsm[ovirt-4.0]: fileUtils: Normalize initial double slashes

2016-07-27 Thread nsoffer
Nir Soffer has uploaded a new change for review. Change subject: fileUtils: Normalize initial double slashes .. fileUtils: Normalize initial double slashes POSIX allows both /path and //path. The second slash may be interpreted

Change in vdsm[master]: fileUtils: Normalize initial double slashes

2016-07-27 Thread automation
gerrit-hooks has posted comments on this change. Change subject: fileUtils: Normalize initial double slashes .. Patch Set 1: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header m

Change in vdsm[master]: mount: Support NFS4 mounts with double slash

2016-07-27 Thread automation
gerrit-hooks has posted comments on this change. Change subject: mount: Support NFS4 mounts with double slash .. Patch Set 1: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header

Change in vdsm[master]: mount: Support NFS4 mounts with double slash

2016-07-27 Thread nsoffer
Nir Soffer has uploaded a new change for review. Change subject: mount: Support NFS4 mounts with double slash .. mount: Support NFS4 mounts with double slash With NFS4, the kernel may present fs_spec using double slashes [1]:

Change in vdsm[master]: fileUtils: Normalize initial double slashes

2016-07-27 Thread nsoffer
Nir Soffer has uploaded a new change for review. Change subject: fileUtils: Normalize initial double slashes .. fileUtils: Normalize initial double slashes POSIX allows both /path and //path. The second slash may be interpreted

Change in vdsm[master]: net: netinfo.dhcp - dhcp info update refactoring

2016-07-27 Thread phoracek
Petr Horáček has posted comments on this change. Change subject: net: netinfo.dhcp - dhcp info update refactoring .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/61457 To unsubscribe, visit https://ger

Change in vdsm[master]: net: dhcp reporting based on dhclient daemon state

2016-07-27 Thread phoracek
Petr Horáček has posted comments on this change. Change subject: net: dhcp reporting based on dhclient daemon state .. Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/61458 To unsubscribe, visit https://g

Change in vdsm[master]: clusterlock: Support for multiple leases

2016-07-27 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: clusterlock: Support for multiple leases .. Patch Set 7: Same with block storage: jsonrpc.Executor/6::INFO::2016-07-27 19:22:49,639::clusterlock::246::Storage.SAN

Change in vdsm[master]: net: netinfo.dhcp - dhcp info update refactoring

2016-07-27 Thread edwardh
Edward Haas has posted comments on this change. Change subject: net: netinfo.dhcp - dhcp info update refactoring .. Patch Set 1: (1 comment) https://gerrit.ovirt.org/#/c/61457/1/lib/vdsm/network/netinfo/dhcp.py File lib/vdsm/n

Change in vdsm[master]: net: dhcp reporting based on dhclient daemon state

2016-07-27 Thread edwardh
Edward Haas has posted comments on this change. Change subject: net: dhcp reporting based on dhclient daemon state .. Patch Set 2: (1 comment) https://gerrit.ovirt.org/#/c/61458/1//COMMIT_MSG Commit Message: PS1, Line 19: exi

Change in vdsm[master]: net: dhcp reporting based on dhclient daemon state

2016-07-27 Thread automation
gerrit-hooks has posted comments on this change. Change subject: net: dhcp reporting based on dhclient daemon state .. Patch Set 2: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure h

Change in vdsm[master]: clusterlock: Support for multiple leases

2016-07-27 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: clusterlock: Support for multiple leases .. Patch Set 7: Log using this patch: Starting spm: 7b810c6a-b74d-456f-b01d-dcc0343524f1::INFO::2016-07-27 19:13:19,343:

Change in vdsm[master]: ifcfg: write current DNS information to a management network...

2016-07-27 Thread phoracek
Petr Horáček has posted comments on this change. Change subject: ifcfg: write current DNS information to a management network's ifcfg file .. Patch Set 5: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/61184 To unsu

Change in vdsm[master]: net: Silently skip persisting a non-existent running-config

2016-07-27 Thread phoracek
Petr Horáček has posted comments on this change. Change subject: net: Silently skip persisting a non-existent running-config .. Patch Set 4: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/60744 To unsubscribe, visit

Change in vdsm[master]: net: dhcp reporting based on dhclient daemon state

2016-07-27 Thread phoracek
Petr Horáček has posted comments on this change. Change subject: net: dhcp reporting based on dhclient daemon state .. Patch Set 1: Code-Review-1 (1 comment) Just a nit, great work! https://gerrit.ovirt.org/#/c/61458/1//COMMI

Change in vdsm[master]: net: netinfo.dhcp - dhcp info update refactoring

2016-07-27 Thread phoracek
Petr Horáček has posted comments on this change. Change subject: net: netinfo.dhcp - dhcp info update refactoring .. Patch Set 1: Code-Review-1 (1 comment) https://gerrit.ovirt.org/#/c/61457/1/lib/vdsm/network/netinfo/dhcp.py

Change in vdsm[master]: virt: sampling: add is_empty() method to StatsSample

2016-07-27 Thread Jenkins CI
Jenkins CI has posted comments on this change. Change subject: virt: sampling: add is_empty() method to StatsSample .. Patch Set 6: Continuous-Integration+1 Propagate review hook: Continuous Integration value inherited from pat

Change in vdsm[master]: net test: Replacing MonkeyPatch with mock.patch for netinfo_...

2016-07-27 Thread phoracek
Petr Horáček has posted comments on this change. Change subject: net test: Replacing MonkeyPatch with mock.patch for netinfo_test .. Patch Set 3: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/61269 To unsubscribe, v

Change in vdsm[master]: net: Silently skip persisting a non-existent running-config

2016-07-27 Thread automation
gerrit-hooks has posted comments on this change. Change subject: net: Silently skip persisting a non-existent running-config .. Patch Set 4: * #1329387::Update tracker: OK * Check Bug-Url::OK * Check Public Bug::#1329387::OK, p

Change in vdsm[master]: net: Silently skip persisting a non-existent running-config

2016-07-27 Thread edwardh
Edward Haas has posted comments on this change. Change subject: net: Silently skip persisting a non-existent running-config .. Patch Set 3: (1 comment) https://gerrit.ovirt.org/#/c/60744/3//COMMIT_MSG Commit Message: PS3, Lin

Change in vdsm[master]: net test: Cleanup _fakeTypeDetection

2016-07-27 Thread phoracek
Petr Horáček has posted comments on this change. Change subject: net test: Cleanup _fakeTypeDetection .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/61362 To unsubscribe, visit https://gerrit.ovirt.or

Change in vdsm[master]: net: Silently skip persisting a non existance running-config

2016-07-27 Thread phoracek
Petr Horáček has posted comments on this change. Change subject: net: Silently skip persisting a non existance running-config .. Patch Set 3: Code-Review-1 (1 comment) Just a nit. https://gerrit.ovirt.org/#/c/60744/3//COMMIT_

Change in vdsm[master]: vm: periodic: fix stats age reporting

2016-07-27 Thread automation
gerrit-hooks has posted comments on this change. Change subject: vm: periodic: fix stats age reporting .. Patch Set 11: * #1357798::Update tracker: OK * Check Bug-Url::OK * Check Public Bug::#1357798::OK, public bug * Check Pro

Change in vdsm[master]: sampling: micro-optimization

2016-07-27 Thread automation
gerrit-hooks has posted comments on this change. Change subject: sampling: micro-optimization .. Patch Set 12: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Ur

Change in vdsm[master]: virt: sampling: add is_empty() method to StatsSample

2016-07-27 Thread automation
gerrit-hooks has posted comments on this change. Change subject: virt: sampling: add is_empty() method to StatsSample .. Patch Set 6: * #1357798::Update tracker: OK * Check Bug-Url::OK * Check Public Bug::#1357798::OK, public b

Change in vdsm[master]: net: introduce acquire module

2016-07-27 Thread automation
gerrit-hooks has posted comments on this change. Change subject: net: introduce acquire module .. Patch Set 10: * #1195208::Update tracker: OK * Check Bug-Url::OK * Check Public Bug::#1195208::OK, public bug * Check Product::#1

Change in vdsm[master]: net: introduce acquire module

2016-07-27 Thread automation
gerrit-hooks has posted comments on this change. Change subject: net: introduce acquire module .. Patch Set 9: * #1195208::Update tracker: OK * Check Bug-Url::OK * Check Public Bug::#1195208::OK, public bug * Check Product::#11

Change in vdsm[master]: spec: Require sanlock version handling EINTR

2016-07-27 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: spec: Require sanlock version handling EINTR .. Patch Set 6: (1 comment) https://gerrit.ovirt.org/#/c/61200/6//COMMIT_MSG Commit Message: Line 6: Line 7: spec: R

Change in vdsm[master]: spec: Require sanlock version handling EINTR

2016-07-27 Thread automation
gerrit-hooks has posted comments on this change. Change subject: spec: Require sanlock version handling EINTR .. Patch Set 7: * #1356676::Update tracker: OK * Check Bug-Url::OK * Check Public Bug::#1356676::OK, public bug * Che

Change in vdsm[master]: spec: Require sanlock version handling EINTR

2016-07-27 Thread amureini
Allon Mureinik has posted comments on this change. Change subject: spec: Require sanlock version handling EINTR .. Patch Set 6: Code-Review+1 (1 comment) Huh! The CI failure, oddly enough, proves that the patch is correct :-)

Change in vdsm[master]: sampling: micro-optimization

2016-07-27 Thread automation
gerrit-hooks has posted comments on this change. Change subject: sampling: micro-optimization .. Patch Set 11: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Ur

Change in vdsm[master]: vm: periodic: fix stats age reporting

2016-07-27 Thread automation
gerrit-hooks has posted comments on this change. Change subject: vm: periodic: fix stats age reporting .. Patch Set 10: * #1357798::Update tracker: OK * Check Bug-Url::OK * Check Public Bug::#1357798::OK, public bug * Check Pro

Change in vdsm[master]: virt: sampling: add empty() method to StatsSample

2016-07-27 Thread automation
gerrit-hooks has posted comments on this change. Change subject: virt: sampling: add empty() method to StatsSample .. Patch Set 5: * #1357798::Update tracker: OK * Check Bug-Url::OK * Check Public Bug::#1357798::OK, public bug

Change in vdsm[master]: virt: Make DomainDescriptor use XML helpers

2016-07-27 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: virt: Make DomainDescriptor use XML helpers .. Patch Set 8: (1 comment) https://gerrit.ovirt.org/#/c/55769/8/vdsm/virt/vmxml.py File vdsm/virt/vmxml.py: Line 78:

Change in vdsm[master]: virt: Make DomainDescriptor use XML helpers

2016-07-27 Thread mzamazal
Milan Zamazal has posted comments on this change. Change subject: virt: Make DomainDescriptor use XML helpers .. Patch Set 8: (1 comment) https://gerrit.ovirt.org/#/c/55769/8/vdsm/virt/vmxml.py File vdsm/virt/vmxml.py: Line 7

Change in vdsm[master]: virt: sampling: add empty() method to StatsSample

2016-07-27 Thread fromani
Francesco Romani has posted comments on this change. Change subject: virt: sampling: add empty() method to StatsSample .. Patch Set 4: (1 comment) https://gerrit.ovirt.org/#/c/61420/4/lib/vdsm/virt/sampling.py File lib/vdsm/vi

Change in vdsm[master]: spec: Require sanlock version handling EINTR

2016-07-27 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: spec: Require sanlock version handling EINTR .. Patch Set 6: The packages are not released yet, CI failure is correct. -- To view, visit https://gerrit.ovirt.org/

Change in vdsm[master]: virt: sampling: add empty() method to StatsSample

2016-07-27 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: virt: sampling: add empty() method to StatsSample .. Patch Set 4: (1 comment) https://gerrit.ovirt.org/#/c/61420/4/lib/vdsm/virt/sampling.py File lib/vdsm/virt

Change in vdsm[master]: virt: Make DomainDescriptor use XML helpers

2016-07-27 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: virt: Make DomainDescriptor use XML helpers .. Patch Set 8: (1 comment) https://gerrit.ovirt.org/#/c/55769/8/vdsm/virt/vmxml.py File vdsm/virt/vmxml.py: Line 78:

Change in vdsm[master]: storage: Move IMAGE_NAMESPACE and VOLUME_NAMESPACE to consta...

2016-07-27 Thread alitke
Adam Litke has posted comments on this change. Change subject: storage: Move IMAGE_NAMESPACE and VOLUME_NAMESPACE to constants.py .. Patch Set 1: (1 comment) https://gerrit.ovirt.org/#/c/61434/1//COMMIT_MSG Commit Message: L

Change in vdsm[master]: EXPERIMENT: move static files to their subfolder

2016-07-27 Thread automation
gerrit-hooks has posted comments on this change. Change subject: EXPERIMENT: move static files to their subfolder .. Patch Set 2: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure hea

Change in vdsm[master]: virt: Make DomainDescriptor use XML helpers

2016-07-27 Thread mzamazal
Milan Zamazal has posted comments on this change. Change subject: virt: Make DomainDescriptor use XML helpers .. Patch Set 8: (1 comment) https://gerrit.ovirt.org/#/c/55769/8/vdsm/virt/vmxml.py File vdsm/virt/vmxml.py: Line 7

Change in vdsm[master]: virt: Make DomainDescriptor use XML helpers

2016-07-27 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: virt: Make DomainDescriptor use XML helpers .. Patch Set 8: (2 comments) https://gerrit.ovirt.org/#/c/55769/8/vdsm/virt/vmxml.py File vdsm/virt/vmxml.py: Line 78:

Change in vdsm[master]: virt net: Interface default driver name set to 'vhost'

2016-07-27 Thread automation
gerrit-hooks has posted comments on this change. Change subject: virt net: Interface default driver name set to 'vhost' .. Patch Set 4: * #1359520::Update tracker: OK * Set MODIFIED::bug 1359520#1359520FAILED, illegal c

Change in vdsm[master]: virt net: Interface default driver name set to 'vhost'

2016-07-27 Thread danken
Dan Kenigsberg has submitted this change and it was merged. Change subject: virt net: Interface default driver name set to 'vhost' .. virt net: Interface default driver name set to 'vhost' When following these steps: - Create a

Change in vdsm[master]: virt: Make DomainDescriptor use XML helpers

2016-07-27 Thread mzamazal
Milan Zamazal has posted comments on this change. Change subject: virt: Make DomainDescriptor use XML helpers .. Patch Set 8: (2 comments) https://gerrit.ovirt.org/#/c/55769/8//COMMIT_MSG Commit Message: Line 33: DomainDescri

Change in vdsm[master]: virt net: Interface default driver name set to 'vhost'

2016-07-27 Thread phoracek
Petr Horáček has posted comments on this change. Change subject: virt net: Interface default driver name set to 'vhost' .. Patch Set 3: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/61297 To unsubscribe, visit https

Change in vdsm[master]: virt net: Interface default driver name set to 'vhost'

2016-07-27 Thread automation
gerrit-hooks has posted comments on this change. Change subject: virt net: Interface default driver name set to 'vhost' .. Patch Set 3: * #1359520::Update tracker: OK * Check Bug-Url::OK * Check Public Bug::#1359520::OK, public

Change in vdsm[master]: modprobe: set bonding max_bonds to 0

2016-07-27 Thread fabiand
Fabian Deutsch has posted comments on this change. Change subject: modprobe: set bonding max_bonds to 0 .. Patch Set 4: Code-Review+1 I think there is a good chance that this will work (at least on node). On node we are rebuil

Change in vdsm[master]: virt net: Interface default driver name set to 'vhost'

2016-07-27 Thread automation
gerrit-hooks has posted comments on this change. Change subject: virt net: Interface default driver name set to 'vhost' .. Patch Set 2: * #1359520::Update tracker: OK * Check Bug-Url::OK * Check Public Bug::#1359520::OK, public

Change in vdsm[master]: virt net: Interface default driver name set to 'vhost'

2016-07-27 Thread phoracek
Petr Horáček has posted comments on this change. Change subject: virt net: Interface default driver name set to 'vhost' .. Patch Set 1: -Code-Review -- To view, visit https://gerrit.ovirt.org/61297 To unsubscribe, visit https:

Change in vdsm[master]: modprobe: set bonding max_bonds to 0

2016-07-27 Thread mpolednik
Martin Polednik has posted comments on this change. Change subject: modprobe: set bonding max_bonds to 0 .. Patch Set 4: Code wise, I believe there isn't anything wrong. My approval would be based on assumption that network te

Change in vdsm[master]: virt net: Interface default driver name set to 'vhost'

2016-07-27 Thread phoracek
Petr Horáček has posted comments on this change. Change subject: virt net: Interface default driver name set to 'vhost' .. Patch Set 1: Code-Review-1 (1 comment) -1 just for attention https://gerrit.ovirt.org/#/c/61297/1//COM

Change in vdsm[master]: EXPERIMENT: move static files to their subfolder

2016-07-27 Thread automation
gerrit-hooks has posted comments on this change. Change subject: EXPERIMENT: move static files to their subfolder .. Patch Set 1: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure hea

Change in vdsm[master]: makefile: remove unused stuff

2016-07-27 Thread automation
gerrit-hooks has posted comments on this change. Change subject: makefile: remove unused stuff .. Patch Set 1: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Ur

Change in vdsm[master]: net: introduce acquire module

2016-07-27 Thread automation
gerrit-hooks has posted comments on this change. Change subject: net: introduce acquire module .. Patch Set 8: * #1195208::Update tracker: OK * Check Bug-Url::OK * Check Public Bug::#1195208::OK, public bug * Check Product::#11

Change in vdsm[master]: Revert "NetworkManager: configure to monitor ifcfg/connectio...

2016-07-27 Thread fabiand
Fabian Deutsch has posted comments on this change. Change subject: Revert "NetworkManager: configure to monitor ifcfg/connection files" .. Patch Set 6: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/59260 To unsubsc

Change in vdsm[master]: spec: Require sanlock version handling EINTR

2016-07-27 Thread automation
gerrit-hooks has posted comments on this change. Change subject: spec: Require sanlock version handling EINTR .. Patch Set 6: * #1356676::Update tracker: OK * Check Bug-Url::OK * Check Public Bug::#1356676::OK, public bug * Che

Change in vdsm[master]: docs: add README about logging configuration

2016-07-27 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: docs: add README about logging configuration .. Patch Set 6: (1 comment) https://gerrit.ovirt.org/#/c/60533/6/README.logging File README.logging: Line 23: Line 2

Change in vdsm[master]: spec: Require sanlock version handling EINTR

2016-07-27 Thread amureini
Allon Mureinik has posted comments on this change. Change subject: spec: Require sanlock version handling EINTR .. Patch Set 5: Code-Review-1 (1 comment) https://gerrit.ovirt.org/#/c/61200/5/vdsm.spec.in File vdsm.spec.in: PS

Change in vdsm[master]: net: introduce acquire module

2016-07-27 Thread automation
gerrit-hooks has posted comments on this change. Change subject: net: introduce acquire module .. Patch Set 7: * #1195208::Update tracker: OK * Check Bug-Url::OK * Check Public Bug::#1195208::OK, public bug * Check Product::#11

Change in vdsm[master]: virt net: Interface default driver name set to 'vhost'

2016-07-27 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: virt net: Interface default driver name set to 'vhost' .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/61297 To unsubscribe, visit htt

Change in vdsm[master]: storage: Introduce guarded utilities

2016-07-27 Thread alitke
Adam Litke has posted comments on this change. Change subject: storage: Introduce guarded utilities .. Patch Set 1: (7 comments) https://gerrit.ovirt.org/#/c/61435/1/lib/vdsm/storage/guarded.py File lib/vdsm/storage/guarded.py

Change in vdsm[master]: virt: sampling: add empty() method to StatsSample

2016-07-27 Thread mzamazal
Milan Zamazal has posted comments on this change. Change subject: virt: sampling: add empty() method to StatsSample .. Patch Set 4: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/61420 To unsubscribe, visit https://g

Change in vdsm[master]: vm: periodic: fix stats age reporting

2016-07-27 Thread automation
gerrit-hooks has posted comments on this change. Change subject: vm: periodic: fix stats age reporting .. Patch Set 9: * #1357798::Update tracker: OK * Check Bug-Url::OK * Check Public Bug::#1357798::OK, public bug * Check Prod

Change in vdsm[master]: sampling: micro-optimization

2016-07-27 Thread automation
gerrit-hooks has posted comments on this change. Change subject: sampling: micro-optimization .. Patch Set 10: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Ur

Change in vdsm[master]: virt: sampling: add empty() method to StatsSample

2016-07-27 Thread automation
gerrit-hooks has posted comments on this change. Change subject: virt: sampling: add empty() method to StatsSample .. Patch Set 4: * #1357798::Update tracker: OK * Check Bug-Url::OK * Check Public Bug::#1357798::OK, public bug

Change in vdsm[master]: supervdsmServer: using moduleloader for dynamic imports

2016-07-27 Thread ybronhei
Yaniv Bronhaim has posted comments on this change. Change subject: supervdsmServer: using moduleloader for dynamic imports .. Patch Set 1: (1 comment) https://gerrit.ovirt.org/#/c/61313/1/vdsm/supervdsmServer File vdsm/supervd

Change in vdsm[master]: virt: sampling: add empty() method to StatsSample

2016-07-27 Thread fromani
Francesco Romani has posted comments on this change. Change subject: virt: sampling: add empty() method to StatsSample .. Patch Set 3: (1 comment) https://gerrit.ovirt.org/#/c/61420/3//COMMIT_MSG Commit Message: Line 7: virt:

Change in vdsm[master]: virt: sampling: add empty() method to StatsSample

2016-07-27 Thread mzamazal
Milan Zamazal has posted comments on this change. Change subject: virt: sampling: add empty() method to StatsSample .. Patch Set 3: (1 comment) https://gerrit.ovirt.org/#/c/61420/3//COMMIT_MSG Commit Message: Line 7: virt: sa

Change in vdsm[master]: utils: atomic write

2016-07-27 Thread automation
gerrit-hooks has posted comments on this change. Change subject: utils: atomic write .. Patch Set 4: * #1195208::Update tracker: OK * Check Bug-Url::OK * Check Public Bug::#1195208::OK, public bug * Check Product::#1195208::OK,

Change in vdsm[master]: automation: fix check-merged.sh

2016-07-27 Thread automation
gerrit-hooks has posted comments on this change. Change subject: automation: fix check-merged.sh .. Patch Set 2: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-

Change in vdsm[master]: vm: periodic: fix stats age reporting

2016-07-27 Thread mzamazal
Milan Zamazal has posted comments on this change. Change subject: vm: periodic: fix stats age reporting .. Patch Set 8: > Commit message was updated. It's better now, thanks! -- To view, visit https://gerrit.ovirt.org/61310

Change in vdsm[master]: docs: add README about logging configuration

2016-07-27 Thread fromani
Francesco Romani has posted comments on this change. Change subject: docs: add README about logging configuration .. Patch Set 6: Verified+1 copied score (changing the content doesn't affect "verification" here) -- To view, v

Change in vdsm[master]: utils: atomic write

2016-07-27 Thread automation
gerrit-hooks has posted comments on this change. Change subject: utils: atomic write .. Patch Set 3: * #1195208::Update tracker: OK * Check Bug-Url::OK * Check Public Bug::#1195208::OK, public bug * Check Product::#1195208::OK,

Change in vdsm[master]: utils: atomic write

2016-07-27 Thread automation
gerrit-hooks has posted comments on this change. Change subject: utils: atomic write .. Patch Set 2: * #1195208::Update tracker: OK * Check Bug-Url::OK * Check Public Bug::#1195208::OK, public bug * Check Product::#1195208::OK,

Change in vdsm[master]: utils: atomic write

2016-07-27 Thread automation
gerrit-hooks has posted comments on this change. Change subject: utils: atomic write .. Patch Set 1: * #1195208::Update tracker: OK * Check Bug-Url::OK * Check Public Bug::#1195208::OK, public bug * Check Product::#1195208::OK,

Change in vdsm[master]: utils: atomic write

2016-07-27 Thread phoracek
Petr Horáček has uploaded a new change for review. Change subject: utils: atomic write .. utils: atomic write Atomic writes are needed for safe file editation. This function will be used in following network patch 'acquire exter

Change in vdsm[master]: Revert "configurator: libvirt: do not jump on virtlogd"

2016-07-27 Thread automation
gerrit-hooks has posted comments on this change. Change subject: Revert "configurator: libvirt: do not jump on virtlogd" .. Patch Set 1: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make s

Change in vdsm[master]: Revert "configurator: libvirt: do not jump on virtlogd"

2016-07-27 Thread fromani
Francesco Romani has uploaded a new change for review. Change subject: Revert "configurator: libvirt: do not jump on virtlogd" .. Revert "configurator: libvirt: do not jump on virtlogd" This reverts commit 0d9be09351814571655fab

Change in vdsm[master]: docs: add README about logging configuration

2016-07-27 Thread mzamazal
Milan Zamazal has posted comments on this change. Change subject: docs: add README about logging configuration .. Patch Set 6: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/60533 To unsubscribe, visit https://gerrit

Change in vdsm[master]: docs: add README about logging configuration

2016-07-27 Thread automation
gerrit-hooks has posted comments on this change. Change subject: docs: add README about logging configuration .. Patch Set 6: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header

Change in vdsm[master]: sampling: micro-optimization

2016-07-27 Thread automation
gerrit-hooks has posted comments on this change. Change subject: sampling: micro-optimization .. Patch Set 9: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url

  1   2   >