Change in vdsm[master]: net: Report the default gateway flag through caps

Ondřej Svoboda has posted comments on this change. Change subject: net: Report the default gateway flag through caps .. Patch Set 12: Code-Review+1 Thanks! -- To view, visit https://gerrit.ovirt.org/58351 To unsubscribe, visi

Change in vdsm[master]: Remove _udevrulesdir global macro

gerrit-hooks has posted comments on this change. Change subject: Remove _udevrulesdir global macro .. Patch Set 3: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bu

Change in vdsm[master]: Remove _udevrulesdir global macro

Idan Shaby has posted comments on this change. Change subject: Remove _udevrulesdir global macro .. Patch Set 3: Verified+1 -- To view, visit https://gerrit.ovirt.org/62196 To unsubscribe, visit https://gerrit.ovirt.org/settin

Change in vdsm[master]: net: Report the default gateway flag through caps

Edward Haas has posted comments on this change. Change subject: net: Report the default gateway flag through caps .. Patch Set 12: Verified+1 -- To view, visit https://gerrit.ovirt.org/58351 To unsubscribe, visit https://gerri

Change in vdsm[master]: net: Report the default gateway flag through caps

gerrit-hooks has posted comments on this change. Change subject: net: Report the default gateway flag through caps .. Patch Set 12: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure h

Change in vdsm[master]: net: Report the default gateway flag through caps

Edward Haas has posted comments on this change. Change subject: net: Report the default gateway flag through caps .. Patch Set 11: (1 comment) https://gerrit.ovirt.org/#/c/58351/11/tests/network/func_static_ip_test.py File tes

Change in vdsm[master]: net: Report the default gateway flag through caps

Ondřej Svoboda has posted comments on this change. Change subject: net: Report the default gateway flag through caps .. Patch Set 11: Code-Review-1 (1 comment) One nit/confusion. https://gerrit.ovirt.org/#/c/58351/11/tests/ne

Change in vdsm[master]: testlib: Use osutils.close_fd to avoid fd leaks

Nir Soffer has posted comments on this change. Change subject: testlib: Use osutils.close_fd to avoid fd leaks .. Patch Set 3: Verified+1 -- To view, visit https://gerrit.ovirt.org/61216 To unsubscribe, visit https://gerrit.ov

Change in vdsm[master]: osutils: Move NoIntrCall to osutils.uninterruptible

Nir Soffer has posted comments on this change. Change subject: osutils: Move NoIntrCall to osutils.uninterruptible .. Patch Set 5: Continuous-Integration+1 Verified+1 CI seems to be sick, tests pass locally. -- To view, visit

Change in vdsm[master]: testlib: Use osutils.close_fd to avoid fd leaks

Nir Soffer has posted comments on this change. Change subject: testlib: Use osutils.close_fd to avoid fd leaks .. Patch Set 3: Continuous-Integration+1 CI seems to be sick, tests pass locally. -- To view, visit https://gerrit

Change in vdsm[master]: sd: Support volume leases

Nir Soffer has posted comments on this change. Change subject: sd: Support volume leases .. Patch Set 9: Continuous-Integration+1 CI seems to be sick, tests pass locally. Cannot verify volume leases since we don't have any cod

Change in vdsm[master]: clusterlock: Support for multiple leases

Nir Soffer has posted comments on this change. Change subject: clusterlock: Support for multiple leases .. Patch Set 9: Continuous-Integration+1 Verified+1 CI seems to be sick, tests pass locally. -- To view, visit https://ge

Change in vdsm[master]: clusterlock: Fix LocalLock.supports_volume_leases

Nir Soffer has posted comments on this change. Change subject: clusterlock: Fix LocalLock.supports_volume_leases .. Patch Set 8: Continuous-Integration+1 CI seems to be sick, tests pass locally. -- To view, visit https://gerr

Change in vdsm[master]: clusterlock: Raise if lock is used improperly

Nir Soffer has posted comments on this change. Change subject: clusterlock: Raise if lock is used improperly .. Patch Set 8: Continuous-Integration+1 Verified+1 CI seems to be sick, tests pass locally. -- To view, visit https

Change in vdsm[master]: sd: Move getVolumeLease to StorageDomainManifest

Nir Soffer has posted comments on this change. Change subject: sd: Move getVolumeLease to StorageDomainManifest .. Patch Set 9: Continuous-Integration+1 Verified+1 CI seems to be sick, tests pass locally. -- To view, visit ht

Change in vdsm[master]: sd: Unify getVolumeLease signature

Nir Soffer has posted comments on this change. Change subject: sd: Unify getVolumeLease signature .. Patch Set 9: Continuous-Integration+1 CI seems to be sick, tests pass locally. -- To view, visit https://gerrit.ovirt.org/60

Change in vdsm[master]: clusterlock: Fix double close on EINTR

Nir Soffer has posted comments on this change. Change subject: clusterlock: Fix double close on EINTR .. Patch Set 7: Continuous-Integration+1 CI seems to be sick, tests pass locally. -- To view, visit https://gerrit.ovirt.or

Change in vdsm[master]: osutils: Start the osutils module

Nir Soffer has posted comments on this change. Change subject: osutils: Start the osutils module .. Patch Set 6: -Code-Review Continuous-Integration+1 -- To view, visit https://gerrit.ovirt.org/61142 To unsubscribe, visit http

Change in vdsm[master]: osutils: Start the osutils module

Nir Soffer has posted comments on this change. Change subject: osutils: Start the osutils module .. Patch Set 6: Code-Review+1 CI seems to be sick, tests pass locally. -- To view, visit https://gerrit.ovirt.org/61142 To unsub

Change in vdsm[master]: cluserlock: Use errno instead of os.errno

Nir Soffer has posted comments on this change. Change subject: cluserlock: Use errno instead of os.errno .. Patch Set 5: CI seems to be sick, tests pass locally. -- To view, visit https://gerrit.ovirt.org/60538 To unsubscribe

Change in vdsm[master]: cluserlock: Use errno instead of os.errno

Nir Soffer has posted comments on this change. Change subject: cluserlock: Use errno instead of os.errno .. Patch Set 5: Continuous-Integration+1 -- To view, visit https://gerrit.ovirt.org/60538 To unsubscribe, visit https://g

Change in vdsm[master]: Revert "Using %{_libdir} macro instead of /usr/lib"

Nir Soffer has posted comments on this change. Change subject: Revert "Using %{_libdir} macro instead of /usr/lib" .. Patch Set 2: Verified+1 -- To view, visit https://gerrit.ovirt.org/62196 To unsubscribe, visit https://gerri

Change in vdsm[master]: sd: Move getVolumeLease to StorageDomainManifest

Nir Soffer has posted comments on this change. Change subject: sd: Move getVolumeLease to StorageDomainManifest .. Patch Set 9: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/60282 To unsubscribe, visit https://gerri

Change in vdsm[master]: sd: Support volume leases

gerrit-hooks has posted comments on this change. Change subject: sd: Support volume leases .. Patch Set 9: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: '

Change in vdsm[master]: clusterlock: Fix double close on EINTR

Nir Soffer has posted comments on this change. Change subject: clusterlock: Fix double close on EINTR .. Patch Set 7: Verified+1 -- To view, visit https://gerrit.ovirt.org/60539 To unsubscribe, visit https://gerrit.ovirt.org/s

Change in vdsm[master]: clusterlock: Raise if lock is used improperly

gerrit-hooks has posted comments on this change. Change subject: clusterlock: Raise if lock is used improperly .. Patch Set 8: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header

Change in vdsm[master]: clusterlock: Fix double close on EINTR

gerrit-hooks has posted comments on this change. Change subject: clusterlock: Fix double close on EINTR .. Patch Set 7: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matche

Change in vdsm[master]: cluserlock: Use errno instead of os.errno

gerrit-hooks has posted comments on this change. Change subject: cluserlock: Use errno instead of os.errno .. Patch Set 5: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header mat

Change in vdsm[master]: sd: Move getVolumeLease to StorageDomainManifest

gerrit-hooks has posted comments on this change. Change subject: sd: Move getVolumeLease to StorageDomainManifest .. Patch Set 9: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure hea

Change in vdsm[master]: osutils: Move NoIntrCall to osutils.uninterruptible

gerrit-hooks has posted comments on this change. Change subject: osutils: Move NoIntrCall to osutils.uninterruptible .. Patch Set 5: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure

Change in vdsm[master]: clusterlock: Fix LocalLock.supports_volume_leases

gerrit-hooks has posted comments on this change. Change subject: clusterlock: Fix LocalLock.supports_volume_leases .. Patch Set 8: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure he

Change in vdsm[master]: testlib: Use osutils.close_fd to avoid fd leaks

gerrit-hooks has posted comments on this change. Change subject: testlib: Use osutils.close_fd to avoid fd leaks .. Patch Set 3: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure head

Change in vdsm[master]: sd: Unify getVolumeLease signature

gerrit-hooks has posted comments on this change. Change subject: sd: Unify getVolumeLease signature .. Patch Set 9: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'B

Change in vdsm[master]: osutils: Start the osutils module

gerrit-hooks has posted comments on this change. Change subject: osutils: Start the osutils module .. Patch Set 6: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bu

Change in vdsm[master]: clusterlock: Support for multiple leases

gerrit-hooks has posted comments on this change. Change subject: clusterlock: Support for multiple leases .. Patch Set 9: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matc

Change in vdsm[master]: logging: Improve logging when receiving signals

Nir Soffer has posted comments on this change. Change subject: logging: Improve logging when receiving signals .. Patch Set 1: ping -- To view, visit https://gerrit.ovirt.org/61289 To unsubscribe, visit https://gerrit.ovirt.o

Change in vdsm[master]: v2v: Log detailed output of virt-v2v

Tomas Golembiovsky has posted comments on this change. Change subject: v2v: Log detailed output of virt-v2v .. Patch Set 14: (1 comment) https://gerrit.ovirt.org/#/c/59834/14/lib/vdsm/v2v.py File lib/vdsm/v2v.py: PS14, Line 8

Change in vdsm[master]: v2v: Add execCmd() that accepts stdin/out/err

Tomas Golembiovsky has posted comments on this change. Change subject: v2v: Add execCmd() that accepts stdin/out/err .. Patch Set 2: (2 comments) https://gerrit.ovirt.org/#/c/62092/2//COMMIT_MSG Commit Message: Line 3: Author

Change in vdsm[master]: v2v: Bump version requirement on python-cpopen.

Tomas Golembiovsky has posted comments on this change. Change subject: v2v: Bump version requirement on python-cpopen. .. Patch Set 2: Verified+1 -- To view, visit https://gerrit.ovirt.org/62093 To unsubscribe, visit https://g

Change in vdsm[master]: lib: vdscli: switch to the new devel_warn helper

gerrit-hooks has posted comments on this change. Change subject: lib: vdscli: switch to the new devel_warn helper .. Patch Set 1: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure hea

Change in vdsm[master]: vdsm: drop the warnings module configuration

gerrit-hooks has posted comments on this change. Change subject: vdsm: drop the warnings module configuration .. Patch Set 1: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header

Change in vdsm[master]: api: use the new devel_warn helper

gerrit-hooks has posted comments on this change. Change subject: api: use the new devel_warn helper .. Patch Set 1: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'B

Change in vdsm[master]: lib: logUtils: add devel_warn function

gerrit-hooks has posted comments on this change. Change subject: lib: logUtils: add devel_warn function .. Patch Set 1: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matche

Change in vdsm[master]: storage: fileUtils: drop redundant warning

gerrit-hooks has posted comments on this change. Change subject: storage: fileUtils: drop redundant warning .. Patch Set 1: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header ma

Change in vdsm[master]: cluserlock: Use errno instead of os.errno

Nir Soffer has posted comments on this change. Change subject: cluserlock: Use errno instead of os.errno .. Patch Set 4: Verified+1 -- To view, visit https://gerrit.ovirt.org/60538 To unsubscribe, visit https://gerrit.ovirt.or

Change in vdsm[master]: net: don't accept nameservers on a non-default network

Edward Haas has posted comments on this change. Change subject: net: don't accept nameservers on a non-default network .. Patch Set 7: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/62167 To unsubscribe, visit https:

Change in vdsm[master]: tests: Add more stub methods for sanlock

Nir Soffer has posted comments on this change. Change subject: tests: Add more stub methods for sanlock .. Patch Set 1: Code-Review-1 (1 comment) https://gerrit.ovirt.org/#/c/61996/1/tests/testrunner.py File tests/testrunner.p

Change in vdsm[ovirt-4.0.2]: api: emit warnings only if configured

gerrit-hooks has posted comments on this change. Change subject: api: emit warnings only if configured .. Patch Set 2: * #1364149::Update tracker: OK * Set MODIFIED::bug 1364149#1364149OK -- To view, visit https://ger

Change in vdsm[ovirt-4.0.2]: api: emit warnings only if configured

Francesco Romani has submitted this change and it was merged. Change subject: api: emit warnings only if configured .. api: emit warnings only if configured The python standard module `warnings` implement filtering for warnings

Change in vdsm[ovirt-4.0.2]: api: emit warnings only if configured

Francesco Romani has posted comments on this change. Change subject: api: emit warnings only if configured .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/62198 To unsubscribe, visit https://gerrit.ovi

Change in vdsm[ovirt-4.0.2]: api: emit warnings only if configured

Francesco Romani has posted comments on this change. Change subject: api: emit warnings only if configured .. Patch Set 1: Verified+1 re-verified on the QE box mentioned in the master patch. -- To view, visit https://gerrit.o

Change in vdsm[master]: net: don't accept nameservers on a non-default network

gerrit-hooks has posted comments on this change. Change subject: net: don't accept nameservers on a non-default network .. Patch Set 7: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make su

Change in vdsm[master]: net: don't accept nameservers on a non-default network

Ondřej Svoboda has posted comments on this change. Change subject: net: don't accept nameservers on a non-default network .. Patch Set 6: (1 comment) https://gerrit.ovirt.org/#/c/62167/6/lib/vdsm/network/ip/validator.py File l

Change in vdsm[master]: net: don't accept nameservers on a non-default network

Edward Haas has posted comments on this change. Change subject: net: don't accept nameservers on a non-default network .. Patch Set 6: Code-Review-1 (1 comment) A small nit. https://gerrit.ovirt.org/#/c/62167/6/lib/vdsm/netwo

Change in vdsm[master]: Live Merge: Restore watermark tracking

gerrit-hooks has posted comments on this change. Change subject: Live Merge: Restore watermark tracking .. Patch Set 13: * #1168327::Update tracker: OK * Check Bug-Url::OK * Check Public Bug::#1168327::OK, public bug * Check Pr

Change in vdsm[master]: vm: refactor: Move pathToVolID method

gerrit-hooks has posted comments on this change. Change subject: vm: refactor: Move pathToVolID method .. Patch Set 3: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches

Change in vdsm[master]: net: don't accept nameservers on a non-default network

gerrit-hooks has posted comments on this change. Change subject: net: don't accept nameservers on a non-default network .. Patch Set 6: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make su

Change in vdsm[master]: virt: Make DomainDescriptor use XML helpers

Nir Soffer has posted comments on this change. Change subject: virt: Make DomainDescriptor use XML helpers .. Patch Set 8: Code-Review-1 (1 comment) https://gerrit.ovirt.org/#/c/55769/8/vdsm/virt/vmxml.py File vdsm/virt/vmxml.

Change in vdsm[master]: net: don't accept nameservers on a non-default network

Ondřej Svoboda has posted comments on this change. Change subject: net: don't accept nameservers on a non-default network .. Patch Set 5: (2 comments) https://gerrit.ovirt.org/#/c/62167/5/lib/vdsm/network/api.py File lib/vdsm/

Change in vdsm[ovirt-4.0.2]: api: emit warnings only if configured

Francesco Romani has posted comments on this change. Change subject: api: emit warnings only if configured .. Patch Set 1: Continuous-Integration+1 no CI here, but - run checks locally (FC23) and on RHEL7.2, OK - same code as o

Change in vdsm[ovirt-4.0.2]: api: emit warnings only if configured

Piotr Kliczewski has posted comments on this change. Change subject: api: emit warnings only if configured .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/62198 To unsubscribe, visit https://gerrit.ovi

Change in vdsm[master]: gluster: use moduleloader for dynamic module import

gerrit-hooks has posted comments on this change. Change subject: gluster: use moduleloader for dynamic module import .. Patch Set 6: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure

Change in vdsm[master]: supervdsmServer: using moduleloader for dynamic imports

gerrit-hooks has posted comments on this change. Change subject: supervdsmServer: using moduleloader for dynamic imports .. Patch Set 3: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make s

Change in vdsm[ovirt-4.0.2]: api: emit warnings only if configured

gerrit-hooks has posted comments on this change. Change subject: api: emit warnings only if configured .. Patch Set 1: * #1364149::Update tracker: OK * Check Bug-Url::OK * Check Public Bug::#1364149::OK, public bug * Check Prod

Change in vdsm[master]: moduleloader: added more functions for modules handling

gerrit-hooks has posted comments on this change. Change subject: moduleloader: added more functions for modules handling .. Patch Set 6: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make s

Change in vdsm[ovirt-4.0.2]: api: emit warnings only if configured

Hello Piotr Kliczewski, Michal Skrivanek, I'd like you to do a code review. Please visit https://gerrit.ovirt.org/62198 to review the following change. Change subject: api: emit warnings only if configured .. api: emit wa

Change in vdsm[ovirt-4.0]: api: emit warnings only if configured

gerrit-hooks has posted comments on this change. Change subject: api: emit warnings only if configured .. Patch Set 2: * #1364149::Update tracker: OK * Set MODIFIED::bug 1364149#1364149OK -- To view, visit https://ger

Change in vdsm[ovirt-4.0]: api: emit warnings only if configured

Francesco Romani has posted comments on this change. Change subject: api: emit warnings only if configured .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/62195 To unsubscribe, visit https://gerrit.ovi

Change in vdsm[ovirt-4.0]: api: emit warnings only if configured

Francesco Romani has submitted this change and it was merged. Change subject: api: emit warnings only if configured .. api: emit warnings only if configured The python standard module `warnings` implement filtering for warnings

Change in vdsm[ovirt-4.0]: api: emit warnings only if configured

Piotr Kliczewski has posted comments on this change. Change subject: api: emit warnings only if configured .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/62195 To unsubscribe, visit https://gerrit.ovi

Change in vdsm[master]: Revert "Using %{_libdir} macro instead of /usr/lib"

Yaniv Bronhaim has posted comments on this change. Change subject: Revert "Using %{_libdir} macro instead of /usr/lib" .. Patch Set 2: Code-Review-1 commented in the first ps -- To view, visit https://gerrit.ovirt.org/62196 T

Change in vdsm[master]: gluster: use moduleloader for dynamic module import

gerrit-hooks has posted comments on this change. Change subject: gluster: use moduleloader for dynamic module import .. Patch Set 5: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure

Change in vdsm[master]: gluster: use moduleloader for dynamic module import

gerrit-hooks has posted comments on this change. Change subject: gluster: use moduleloader for dynamic module import .. Patch Set 4: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure

Change in vdsm[master]: Revert "Using %{_libdir} macro instead of /usr/lib"

Yaniv Bronhaim has posted comments on this change. Change subject: Revert "Using %{_libdir} macro instead of /usr/lib" .. Patch Set 1: Code-Review-1 (3 comments) can you focus on the vdsm-lvm file issue and revert only the par

Change in vdsm[master]: Revert "Using %{_libdir} macro instead of /usr/lib"

gerrit-hooks has posted comments on this change. Change subject: Revert "Using %{_libdir} macro instead of /usr/lib" .. Patch Set 2: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure

Change in vdsm[master]: net: don't accept nameservers on a non-default network

Edward Haas has posted comments on this change. Change subject: net: don't accept nameservers on a non-default network .. Patch Set 5: Code-Review-1 -- To view, visit https://gerrit.ovirt.org/62167 To unsubscribe, visit https:

Change in vdsm[master]: Revert "Using %{_libdir} macro instead of /usr/lib"

Idan Shaby has posted comments on this change. Change subject: Revert "Using %{_libdir} macro instead of /usr/lib" .. Patch Set 1: Verified+1 -- To view, visit https://gerrit.ovirt.org/62196 To unsubscribe, visit https://gerri

Change in vdsm[master]: Revert "Using %{_libdir} macro instead of /usr/lib"

gerrit-hooks has posted comments on this change. Change subject: Revert "Using %{_libdir} macro instead of /usr/lib" .. Patch Set 1: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure

Change in vdsm[master]: Revert "Using %{_libdir} macro instead of /usr/lib"

Idan Shaby has uploaded a new change for review. Change subject: Revert "Using %{_libdir} macro instead of /usr/lib" .. Revert "Using %{_libdir} macro instead of /usr/lib" This reverts commit 271dd9bca1288e732f8d80d98a3d022e5c46

Change in vdsm[master]: changing repos to be multi arch and support ppc64le

Sandro Bonazzola has posted comments on this change. Change subject: changing repos to be multi arch and support ppc64le .. Patch Set 1: -Code-Review (2 comments) https://gerrit.ovirt.org/#/c/62123/1/automation/check-patch.rep

Change in vdsm[master]: sampling: Retrieve backing chain stats

gerrit-hooks has posted comments on this change. Change subject: sampling: Retrieve backing chain stats .. Patch Set 4: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matche

Change in vdsm[ovirt-4.0]: api: emit warnings only if configured

gerrit-hooks has posted comments on this change. Change subject: api: emit warnings only if configured .. Patch Set 1: * #1364149::Update tracker: OK * Check Bug-Url::OK * Check Public Bug::#1364149::OK, public bug * Check Prod

Change in vdsm[ovirt-4.0]: api: emit warnings only if configured

Francesco Romani has posted comments on this change. Change subject: api: emit warnings only if configured .. Patch Set 1: Verified+1 62186 was actually verified on branch, so V+1 -- To view, visit https://gerrit.ovirt.org/62

Change in vdsm[ovirt-4.0]: api: emit warnings only if configured

Hello Piotr Kliczewski, Michal Skrivanek, I'd like you to do a code review. Please visit https://gerrit.ovirt.org/62195 to review the following change. Change subject: api: emit warnings only if configured .. api: emit wa

Change in vdsm[master]: api: emit warnings only if configured

gerrit-hooks has posted comments on this change. Change subject: api: emit warnings only if configured .. Patch Set 2: * #1364149::Update tracker: OK * Set MODIFIED::bug 1364149#1364149OK -- To view, visit https://ger

Change in vdsm[master]: api: emit warnings only if configured

Nir Soffer has submitted this change and it was merged. Change subject: api: emit warnings only if configured .. api: emit warnings only if configured The python standard module `warnings` implement filtering for warnings, to a

Change in vdsm[master]: net: don't accept nameservers on a non-default network

Edward Haas has posted comments on this change. Change subject: net: don't accept nameservers on a non-default network .. Patch Set 5: (2 comments) https://gerrit.ovirt.org/#/c/62167/5/lib/vdsm/network/api.py File lib/vdsm/net

Change in vdsm[master]: sampling: Retrieve backing chain stats

Ala Hino has posted comments on this change. Change subject: sampling: Retrieve backing chain stats .. Patch Set 4: Verified-1 -1 for visibility: once this patch is +1ed one, I will run performance tests in order to verify no

Change in vdsm[master]: vm: refactor: Move pathToVolID method

gerrit-hooks has posted comments on this change. Change subject: vm: refactor: Move pathToVolID method .. Patch Set 2: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches

Change in vdsm[master]: Live Merge: Restore watermark tracking

gerrit-hooks has posted comments on this change. Change subject: Live Merge: Restore watermark tracking .. Patch Set 12: * #1168327::Update tracker: OK * Check Bug-Url::OK * Check Public Bug::#1168327::OK, public bug * Check Pr

Change in vdsm[master]: sampling: Retrieve backing chain stats

Ala Hino has posted comments on this change. Change subject: sampling: Retrieve backing chain stats .. Patch Set 3: (7 comments) https://gerrit.ovirt.org/#/c/60888/3/lib/vdsm/virt/sampling.py File lib/vdsm/virt/sampling.py: L

Change in vdsm[master]: vm: refactor: Move pathToVolID method

Ala Hino has posted comments on this change. Change subject: vm: refactor: Move pathToVolID method .. Patch Set 1: (3 comments) https://gerrit.ovirt.org/#/c/62180/1//COMMIT_MSG Commit Message: Line 3: AuthorDate: 2016-08-08 1

Change in vdsm[master]: core: refactor: Move pathToVolID method

Francesco Romani has posted comments on this change. Change subject: core: refactor: Move pathToVolID method .. Patch Set 1: Code-Review-1 (3 comments) conceptually ok, we just need a few minor tweaks. -1 for visibility of the

Change in vdsm[master]: net tests: add a 'status' parameter to SetupNetworksError

Edward Haas has posted comments on this change. Change subject: net tests: add a 'status' parameter to SetupNetworksError .. Patch Set 3: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/62166 To unsubscribe, visit htt

Change in vdsm[master]: net tests: add a 'status' parameter to SetupNetworksError

gerrit-hooks has posted comments on this change. Change subject: net tests: add a 'status' parameter to SetupNetworksError .. Patch Set 3: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make

Change in vdsm[master]: net: don't accept nameservers on a non-default network

gerrit-hooks has posted comments on this change. Change subject: net: don't accept nameservers on a non-default network .. Patch Set 5: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make su

Change in vdsm[master]: sampling: Retrieve backing chain stats

Francesco Romani has posted comments on this change. Change subject: sampling: Retrieve backing chain stats .. Patch Set 3: (1 comment) https://gerrit.ovirt.org/#/c/60888/3/lib/vdsm/virt/sampling.py File lib/vdsm/virt/sampling

Change in vdsm[master]: sampling: Retrieve backing chain stats

Francesco Romani has posted comments on this change. Change subject: sampling: Retrieve backing chain stats .. Patch Set 3: Code-Review-1 (2 comments) I'm not convinced this is correct, please check inline comments. https://g

Change in vdsm[master]: tests: add a 'status' parameter to SetupNetworksError

Ondřej Svoboda has posted comments on this change. Change subject: tests: add a 'status' parameter to SetupNetworksError .. Patch Set 2: (1 comment) https://gerrit.ovirt.org/#/c/62166/2//COMMIT_MSG Commit Message: PS2, Line 7

Change in vdsm[master]: tests: add a 'status' parameter to SetupNetworksError

Edward Haas has posted comments on this change. Change subject: tests: add a 'status' parameter to SetupNetworksError .. Patch Set 2: (1 comment) Nit: Please update the commit message so it will include 'net' in it. https://g

  1   2   >