Francesco Romani has posted comments on this change.
Change subject: rng: allow urandom as virtio rng entropy source
..
Patch Set 7:
(1 comment)
https://gerrit.ovirt.org/#/c/59031/7/lib/vdsm/host/rngsources.py
File lib/vdsm/ho
Nir Soffer has posted comments on this change.
Change subject: storage: export volume lease state in getVolumeInfo
..
Patch Set 5: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/61995
To unsubscribe, visit https://ge
gerrit-hooks has posted comments on this change.
Change subject: storage: domainMonitor.getAllHostIds() API
..
Patch Set 5:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header ma
gerrit-hooks has posted comments on this change.
Change subject: storage: export volume lease state in getVolumeInfo
..
Patch Set 5:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure
gerrit-hooks has posted comments on this change.
Change subject: tests: Add GuardedLocks checking utility
..
Patch Set 1:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matc
gerrit-hooks has posted comments on this change.
Change subject: storage: Sortable ResourceManager lock namespaces
..
Patch Set 8:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure he
gerrit-hooks has posted comments on this change.
Change subject: tests: Introduce FakeSanlock
..
Patch Set 4:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url
gerrit-hooks has posted comments on this change.
Change subject: sdm: Use guarded.context in copy_data
..
Patch Set 7:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches
gerrit-hooks has posted comments on this change.
Change subject: storage: Introduce guarded utilities
..
Patch Set 9:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches
Adam Litke has uploaded a new change for review.
Change subject: tests: Add GuardedLocks checking utility
..
tests: Add GuardedLocks checking utility
We want to validate that sdm verbs are taking the proper locks in the
proper o
Nir Soffer has posted comments on this change.
Change subject: dump_volume_chains: migrate to jsonrpcvdscli
..
Patch Set 9: Code-Review-1
status is wrong:
image:c7901677-2a44-4365-81fa-ba235f93b73c
- a80cfc
Irit Goihman has posted comments on this change.
Change subject: dump_volume_chains: migrate to jsonrpcvdscli
..
Patch Set 9: Verified+1
In [2]:
dump_volume_chains.dump_chains('dump-volume-chains','33d5731d-665e-4a70-bb0d-84cd
Nir Soffer has posted comments on this change.
Change subject: Using %{?_smp_mflags} for make calls
..
Patch Set 2:
(2 comments)
https://gerrit.ovirt.org/#/c/62163/2/vdsm.spec.in
File vdsm.spec.in:
Line 743: %endif
Line 744:
gerrit-hooks has posted comments on this change.
Change subject: dump_volume_chains: migrate to jsonrpcvdscli
..
Patch Set 9:
* #1365007::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1365007::OK, public bug
* Che
gerrit-hooks has posted comments on this change.
Change subject: dump_volume_chains: migrate to jsonrpcvdscli
..
Patch Set 8:
* #1365007::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1365007::OK, public bug
* Che
Yaniv Bronhaim has posted comments on this change.
Change subject: spec: remove deprecated BuildRoot macro
..
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/62164
To unsubscribe, visit https://gerrit.ovi
Yaniv Bronhaim has posted comments on this change.
Change subject: vdsm reg: clean up
..
Patch Set 2: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/62463
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerr
Douglas Schilling Landgraf has posted comments on this change.
Change subject: Vdsm supports only x86, ppc and ppc64
..
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/62465
To unsubscribe, visit https://
gerrit-hooks has posted comments on this change.
Change subject: Vdsm supports only x86, ppc and ppc64
..
Patch Set 1:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches
gerrit-hooks has posted comments on this change.
Change subject: Revert "Remove __init__.py file from lib64 vdsm python
directory"
..
Patch Set 2:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url fo
Yaniv Bronhaim has uploaded a new change for review.
Change subject: Vdsm supports only x86, ppc and ppc64
..
Vdsm supports only x86, ppc and ppc64
Adding exclusive arch to spec to avoid building on unsupported platform
in koji
Yaniv Bronhaim has posted comments on this change.
Change subject: Revert "Remove __init__.py file from lib64 vdsm python
directory"
..
Patch Set 1: Verified+1
--
To view, visit https://gerrit.ovirt.org/62453
To unsubscribe,
Irit Goihman has posted comments on this change.
Change subject: dump_volume_chains: migrate to jsonrpcvdscli
..
Patch Set 7:
(2 comments)
https://gerrit.ovirt.org/#/c/62324/6/lib/vdsm/tool/dump_volume_chains.py
File lib/vdsm/
gerrit-hooks has posted comments on this change.
Change subject: jsonrpcvdscli: change getVolumesList schema conversion
..
Patch Set 3:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make su
gerrit-hooks has posted comments on this change.
Change subject: dump_volume_chains: migrate to jsonrpcvdscli
..
Patch Set 7:
* #1365007::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1365007::OK, public bug
* Che
Nir Soffer has posted comments on this change.
Change subject: storage: export volume lease state in getVolumeInfo
..
Patch Set 4: Code-Review+1
(1 comment)
https://gerrit.ovirt.org/#/c/61995/4//COMMIT_MSG
Commit Message:
Lin
gerrit-hooks has posted comments on this change.
Change subject: storage: export volume lease state in getVolumeInfo
..
Patch Set 4:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure
gerrit-hooks has posted comments on this change.
Change subject: storage: Sortable ResourceManager lock namespaces
..
Patch Set 7:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure he
Nir Soffer has posted comments on this change.
Change subject: spec: remove deprecated BuildRoot macro
..
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/62164
To unsubscribe, visit https://gerrit.ovirt.o
Adam Litke has posted comments on this change.
Change subject: storage: export volume lease state in getVolumeInfo
..
Patch Set 3:
(2 comments)
https://gerrit.ovirt.org/#/c/61995/3/lib/api/vdsm-api.yml
File lib/api/vdsm-api.ym
Douglas Schilling Landgraf has posted comments on this change.
Change subject: spec: remove deprecated BuildRoot macro
..
Patch Set 1: Verified+1
--
To view, visit https://gerrit.ovirt.org/62164
To unsubscribe, visit https://g
Douglas Schilling Landgraf has posted comments on this change.
Change subject: vdsm reg: clean up
..
Patch Set 2: Verified+1
--
To view, visit https://gerrit.ovirt.org/62463
To unsubscribe, visit https://gerrit.ovirt.org/setti
gerrit-hooks has posted comments on this change.
Change subject: vdsm reg: clean up
..
Patch Set 2:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: '
and i
gerrit-hooks has posted comments on this change.
Change subject: vdsm reg: clean up
..
Patch Set 1:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: '
and i
Douglas Schilling Landgraf has uploaded a new change for review.
Change subject: vdsm reg: clean up
..
vdsm reg: clean up
Reviewing the vdsm spec found some remaning of vdsm reg deprecated
in early 3.6 versions.
Change-Id: I9f8
Douglas Schilling Landgraf has posted comments on this change.
Change subject: Using %{?_smp_mflags} for make calls
..
Patch Set 2:
This would be perfect but using the flag in all make looks like trigger an
issue in jenkins.
Douglas Schilling Landgraf has posted comments on this change.
Change subject: Revert "Remove __init__.py file from lib64 vdsm python
directory"
..
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/62453
T
Douglas Schilling Landgraf has posted comments on this change.
Change subject: hook-fcoe is arch depended
..
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/62454
To unsubscribe, visit https://gerrit.ovir
gerrit-hooks has posted comments on this change.
Change subject: hook-fcoe is arch depended
..
Patch Set 1:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url:
Yaniv Bronhaim has uploaded a new change for review.
Change subject: hook-fcoe is arch depended
..
hook-fcoe is arch depended
Using %post script in sub-package of arch depended package requires to
declare the package as arch dep
gerrit-hooks has posted comments on this change.
Change subject: Revert "Remove __init__.py file from lib64 vdsm python
directory"
..
Patch Set 1:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url fo
Yaniv Bronhaim has uploaded a new change for review.
Change subject: Revert "Remove __init__.py file from lib64 vdsm python
directory"
..
Revert "Remove __init__.py file from lib64 vdsm python directory"
This reverts commit 9f9
gerrit-hooks has posted comments on this change.
Change subject: Revert "Remove __init__.py file from lib64 vdsm python
directory"
..
Patch Set 1:
* Update tracker: IGNORE, no Bug-Url found
--
To view, visit https://gerrit.o
gerrit-hooks has posted comments on this change.
Change subject: Revert "Remove __init__.py file from lib64 vdsm python
directory"
..
Patch Set 1: Verified-1
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::ERROR,
Yaniv Bronhaim has abandoned this change.
Change subject: Revert "Remove __init__.py file from lib64 vdsm python
directory"
..
Abandoned
--
To view, visit https://gerrit.ovirt.org/62446
To unsubscribe, visit https://gerrit.ov
Yaniv Bronhaim has reverted this change.
Change subject: Revert "Remove __init__.py file from lib64 vdsm python
directory"
..
Uploaded patch set 1.
--
To view, visit https://gerrit.ovirt.org/62446
To unsubscribe, visit https:
Yaniv Bronhaim has uploaded a new change for review.
Change subject: Revert "Remove __init__.py file from lib64 vdsm python
directory"
..
Revert "Remove __init__.py file from lib64 vdsm python directory"
This reverts commit 9f9
Nir Soffer has posted comments on this change.
Change subject: lvm: Separate lv reduce and extend
..
Patch Set 3:
(1 comment)
https://gerrit.ovirt.org/#/c/62369/3/vdsm/storage/lvm.py
File vdsm/storage/lvm.py:
Line 1177: _
Dan Kenigsberg has posted comments on this change.
Change subject: net: early IP+link setup
..
Patch Set 15: Code-Review-1
(3 comments)
-1 is mainly for handling a mismatch with ovsdb.
https://gerrit.ovirt.org/#/c/60371/15/li
Nir Soffer has posted comments on this change.
Change subject: dump_volume_chains: migrate to jsonrpcvdscli
..
Patch Set 6: Code-Review-1
Please address comments in version 6.
--
To view, visit https://gerrit.ovirt.org/62324
Nir Soffer has posted comments on this change.
Change subject: kvm2ovirt: add dry run option
..
Patch Set 1:
(1 comment)
https://gerrit.ovirt.org/#/c/62257/1/helpers/kvm2ovirt
File helpers/kvm2ovirt:
Line 99
Line 100
Line 101
Nir Soffer has posted comments on this change.
Change subject: kvm2ovirt: Fixes issue in importing VMs with libvirt uri
qemu+tcp
..
Patch Set 2: Code-Review-1
(1 comment)
https://gerrit.ovirt.org/#/c/62052/2/helpers/kvm2ovirt
Dan Kenigsberg has posted comments on this change.
Change subject: net: Report the default gateway flag through caps
..
Patch Set 13:
(1 comment)
https://gerrit.ovirt.org/#/c/58351/13/lib/vdsm/network/kernelconfig.py
File lib/
gerrit-hooks has posted comments on this change.
Change subject: hook-fcoe: enable lldpad and fceo service on boot
..
Patch Set 2:
* #1353456::Update tracker: OK
--
To view, visit https://gerrit.ovirt.org/62365
To unsubscribe
Dan Kenigsberg has abandoned this change.
Change subject: hook-fcoe: enable lldpad and fceo service on boot
..
Abandoned
bug nack'ed from 4.0.2 by ydary.
--
To view, visit https://gerrit.ovirt.org/62365
To unsubscribe, visit
Edward Haas has posted comments on this change.
Change subject: net test: Rename link_test module to netlink_test
..
Patch Set 1: Verified+1
--
To view, visit https://gerrit.ovirt.org/62442
To unsubscribe, visit https://gerrit
Edward Haas has uploaded a new change for review.
Change subject: net test: Rename link_test module to netlink_test
..
net test: Rename link_test module to netlink_test
Change-Id: Iefcf2789544b2106a5edcc0401195bc8830c5aa8
Signed
gerrit-hooks has posted comments on this change.
Change subject: net test: Rename link_test module to netlink_test
..
Patch Set 1:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure he
Yaniv Kaul has posted comments on this change.
Change subject: virt: enable glusterfs access through libgfapi interface
..
Patch Set 8:
(1 comment)
I'm quite sure this patch has to depend on the cluster level being 4.1 or abov
Francesco Romani has posted comments on this change.
Change subject: WIP vm: add utility to get sublogger
..
Patch Set 4: Code-Review-1 Verified-1
broken as per Nir's comments.
--
To view, visit https://gerrit.ovirt.org/61992
Freddy Rolland has posted comments on this change.
Change subject: lvm: Separate lv reduce and extend
..
Patch Set 3:
I think we should squash the two patches.
It will be easier to backport if we will have more fixes in the fut
gerrit-hooks has posted comments on this change.
Change subject: migration: more debug logs for connection
..
Patch Set 2:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header mat
Francesco Romani has posted comments on this change.
Change subject: WIP vm: add utility to get sublogger
..
Patch Set 3:
(2 comments)
https://gerrit.ovirt.org/#/c/61992/3/vdsm/virt/vm.py
File vdsm/virt/vm.py:
Line 222:
Francesco Romani has uploaded a new change for review.
Change subject: migration: more logs for connection
..
migration: more logs for connection
Add additional debug logs to help troubleshoot
weird issues like rhbz#134
Cha
gerrit-hooks has posted comments on this change.
Change subject: migration: more logs for connection
..
Patch Set 1:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches '
Francesco Romani has uploaded a new change for review.
Change subject: migration: add low-level socket timeout
..
migration: add low-level socket timeout
Helpful to troubleshoot werird failures like
rhbz#134
Change-Id: I004
gerrit-hooks has posted comments on this change.
Change subject: migration: add low-level socket timeout
..
Patch Set 1:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header match
gerrit-hooks has posted comments on this change.
Change subject: configs: move systemd service files to static
..
Patch Set 14:
* Update tracker: IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no Bug-Url found.
--
To view,
gerrit-hooks has posted comments on this change.
Change subject: configs: move modprobe files loading to static
..
Patch Set 13:
* Update tracker: IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no Bug-Url found.
--
To view,
gerrit-hooks has posted comments on this change.
Change subject: configs: move sysctl to static
..
Patch Set 16:
* Update tracker: IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no Bug-Url found.
--
To view, visit https://g
Yaniv Bronhaim has posted comments on this change.
Change subject: dump_volume_chains: migrate to jsonrpcvdscli
..
Patch Set 6: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/62324
To unsubscribe, visit https://gerri
gerrit-hooks has posted comments on this change.
Change subject: configs: move kernel module loading to static
..
Patch Set 15:
* Update tracker: IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no Bug-Url found.
--
To view,
Dan Kenigsberg has submitted this change and it was merged.
Change subject: configs: move systemd service files to static
..
configs: move systemd service files to static
Part of the move of static files to new directory. The f
Dan Kenigsberg has submitted this change and it was merged.
Change subject: configs: move modprobe files loading to static
..
configs: move modprobe files loading to static
Part of the move of static files to new directory. Th
Dan Kenigsberg has submitted this change and it was merged.
Change subject: configs: move sysctl to static
..
configs: move sysctl to static
Part of the move of static files to new directory. The files are moved
to correspondi
gerrit-hooks has posted comments on this change.
Change subject: configs: move logrotate to static
..
Patch Set 15:
* Update tracker: IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no Bug-Url found.
--
To view, visit https:
Dan Kenigsberg has submitted this change and it was merged.
Change subject: configs: move kernel module loading to static
..
configs: move kernel module loading to static
Part of the move of static files to new directory. The f
Dan Kenigsberg has submitted this change and it was merged.
Change subject: configs: move logrotate to static
..
configs: move logrotate to static
Part of the move of static files to new directory. The files are moved
to corre
gerrit-hooks has posted comments on this change.
Change subject: virt: Fix of Executor._active_workers crash on modification
..
Patch Set 3:
* #1364925::Update tracker: OK
* Set MODIFIED::bug 1364925#1364925OK
--
To v
gerrit-hooks has posted comments on this change.
Change subject: virt: Fix of Executor._active_workers crash on modification
..
Patch Set 2:
* #1364925::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1364925::OK, p
Francesco Romani has submitted this change and it was merged.
Change subject: virt: Fix of Executor._active_workers crash on modification
..
virt: Fix of Executor._active_workers crash on modification
Executor._active_workers d
gerrit-hooks has posted comments on this change.
Change subject: virt: Limit the number of workers in executor
..
Patch Set 2:
* #1364925::Update tracker: OK
* Set MODIFIED::bug 1364925#1364925IGNORE, not all related pa
Francesco Romani has posted comments on this change.
Change subject: virt: Limit the number of workers in executor
..
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/62402
To unsubscribe, visit https://ge
Francesco Romani has submitted this change and it was merged.
Change subject: virt: Limit the number of workers in executor
..
virt: Limit the number of workers in executor
In some situations, periodic operations may hang insid
Francesco Romani has posted comments on this change.
Change subject: vm: periodic: fix stats age reporting
..
Patch Set 1: Verified+1
re-verified on branch, using the same steps as master branch.
--
To view, visit https://ger
Francesco Romani has posted comments on this change.
Change subject: virt: sampling: add is_empty() method to StatsSample
..
Patch Set 1: Verified+1
verified with the tests and with 62418
--
To view, visit https://gerrit.ovir
Francesco Romani has posted comments on this change.
Change subject: virt: Fix of Executor._active_workers crash on modification
..
Patch Set 1:
no-brainer once parent patch is in.
--
To view, visit https://gerrit.ovirt.org/6
Francesco Romani has posted comments on this change.
Change subject: virt: Fix of Executor._active_workers crash on modification
..
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/62403
To unsubscribe, vi
Francesco Romani has posted comments on this change.
Change subject: virt: Limit the number of workers in executor
..
Patch Set 1: Code-Review+1
will have myself another review cycle (worst case ETA tomorrow) -- for extra
care
gerrit-hooks has posted comments on this change.
Change subject: periodic: always re-schedule operations
..
Patch Set 2:
* #1364925::Update tracker: OK
* Set MODIFIED::bug 1364925#1364925IGNORE, not all related patches
Francesco Romani has submitted this change and it was merged.
Change subject: periodic: always re-schedule operations
..
periodic: always re-schedule operations
when one periodic.Operation() try to dispatch itself
to the execut
Francesco Romani has posted comments on this change.
Change subject: periodic: always re-schedule operations
..
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/62401
To unsubscribe, visit https://gerrit.o
Francesco Romani has posted comments on this change.
Change subject: virt: Fix of Executor._active_workers crash on modification
..
Patch Set 1: Verified+1
verified with 62402
--
To view, visit https://gerrit.ovirt.org/62403
Francesco Romani has posted comments on this change.
Change subject: virt: Limit the number of workers in executor
..
Patch Set 1: Verified+1
re-verified on-branch the same way as master patch:
[root@goji ~]# grep 'Too many' /v
Francesco Romani has posted comments on this change.
Change subject: periodic: always re-schedule operations
..
Patch Set 1: Verified+1
Verified on-branch the same way as master patch and ovirt-4.0 patch:
vdsm.Scheduler::WARNI
Martin Polednik has posted comments on this change.
Change subject: configs: move logrotate to static
..
Patch Set 14:
Rebased again.
--
To view, visit https://gerrit.ovirt.org/61616
To unsubscribe, visit https://gerrit.ovirt
gerrit-hooks has posted comments on this change.
Change subject: configs: move modprobe files loading to static
..
Patch Set 12:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure head
gerrit-hooks has posted comments on this change.
Change subject: configs: move sysctl to static
..
Patch Set 15:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-
gerrit-hooks has posted comments on this change.
Change subject: configs: move systemd service files to static
..
Patch Set 13:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure heade
gerrit-hooks has posted comments on this change.
Change subject: configs: move logrotate to static
..
Patch Set 14:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'B
1 - 100 of 168 matches
Mail list logo
