Michal Skrivanek has posted comments on this change.
Change subject: logging: More standard logging format
..
Patch Set 3: Code-Review-1
I would hate to see the thread id somewhere deep, it is THE most critical thing
to follow
Francesco Romani has posted comments on this change.
Change subject: alignmentScan: Add Red Hat copyright
..
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/64223
To unsubscribe, visit https://gerrit.ovir
Francesco Romani has posted comments on this change.
Change subject: logging: Document the secret TRACE log level
..
Patch Set 2: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/64218
To unsubscribe, visit https://ger
Francesco Romani has posted comments on this change.
Change subject: alignmentScan: Use proper environment
..
Patch Set 2: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/64123
To unsubscribe, visit https://gerrit.ovi
Nir Soffer has posted comments on this change.
Change subject: virt: enable libgfapi with snapshot support
..
Patch Set 1:
(4 comments)
https://gerrit.ovirt.org/#/c/56906/1/vdsm/virt/vm.py
File vdsm/virt/vm.py:
Line 3197
Line
Nir Soffer has posted comments on this change.
Change subject: virt: enable libgfapi with snapshot support
..
Patch Set 1:
This should be rebased on https://gerrit.ovirt.org/56907, right?
--
To view, visit https://gerrit.ovir
Nir Soffer has posted comments on this change.
Change subject: virt: enable glusterfs access through libgfapi interface
..
Patch Set 8:
(1 comment)
https://gerrit.ovirt.org/#/c/44061/8/vdsm/storage/glusterVolume.py
File vdsm/s
Nir Soffer has posted comments on this change.
Change subject: [QCOW1.1]qemuimg: Add kwargs optional parameter for qcow.
..
Patch Set 4:
(1 comment)
https://gerrit.ovirt.org/#/c/64169/4/lib/vdsm/qemuimg.py
File lib/vdsm/qemuim
Maor Lipchuk has posted comments on this change.
Change subject: [QCOW1.1]qemuimg: Add kwargs optional parameter for qcow.
..
Patch Set 4:
(5 comments)
https://gerrit.ovirt.org/#/c/64169/4//COMMIT_MSG
Commit Message:
Line 3:
Nir Soffer has posted comments on this change.
Change subject: [QCOW1.1]qemuimg: Add kwargs optional parameter for qcow.
..
Patch Set 4:
(1 comment)
https://gerrit.ovirt.org/#/c/64169/4/lib/vdsm/qemuimg.py
File lib/vdsm/qemuim
Nir Soffer has posted comments on this change.
Change subject: [QCOW1.1]qemuimg: Add kwargs optional parameter for qcow.
..
Patch Set 4:
(3 comments)
https://gerrit.ovirt.org/#/c/64169/4/lib/vdsm/qemuimg.py
File lib/vdsm/qemui
Nir Soffer has posted comments on this change.
Change subject: [QCOW1.1]qemuimg: Add kwargs optional parameter for qcow.
..
Patch Set 4:
(1 comment)
https://gerrit.ovirt.org/#/c/64169/4//COMMIT_MSG
Commit Message:
Line 3: Aut
Nir Soffer has posted comments on this change.
Change subject: storage: Use mismatched_vm_conf_disk workaround in copy_data
..
Patch Set 1: Code-Review-1
(2 comments)
https://gerrit.ovirt.org/#/c/64231/1/vdsm/storage/sdm/api/c
Nir Soffer has posted comments on this change.
Change subject: storage: Refactor workarounds.detect_format
..
Patch Set 1:
(4 comments)
https://gerrit.ovirt.org/#/c/64230/1/vdsm/storage/image.py
File vdsm/storage/image.py:
Li
Nir Soffer has posted comments on this change.
Change subject: storage: Move detect_format to new workarounds module
..
Patch Set 1:
(2 comments)
https://gerrit.ovirt.org/#/c/64229/1/tests/storage_workarounds_test.py
File test
Nir Soffer has posted comments on this change.
Change subject: storage: Refactor workarounds.detect_format
..
Patch Set 1: Code-Review-1
(3 comments)
https://gerrit.ovirt.org/#/c/64230/1/tests/storage_workarounds_test.py
File
Maor Lipchuk has posted comments on this change.
Change subject: [QCOW1.1]qemuimg: Add kwargs optional parameter for qcow.
..
Patch Set 4:
(6 comments)
@Nir, I disagree regarding the approach of no upload new versions while th
Nir Soffer has posted comments on this change.
Change subject: storage: Refactor workarounds.detect_format
..
Patch Set 1:
Nice, look much better then the original code, and the complicated tests are
simple now.
--
To view,
Nir Soffer has posted comments on this change.
Change subject: storage: Move detect_format to new workarounds module
..
Patch Set 1:
(4 comments)
Nice, I like this name, this makes working on vdsm more fun.
https://gerrit.ovi
Nir Soffer has posted comments on this change.
Change subject: tests: TestCopyDataDIV needs to initialize the jobs module
..
Patch Set 1: Code-Review-1
(1 comment)
https://gerrit.ovirt.org/#/c/64228/1/tests/storage_sdm_copy_da
Nir Soffer has posted comments on this change.
Change subject: vdsm: Do not modify warnings filter in a library
..
Patch Set 2:
Thanks for the quick reviews. Lets merge this soon so we don't miss the next
build.
--
To view,
Saša Tomić has posted comments on this change.
Change subject: alignmentScan: Add Red Hat copyright
..
Patch Set 1: Code-Review+1 Verified+1
Seems perfectly fine to me.
--
To view, visit https://gerrit.ovirt.org/64223
To unsu
Adam Litke has uploaded a new change for review.
Change subject: storage: Refactor workarounds.detect_format
..
storage: Refactor workarounds.detect_format
The function workarounds.detect_format accepts two volumes, checks for a
gerrit-hooks has posted comments on this change.
Change subject: storage: Use mismatched_vm_conf_disk workaround in copy_data
..
Patch Set 1:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, m
gerrit-hooks has posted comments on this change.
Change subject: storage: Move detect_format to new workarounds module
..
Patch Set 1:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sur
gerrit-hooks has posted comments on this change.
Change subject: tests: TestCopyDataDIV needs to initialize the jobs module
..
Patch Set 1:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, mak
gerrit-hooks has posted comments on this change.
Change subject: storage: Refactor workarounds.detect_format
..
Patch Set 1:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header m
Adam Litke has uploaded a new change for review.
Change subject: storage: Move detect_format to new workarounds module
..
storage: Move detect_format to new workarounds module
The function Image._detect_format is a workaround fo
Adam Litke has uploaded a new change for review.
Change subject: tests: TestCopyDataDIV needs to initialize the jobs module
..
tests: TestCopyDataDIV needs to initialize the jobs module
The copy_data job now relies on the jobs m
Adam Litke has uploaded a new change for review.
Change subject: storage: Use mismatched_vm_conf_disk workaround in copy_data
..
storage: Use mismatched_vm_conf_disk workaround in copy_data
SDM.copy_data needs to apply the same
gerrit-hooks has posted comments on this change.
Change subject: logging: Unify SimpleLogAdapter format
..
Patch Set 1:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matche
gerrit-hooks has posted comments on this change.
Change subject: logging: Improve log level alignment
..
Patch Set 2:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches
Nir Soffer has posted comments on this change.
Change subject: logging: Use same log format in the tests
..
Patch Set 2: Verified+1
--
To view, visit https://gerrit.ovirt.org/64216
To unsubscribe, visit https://gerrit.ovirt.or
gerrit-hooks has posted comments on this change.
Change subject: logging: Document the secret TRACE log level
..
Patch Set 2:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
gerrit-hooks has posted comments on this change.
Change subject: logging: Use same log format in the tests
..
Patch Set 2:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header mat
Nir Soffer has posted comments on this change.
Change subject: logging: Unify SimpleLogAdapter format
..
Patch Set 1: Verified+1
--
To view, visit https://gerrit.ovirt.org/64227
To unsubscribe, visit https://gerrit.ovirt.org/s
Nir Soffer has posted comments on this change.
Change subject: logging: Improve log level alignment
..
Patch Set 2: Verified+1
--
To view, visit https://gerrit.ovirt.org/64217
To unsubscribe, visit https://gerrit.ovirt.org/set
Nir Soffer has posted comments on this change.
Change subject: logging: More standard logging format
..
Patch Set 3: Verified+1
--
To view, visit https://gerrit.ovirt.org/64113
To unsubscribe, visit https://gerrit.ovirt.org/se
gerrit-hooks has posted comments on this change.
Change subject: logging: More standard logging format
..
Patch Set 3:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches
Nir Soffer has posted comments on this change.
Change subject: logging: Document the secret TRACE log level
..
Patch Set 2: Verified+1
--
To view, visit https://gerrit.ovirt.org/64218
To unsubscribe, visit https://gerrit.ovirt
Nir Soffer has uploaded a new change for review.
Change subject: logging: Unify SimpleLogAdapter format
..
logging: Unify SimpleLogAdapter format
SimpleLogAdapter was prefixing the log message with context info, using
"::" as me
Nir Soffer has posted comments on this change.
Change subject: alignmentScan: Add Red Hat copyright
..
Patch Set 1: Verified+1
--
To view, visit https://gerrit.ovirt.org/64223
To unsubscribe, visit https://gerrit.ovirt.org/set
Nir Soffer has posted comments on this change.
Change subject: [WIP] core: Expose API for qemu-img commit
..
Patch Set 2:
(6 comments)
Great work!
https://gerrit.ovirt.org/#/c/64222/2//COMMIT_MSG
Commit Message:
Line 3: Auth
Nir Soffer has posted comments on this change.
Change subject: tests: Rename qemuimgTests.py to new Vdsm convention
..
Patch Set 3: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/64203
To unsubscribe, visit https://g
Nir Soffer has posted comments on this change.
Change subject: alignmentScan: Use proper environment
..
Patch Set 2:
(1 comment)
https://gerrit.ovirt.org/#/c/64123/2/vdsm/alignmentScan.py
File vdsm/alignmentScan.py:
Line 1: #
gerrit-hooks has posted comments on this change.
Change subject: alignmentScan: Add Red Hat copyright
..
Patch Set 1:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches
Nir Soffer has uploaded a new change for review.
Change subject: alignmentScan: Add Red Hat copyright
..
alignmentScan: Add Red Hat copyright
This module was started by Saša Tomić in 2012. According to git log Red
Hat is maintai
Ala Hino has posted comments on this change.
Change subject: tests: Rename qemuimgTests.py to new Vdsm convention
..
Patch Set 3: Verified+1
--
To view, visit https://gerrit.ovirt.org/64203
To unsubscribe, visit https://gerrit
gerrit-hooks has posted comments on this change.
Change subject: sdm: Introduce new SDM.merge verb
..
Patch Set 4:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bu
gerrit-hooks has posted comments on this change.
Change subject: [WIP] core: Expose API for qemu-img commit
..
Patch Set 2:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header ma
gerrit-hooks has posted comments on this change.
Change subject: sdm: Introduce new SDM.merge verb
..
Patch Set 3:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bu
gerrit-hooks has posted comments on this change.
Change subject: [WIP] core: Expose API for qemu-img commit
..
Patch Set 1:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header ma
Ala Hino has uploaded a new change for review.
Change subject: [WIP] core: Expose API for qemu-img commit
..
[WIP] core: Expose API for qemu-img commit
Change-Id: If7a13be40541fb268541bd8614a642263b96b487
Signed-off-by: Ala Hino
Ala Hino has posted comments on this change.
Change subject: tests: Rename qemuimgTests.py to new Vdsm convention
..
Patch Set 2:
(1 comment)
https://gerrit.ovirt.org/#/c/64203/2/tests/Makefile.am
File tests/Makefile.am:
Line
gerrit-hooks has posted comments on this change.
Change subject: tests: Rename qemuimgTests.py to new Vdsm convention
..
Patch Set 3:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure
Nir Soffer has posted comments on this change.
Change subject: sdm: Introduce new SDM.merge verb
..
Patch Set 2:
(1 comment)
https://gerrit.ovirt.org/#/c/64196/2/lib/api/vdsm-api.yml
File lib/api/vdsm-api.yml:
Line 9915:
Adam Litke has posted comments on this change.
Change subject: sdm: Introduce new SDM.merge verb
..
Patch Set 2:
(1 comment)
Let's discuss the API we want before proceeding.
https://gerrit.ovirt.org/#/c/64196/2/lib/api/vdsm-a
Nir Soffer has posted comments on this change.
Change subject: logging: Document the secret TRACE log level
..
Patch Set 1: Verified+1
--
To view, visit https://gerrit.ovirt.org/64218
To unsubscribe, visit https://gerrit.ovirt
Nir Soffer has posted comments on this change.
Change subject: logging: Improve log level alignment
..
Patch Set 1: Verified+1
--
To view, visit https://gerrit.ovirt.org/64217
To unsubscribe, visit https://gerrit.ovirt.org/set
Nir Soffer has posted comments on this change.
Change subject: log: More standard logging format
..
Patch Set 2: Verified+1
--
To view, visit https://gerrit.ovirt.org/64113
To unsubscribe, visit https://gerrit.ovirt.org/settin
gerrit-hooks has posted comments on this change.
Change subject: logging: Improve log level alignment
..
Patch Set 1:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches
Nir Soffer has posted comments on this change.
Change subject: tests: Use same log format as vdsm
..
Patch Set 1: Verified+1
--
To view, visit https://gerrit.ovirt.org/64216
To unsubscribe, visit https://gerrit.ovirt.org/setti
gerrit-hooks has posted comments on this change.
Change subject: tests: Use same log format as vdsm
..
Patch Set 1:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'B
gerrit-hooks has posted comments on this change.
Change subject: logging: Document the secret TRACE log level
..
Patch Set 1:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
Nir Soffer has uploaded a new change for review.
Change subject: logging: Document the secret TRACE log level
..
logging: Document the secret TRACE log level
This may be useful to for developers to understand complicated flows.
Nir Soffer has uploaded a new change for review.
Change subject: logging: Improve log level alignment
..
logging: Improve log level alignment
Shorten WARNING to WARN and CRITICAL to CRIT to make log messages align
nicer.
Here i
Nir Soffer has uploaded a new change for review.
Change subject: tests: Use same log format as vdsm
..
tests: Use same log format as vdsm
Using the same format as in vdsm logs may make it easier to debug
failing tests. In partic
Jenny Tokar has posted comments on this change.
Change subject: Add new api to get the IO tune policies for all vms
..
Patch Set 2:
(4 comments)
https://gerrit.ovirt.org/#/c/63748/2/vdsm/virt/vm.py
File vdsm/virt/vm.py:
PS2,
gerrit-hooks has posted comments on this change.
Change subject: log: More standard logging format
..
Patch Set 2:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bu
Jenny Tokar has posted comments on this change.
Change subject: Add new api to get the IO tune policies for all vms
..
Patch Set 2:
(2 comments)
https://gerrit.ovirt.org/#/c/63748/2/lib/api/vdsm-api.yml
File lib/api/vdsm-api.y
Francesco Romani has posted comments on this change.
Change subject: Add new api to get the IO tune policies for all vms
..
Patch Set 2: Code-Review-1
(5 comments)
-1 for visibility
https://gerrit.ovirt.org/#/c/63748/2/vdsm/c
Piotr Kliczewski has posted comments on this change.
Change subject: vdsm: Do not modify warnings filter in a library
..
Patch Set 2: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/64100
To unsubscribe, visit https:/
Martin Sivák has posted comments on this change.
Change subject: vdsm: Do not modify warnings filter in a library
..
Patch Set 2:
(1 comment)
https://gerrit.ovirt.org/#/c/64100/2/lib/vdsm/vdscli.py
File lib/vdsm/vdscli.py:
Li
Marcin Mirecki has posted comments on this change.
Change subject: virt: Migration plugins to enable skipping of special OVS
processing for nics
..
Patch Set 2:
(8 comments)
This was just a quick and dirty draft to show the c
gerrit-hooks has posted comments on this change.
Change subject: virt: Migration plugins to enable skipping of special OVS
processing for nics
..
Patch Set 2:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, n
Nir Soffer has posted comments on this change.
Change subject: sdm: Introduce new SDM.merge verb
..
Patch Set 2: Code-Review+1
Waiting for more reviews.
--
To view, visit https://gerrit.ovirt.org/64196
To unsubscribe, visit h
Piotr Kliczewski has posted comments on this change.
Change subject: Add new api to get the IO tune policies for all vms
..
Patch Set 2: Code-Review-1
(3 comments)
https://gerrit.ovirt.org/#/c/63748/2/lib/api/vdsm-api.yml
File
Nir Soffer has posted comments on this change.
Change subject: tests: Rename qemuimgTests.py to new Vdsm convention
..
Patch Set 2:
(1 comment)
https://gerrit.ovirt.org/#/c/64203/2/tests/Makefile.am
File tests/Makefile.am:
Li
gerrit-hooks has posted comments on this change.
Change subject: net: Setup validation for OVS - Check nics usage
..
Patch Set 1:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure hea
Edward Haas has uploaded a new change for review.
Change subject: net: Setup validation for OVS - Check nics usage
..
net: Setup validation for OVS - Check nics usage
OVS is not properly failing when adding a port that is alread
gerrit-hooks has posted comments on this change.
Change subject: stomp: use socket pending
..
Patch Set 3:
* #133::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#133::OK, public bug
* Check Product::#13
gerrit-hooks has posted comments on this change.
Change subject: stomp: use socket pending
..
Patch Set 3: -Verified
* #133::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#133::OK, public bug
* Check Produc
Piotr Kliczewski has posted comments on this change.
Change subject: stomp: use socket pending
..
Patch Set 3:
Rerun-Hooks: all
--
To view, visit https://gerrit.ovirt.org/63482
To unsubscribe, visit https://gerrit.ovirt.org/s
gerrit-hooks has posted comments on this change.
Change subject: Add new api to get the IO tune policies for all vms
..
Patch Set 2:
* #1374988::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1374988::OK, public bu
Francesco Romani has posted comments on this change.
Change subject: virt: Pass missing parameter on desktopLogoff
..
Patch Set 4: Continuous-Integration+1
--
To view, visit https://gerrit.ovirt.org/63972
To unsubscribe, visit
Francesco Romani has posted comments on this change.
Change subject: virt: Ensure uncaught exceptions on disconnect events are caught
..
Patch Set 4: Continuous-Integration+1
jenkins failure unrelated:
00:06:31.336
==
Francesco Romani has posted comments on this change.
Change subject: virt: Pass missing parameter on desktopLogoff
..
Patch Set 4:
indeed failure not related (netlink error)
--
To view, visit https://gerrit.ovirt.org/63972
To
Dan Kenigsberg has posted comments on this change.
Change subject: log: Nicer logging format
..
Patch Set 1: Code-Review-1
(1 comment)
https://gerrit.ovirt.org/#/c/64113/1/static/etc/vdsm/logger.conf.in
File static/etc/vdsm/lo
Edward Haas has posted comments on this change.
Change subject: net: edit bond detached from bridge but still attached to a vlan
..
Patch Set 11: Code-Review-1
(1 comment)
https://gerrit.ovirt.org/#/c/63723/11/tests/network/fu
Vinzenz Feenstra has posted comments on this change.
Change subject: virt: Pass missing parameter on desktopLogoff
..
Patch Set 4:
Unrelated Jenkins Error
--
To view, visit https://gerrit.ovirt.org/63972
To unsubscribe, visit
gerrit-hooks has posted comments on this change.
Change subject: config: Rename irs:scsi_settle_timeout option
..
Patch Set 2:
* Update tracker: IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no Bug-Url found.
--
To view, v
Dan Kenigsberg has posted comments on this change.
Change subject: config: Rename irs:scsi_settle_timeout option
..
Patch Set 1: Code-Review+2
Ok, I don't suppose people in the field use and depend on it.
--
To view, visit ht
Dan Kenigsberg has submitted this change and it was merged.
Change subject: config: Rename irs:scsi_settle_timeout option
..
config: Rename irs:scsi_settle_timeout option
This option is not about SCSI but about udev events. We
Petr Horáček has posted comments on this change.
Change subject: net test: shared nic between bond and network
..
Patch Set 1: Verified-1
Fails for OVS, we must fix verification and exception raising.
--
To view, visit https:
Yaniv Bronhaim has posted comments on this change.
Change subject: vdsm: Do not modify warnings filter in a library
..
Patch Set 2: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/64100
To unsubscribe, visit https://g
Dan Kenigsberg has posted comments on this change.
Change subject: vdsm: Do not modify warnings filter in a library
..
Patch Set 2: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/64100
To unsubscribe, visit https://g
Yaniv Bronhaim has posted comments on this change.
Change subject: build: Disable tests during build
..
Patch Set 3: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/63966
To unsubscribe, visit https://gerrit.ovirt.org
Petr Horáček has posted comments on this change.
Change subject: net: Split OVS setup transaction to adjust for bond setup
..
Patch Set 4:
(1 comment)
https://gerrit.ovirt.org/#/c/64118/4/lib/vdsm/network/netswitch.py
File lib
gerrit-hooks has posted comments on this change.
Change subject: net test: shared nic between bond and network
..
Patch Set 1:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
Petr Horáček has uploaded a new change for review.
Change subject: net test: shared nic between bond and network
..
net test: shared nic between bond and network
Change-Id: Ice4ead640d45d0717d2a30bd01398cbbfff3f88a
Signed-off-by
1 - 100 of 220 matches
Mail list logo
