Change in vdsm[master]: net: edit nic detached from bridge but still attached to a vlan

Edward Haas has posted comments on this change. Change subject: net: edit nic detached from bridge but still attached to a vlan .. Patch Set 2: (1 comment) https://gerrit.ovirt.org/#/c/65231/2/tests/network/func_net_basic_test

Change in vdsm[master]: net: Change classmethod to staticmethod in IPv4 and IPv6 cla...

Edward Haas has posted comments on this change. Change subject: net: Change classmethod to staticmethod in IPv4 and IPv6 classes .. Patch Set 2: It could have been a function if ipv4/6 would have been modules. Static methods pr

Change in vdsm[master]: net: Validate nameservers setup

Petr Horáček has posted comments on this change. Change subject: net: Validate nameservers setup .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/65613 To unsubscribe, visit https://gerrit.ovirt.org/set

Change in vdsm[master]: py3: make ovs_test pass

Petr Horáček has posted comments on this change. Change subject: py3: make ovs_test pass .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/65599 To unsubscribe, visit https://gerrit.ovirt.org/settings G

Change in vdsm[master]: net: Change classmethod to staticmethod in IPv4 and IPv6 cla...

Petr Horáček has posted comments on this change. Change subject: net: Change classmethod to staticmethod in IPv4 and IPv6 classes .. Patch Set 2: Why don't we just extract them into standalone functions? -- To view, visit htt

Change in vdsm[master]: net: Change classmethod to staticmethod in IPv4 and IPv6 cla...

Petr Horáček has posted comments on this change. Change subject: net: Change classmethod to staticmethod in IPv4 and IPv6 classes .. Patch Set 2: this way we just abuse staticmethods to use IPvX as a module. -- To view, visit

Change in vdsm[master]: sos: change getConnectedStoragePoolsList result key

gerrit-hooks has posted comments on this change. Change subject: sos: change getConnectedStoragePoolsList result key .. Patch Set 3: * Update Tracker::IGNORE, no bug url/s found -- To view, visit https://gerrit.ovirt.org/6355

Change in vdsm[master]: sos: change getConnectedStoragePoolsList result key

Irit Goihman has abandoned this change. Change subject: sos: change getConnectedStoragePoolsList result key .. Abandoned -- To view, visit https://gerrit.ovirt.org/63557 To unsubscribe, visit https://gerrit.ovirt.org/settings

Change in vdsm[master]: net: Change classmethod to staticmethod in IPv4 and IPv6 cla...

gerrit-hooks has posted comments on this change. Change subject: net: Change classmethod to staticmethod in IPv4 and IPv6 classes .. Patch Set 2: * Update Tracker::IGNORE, no bug url/s found * Check Bug-Url::IGNORE, not relevan

Change in vdsm[master]: net: Change classmethod to staticmethod in IPv4 and IPv6 cla...

Edward Haas has posted comments on this change. Change subject: net: Change classmethod to staticmethod in IPv4 and IPv6 classes .. Patch Set 1: (1 comment) https://gerrit.ovirt.org/#/c/65609/1//COMMIT_MSG Commit Message: Lin

Change in vdsm[master]: py3: make ovs_test pass

Dan Kenigsberg has posted comments on this change. Change subject: py3: make ovs_test pass .. Patch Set 1: Verified+1 passes in Jenkins under both py2 and py3 -- To view, visit https://gerrit.ovirt.org/65599 To unsubscribe, v

Change in vdsm[master]: after_vm_start: migrate to jsonrpcvdsli

Dan Kenigsberg has submitted this change and it was merged. Change subject: after_vm_start: migrate to jsonrpcvdsli .. after_vm_start: migrate to jsonrpcvdsli vdscli is deprecated and was replaced by jsonrpcvdsli Change-Id: I6

Change in vdsm[master]: after_vm_start: migrate to jsonrpcvdsli

gerrit-hooks has posted comments on this change. Change subject: after_vm_start: migrate to jsonrpcvdsli .. Patch Set 6: * Update Tracker::IGNORE, no bug url/s found * Set MODIFIED::IGNORE, no Bug-Url found. -- To view, visit

Change in vdsm[master]: net: Change classmethod to staticmethod in IPv4 and IPv6 cla...

Dan Kenigsberg has posted comments on this change. Change subject: net: Change classmethod to staticmethod in IPv4 and IPv6 classes .. Patch Set 1: (1 comment) https://gerrit.ovirt.org/#/c/65609/1//COMMIT_MSG Commit Message:

Change in vdsm[master]: net: Change classmethod to staticmethod in IPv4 and IPv6 cla...

Edward Haas has posted comments on this change. Change subject: net: Change classmethod to staticmethod in IPv4 and IPv6 classes .. Patch Set 1: Verified+1 -- To view, visit https://gerrit.ovirt.org/65609 To unsubscribe, visit

Change in vdsm[master]: net: Validate nameservers setup

Edward Haas has posted comments on this change. Change subject: net: Validate nameservers setup .. Patch Set 1: Verified+1 -- To view, visit https://gerrit.ovirt.org/65613 To unsubscribe, visit https://gerrit.ovirt.org/setting

Change in vdsm[master]: net: Validate nameservers setup

Edward Haas has uploaded a new change for review. Change subject: net: Validate nameservers setup .. net: Validate nameservers setup Add address validation for the nameservers setup. Change-Id: I68b8a834eabd9775178e395f643d555a

Change in vdsm[master]: net: Validate nameservers setup

gerrit-hooks has posted comments on this change. Change subject: net: Validate nameservers setup .. Patch Set 1: * Update Tracker::IGNORE, no bug url/s found * Check Bug-Url::IGNORE, not relevant for branch: master * Check Publ

Change in vdsm[master]: after_vm_start: migrate to jsonrpcvdsli

Marcin Mirecki has posted comments on this change. Change subject: after_vm_start: migrate to jsonrpcvdsli .. Patch Set 5: Verified+1 -- To view, visit https://gerrit.ovirt.org/62713 To unsubscribe, visit https://gerrit.ovirt.

Change in vdsm[master]: net: Change classmethod to staticmethod in IPv4 and IPv6 cla...

gerrit-hooks has posted comments on this change. Change subject: net: Change classmethod to staticmethod in IPv4 and IPv6 classes .. Patch Set 1: * Update Tracker::IGNORE, no bug url/s found * Check Bug-Url::IGNORE, not relevan

Change in vdsm[master]: net: Change classmethod to staticmethod in IPv4 and IPv6 cla...

Edward Haas has uploaded a new change for review. Change subject: net: Change classmethod to staticmethod in IPv4 and IPv6 classes .. net: Change classmethod to staticmethod in IPv4 and IPv6 classes Several validation methods ha

Change in vdsm[master]: Allow pinning of VM NUMA nodes to host NUMA nodes.

Martin Polednik has posted comments on this change. Change subject: Allow pinning of VM NUMA nodes to host NUMA nodes. .. Patch Set 6: (1 comment) https://gerrit.ovirt.org/#/c/65565/6/vdsm/virt/vmxml.py File vdsm/virt/vmxml.py

Change in vdsm[master]: net: edit nic detached from bridge but still attached to a vlan

Petr Horáček has posted comments on this change. Change subject: net: edit nic detached from bridge but still attached to a vlan .. Patch Set 4: Verified+1 Manually tested with physical nic. Passed network/*_test.py and functi

Change in vdsm[master]: Allow pinning of VM NUMA nodes to host NUMA nodes.

gerrit-hooks has posted comments on this change. Change subject: Allow pinning of VM NUMA nodes to host NUMA nodes. .. Patch Set 6: * Update Tracker::#1306698::OK, status: POST * Check Bug-Url::IGNORE, not relevant for branch:

Change in vdsm[master]: Allow pinning of VM NUMA nodes to host NUMA nodes.

gerrit-hooks has posted comments on this change. Change subject: Allow pinning of VM NUMA nodes to host NUMA nodes. .. Patch Set 5: * Update Tracker::#1306698::OK, status: POST * Check Bug-Url::IGNORE, not relevant for branch:

Change in vdsm[master]: Allow pinning of VM NUMA nodes to host NUMA nodes.

gerrit-hooks has posted comments on this change. Change subject: Allow pinning of VM NUMA nodes to host NUMA nodes. .. Patch Set 4: * Update Tracker::#1306698::OK, status: POST * Check Bug-Url::IGNORE, not relevant for branch:

Change in vdsm[master]: Allow pinning of VM NUMA nodes to host NUMA nodes.

gerrit-hooks has posted comments on this change. Change subject: Allow pinning of VM NUMA nodes to host NUMA nodes. .. Patch Set 3: * Update Tracker::#1306698::OK, status: POST * Check Bug-Url::IGNORE, not relevant for branch:

Change in vdsm[master]: vdsm: log proper tag for messages comming from vdsm-logrotate

Tomas Golembiovsky has posted comments on this change. Change subject: vdsm: log proper tag for messages comming from vdsm-logrotate .. Patch Set 1: CI failure unrelated: stderr: fatal: Unable to look up gerrit.ovirt.org (

Change in vdsm[master]: vdsm: report correct exit value in vdsm-logrotate

Tomas Golembiovsky has posted comments on this change. Change subject: vdsm: report correct exit value in vdsm-logrotate .. Patch Set 1: CI failure unrelated: stderr: fatal: Unable to look up gerrit.ovirt.org (port 9418) (

Change in vdsm[master]: vdsm: document why we prefer running logrotate manually

Tomas Golembiovsky has posted comments on this change. Change subject: vdsm: document why we prefer running logrotate manually .. Patch Set 4: CI failure unrelated: stderr: fatal: Unable to look up gerrit.ovirt.org (port 9

Change in vdsm[master]: vdsm: log proper tag for messages comming from vdsm-logrotate

gerrit-hooks has posted comments on this change. Change subject: vdsm: log proper tag for messages comming from vdsm-logrotate .. Patch Set 1: * Update Tracker::IGNORE, no bug url/s found * Check Bug-Url::IGNORE, not relevant f

Change in vdsm[master]: vdsm: log proper tag for messages comming from vdsm-logrotate

Tomas Golembiovsky has uploaded a new change for review. Change subject: vdsm: log proper tag for messages comming from vdsm-logrotate .. vdsm: log proper tag for messages comming from vdsm-logrotate The log messages comming fro

Change in vdsm[master]: vdsm: report correct exit value in vdsm-logrotate

gerrit-hooks has posted comments on this change. Change subject: vdsm: report correct exit value in vdsm-logrotate .. Patch Set 1: * Update Tracker::IGNORE, no bug url/s found * Check Bug-Url::IGNORE, not relevant for branch: m

Change in vdsm[master]: vdsm: report correct exit value in vdsm-logrotate

Tomas Golembiovsky has uploaded a new change for review. Change subject: vdsm: report correct exit value in vdsm-logrotate .. vdsm: report correct exit value in vdsm-logrotate The exit code was reported improperly. If all but th

Change in vdsm[master]: net: edit nic detached from bridge but still attached to a vlan

gerrit-hooks has posted comments on this change. Change subject: net: edit nic detached from bridge but still attached to a vlan .. Patch Set 4: * Update Tracker::#1372798::IGNORE, not relevant for Red Hat classification * Chec

Change in vdsm[master]: net: edit nic detached from bridge but still attached to a vlan

gerrit-hooks has posted comments on this change. Change subject: net: edit nic detached from bridge but still attached to a vlan .. Patch Set 3: * Update Tracker::#1372798::IGNORE, not relevant for Red Hat classification * Chec

Change in vdsm[master]: vdsm: document why we prefer running logrotate manually

gerrit-hooks has posted comments on this change. Change subject: vdsm: document why we prefer running logrotate manually .. Patch Set 4: * Update Tracker::#1113264::IGNORE, not relevant for Red Hat classification * Check Bug-Ur

Change in vdsm[master]: net: edit nic detached from bridge but still attached to a vlan

Petr Horáček has posted comments on this change. Change subject: net: edit nic detached from bridge but still attached to a vlan .. Patch Set 2: Verified-1 (1 comment) https://gerrit.ovirt.org/#/c/65231/2/tests/network/func_ne

Change in vdsm[master]: net: edit nic detached from bridge but still attached to a vlan

gerrit-hooks has posted comments on this change. Change subject: net: edit nic detached from bridge but still attached to a vlan .. Patch Set 2: * Update Tracker::#1372798::IGNORE, not relevant for Red Hat classification * Chec

Change in vdsm[master]: py3: make ovs_test pass

gerrit-hooks has posted comments on this change. Change subject: py3: make ovs_test pass .. Patch Set 1: * Update Tracker::IGNORE, no bug url/s found * Check Bug-Url::IGNORE, not relevant for branch: master * Check Public Bug::

Change in vdsm[master]: py3: make ovs_test pass

Dan Kenigsberg has uploaded a new change for review. Change subject: py3: make ovs_test pass .. py3: make ovs_test pass Change-Id: Id812fb7c37573ed68dd4be9f982b8ae892532c9c Signed-off-by: Dan Kenigsberg --- M tests/Makefile.am

Change in vdsm[master]: vm: introduce a `monitorable' attribute

Milan Zamazal has posted comments on this change. Change subject: vm: introduce a `monitorable' attribute .. Patch Set 2: Code-Review+1 (Except for the style check.) -- To view, visit https://gerrit.ovirt.org/65590 To unsubsc

Change in vdsm[master]: py3: fix remaining references to monitor.MonitorError as ite...

Petr Horáček has posted comments on this change. Change subject: py3: fix remaining references to monitor.MonitorError as iterable .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/64929 To unsubscribe,

Change in vdsm[master]: Add new api to get the IO tune policies for all vms

Francesco Romani has posted comments on this change. Change subject: Add new api to get the IO tune policies for all vms .. Patch Set 10: Code-Review-1 ...but my comments in vm.py still holds, so please check them. -1 for visi

Change in vdsm[master]: Add new api to get the IO tune policies for all vms

Francesco Romani has posted comments on this change. Change subject: Add new api to get the IO tune policies for all vms .. Patch Set 10: -Code-Review changed my score as per discussion in comments -- To view, visit https://g

Change in vdsm[master]: vm: introduce a `monitorable' attribute

gerrit-hooks has posted comments on this change. Change subject: vm: introduce a `monitorable' attribute .. Patch Set 2: * Update Tracker::#1382578::IGNORE, not relevant for Red Hat classification * Update Tracker::#1382583::IG

Change in vdsm[master]: vm: rename statsAge parameter

gerrit-hooks has posted comments on this change. Change subject: vm: rename statsAge parameter .. Patch Set 5: * Update Tracker::#1382578::IGNORE, not relevant for Red Hat classification * Check Bug-Url::IGNORE, not relevant fo

Change in vdsm[master]: vm: introduce a `monitorable' attribute

gerrit-hooks has posted comments on this change. Change subject: vm: introduce a `monitorable' attribute .. Patch Set 1: * Update Tracker::#1382578::IGNORE, not relevant for Red Hat classification * Update Tracker::#1382583::IG

Change in vdsm[master]: vm: introduce a `monitorable' attribute

Francesco Romani has uploaded a new change for review. Change subject: vm: introduce a `monitorable' attribute .. vm: introduce a `monitorable' attribute In the change I3e61626625a2e0517d55dc61e361f3f5eb690c00 we fixed the stats