Edward Haas has posted comments on this change. Change subject: net: Change classmethod to staticmethod in IPv4 and IPv6 classes ......................................................................
Patch Set 1: (1 comment) https://gerrit.ovirt.org/#/c/65609/1//COMMIT_MSG Commit Message: Line 9: Several validation methods have been defined as classmethods where Line 10: staticmethods seems to fit better. Line 11: Line 12: The change has been triggered by the need to validate IP addresses from Line 13: other locations, without instantiating the IPv4/IPv6 classes. > ? Right, I meant to say that it is not needed. The implicit class that is passed in is not used (to create an instance of the class). For me it is confusing, made me look all over on why it is a classmethod and not a simple staticmethod. Unless used as a factory and have others inherit from the class, I see no need to use the classmethod. But I guess you are right, it is not a must for the next patch and it may be just me being confused all the time. Will change the commit text. Line 14: (see the next nameservers validation patch) Line 15: Line 16: Change-Id: I061a33c6404198c7691d853d683e8535c38442e6 -- To view, visit https://gerrit.ovirt.org/65609 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I061a33c6404198c7691d853d683e8535c38442e6 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Edward Haas <edwa...@redhat.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Edward Haas <edwa...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Petr Horáček <phora...@redhat.com> Gerrit-Reviewer: gerrit-hooks <automat...@ovirt.org> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
