Change in vdsm[master]: drop execCmd(raw)

2017-08-05 Thread Code Review
From Dan Kenigsberg : Dan Kenigsberg has uploaded a new change for review. Change subject: drop execCmd(raw) .. drop execCmd(raw) The `raw` argument was ill-conceived, as it modified the type of the output of execCmd. Nowadays

Change in vdsm[master]: checkimages hook: avoid using execCmd(sync=False)

2017-08-05 Thread Code Review
From Dan Kenigsberg : Dan Kenigsberg has uploaded a new change for review. Change subject: checkimages hook: avoid using execCmd(sync=False) .. checkimages hook: avoid using execCmd(sync=False) I would like to move hooking.py t

Change in vdsm[master]: tool.service: avoid execCmd(raw=False)

2017-08-05 Thread Code Review
From Dan Kenigsberg : Dan Kenigsberg has uploaded a new change for review. Change subject: tool.service: avoid execCmd(raw=False) .. tool.service: avoid execCmd(raw=False) tool.service is the only place where we use raw=False t

Change in vdsm[master]: Openstacknet hooks must check provider type to run

2017-08-05 Thread Code Review
From Dan Kenigsberg : Dan Kenigsberg has posted comments on this change. Change subject: Openstacknet hooks must check provider type to run .. Patch Set 1: (3 comments) https://gerrit.ovirt.org/#/c/80155/1//COMMIT_MSG Commit

Change in vdsm[master]: drop execCmd(raw)

2017-08-05 Thread Code Review
From Dan Kenigsberg : Dan Kenigsberg has posted comments on this change. Change subject: drop execCmd(raw) .. Patch Set 2: Code-Review-1 nope, there's still plenty of code using the depending on raw=False. -- To view, visit

Change in vdsm[master]: net: Centralize call to pre-config validation

2017-08-05 Thread Code Review
From Dan Kenigsberg : Dan Kenigsberg has posted comments on this change. Change subject: net: Centralize call to pre-config validation .. Patch Set 3: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/80015 To unsubscr

Change in vdsm[master]: net: sb validator: raise on missing sb device.

2017-08-05 Thread Code Review
From Dan Kenigsberg : Dan Kenigsberg has posted comments on this change. Change subject: net: sb validator: raise on missing sb device. .. Patch Set 20: Code-Review-1 (1 comment) https://gerrit.ovirt.org/#/c/79953/20//COMMIT_