Change in vdsm[master]: asyncore: heartbeat fix

2015-03-23 Thread dkuznets
Dima Kuznetsov has posted comments on this change. Change subject: asyncore: heartbeat fix .. Patch Set 1: (1 comment) https://gerrit.ovirt.org/#/c/38988/1/lib/yajsonrpc/betterAsyncore.py File lib/yajsonrpc/betterAsyncore.py:

Change in vdsm[master]: asyncore: heartbeat fix

2015-03-22 Thread dkuznets
Dima Kuznetsov has posted comments on this change. Change subject: asyncore: heartbeat fix .. Patch Set 1: (1 comment) https://gerrit.ovirt.org/#/c/38988/1/lib/yajsonrpc/betterAsyncore.py File lib/yajsonrpc/betterAsyncore.py:

Change in vdsm[master]: vdscli: add a timeout option for plaintext connections

2015-03-22 Thread dkuznets
Dima Kuznetsov has posted comments on this change. Change subject: vdscli: add a timeout option for plaintext connections .. Patch Set 3: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/38947 To unsubscribe, visit

Change in vdsm[master]: jsonrpc: for checking the event use the class method

2015-03-19 Thread dkuznets
Dima Kuznetsov has posted comments on this change. Change subject: jsonrpc: for checking the event use the class method .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/37832 To unsubscribe, visit

Change in vdsm[master]: multiapth conf: Replace TM to OVIRT

2015-03-19 Thread dkuznets
Dima Kuznetsov has posted comments on this change. Change subject: multiapth conf: Replace TM to OVIRT .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/37966 To unsubscribe, visit

Change in vdsm[master]: asyncore: dynamic tick support

2015-03-18 Thread dkuznets
Dima Kuznetsov has posted comments on this change. Change subject: asyncore: dynamic tick support .. Patch Set 16: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/37057 To unsubscribe, visit

Change in vdsm[master]: asyncore: Move ssl buffer handling to dispatcher

2015-03-18 Thread dkuznets
Dima Kuznetsov has posted comments on this change. Change subject: asyncore: Move ssl buffer handling to dispatcher .. Patch Set 15: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/37097 To unsubscribe, visit

Change in vdsm[master]: Adding Vdsm cron job check for available packages update

2015-03-15 Thread dkuznets
Dima Kuznetsov has posted comments on this change. Change subject: Adding Vdsm cron job check for available packages update .. Patch Set 4: (2 comments) https://gerrit.ovirt.org/#/c/38401/4/vdsm/updater-tool File

Change in vdsm[master]: caps: Fix access to /sys/class/iommu

2015-03-12 Thread dkuznets
Dima Kuznetsov has uploaded a new change for review. Change subject: caps: Fix access to /sys/class/iommu .. caps: Fix access to /sys/class/iommu This patch fixes OSError during getVdsCapabilities introduced in

Change in vdsm[master]: asyncore: Move ssl buffer handling to dispatcher

2015-03-12 Thread dkuznets
Dima Kuznetsov has posted comments on this change. Change subject: asyncore: Move ssl buffer handling to dispatcher .. Patch Set 11: (1 comment) https://gerrit.ovirt.org/#/c/37097/11/lib/yajsonrpc/stompReactor.py File

Change in vdsm[master]: asyncore: dynamic tick support

2015-03-12 Thread dkuznets
Dima Kuznetsov has posted comments on this change. Change subject: asyncore: dynamic tick support .. Patch Set 11: (1 comment) https://gerrit.ovirt.org/#/c/37057/11/lib/yajsonrpc/betterAsyncore.py File

Change in vdsm[master]: asyncore: dynamic tick support

2015-03-12 Thread dkuznets
Dima Kuznetsov has posted comments on this change. Change subject: asyncore: dynamic tick support .. Patch Set 12: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/37057 To unsubscribe, visit

Change in vdsm[master]: asyncore: Move generic reactor functionality

2015-03-12 Thread dkuznets
Dima Kuznetsov has posted comments on this change. Change subject: asyncore: Move generic reactor functionality .. Patch Set 12: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/37055 To unsubscribe, visit

Change in vdsm[master]: caps: Fix access to /sys/class/iommu

2015-03-12 Thread dkuznets
Dima Kuznetsov has posted comments on this change. Change subject: caps: Fix access to /sys/class/iommu .. Patch Set 1: Verified+1 I encountered this on a CentOS 6 although it is probably more related to what HW the kernel

Change in vdsm[master]: virt: Do not count time spent on migrationCreate against tim...

2015-03-12 Thread dkuznets
Dima Kuznetsov has posted comments on this change. Change subject: virt: Do not count time spent on migrationCreate against timeout .. Patch Set 4: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/38397 To

Change in vdsm[master]: caps: Fix access to /sys/class/iommu

2015-03-12 Thread dkuznets
Dima Kuznetsov has posted comments on this change. Change subject: caps: Fix access to /sys/class/iommu .. Patch Set 1: As long as master is built for el6 (and we even have official nightlies) we should not make such

Change in vdsm[master]: asyncore: Move generic reactor functionality

2015-03-11 Thread dkuznets
Dima Kuznetsov has posted comments on this change. Change subject: asyncore: Move generic reactor functionality .. Patch Set 11: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/37055 To unsubscribe, visit

Change in vdsm[master]: Adding Vdsm cron job check for available packages update

2015-03-11 Thread dkuznets
Dima Kuznetsov has posted comments on this change. Change subject: Adding Vdsm cron job check for available packages update .. Patch Set 3: (7 comments) https://gerrit.ovirt.org/#/c/38401/3/vdsm/updater-tool File

Change in vdsm[master]: Introducing getAvailableUpdates API

2015-03-11 Thread dkuznets
Dima Kuznetsov has posted comments on this change. Change subject: Introducing getAvailableUpdates API .. Patch Set 1: (1 comment) https://gerrit.ovirt.org/#/c/38559/1/vdsm/API.py File vdsm/API.py: Line 1305: Return

Change in vdsm[master]: signals: Handle signals to non-main threads

2015-02-10 Thread dkuznets
Dima Kuznetsov has posted comments on this change. Change subject: signals: Handle signals to non-main threads .. Patch Set 26: Removed double 'done' output on tests -- To view, visit http://gerrit.ovirt.org/29392 To

Change in vdsm[master]: signals: Handle signals to non-main threads

2015-02-10 Thread dkuznets
Dima Kuznetsov has posted comments on this change. Change subject: signals: Handle signals to non-main threads .. Patch Set 26: Verified+1 verified by adding manually to engine and restarting vdsmd and supervdsmd several

Change in vdsm[master]: signals: Handle signals to non-main threads

2015-01-19 Thread dkuznets
Dima Kuznetsov has posted comments on this change. Change subject: signals: Handle signals to non-main threads .. Patch Set 24: (7 comments) http://gerrit.ovirt.org/#/c/29392/24/lib/vdsm/infra/sigutils/tests.py File

Change in vdsm[master]: bridge: Make VdsmError more verbose

2015-01-19 Thread dkuznets
Dima Kuznetsov has posted comments on this change. Change subject: bridge: Make VdsmError more verbose .. Patch Set 2: (2 comments) http://gerrit.ovirt.org/#/c/37015/2//COMMIT_MSG Commit Message: Line 4: Commit: Dima

Change in vdsm[master]: packaging: Move libvirt_password out of PKI

2015-01-19 Thread dkuznets
Dima Kuznetsov has uploaded a new change for review. Change subject: packaging: Move libvirt_password out of PKI .. packaging: Move libvirt_password out of PKI New location is /etc/vdsm/libvirt_password Bug-Url:

Change in vdsm[master]: bridge: Make VdsmError more verbose

2015-01-18 Thread dkuznets
Dima Kuznetsov has uploaded a new change for review. Change subject: bridge: Make VdsmError more verbose .. bridge: Make VdsmError more verbose Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1181646 Change-Id:

Change in vdsm[master]: spec: only gluster requires blivet

2015-01-18 Thread dkuznets
Dima Kuznetsov has posted comments on this change. Change subject: spec: only gluster requires blivet .. Patch Set 1: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/37010 To unsubscribe, visit

Change in vdsm[master]: bridge: Make VdsmError more verbose

2015-01-18 Thread dkuznets
Dima Kuznetsov has posted comments on this change. Change subject: bridge: Make VdsmError more verbose .. Patch Set 1: (1 comment) http://gerrit.ovirt.org/#/c/37015/1/vdsm/rpc/Bridge.py File vdsm/rpc/Bridge.py: Line 33:

Change in vdsm[master]: spec: Unlist remove file from spec file

2015-01-17 Thread dkuznets
Dima Kuznetsov has uploaded a new change for review. Change subject: spec: Unlist remove file from spec file .. spec: Unlist remove file from spec file Patch http://gerrit.ovirt.org/#/c/36711/ removed

Change in vdsm[master]: jsonrpc: regression on setupNetworks

2015-01-06 Thread dkuznets
Dima Kuznetsov has posted comments on this change. Change subject: jsonrpc: regression on setupNetworks .. Patch Set 1: Verified+1 Code-Review+1 This works for me, added host to to engine, setup networks completed

Change in vdsm[master]: signals: Handle signals to non-main threads

2015-01-05 Thread dkuznets
Dima Kuznetsov has posted comments on this change. Change subject: signals: Handle signals to non-main threads .. Patch Set 24: Verified+1 -- To view, visit http://gerrit.ovirt.org/29392 To unsubscribe, visit

Change in vdsm[master]: signals: Handle signals to non-main threads

2015-01-05 Thread dkuznets
Dima Kuznetsov has posted comments on this change. Change subject: signals: Handle signals to non-main threads .. Patch Set 23: (2 comments) http://gerrit.ovirt.org/#/c/29392/23/lib/vdsm/infra/sigutils/__init__.py File

Change in vdsm[master]: signals: Handle signals to non-main threads

2015-01-05 Thread dkuznets
Dima Kuznetsov has posted comments on this change. Change subject: signals: Handle signals to non-main threads .. Patch Set 24: Rebased and fixed imports, verified as above. -- To view, visit http://gerrit.ovirt.org/29392 To

Change in vdsm[master]: tool: configurator module names optional, defaults to file n...

2015-01-05 Thread dkuznets
Dima Kuznetsov has posted comments on this change. Change subject: tool: configurator module names optional, defaults to file name. .. Patch Set 9: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/34099 To unsubscribe,

Change in vdsm[master]: signals: Handle signals to non-main threads

2015-01-04 Thread dkuznets
Dima Kuznetsov has posted comments on this change. Change subject: signals: Handle signals to non-main threads .. Patch Set 23: Verified+1 Verified by connecting vdsm to engine, both vdsmd and supervdsmd respond to signals

Change in vdsm[master]: qemu-img: Allow creation of zero-sized volumes

2014-12-29 Thread dkuznets
Dima Kuznetsov has posted comments on this change. Change subject: qemu-img: Allow creation of zero-sized volumes .. Patch Set 2: Verified+1 Verified by running unit tests and creating a disk over NFS storaged domain -- To

Change in vdsm[master]: jsonrpc: Cache attributes for AsyncoreDispatcher

2014-12-28 Thread dkuznets
Dima Kuznetsov has posted comments on this change. Change subject: jsonrpc: Cache attributes for AsyncoreDispatcher .. Patch Set 2: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/35252 To unsubscribe, visit

Change in vdsm[master]: infra: Switch utils calls to filecontrol

2014-12-28 Thread dkuznets
Dima Kuznetsov has posted comments on this change. Change subject: infra: Switch utils calls to filecontrol .. Patch Set 4: Verified+1 Verified by: * Installing vdsm on the hypervisor (acting as SPM) connected to the engine. *

Change in vdsm[master]: signals: Handle signals to non-main threads

2014-12-28 Thread dkuznets
Dima Kuznetsov has posted comments on this change. Change subject: signals: Handle signals to non-main threads .. Patch Set 20: (3 comments) http://gerrit.ovirt.org/#/c/29392/20/lib/vdsm/infra/sigutils/__init__.py File

Change in vdsm[master]: signals: Handle signals to non-main threads

2014-12-28 Thread dkuznets
Dima Kuznetsov has posted comments on this change. Change subject: signals: Handle signals to non-main threads .. Patch Set 21: Changed comments as suggested by Nir and Yaniv. -- To view, visit http://gerrit.ovirt.org/29392

Change in vdsm[master]: spec: Enable vhostmd on non-koji Fedora builds

2014-12-28 Thread dkuznets
Dima Kuznetsov has posted comments on this change. Change subject: spec: Enable vhostmd on non-koji Fedora builds .. Patch Set 4: Verified+1 Verified by building rpms on both el6 and fc20, while modifying %global

Change in vdsm[master]: signals: Handle signals to non-main threads

2014-12-28 Thread dkuznets
Dima Kuznetsov has posted comments on this change. Change subject: signals: Handle signals to non-main threads .. Patch Set 22: (1 comment) http://gerrit.ovirt.org/#/c/29392/22/vdsm/supervdsmServer File vdsm/supervdsmServer:

Change in vdsm[master]: signals: Handle signals to non-main threads

2014-12-28 Thread dkuznets
Dima Kuznetsov has posted comments on this change. Change subject: signals: Handle signals to non-main threads .. Patch Set 22: (1 comment) http://gerrit.ovirt.org/#/c/29392/22/vdsm/supervdsmServer File vdsm/supervdsmServer:

Change in vdsm[master]: qemu-img: Allow creation of zero-sized volumes

2014-12-24 Thread dkuznets
Dima Kuznetsov has posted comments on this change. Change subject: qemu-img: Allow creation of zero-sized volumes .. Patch Set 1: (1 comment) http://gerrit.ovirt.org/#/c/36276/1//COMMIT_MSG Commit Message: Line 5:

Change in vdsm[master]: qemu-img: Allow creation of zero-sized volumes

2014-12-24 Thread dkuznets
Dima Kuznetsov has posted comments on this change. Change subject: qemu-img: Allow creation of zero-sized volumes .. Patch Set 1: (1 comment) http://gerrit.ovirt.org/#/c/36276/1/lib/vdsm/qemuimg.py File lib/vdsm/qemuimg.py:

Change in vdsm[master]: Adding %configure option for rhev_build

2014-12-23 Thread dkuznets
Dima Kuznetsov has posted comments on this change. Change subject: Adding %configure option for rhev_build .. Patch Set 1: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/36351 To unsubscribe, visit

Change in vdsm[master]: infra: Switch utils calls to filecontrol

2014-12-23 Thread dkuznets
Dima Kuznetsov has posted comments on this change. Change subject: infra: Switch utils calls to filecontrol .. Patch Set 4: Verified+1 Verified by running make rpm. Included tests passed and vdsm-infra rpm contained the

Change in vdsm[master]: oopTests: Use monkeypatch for changing idle time

2014-12-23 Thread dkuznets
Dima Kuznetsov has posted comments on this change. Change subject: oopTests: Use monkeypatch for changing idle time .. Patch Set 1: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/36337 To unsubscribe, visit

Change in vdsm[master]: qemu-img: Allow creation of zero-sized volumes

2014-12-23 Thread dkuznets
Dima Kuznetsov has posted comments on this change. Change subject: qemu-img: Allow creation of zero-sized volumes .. Patch Set 1: (1 comment) http://gerrit.ovirt.org/#/c/36276/1/lib/vdsm/qemuimg.py File lib/vdsm/qemuimg.py:

Change in vdsm[master]: qemu-img: Allow creation of zero-sized volumes

2014-12-23 Thread dkuznets
Dima Kuznetsov has posted comments on this change. Change subject: qemu-img: Allow creation of zero-sized volumes .. Patch Set 1: (1 comment) http://gerrit.ovirt.org/#/c/36276/1//COMMIT_MSG Commit Message: Line 5:

Change in vdsm[master]: infra: Switch utils calls to filecontrol

2014-12-23 Thread dkuznets
Dima Kuznetsov has posted comments on this change. Change subject: infra: Switch utils calls to filecontrol .. Patch Set 4: -Verified -- To view, visit http://gerrit.ovirt.org/35919 To unsubscribe, visit

Change in vdsm[master]: infra: Add filecontrol module

2014-12-23 Thread dkuznets
Dima Kuznetsov has posted comments on this change. Change subject: infra: Add filecontrol module .. Patch Set 4: Verified+1 Verified by running make rpm. Included tests passed and vdsm-infra rpm contained the files.

Change in vdsm[master]: api: compat: fix api breakage of 'config' and 'netinfo' used...

2014-12-22 Thread dkuznets
Dima Kuznetsov has posted comments on this change. Change subject: api: compat: fix api breakage of 'config' and 'netinfo' used by bootstrap .. Patch Set 7: (1 comment) http://gerrit.ovirt.org/#/c/35721/7/vdsm.spec.in File

Change in vdsm[master]: api: compat: fix api breakage of 'config' and 'netinfo' used...

2014-12-22 Thread dkuznets
Dima Kuznetsov has posted comments on this change. Change subject: api: compat: fix api breakage of 'config' and 'netinfo' used by bootstrap .. Patch Set 8: Verified+1 Changed tab to spaces in vdsm.spec.in and verified same

Change in vdsm[master]: spec: Enable vhostmd on non-koji Fedora builds

2014-12-21 Thread dkuznets
Dima Kuznetsov has uploaded a new change for review. Change subject: spec: Enable vhostmd on non-koji Fedora builds .. spec: Enable vhostmd on non-koji Fedora builds Change-Id: Ie0bbca861f60d28bb23404b70888321f90ab101a

Change in vdsm[master]: api: compat: fix api breakage of 'config' and 'netinfo' used...

2014-12-21 Thread dkuznets
Dima Kuznetsov has posted comments on this change. Change subject: api: compat: fix api breakage of 'config' and 'netinfo' used by bootstrap .. Patch Set 5: (1 comment) http://gerrit.ovirt.org/#/c/35721/5/configure.ac File

Change in vdsm[master]: Using with_rhev flag in spec to configure rhev changes if re...

2014-12-21 Thread dkuznets
Dima Kuznetsov has posted comments on this change. Change subject: Using with_rhev flag in spec to configure rhev changes if required .. Patch Set 10: (3 comments) http://gerrit.ovirt.org/#/c/35722/10//COMMIT_MSG Commit

Change in vdsm[master]: api: compat: fix api breakage of 'config' and 'netinfo' used...

2014-12-21 Thread dkuznets
Dima Kuznetsov has posted comments on this change. Change subject: api: compat: fix api breakage of 'config' and 'netinfo' used by bootstrap .. Patch Set 7: Verified+1 Verified by creating rpms and checking contents: $

Change in vdsm[master]: Using with_rhev flag in spec to configure rhev changes if re...

2014-12-21 Thread dkuznets
Dima Kuznetsov has posted comments on this change. Change subject: Using with_rhev flag in spec to configure rhev changes if required .. Patch Set 12: Verified+1 Verified by running `make rpm` and checking Requires fields.

Change in vdsm[master]: utils: move nice ionice sid and sudo out of execCmd

2014-12-20 Thread dkuznets
Dima Kuznetsov has posted comments on this change. Change subject: utils: move nice ionice sid and sudo out of execCmd .. Patch Set 4: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/33691 To unsubscribe, visit

Change in vdsm[master]: qemu-img: Allow creation of zero-sized volumes

2014-12-18 Thread dkuznets
Dima Kuznetsov has uploaded a new change for review. Change subject: qemu-img: Allow creation of zero-sized volumes .. qemu-img: Allow creation of zero-sized volumes In previous version if size is zero it was omitted from the

Change in vdsm[master]: qemu-img: Allow creation of zero-sized volumes

2014-12-18 Thread dkuznets
Dima Kuznetsov has posted comments on this change. Change subject: qemu-img: Allow creation of zero-sized volumes .. Patch Set 1: By default size=None because it is not needed on all create commands like: qemu-img create -b

Change in vdsm[master]: qemu-img: Allow creation of zero-sized volumes

2014-12-18 Thread dkuznets
Dima Kuznetsov has posted comments on this change. Change subject: qemu-img: Allow creation of zero-sized volumes .. Patch Set 1: Size must be passed if not using backing file, but passing size=0 is not distinguished from

Change in vdsm[master]: qemu-img: Allow creation of zero-sized volumes

2014-12-18 Thread dkuznets
Dima Kuznetsov has posted comments on this change. Change subject: qemu-img: Allow creation of zero-sized volumes .. Patch Set 1: AFAIU -- To view, visit http://gerrit.ovirt.org/36276 To unsubscribe, visit

Change in vdsm[master]: doc: Remove create_sl.sh

2014-12-17 Thread dkuznets
Dima Kuznetsov has posted comments on this change. Change subject: doc: Remove create_sl.sh .. Patch Set 1: Verified+1 Verified by running make rpm, make check, and make html inside doc/ on fc20 -- To view, visit

Change in vdsm[master]: doc: Add index for vdsm-infra package

2014-12-17 Thread dkuznets
Dima Kuznetsov has posted comments on this change. Change subject: doc: Add index for vdsm-infra package .. Patch Set 1: Verified+1 Verified by running make rpm, make check, and make html inside doc/. Generated html had infra

Change in vdsm[master]: api: compat: fix api breakage of 'config' and 'netinfo' used...

2014-12-17 Thread dkuznets
Dima Kuznetsov has posted comments on this change. Change subject: api: compat: fix api breakage of 'config' and 'netinfo' used by bootstrap .. Patch Set 4: (2 comments) http://gerrit.ovirt.org/#/c/35721/4/Makefile.am File

Change in vdsm[master]: infra: Add filecontrol module

2014-12-17 Thread dkuznets
Dima Kuznetsov has posted comments on this change. Change subject: infra: Add filecontrol module .. Patch Set 4: (1 comment) http://gerrit.ovirt.org/#/c/35918/4/lib/vdsm/infra/filecontrol/tests.py File

Change in vdsm[master]: Using with_rhev flag in spec to configure rhev changes if re...

2014-12-17 Thread dkuznets
Dima Kuznetsov has posted comments on this change. Change subject: Using with_rhev flag in spec to configure rhev changes if required .. Patch Set 9: (2 comments) http://gerrit.ovirt.org/#/c/35722/9/vdsm.spec.in File

Change in vdsm[master]: infra: Add filecontrol module

2014-12-08 Thread dkuznets
Dima Kuznetsov has posted comments on this change. Change subject: infra: Add filecontrol module .. Patch Set 3: (1 comment) http://gerrit.ovirt.org/#/c/35918/3/lib/vdsm/infra/filecontrol/__init__.py File

Change in vdsm[master]: infra: Switch utils calls to filecontrol

2014-12-07 Thread dkuznets
Dima Kuznetsov has uploaded a new change for review. Change subject: infra: Switch utils calls to filecontrol .. infra: Switch utils calls to filecontrol Change all call to functions moved to filecontrol to appropriate module

Change in vdsm[master]: doc: Add index for vdsm-infra package

2014-12-07 Thread dkuznets
Dima Kuznetsov has uploaded a new change for review. Change subject: doc: Add index for vdsm-infra package .. doc: Add index for vdsm-infra package Change-Id: I2cfc59ad59dbec52173d70ff320259cbdd95d77f Signed-off-by: Dima

Change in vdsm[master]: Add filecontrol module

2014-12-07 Thread dkuznets
Dima Kuznetsov has uploaded a new change for review. Change subject: Add filecontrol module .. Add filecontrol module Added module with fcntl convenience functions Change-Id: I4f455711d81e84db600647a2d5d80a5e7cadd5e2

Change in vdsm[master]: jsonrpc: Cache attributes for AsyncoreDispatcher

2014-12-07 Thread dkuznets
Dima Kuznetsov has posted comments on this change. Change subject: jsonrpc: Cache attributes for AsyncoreDispatcher .. Patch Set 2: See my comment on patch set 1 -- To view, visit http://gerrit.ovirt.org/35252 To

Change in vdsm[master]: hooks: Include sudoers file in ethtool_options rpm

2014-12-01 Thread dkuznets
Dima Kuznetsov has posted comments on this change. Change subject: hooks: Include sudoers file in ethtool_options rpm .. Patch Set 2: Ok, I'll drop the changes, and remove sudoers file (along with its install rules)? -- To

Change in vdsm[master]: supervdsm: enable coredumping

2014-11-30 Thread dkuznets
Dima Kuznetsov has posted comments on this change. Change subject: supervdsm: enable coredumping .. Patch Set 3: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/35480 To unsubscribe, visit

Change in vdsm[master]: packaging: Branding and spec file changes for downstream

2014-11-30 Thread dkuznets
Hello Douglas Schilling Landgraf, Eyal Edri, Yaniv Bronhaim, Federico Simoncelli, I'd like you to do a code review. Please visit http://gerrit.ovirt.org/35722 to review the following change. Change subject: packaging: Branding and spec file changes for downstream

Change in vdsm[master]: api: compat: fix api breakage of 'config' and 'netinfo' used...

2014-11-30 Thread dkuznets
Hello Douglas Schilling Landgraf, I'd like you to do a code review. Please visit http://gerrit.ovirt.org/35721 to review the following change. Change subject: api: compat: fix api breakage of 'config' and 'netinfo' used by bootstrap

Change in vdsm[master]: hooks: Include sudoers file in ethtool_options rpm

2014-11-30 Thread dkuznets
Dima Kuznetsov has uploaded a new change for review. Change subject: hooks: Include sudoers file in ethtool_options rpm .. hooks: Include sudoers file in ethtool_options rpm The hook contained the file and the rules to install

Change in vdsm[master]: Remove orphaned files

2014-11-30 Thread dkuznets
Dima Kuznetsov has posted comments on this change. Change subject: Remove orphaned files .. Patch Set 1: Verified+1 git grep $FILENAME shows nothing -- To view, visit http://gerrit.ovirt.org/35724 To unsubscribe, visit

Change in vdsm[master]: hooks: Include sudoers file in ethtool_options rpm

2014-11-30 Thread dkuznets
Dima Kuznetsov has posted comments on this change. Change subject: hooks: Include sudoers file in ethtool_options rpm .. Patch Set 2: Replaced trailing tabs with spaces -- To view, visit http://gerrit.ovirt.org/35725 To

Change in vdsm[master]: vdsm: check libvirt availability at startup

2014-11-27 Thread dkuznets
Dima Kuznetsov has posted comments on this change. Change subject: vdsm: check libvirt availability at startup .. Patch Set 2: (1 comment) http://gerrit.ovirt.org/#/c/35596/2/vdsm/vdsm File vdsm/vdsm: Line 83: conn =

Change in vdsm[master]: jsonrpc: Cache attributes for AsyncoreDispatcher

2014-11-24 Thread dkuznets
Dima Kuznetsov has posted comments on this change. Change subject: jsonrpc: Cache attributes for AsyncoreDispatcher .. Patch Set 1: (1 comment) http://gerrit.ovirt.org/#/c/35252/1/lib/yajsonrpc/betterAsyncore.py File

Change in vdsm[master]: jsonrpc: add ability to get dictionary directly from JsonRpc...

2014-11-24 Thread dkuznets
Dima Kuznetsov has posted comments on this change. Change subject: jsonrpc: add ability to get dictionary directly from JsonRpcRequest .. Patch Set 1: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/35254 To

Change in vdsm[master]: jsonrpc: Optimize stomp encoder\decoder

2014-11-24 Thread dkuznets
Dima Kuznetsov has posted comments on this change. Change subject: jsonrpc: Optimize stomp encoder\decoder .. Patch Set 1: (1 comment) http://gerrit.ovirt.org/#/c/35255/1/lib/yajsonrpc/stomp.py File lib/yajsonrpc/stomp.py:

Change in vdsm[master]: tests: Fix API change in sourceroute.py

2014-11-24 Thread dkuznets
Dima Kuznetsov has uploaded a new change for review. Change subject: tests: Fix API change in sourceroute.py .. tests: Fix API change in sourceroute.py Fix signature change introduced in http://gerrit.ovirt.org/#/c/34067

Change in vdsm[master]: Add sourceroutingTests and qosTests to make check

2014-11-24 Thread dkuznets
Dima Kuznetsov has uploaded a new change for review. Change subject: Add sourceroutingTests and qosTests to make check .. Add sourceroutingTests and qosTests to make check Change-Id: I8cc5a628516b59723575e0cfcf569a1aa99b6602

Change in vdsm[master]: tests: Fix API change in sourceroute.py

2014-11-24 Thread dkuznets
Dima Kuznetsov has posted comments on this change. Change subject: tests: Fix API change in sourceroute.py .. Patch Set 1: Verified+1 ran make check and make rpm -- To view, visit http://gerrit.ovirt.org/35478 To

Change in vdsm[master]: tests: Add sourceroutingTests and qosTests to make check

2014-11-24 Thread dkuznets
Dima Kuznetsov has posted comments on this change. Change subject: tests: Add sourceroutingTests and qosTests to make check .. Patch Set 3: verified by running make check and make rpm -- To view, visit

Change in vdsm[master]: tests: Add sourceroutingTests and qosTests to make check

2014-11-24 Thread dkuznets
Dima Kuznetsov has posted comments on this change. Change subject: tests: Add sourceroutingTests and qosTests to make check .. Patch Set 3: Verified+1 -- To view, visit http://gerrit.ovirt.org/35479 To unsubscribe, visit

Change in vdsm[master]: oopTests: replace 'if None' with try except clause

2014-11-17 Thread dkuznets
Dima Kuznetsov has posted comments on this change. Change subject: oopTests: replace 'if None' with try except clause .. Patch Set 1: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/35243 To unsubscribe, visit

Change in vdsm[master]: jsonrpc: switch to the simplejson module

2014-11-12 Thread dkuznets
Dima Kuznetsov has posted comments on this change. Change subject: jsonrpc: switch to the simplejson module .. Patch Set 3: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/35024 To unsubscribe, visit

Change in vdsm[master]: Makefile: add whitelist files to pyflakes and pep8 check

2014-11-12 Thread dkuznets
Dima Kuznetsov has posted comments on this change. Change subject: Makefile: add whitelist files to pyflakes and pep8 check .. Patch Set 2: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/27025 To unsubscribe, visit

Change in vdsm[master]: vdsm-reg: Fix closed log file descriptors

2014-11-11 Thread dkuznets
Dima Kuznetsov has posted comments on this change. Change subject: vdsm-reg: Fix closed log file descriptors .. Patch Set 3: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/34981 To unsubscribe, visit

Change in vdsm[master]: jsonrpc: switch to the simplejson module

2014-11-11 Thread dkuznets
Dima Kuznetsov has posted comments on this change. Change subject: jsonrpc: switch to the simplejson module .. Patch Set 2: (1 comment) http://gerrit.ovirt.org/#/c/35024/2/lib/yajsonrpc/__init__.py File

Change in vdsm[ovirt-3.5]: supervdsm: Add zombiereaper to supervdsm

2014-11-10 Thread dkuznets
Dima Kuznetsov has uploaded a new change for review. Change subject: supervdsm: Add zombiereaper to supervdsm .. supervdsm: Add zombiereaper to supervdsm Supervdsm uses multiprocessing.Process to impersonate other users and

Change in vdsm[ovirt-3.5]: supervdsm: Add zombiereaper to supervdsm

2014-11-10 Thread dkuznets
Dima Kuznetsov has posted comments on this change. Change subject: supervdsm: Add zombiereaper to supervdsm .. Patch Set 2: Verified+1 Verified same as upstream patch: added to engine with storage, checked there is a defunct

Change in vdsm[master]: utils: move nice ionice sid and sudo out of execCmd

2014-11-10 Thread dkuznets
Dima Kuznetsov has posted comments on this change. Change subject: utils: move nice ionice sid and sudo out of execCmd .. Patch Set 2: No review material yet but I talked with Saggi about doing the same, I wanted to go with

Change in vdsm[master]: supervdsm: Add zombiereaper to supervdsm

2014-11-09 Thread dkuznets
Dima Kuznetsov has posted comments on this change. Change subject: supervdsm: Add zombiereaper to supervdsm .. Patch Set 21: Verified+1 Checked on EL6, added host to engine and added an nfs storage domain, supervdsm spawned a

Change in vdsm[master]: tests: Avoid printing objects that reference None

2014-11-09 Thread dkuznets
Dima Kuznetsov has uploaded a new change for review. Change subject: tests: Avoid printing objects that reference None .. tests: Avoid printing objects that reference None One of the current ioprocess tests checks who holds

Change in vdsm[master]: vdsm-reg: make vdsm-reg-setup PEP8-happy

2014-11-09 Thread dkuznets
Dima Kuznetsov has uploaded a new change for review. Change subject: vdsm-reg: make vdsm-reg-setup PEP8-happy .. vdsm-reg: make vdsm-reg-setup PEP8-happy Change-Id: Ibd9487677aae58b0dd401aed597b37dfa1fb5401 Signed-off-by: Dima

<    1   2   3   4   5   >