Change in vdsm[master]: virt: migration: switch to concurrent.thread()

Francesco Romani has posted comments on this change. Change subject: virt: migration: switch to concurrent.thread() .. Patch Set 3: Code-Review-1 (3 comments) https://gerrit.ovirt.org/#/c/61463/3/vdsm/virt/migration.py File

Change in vdsm[ovirt-4.0]: automation: use 4.0 repos

Francesco Romani has posted comments on this change. Change subject: automation: use 4.0 repos .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/61969 To unsubscribe, visit

Change in vdsm[ovirt-3.6]: automation: use 3.6 repos

Francesco Romani has posted comments on this change. Change subject: automation: use 3.6 repos .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/61970 To unsubscribe, visit

Change in vdsm[master]: Moving vmstatus to vdsm.common.virt

Francesco Romani has posted comments on this change. Change subject: Moving vmstatus to vdsm.common.virt .. Patch Set 12: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/57820 To unsubscribe, visit

Change in vdsm[master]: configs: move systemd service files to static

Francesco Romani has posted comments on this change. Change subject: configs: move systemd service files to static .. Patch Set 9: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/61763 To unsubscribe, visit

Change in vdsm[master]: configs: move kernel module loading to static

Francesco Romani has posted comments on this change. Change subject: configs: move kernel module loading to static .. Patch Set 10: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/61617 To unsubscribe, visit

Change in vdsm[master]: configs: move sysctl to static

Francesco Romani has posted comments on this change. Change subject: configs: move sysctl to static .. Patch Set 11: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/61619 To unsubscribe, visit

Change in vdsm[master]: configs: move limits to static

Francesco Romani has posted comments on this change. Change subject: configs: move limits to static .. Patch Set 11: (1 comment) https://gerrit.ovirt.org/#/c/61605/11/static/Makefile.am File static/Makefile.am: Line 61:

Change in vdsm[master]: configs: move rwtab to static

Francesco Romani has posted comments on this change. Change subject: configs: move rwtab to static .. Patch Set 10: Code-Review+1 ok with the move and this patch seems OK, but I wonder if this file is still relevant -- To

Change in vdsm[master]: configs: move logrotate to static

Francesco Romani has posted comments on this change. Change subject: configs: move logrotate to static .. Patch Set 10: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/61616 To unsubscribe, visit

Change in vdsm[master]: configs: move limits to static

Francesco Romani has posted comments on this change. Change subject: configs: move limits to static .. Patch Set 11: Code-Review+1 (1 comment) seems OK, but please check the inline question

Change in vdsm[master]: configs: move sudoers to static

Francesco Romani has posted comments on this change. Change subject: configs: move sudoers to static .. Patch Set 11: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/61603 To unsubscribe, visit

Change in vdsm[master]: configs: move mom to static

Francesco Romani has posted comments on this change. Change subject: configs: move mom to static .. Patch Set 11: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/61602 To unsubscribe, visit

Change in vdsm[master]: configs: move logger to static

Francesco Romani has posted comments on this change. Change subject: configs: move logger to static .. Patch Set 8: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/61601 To unsubscribe, visit

Change in vdsm[master]: jsonrpc: Fix toDict method when error is present

Francesco Romani has posted comments on this change. Change subject: jsonrpc: Fix toDict method when error is present .. Patch Set 3: Code-Review-1 -1 for visibility only -- To view, visit https://gerrit.ovirt.org/60491 To

Change in vdsm[master]: jsonrpc: Fix toDict method when error is present

Francesco Romani has posted comments on this change. Change subject: jsonrpc: Fix toDict method when error is present .. Patch Set 3: not sure this is a good direction. On which case do you need this? Do you still need also

Change in vdsm[master]: Add all MOM calls to jsonrpc client

Francesco Romani has posted comments on this change. Change subject: Add all MOM calls to jsonrpc client .. Patch Set 5: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/60492 To unsubscribe, visit

Change in vdsm[master]: Rename reports to metrics

Francesco Romani has posted comments on this change. Change subject: Rename reports to metrics .. Patch Set 3: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/61870 To unsubscribe, visit

Change in vdsm[master]: rng: allow urandom as virtio rng entropy source

Francesco Romani has posted comments on this change. Change subject: rng: allow urandom as virtio rng entropy source .. Patch Set 7: Code-Review-1 I find the linked discussion enlightening, I'm fine with the concept and I

Change in vdsm[master]: hostdev: prefer numa nodes close to device MMIO

Francesco Romani has posted comments on this change. Change subject: hostdev: prefer numa nodes close to device MMIO .. Patch Set 6: Code-Review-1 (1 comment) looks fine (hence +2 pending), but I have one question, so I -1'd

Change in vdsm[master]: vmxml: move condition from appendNumaTune to buildDomainXML

Francesco Romani has posted comments on this change. Change subject: vmxml: move condition from appendNumaTune to buildDomainXML .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/61929 To unsubscribe,

Change in vdsm[master]: hostdev: report device MMIO numa node

Francesco Romani has posted comments on this change. Change subject: hostdev: report device MMIO numa node .. Patch Set 6: Code-Review-1 (1 comment) -1 for visibility only, I'd like an improvement of the commit message (more

Change in vdsm[master]: rng: allow urandom as virtio rng entropy source

Francesco Romani has posted comments on this change. Change subject: rng: allow urandom as virtio rng entropy source .. Patch Set 5: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/59031 To unsubscribe, visit

Change in vdsm[master]: Send vm info report each sampling interval from VMBulkSampler

Francesco Romani has posted comments on this change. Change subject: Send vm info report each sampling interval from VMBulkSampler .. Patch Set 14: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/59523 To

Change in vdsm[master]: Rename reports to metrics

Francesco Romani has posted comments on this change. Change subject: Rename reports to metrics .. Patch Set 2: Code-Review+2 mostly virt domain, so taking ownership -> +2 -- To view, visit https://gerrit.ovirt.org/61870 To

Change in vdsm[master]: configs: move kernel module loading to static

Francesco Romani has posted comments on this change. Change subject: configs: move kernel module loading to static .. Patch Set 6: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/61617 To unsubscribe, visit

Change in vdsm[master]: configs: move logrotate to static

Francesco Romani has posted comments on this change. Change subject: configs: move logrotate to static .. Patch Set 6: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/61616 To unsubscribe, visit

Change in vdsm[master]: configs: move systemd service files to static

Francesco Romani has posted comments on this change. Change subject: configs: move systemd service files to static .. Patch Set 3: Code-Review-1 (1 comment) -1 for visibility only

Change in vdsm[master]: confis: move modprobe files loading to static

Francesco Romani has posted comments on this change. Change subject: confis: move modprobe files loading to static .. Patch Set 3: (1 comment) https://gerrit.ovirt.org/#/c/61762/3//COMMIT_MSG Commit Message: PS3, Line 7:

Change in vdsm[master]: confis: move modprobe files loading to static

Francesco Romani has posted comments on this change. Change subject: confis: move modprobe files loading to static .. Patch Set 3: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/61762 To unsubscribe, visit

Change in vdsm[master]: configs: move sysctl to static

Francesco Romani has posted comments on this change. Change subject: configs: move sysctl to static .. Patch Set 7: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/61619 To unsubscribe, visit

Change in vdsm[master]: configs: move limits to static

Francesco Romani has posted comments on this change. Change subject: configs: move limits to static .. Patch Set 7: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/61605 To unsubscribe, visit

Change in vdsm[master]: configs: move sudoers to static

Francesco Romani has posted comments on this change. Change subject: configs: move sudoers to static .. Patch Set 7: Code-Review-1 (1 comment) -1 for visibility bad rebase? https://gerrit.ovirt.org/#/c/61603/7/.gitignore

Change in vdsm[master]: configs: move mom to static

Francesco Romani has posted comments on this change. Change subject: configs: move mom to static .. Patch Set 7: Code-Review-1 (1 comment) -1 for visibility, I like this patch (series) very much

Change in vdsm[master]: configs: move logger to static

Francesco Romani has posted comments on this change. Change subject: configs: move logger to static .. Patch Set 6: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/61601 To unsubscribe, visit

Change in vdsm[master]: vdsm: removing txRate and rxRate from code

Francesco Romani has posted comments on this change. Change subject: vdsm: removing txRate and rxRate from code .. Patch Set 6: Code-Review+1 the virt part looks ok -- To view, visit https://gerrit.ovirt.org/59544 To

Change in vdsm[ovirt-4.0]: periodic: always re-schedule operations

Hello Dan Kenigsberg, Milan Zamazal, I'd like you to do a code review. Please visit https://gerrit.ovirt.org/61889 to review the following change. Change subject: periodic: always re-schedule operations .. periodic:

Change in vdsm[master]: Revert "configurator: libvirt: do not jump on virtlogd"

Francesco Romani has posted comments on this change. Change subject: Revert "configurator: libvirt: do not jump on virtlogd" .. Patch Set 2: initial verification with basic flow went nice and without any issue. Will keep this

Change in vdsm[master]: packaging: spec: update Url field

Francesco Romani has posted comments on this change. Change subject: packaging: spec: update Url field .. Patch Set 1: Code-Review+1 Thanks Sandro! -- To view, visit https://gerrit.ovirt.org/61883 To unsubscribe, visit

Change in vdsm[master]: sampling: micro-optimization

Francesco Romani has abandoned this change. Change subject: sampling: micro-optimization .. Abandoned fun hack, but we don't really need this. -- To view, visit https://gerrit.ovirt.org/61311 To unsubscribe, visit

Change in vdsm[master]: Send metrics info only if metrics enabled to avoid parsing l...

Francesco Romani has posted comments on this change. Change subject: Send metrics info only if metrics enabled to avoid parsing logic .. Patch Set 1: raising score because this is in the virt kingdom -- To view, visit

Change in vdsm[master]: Send metrics info only if metrics enabled to avoid parsing l...

Francesco Romani has posted comments on this change. Change subject: Send metrics info only if metrics enabled to avoid parsing logic .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/61869 To

Change in vdsm[master]: Send metrics info only if metrics enabled to avoid parsing l...

Francesco Romani has posted comments on this change. Change subject: Send metrics info only if metrics enabled to avoid parsing logic .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/61869 To

Change in vdsm[master]: Send vm info report each sampling interval from VMBulkSampler

Francesco Romani has posted comments on this change. Change subject: Send vm info report each sampling interval from VMBulkSampler .. Patch Set 13: Code-Review+2 performance concerns addressed on 61869 we agreed to do deeper

Change in vdsm[master]: Moving vmstatus to vdsm.common.virt

Francesco Romani has posted comments on this change. Change subject: Moving vmstatus to vdsm.common.virt .. Patch Set 10: jenkins failure is real: 00:03:55.095 ./vdsm/API.py:45: 'vmstatus' imported but unused -- To view,

Change in vdsm[master]: Moving vmstatus to vdsm.common.virt

Francesco Romani has posted comments on this change. Change subject: Moving vmstatus to vdsm.common.virt .. Patch Set 10: Code-Review-1 -- To view, visit https://gerrit.ovirt.org/57820 To unsubscribe, visit

Change in vdsm[master]: Moving vmstatus to vdsm.common.virt

Francesco Romani has posted comments on this change. Change subject: Moving vmstatus to vdsm.common.virt .. Patch Set 10: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/57820 To unsubscribe, visit

Change in vdsm[master]: configs: move mom to static

Francesco Romani has posted comments on this change. Change subject: configs: move mom to static .. Patch Set 6: Code-Review-1 (4 comments) -1 for visibility https://gerrit.ovirt.org/#/c/61602/6/.gitignore File .gitignore:

Change in vdsm[master]: configs: move logger to static

Francesco Romani has posted comments on this change. Change subject: configs: move logger to static .. Patch Set 5: Code-Review-1 (1 comment) missing .gitignore updates https://gerrit.ovirt.org/#/c/61601/5/.gitignore File

Change in vdsm[master]: autoconf: properly sort makefiles

Francesco Romani has posted comments on this change. Change subject: autoconf: properly sort makefiles .. Patch Set 4: Code-Review+1 seems ok -- To view, visit https://gerrit.ovirt.org/61600 To unsubscribe, visit

Change in vdsm[master]: contrib: jsonrpc: add example script to run a VM

Francesco Romani has posted comments on this change. Change subject: contrib: jsonrpc: add example script to run a VM .. Patch Set 5: Verified+1 works as expected -- To view, visit https://gerrit.ovirt.org/61047 To

Change in vdsm[master]: Adding get_batch to StatsCache - returns dict with all vms stat

Francesco Romani has posted comments on this change. Change subject: Adding get_batch to StatsCache - returns dict with all vms stat .. Patch Set 3: (1 comment) https://gerrit.ovirt.org/#/c/61768/3//COMMIT_MSG Commit Message:

Change in vdsm[master]: Adding get_batch to StatsCache - returns dict with all vms stat

Francesco Romani has posted comments on this change. Change subject: Adding get_batch to StatsCache - returns dict with all vms stat .. Patch Set 3: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/61768 To

Change in vdsm[master]: lib: api: allow to return prebuilt responses

Francesco Romani has posted comments on this change. Change subject: lib: api: allow to return prebuilt responses .. Patch Set 3: Verified+1 verified with the tests. -- To view, visit https://gerrit.ovirt.org/61474 To

Change in vdsm[ovirt-4.0]: tests: sampling: add FakeClock helper

Francesco Romani has posted comments on this change. Change subject: tests: sampling: add FakeClock helper .. Patch Set 1: Verified+1 changes only in tests: if Jenkins is happy, so we are. -- To view, visit

Change in vdsm[ovirt-4.0]: virt: sampling: add is_empty() method to StatsSample

Hello Dan Kenigsberg, I'd like you to do a code review. Please visit https://gerrit.ovirt.org/61821 to review the following change. Change subject: virt: sampling: add is_empty() method to StatsSample .. virt: sampling:

Change in vdsm[ovirt-4.0]: vm: periodic: fix stats age reporting

Hello Dan Kenigsberg, I'd like you to do a code review. Please visit https://gerrit.ovirt.org/61822 to review the following change. Change subject: vm: periodic: fix stats age reporting .. vm: periodic: fix stats age

Change in vdsm[ovirt-4.0]: tests: sampling: add FakeClock helper

Hello Dan Kenigsberg, Martin Polednik, I'd like you to do a code review. Please visit https://gerrit.ovirt.org/61820 to review the following change. Change subject: tests: sampling: add FakeClock helper .. tests:

Change in vdsm[master]: Adding get_batch to StatsCache - returns dict with all vms stat

Francesco Romani has posted comments on this change. Change subject: Adding get_batch to StatsCache - returns dict with all vms stat .. Patch Set 2: Code-Review+2 thanks for the updates! -- To view, visit

Change in vdsm[master]: v2v: Log detailed output of virt-v2v

Francesco Romani has posted comments on this change. Change subject: v2v: Log detailed output of virt-v2v .. Patch Set 10: (2 comments) initial review. Good improvements! https://gerrit.ovirt.org/#/c/59834/10/lib/vdsm/v2v.py

Change in vdsm[ovirt-4.0]: virt net: Interface default driver name set to 'vhost'

Francesco Romani has posted comments on this change. Change subject: virt net: Interface default driver name set to 'vhost' .. Patch Set 1: Code-Review+1 please verify -- To view, visit https://gerrit.ovirt.org/61772 To

Change in vdsm[ovirt-4.0]: virt net: Interface default driver name set to 'vhost'

Francesco Romani has posted comments on this change. Change subject: virt net: Interface default driver name set to 'vhost' .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/61772 To unsubscribe, visit

Change in vdsm[master]: configs: move sudoers to static

Francesco Romani has posted comments on this change. Change subject: configs: move sudoers to static .. Patch Set 5: (2 comments) https://gerrit.ovirt.org/#/c/61603/5/static/Makefile.am File static/Makefile.am: PS5, Line 58:

Change in vdsm[ovirt-4.0]: virt: Fix of Executor._active_workers crash on modification

Francesco Romani has posted comments on this change. Change subject: virt: Fix of Executor._active_workers crash on modification .. Patch Set 2: Verified+1 verified together on-branch: 61769, 61770 - injected sleep(900) in

Change in vdsm[ovirt-4.0]: virt: Limit the number of workers in executor

Francesco Romani has posted comments on this change. Change subject: virt: Limit the number of workers in executor .. Patch Set 2: Verified+1 verified together on-branch: 61769, 61770 - injected sleep(900) in

Change in vdsm[master]: Collect ksm values only if exist

Francesco Romani has posted comments on this change. Change subject: Collect ksm values only if exist .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/61767 To unsubscribe, visit

Change in vdsm[master]: Send vm info report each sampling interval from VMBulkSampler

Francesco Romani has posted comments on this change. Change subject: Send vm info report each sampling interval from VMBulkSampler .. Patch Set 12: Code-Review+1 we only need to benchmark this. Partial ACK. -- To view, visit

Change in vdsm[master]: Adding get_batch to StatsCache - returns dict with all vms stat

Francesco Romani has posted comments on this change. Change subject: Adding get_batch to StatsCache - returns dict with all vms stat .. Patch Set 1: Code-Review-1 (2 comments) ok, we need a couple of fixes in the tests,

Change in vdsm[master]: confis: move modprobe files loading to static

Francesco Romani has posted comments on this change. Change subject: confis: move modprobe files loading to static .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/61762 To unsubscribe, visit

Change in vdsm[master]: configs: move systemd service files to static

Francesco Romani has posted comments on this change. Change subject: configs: move systemd service files to static .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/61763 To unsubscribe, visit

Change in vdsm[master]: configs: move limits to static

Francesco Romani has posted comments on this change. Change subject: configs: move limits to static .. Patch Set 5: Code-Review-1 another instance of the `cp` vs `mv` question, -1 for visibility. Once this is discussed, I'm

Change in vdsm[master]: configs: move rwtab to static

Francesco Romani has posted comments on this change. Change subject: configs: move rwtab to static .. Patch Set 5: Code-Review-1 (1 comment) -1 for visibility, please check inline question. Conceptually ok.

Change in vdsm[master]: configs: move sudoers to static

Francesco Romani has posted comments on this change. Change subject: configs: move sudoers to static .. Patch Set 5: Code-Review-1 (2 comments) conceptually fine, a couple of questions about Makefile.am, -1 for visibility

Change in vdsm[master]: configs: move mom to static

Francesco Romani has posted comments on this change. Change subject: configs: move mom to static .. Patch Set 5: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/61602 To unsubscribe, visit

Change in vdsm[master]: configs: move logger to static

Francesco Romani has posted comments on this change. Change subject: configs: move logger to static .. Patch Set 4: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/61601 To unsubscribe, visit

Change in vdsm[ovirt-4.0]: virt: Limit the number of workers in executor

Hello Nir Soffer, Milan Zamazal, I'd like you to do a code review. Please visit https://gerrit.ovirt.org/61769 to review the following change. Change subject: virt: Limit the number of workers in executor .. virt: Limit

Change in vdsm[ovirt-4.0]: virt: Fix of Executor._active_workers crash on modification

Hello Milan Zamazal, I'd like you to do a code review. Please visit https://gerrit.ovirt.org/61770 to review the following change. Change subject: virt: Fix of Executor._active_workers crash on modification .. virt: Fix

Change in vdsm[master]: periodic: always re-schedule operations

Francesco Romani has posted comments on this change. Change subject: periodic: always re-schedule operations .. Patch Set 4: Verified+1 Verified setting [sampling] periodic_workers = 1 periodic_task_per_worker = 1 in

Change in vdsm[master]: vm: periodic: fix stats age reporting

Francesco Romani has posted comments on this change. Change subject: vm: periodic: fix stats age reporting .. Patch Set 11: Verified+1 verified again with 61420 (same way as before) -- To view, visit

Change in vdsm[master]: sampling: micro-optimization

Francesco Romani has posted comments on this change. Change subject: sampling: micro-optimization .. Patch Set 12: verified with 61310 - timestamps looks good -- To view, visit https://gerrit.ovirt.org/61311 To unsubscribe,

Change in vdsm[master]: virt: sampling: add is_empty() method to StatsSample

Francesco Romani has posted comments on this change. Change subject: virt: sampling: add is_empty() method to StatsSample .. Patch Set 6: Verified+1 re-verified with the tests. -- To view, visit

Change in vdsm[ovirt-3.6]: yajsonrpc: use proper exception in the recovery

Francesco Romani has posted comments on this change. Change subject: yajsonrpc: use proper exception in the recovery .. Patch Set 1: Code-Review-2 We don't need this patch here, because 1. we don't have the new exception

Change in vdsm[ovirt-3.6]: yajsonrpc: use proper exception in the recovery

Francesco Romani has abandoned this change. Change subject: yajsonrpc: use proper exception in the recovery .. Abandoned see inline comments to learn why we don't need this patch in this branch -- To view, visit

Change in vdsm[ovirt-3.6]: yajsonrpc: use proper exception in the recovery

Hello Piotr Kliczewski, Milan Zamazal, I'd like you to do a code review. Please visit https://gerrit.ovirt.org/61751 to review the following change. Change subject: yajsonrpc: use proper exception in the recovery ..

Change in vdsm[ovirt-4.0]: yajsonrpc: use proper exception in the recovery

Francesco Romani has posted comments on this change. Change subject: yajsonrpc: use proper exception in the recovery .. Patch Set 1: raised score. -- To view, visit https://gerrit.ovirt.org/61631 To unsubscribe, visit

Change in vdsm[ovirt-4.0]: yajsonrpc: use proper exception in the recovery

Francesco Romani has submitted this change and it was merged. Change subject: yajsonrpc: use proper exception in the recovery .. yajsonrpc: use proper exception in the recovery If recovery takes too long and if we get an API

Change in vdsm[ovirt-4.0]: yajsonrpc: use proper exception in the recovery

Francesco Romani has posted comments on this change. Change subject: yajsonrpc: use proper exception in the recovery .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/61631 To unsubscribe, visit

Change in vdsm[ovirt-4.0]: yajsonrpc: use proper exception in the recovery

Francesco Romani has posted comments on this change. Change subject: yajsonrpc: use proper exception in the recovery .. Patch Set 1: Verified+1 verified on branch: Thread-16::INFO::2016-08-01

Change in vdsm[ovirt-4.0]: yajsonrpc: use proper exception in the recovery

Francesco Romani has posted comments on this change. Change subject: yajsonrpc: use proper exception in the recovery .. Patch Set 1: adding one exceptional exception for this trivial bug -- To view, visit

Change in vdsm[master]: docs: add README about logging configuration

Francesco Romani has posted comments on this change. Change subject: docs: add README about logging configuration .. Patch Set 8: Verified+1 -- To view, visit https://gerrit.ovirt.org/60533 To unsubscribe, visit

Change in vdsm[master]: docs: add README about logging configuration

Francesco Romani has posted comments on this change. Change subject: docs: add README about logging configuration .. Patch Set 7: (2 comments) https://gerrit.ovirt.org/#/c/60533/7/README.logging File README.logging: PS7,

Change in vdsm[master]: build: we don't use the VERSION file anymore

Francesco Romani has abandoned this change. Change subject: build: we don't use the VERSION file anymore .. Abandoned -- To view, visit https://gerrit.ovirt.org/59345 To unsubscribe, visit https://gerrit.ovirt.org/settings

Change in vdsm[master]: vm: sampling: use the new vmhealth handling

Francesco Romani has uploaded a new change for review. Change subject: vm: sampling: use the new vmhealth handling .. vm: sampling: use the new vmhealth handling This patch implements the new periodic.Operation needed for the

Change in vdsm[master]: virt: Fix of Executor._active_workers crash on modification

Francesco Romani has posted comments on this change. Change subject: virt: Fix of Executor._active_workers crash on modification .. Patch Set 1: Code-Review+2 (1 comment)

Change in vdsm[master]: virt: Fix of Executor._active_workers crash on modification

Francesco Romani has posted comments on this change. Change subject: virt: Fix of Executor._active_workers crash on modification .. Patch Set 1: (1 comment) https://gerrit.ovirt.org/#/c/61690/1/lib/vdsm/executor.py File

Change in vdsm[master]: virt: Fix of Executor._active_workers crash on modification

Francesco Romani has posted comments on this change. Change subject: virt: Fix of Executor._active_workers crash on modification .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/61690 To unsubscribe,

Change in vdsm[master]: periodic: always re-schedule operations

Francesco Romani has uploaded a new change for review. Change subject: periodic: always re-schedule operations .. periodic: always re-schedule operations Should executor.dispatch() raise in Operation, perhaps because of

Change in vdsm[master]: docs: add README about logging configuration

Francesco Romani has posted comments on this change. Change subject: docs: add README about logging configuration .. Patch Set 6: (1 comment) https://gerrit.ovirt.org/#/c/60533/6/README.logging File README.logging: Line 23:

Change in vdsm[master]: docs: add README about logging configuration

Francesco Romani has posted comments on this change. Change subject: docs: add README about logging configuration .. Patch Set 7: Verified+1 -- To view, visit https://gerrit.ovirt.org/60533 To unsubscribe, visit

Change in vdsm[ovirt-4.0]: yajsonrpc: use proper exception in the recovery

Hello Piotr Kliczewski, Milan Zamazal, I'd like you to do a code review. Please visit https://gerrit.ovirt.org/61631 to review the following change. Change subject: yajsonrpc: use proper exception in the recovery ..

<    3   4   5   6   7   8   9   10   11   12   >