Hello Piotr Kliczewski, Milan Zamazal,
I'd like you to do a code review. Please visit
https://gerrit.ovirt.org/61631
to review the following change.
Change subject: yajsonrpc: use proper exception in the recovery
..
yajso
Francesco Romani has posted comments on this change.
Change subject: autoconf: properly sort makefiles
..
Patch Set 2: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/61600
To unsubscribe, visit https://gerrit.ovirt.o
Francesco Romani has posted comments on this change.
Change subject: makefile: remove unused all-local section
..
Patch Set 3: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/61545
To unsubscribe, visit https://gerrit
Francesco Romani has posted comments on this change.
Change subject: configs: introduce static dir
..
Patch Set 2: Code-Review+2
I strongly support this idea. We should perhaps autogenerate everything we need
using vdsm-tool,
Francesco Romani has posted comments on this change.
Change subject: yajsonrpc: use proper exception in the recovery
..
Patch Set 2:
this issue was already present but silent.
78bdaa1d6578b6491d77fa9432f555fe05c1c0c2 exposed it
Francesco Romani has posted comments on this change.
Change subject: yajsonrpc: use proper exception in the recovery
..
Patch Set 2: Verified+1
stumbled on this during tests of
https://gerrit.ovirt.org/#/c/61592/2
Verified li
Francesco Romani has uploaded a new change for review.
Change subject: yajsonrpc: use proper exception in the recovery
..
yajsonrpc: use proper exception in the recovery
If recovery takes too long and if we get an API call meant
Francesco Romani has posted comments on this change.
Change subject: virt: periodic health check - WIP
..
Patch Set 2: Code-Review-1
(3 comments)
https://gerrit.ovirt.org/#/c/61592/2/lib/vdsm/virt/vmhealth.py
File lib/vdsm/vir
Francesco Romani has posted comments on this change.
Change subject: virt: Always execute after_hibernation event
..
Patch Set 2: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/59914
To unsubscribe, visit https://ger
Francesco Romani has posted comments on this change.
Change subject: EXPERIMENT: move static files to their subfolder
..
Patch Set 2:
(1 comment)
at first glance Makefile looks ok, but the logger configuration seems outdated
Francesco Romani has posted comments on this change.
Change subject: virt: sampling: add empty() method to StatsSample
..
Patch Set 4:
(1 comment)
https://gerrit.ovirt.org/#/c/61420/4/lib/vdsm/virt/sampling.py
File lib/vdsm/vi
Francesco Romani has posted comments on this change.
Change subject: virt: sampling: add empty() method to StatsSample
..
Patch Set 3:
(1 comment)
https://gerrit.ovirt.org/#/c/61420/3//COMMIT_MSG
Commit Message:
Line 7: virt:
Francesco Romani has posted comments on this change.
Change subject: docs: add README about logging configuration
..
Patch Set 6: Verified+1
copied score (changing the content doesn't affect "verification" here)
--
To view, v
Francesco Romani has uploaded a new change for review.
Change subject: Revert "configurator: libvirt: do not jump on virtlogd"
..
Revert "configurator: libvirt: do not jump on virtlogd"
This reverts commit 0d9be09351814571655fab
Francesco Romani has posted comments on this change.
Change subject: docs: add README about logging configuration
..
Patch Set 5:
(1 comment)
https://gerrit.ovirt.org/#/c/60533/5/README.logging
File README.logging:
Line 23:
Francesco Romani has posted comments on this change.
Change subject: vm: periodic: fix stats age reporting
..
Patch Set 7:
(4 comments)
https://gerrit.ovirt.org/#/c/61310/7//COMMIT_MSG
Commit Message:
PS7, Line 24: it
> its ?
Francesco Romani has uploaded a new change for review.
Change subject: network: switch to concurrent.thread()
..
network: switch to concurrent.thread()
This patch:
1. replaces good usages of threading.Thread() with
more moder
Francesco Romani has uploaded a new change for review.
Change subject: virt: vm: switch to concurrent.thread()
..
virt: vm: switch to concurrent.thread()
This patch:
1. replaces good usages of threading.Thread() with
more mod
Francesco Romani has uploaded a new change for review.
Change subject: jsonrpc: switch to concurrent.thread()
..
jsonrpc: switch to concurrent.thread()
This patch:
1. replaces good usages of threading.Thread() with
more moder
Francesco Romani has uploaded a new change for review.
Change subject: virt: migration: switch to concurrent.thread()
..
virt: migration: switch to concurrent.thread()
This patch:
1. replaces good usages of threading.Thread() wi
Francesco Romani has uploaded a new change for review.
Change subject: virt: vmchannels: switch to concurrent.thread()
..
virt: vmchannels: switch to concurrent.thread()
This patch:
1. replaces good usages of threading.Thread()
Francesco Romani has uploaded a new change for review.
Change subject: yajsonrpc: switch to concurrent.thread()
..
yajsonrpc: switch to concurrent.thread()
This patch:
1. replaces good usages of threading.Thread() with
more m
Francesco Romani has abandoned this change.
Change subject: json: use forzenset for filtered methods
..
Abandoned
let's put this back to rest.
--
To view, visit https://gerrit.ovirt.org/58796
To unsubscribe, visit https://ger
Francesco Romani has abandoned this change.
Change subject: vm: conf: proper locking in setNumberOfCpus()
..
Abandoned
--
To view, visit https://gerrit.ovirt.org/54910
To unsubscribe, visit https://gerrit.ovirt.org/settings
G
Francesco Romani has abandoned this change.
Change subject: tests: re-enable setNumberOfCpus tests
..
Abandoned
--
To view, visit https://gerrit.ovirt.org/56348
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-M
Francesco Romani has posted comments on this change.
Change subject: docs: add README about logging configuration
..
Patch Set 5: Verified+1
--
To view, visit https://gerrit.ovirt.org/60533
To unsubscribe, visit https://gerrit
Francesco Romani has posted comments on this change.
Change subject: docs: add README about logging configuration
..
Patch Set 4:
(3 comments)
https://gerrit.ovirt.org/#/c/60533/4/README.logging
File README.logging:
Line 25:
Francesco Romani has posted comments on this change.
Change subject: Fix return value names for VM.ioTune calls
..
Patch Set 6: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/60513
To unsubscribe, visit https://gerri
Francesco Romani has posted comments on this change.
Change subject: virt: clientIF: extract vmContainer into a module
..
Patch Set 11:
(1 comment)
https://gerrit.ovirt.org/#/c/53101/11/lib/vdsm/virt/vmstore.py
File lib/vdsm/v
Francesco Romani has posted comments on this change.
Change subject: contrib: jsonrpc: add example script to run a VM
..
Patch Set 4: Code-Review-1
(1 comment)
could be simplified and minified more.
https://gerrit.ovirt.org/#
Francesco Romani has posted comments on this change.
Change subject: virt: sampling: add empty() method to StatsSample
..
Patch Set 2: Verified+1
verified running the tests, and with 61310
--
To view, visit https://gerrit.ovi
Francesco Romani has posted comments on this change.
Change subject: vm: periodic: fix stats age reporting
..
Patch Set 6: Verified+1
verified again as before
--
To view, visit https://gerrit.ovirt.org/61310
To unsubscribe, v
Francesco Romani has uploaded a new change for review.
Change subject: virt: sampling: add empty() method to StatsSample
..
virt: sampling: add empty() method to StatsSample
kill the EMPTY_SAMPLE constant.
we always need to fill
Francesco Romani has posted comments on this change.
Change subject: vm: periodic: fix stats age reporting
..
Patch Set 3:
(1 comment)
https://gerrit.ovirt.org/#/c/61310/3/lib/vdsm/virt/sampling.py
File lib/vdsm/virt/sampling.
Francesco Romani has posted comments on this change.
Change subject: modprobe: set bonding max_bonds to 0
..
Patch Set 1: Code-Review-1
+1 for the name suggestion
I strongly agree with Martin about finding a better way to ship
Francesco Romani has posted comments on this change.
Change subject: rng: allow urandom as virtio rng entropy source
..
Patch Set 3: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/59031
To unsubscribe, visit https://
Francesco Romani has posted comments on this change.
Change subject: vm: api: move vm status check into migrate()
..
Patch Set 8: Verified+1
changes in the tests only, verification still holds.
--
To view, visit https://gerri
Francesco Romani has posted comments on this change.
Change subject: vm: api: move vm status check into migrate()
..
Patch Set 7:
(3 comments)
https://gerrit.ovirt.org/#/c/60608/7/tests/vmMigrationTests.py
File tests/vmMigrati
Francesco Romani has posted comments on this change.
Change subject: vm: api: move vm status check into migrate()
..
Patch Set 7: Code-Review-1
--
To view, visit https://gerrit.ovirt.org/60608
To unsubscribe, visit https://ger
Francesco Romani has posted comments on this change.
Change subject: vm: periodic: fix stats age reporting
..
Patch Set 3:
(1 comment)
https://gerrit.ovirt.org/#/c/61310/3/lib/vdsm/virt/sampling.py
File lib/vdsm/virt/sampling.
Francesco Romani has posted comments on this change.
Change subject: Fix return value names for VM.ioTune calls
..
Patch Set 4: Code-Review-1
(score changed for visibility, I still want this patch very much)
Looks like tests n
Francesco Romani has posted comments on this change.
Change subject: vdscli test: Minor pythonic changes in _assertValidAddress
..
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/61386
To unsubscribe, vis
Francesco Romani has posted comments on this change.
Change subject: build: Remove python 3 test run
..
Patch Set 1:
interesting idea, but I'd wait 4.0.4 for a possible merge
--
To view, visit https://gerrit.ovirt.org/61189
T
Francesco Romani has submitted this change and it was merged.
Change subject: ovs: create ovs-vsctl command only on demand
..
ovs: create ovs-vsctl command only on demand
If openvswitch package is not installed, import of ovs m
Francesco Romani has submitted this change and it was merged.
Change subject: ovs: pass --disable-openvswitch to vdsm.spec
..
ovs: pass --disable-openvswitch to vdsm.spec
In order to not include openvswitch requirement in vdsm-
Francesco Romani has submitted this change and it was merged.
Change subject: spec: never require openvswitch on ppc
..
spec: never require openvswitch on ppc
openvswitch.rpm is not built for el7 on ppc. Never require it there.
Francesco Romani has posted comments on this change.
Change subject: ovs: create ovs-vsctl command only on demand
..
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/61347
To unsubscribe, visit https://ger
Francesco Romani has posted comments on this change.
Change subject: spec: never require openvswitch on ppc
..
Patch Set 4: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/61349
To unsubscribe, visit https://gerrit.ov
Francesco Romani has posted comments on this change.
Change subject: ovs: pass --disable-openvswitch to vdsm.spec
..
Patch Set 1: Code-Review+2
ANy change needed to contrib/rhev_build.sh or contrib/koji_build.sh ?
--
To view,
Francesco Romani has posted comments on this change.
Change subject: fix vdscli: Replace the default '::' host with hostname
..
Patch Set 1:
(1 comment)
https://gerrit.ovirt.org/#/c/61381/1//COMMIT_MSG
Commit Message:
Line 8:
Francesco Romani has posted comments on this change.
Change subject: fix vdscli: Replace the default '::' host with hostname
..
Patch Set 1: Code-Review+1 Verified+1
(2 comments)
works for me, both vdsClientTests.py and 'make
Francesco Romani has posted comments on this change.
Change subject: virt: graphics: open nontls port only if requested
..
Patch Set 5:
(1 comment)
https://gerrit.ovirt.org/#/c/56839/5//COMMIT_MSG
Commit Message:
Line 13: Ins
Francesco Romani has posted comments on this change.
Change subject: vm: periodic: fix stats age reporting
..
Patch Set 3: Verified+1
added one test, copying score
--
To view, visit https://gerrit.ovirt.org/61310
To unsubscri
Francesco Romani has posted comments on this change.
Change subject: Live Merge: Restore watermark tracking
..
Patch Set 10:
(6 comments)
-1 for visibility of inline questions
https://gerrit.ovirt.org/#/c/60889/10/vdsm/virt/v
Francesco Romani has posted comments on this change.
Change subject: log: Use INFO log level as default
..
Patch Set 2: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/32504
To unsubscribe, visit https://gerrit.ovirt.
Francesco Romani has posted comments on this change.
Change subject: Send vm info report each sampling interval from VMBulkSampler
..
Patch Set 11: Code-Review-1
(2 comments)
almost there, we need
- to split the new StatsCache
Francesco Romani has posted comments on this change.
Change subject: Adding report_stats to virt.stats
..
Patch Set 14: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/59066
To unsubscribe, visit https://gerrit.ovirt.
Francesco Romani has posted comments on this change.
Change subject: Pass the Scheduler instance to HSM
..
Patch Set 2: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/61253
To unsubscribe, visit https://gerrit.ovirt.
Francesco Romani has posted comments on this change.
Change subject: sampling: micro-optimization
..
Patch Set 4: -Code-Review
--
To view, visit https://gerrit.ovirt.org/61311
To unsubscribe, visit https://gerrit.ovirt.org/set
Francesco Romani has posted comments on this change.
Change subject: sampling: micro-optimization
..
Patch Set 3:
see also https://paste.fedoraproject.org/395484/
--
To view, visit https://gerrit.ovirt.org/61311
To unsubscrib
Francesco Romani has posted comments on this change.
Change subject: sampling: micro-optimization
..
Patch Set 3: Verified+1
Codewise trivial patch
verified faster using the example benchmark script (see the comments)
--
To v
Francesco Romani has posted comments on this change.
Change subject: sampling: micro-optimization
..
Patch Set 3: Code-Review-1
--
To view, visit https://gerrit.ovirt.org/61311
To unsubscribe, visit https://gerrit.ovirt.org/se
Francesco Romani has posted comments on this change.
Change subject: vm: periodic: fix stats age reporting
..
Patch Set 3:
(1 comment)
https://gerrit.ovirt.org/#/c/61310/3/lib/vdsm/virt/sampling.py
File lib/vdsm/virt/sampling.
Francesco Romani has submitted this change and it was merged.
Change subject: blockSD: fix rebase error of commit dd3306d
..
blockSD: fix rebase error of commit dd3306d
A faulty rebase of commit dd3306d accidently removed an ex
Francesco Romani has posted comments on this change.
Change subject: hostdev: prefer numa nodes close to device MMIO
..
Patch Set 5: Code-Review+1
(1 comment)
https://gerrit.ovirt.org/#/c/60640/5//COMMIT_MSG
Commit Message:
L
Francesco Romani has posted comments on this change.
Change subject: vmxml: add appendNumaTune return value
..
Patch Set 3:
After reading again, if we just need to distinguish if Engine sent explicit
configuration or not (AFAI
Francesco Romani has posted comments on this change.
Change subject: vmxml: add appendNumaTune return value
..
Patch Set 3: Code-Review+1
Milan's right, I overlooked the inner 'if'
--
To view, visit https://gerrit.ovirt.org/6
Francesco Romani has posted comments on this change.
Change subject: vmxml: add appendNumaTune return value
..
Patch Set 3: Code-Review-1
--
To view, visit https://gerrit.ovirt.org/61106
To unsubscribe, visit https://gerrit.ov
Francesco Romani has posted comments on this change.
Change subject: hostdev: expose numa_node in host device
..
Patch Set 5: Code-Review+2
perhaps could even be squashed in the parent one. I'm fine anyway.
--
To view, visit
Francesco Romani has posted comments on this change.
Change subject: hostdev: report device MMIO numa node
..
Patch Set 5: Code-Review+1
(1 comment)
https://gerrit.ovirt.org/#/c/60637/5//COMMIT_MSG
Commit Message:
Line 4: Com
Francesco Romani has posted comments on this change.
Change subject: vm: reorder operations in _domDependentInit
..
Patch Set 20: Verified+1
verified running a VM with no issues (as expected)
--
To view, visit https://gerrit.
Francesco Romani has posted comments on this change.
Change subject: virt: utils: add is_kvm helper
..
Patch Set 29: Verified+1
verified using the tests
--
To view, visit https://gerrit.ovirt.org/55647
To unsubscribe, visit h
Francesco Romani has posted comments on this change.
Change subject: blockSD: fix rebase error of commit dd3306d
..
Patch Set 1: Code-Review+2 Continuous-Integration+1
--
To view, visit https://gerrit.ovirt.org/61346
To unsubs
Francesco Romani has posted comments on this change.
Change subject: blockSD: fix rebase error of commit dd3306d
..
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/61342
To unsubscribe, visit https://gerr
Francesco Romani has posted comments on this change.
Change subject: virt: utils: add is_kvm helper
..
Patch Set 28:
(1 comment)
https://gerrit.ovirt.org/#/c/55647/28/tests/vmUtilsTests.py
File tests/vmUtilsTests.py:
PS28, Li
Francesco Romani has posted comments on this change.
Change subject: vdsm: virt: add optional container support
..
Patch Set 43: Code-Review-1
(15 comments)
Martin's comments needs to be addressed.
https://gerrit.ovirt.org/#/
Francesco Romani has posted comments on this change.
Change subject: supervdsm: expose systemd utilities
..
Patch Set 24:
(3 comments)
https://gerrit.ovirt.org/#/c/56491/24/vdsm/supervdsm_api/systemd.py
File vdsm/supervdsm_api
Francesco Romani has posted comments on this change.
Change subject: virt: utils: add is_kvm helper
..
Patch Set 28:
(4 comments)
https://gerrit.ovirt.org/#/c/55647/28//COMMIT_MSG
Commit Message:
PS28, Line 9: Proper containe
Francesco Romani has posted comments on this change.
Change subject: cmdutils: enhance systemd_run
..
Patch Set 24:
(1 comment)
https://gerrit.ovirt.org/#/c/56474/24/lib/vdsm/cmdutils.py
File lib/vdsm/cmdutils.py:
PS24, Line
Francesco Romani has posted comments on this change.
Change subject: vm: periodic: fix stats age reporting
..
Patch Set 2: Verified+1
PS1->2
- changed one comment
- dropped unused code
If jenkins is happy, the verification hold
Francesco Romani has posted comments on this change.
Change subject: tests: sampling: add FakeClock helper
..
Patch Set 2: Verified+1
verified running the tests themselves.
--
To view, visit https://gerrit.ovirt.org/61309
To
Francesco Romani has posted comments on this change.
Change subject: sampling: micro-optimization
..
Patch Set 2:
Verification: see also https://paste.fedoraproject.org/395295/
--
To view, visit https://gerrit.ovirt.org/61311
Francesco Romani has submitted this change and it was merged.
Change subject: ovs: do not call ovs_info if ovs service is down
..
ovs: do not call ovs_info if ovs service is down
PPC downstream does not require OVS, therefore i
Francesco Romani has submitted this change and it was merged.
Change subject: net systemd: Require openvswitch.service
..
net systemd: Require openvswitch.service
vdsm-network service requires openvswitch service to be running.
Francesco Romani has submitted this change and it was merged.
Change subject: net func tests: drop ovs/legacy permutation
..
net func tests: drop ovs/legacy permutation
OVS tests are now covered in new functional tests
tests/ne
Francesco Romani has submitted this change and it was merged.
Change subject: net: call address.flush explicitly after dhclient.kill
..
net: call address.flush explicitly after dhclient.kill
Change-Id: I7c03ce4917174a78fc97f216
Francesco Romani has submitted this change and it was merged.
Change subject: ovs hook: fix dhclient imports
..
ovs hook: fix dhclient imports
Change-Id: Ie13c017538750902713831bbcb07a30c885abd7d
Signed-off-by: Petr Horáček
Re
Francesco Romani has submitted this change and it was merged.
Change subject: net: add address.flush family argument
..
net: add address.flush family argument
Add family argument to address.flush to be able to flush just
IP add
Francesco Romani has submitted this change and it was merged.
Change subject: ovs: move bridges cleanup to a separate function
..
ovs: move bridges cleanup to a separate function
In order to trigger rollback as late as possible
Francesco Romani has submitted this change and it was merged.
Change subject: ovs: add network with dhcp configuration
..
ovs: add network with dhcp configuration
Change-Id: I792713f27f41faf5e2d4de02c51ad8d0ee02
Bug-Url: ht
Francesco Romani has submitted this change and it was merged.
Change subject: ovs: rollback transaction
..
ovs: rollback transaction
Use netconfpersistence.Transaction() to trigger rollback after failed
OVS network setup.
Chan
Francesco Romani has submitted this change and it was merged.
Change subject: net: move dhclient_run/stop helpers to dhclient.py
..
net: move dhclient_run/stop helpers to dhclient.py
dhclient.py will be moved to ip module in th
Francesco Romani has submitted this change and it was merged.
Change subject: net: move dhclient.py to ip package
..
net: move dhclient.py to ip package
Change-Id: I4065d551e62cf6aa04021e2cfc5de73afd0334fd
Bug-Url: https://bugz
Francesco Romani has submitted this change and it was merged.
Change subject: net: disable unused IPv6 in ip.address.add()
..
net: disable unused IPv6 in ip.address.add()
Move the code to shared ip.address.add() function so it
Francesco Romani has submitted this change and it was merged.
Change subject: ovs: turn created links UP
..
ovs: turn created links UP
Change-Id: I1b0263c75a7b5beae97f06f9248fcc26abfc8de7
Bug-Url: https://bugzilla.redhat.com/11
Francesco Romani has submitted this change and it was merged.
Change subject: net func test: add basic bond tests
..
net func test: add basic bond tests
The patch introduces bond assertions for the functional tests and some
bas
Francesco Romani has submitted this change and it was merged.
Change subject: ovs: add OVS network with IP configuration
..
ovs: add OVS network with IP configuration
This patch also includes basic functional tests for static I
Francesco Romani has submitted this change and it was merged.
Change subject: net tests: common tests for 'ovs' and 'legacy'
..
net tests: common tests for 'ovs' and 'legacy'
New functional tests cover need to test both 'ovs' a
Francesco Romani has submitted this change and it was merged.
Change subject: net func test: test network based on a vlan
..
net func test: test network based on a vlan
Change-Id: I654af5a81518c2b51ac8694b1ed307aad004a256
Signe
Francesco Romani has submitted this change and it was merged.
Change subject: net func test: Support remove network check
..
net func test: Support remove network check
Change-Id: Idcceb6e16a091226ffb104e50e462a89c2e3f247
Signe
801 - 900 of 9949 matches
Mail list logo
