Francesco Romani has posted comments on this change. Change subject: supervdsm: expose systemd utilities ......................................................................
Patch Set 24: (3 comments) https://gerrit.ovirt.org/#/c/56491/24/vdsm/supervdsm_api/systemd.py File vdsm/supervdsm_api/systemd.py: PS24, Line 41: systemd_run > This is inconsistent with line marked by comment '$inconsistence'. I don't have a good excuse here :) But let me just explain that I'd like to expose only _some_ functionalities of these tools. systemd_run is a poor example here, because it can run a lot; still, here I want to run commands with a guaranteed set of options. PS24, Line 49: systemctl_stop > $inconsistence In a way, yes. In another, it is a different tool, which does a different thing; and I want to expose onyl one very specific action of the many that this tool allows. PS24, Line 54: machinectl_poweroff same here -- To view, visit https://gerrit.ovirt.org/56491 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I38e9a346da784fc200a82d9e5d9fdf665e752987 Gerrit-PatchSet: 24 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani <from...@redhat.com> Gerrit-Reviewer: Francesco Romani <from...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Polednik <mpoled...@redhat.com> Gerrit-Reviewer: gerrit-hooks <automat...@ovirt.org> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
