Marcin Mirecki has posted comments on this change.
Change subject: after_vm_start: migrate to jsonrpcvdsli
..
Patch Set 5: Verified+1
--
To view, visit https://gerrit.ovirt.org/62713
To unsubscribe, visit https://gerrit.ovirt.
Marcin Mirecki has posted comments on this change.
Change subject: virt: Migration plugins to enable skipping of special OVS
processing for nics
..
Patch Set 2:
The hook (vm_migrate_hook.py) was added as part of OVS support
(
Marcin Mirecki has posted comments on this change.
Change subject: draft: vm_migration_libvirt_hook_plugins
..
Patch Set 4:
During vm migration we invoke a libvirt hook: vm_migrate_hook.py.
This was added recently, and adds som
Marcin Mirecki has posted comments on this change.
Change subject: virt: Migration plugins to enable skipping of special OVS
processing for nics
..
Patch Set 2:
(1 comment)
https://gerrit.ovirt.org/#/c/64186/2//COMMIT_MSG
Com
Marcin Mirecki has posted comments on this change.
Change subject: virt: Migration plugins to enable skipping of special OVS
processing for nics
..
Patch Set 2:
(8 comments)
This was just a quick and dirty draft to show the c
Marcin Mirecki has uploaded a new change for review.
Change subject: draft: migration plugin proposal - draft 102
..
draft: migration plugin proposal - draft 102
Just a draft to show the idea, not verified
Change-Id: Ia0fb056c4
Marcin Mirecki has abandoned this change.
Change subject: draft: Hook nic_libvirt_migration_destination, proposal 2
..
Abandoned
--
To view, visit https://gerrit.ovirt.org/63686
To unsubscribe, visit https://gerrit.ovirt.org/s
Marcin Mirecki has abandoned this change.
Change subject: draft: Hook before_nic_libvirt_migration_destination, proposal 1
..
Abandoned
--
To view, visit https://gerrit.ovirt.org/63684
To unsubscribe, visit https://gerrit.ovir
Marcin Mirecki has posted comments on this change.
Change subject: draft: vm_migration_libvirt_hook_plugins
..
Patch Set 1: Code-Review-1 Verified-1
--
To view, visit https://gerrit.ovirt.org/64001
To unsubscribe, visit https:
Marcin Mirecki has uploaded a new change for review.
Change subject: draft: vm_migration_libvirt_hook_plugins
..
draft: vm_migration_libvirt_hook_plugins
Quick draft for vm migration libvirt hook plugins
Change-Id: I7e13a94fa28
Marcin Mirecki has posted comments on this change.
Change subject: draft: Hook nic_libvirt_migration_destination, proposal 2
..
Patch Set 1: Code-Review-1 Verified-1
--
To view, visit https://gerrit.ovirt.org/63686
To unsubscr
Marcin Mirecki has posted comments on this change.
Change subject: draft: Hook before_nic_libvirt_migration_destination, proposal 1
..
Patch Set 2: Code-Review-1 Verified-1
--
To view, visit https://gerrit.ovirt.org/63684
To u
Marcin Mirecki has uploaded a new change for review.
Change subject: draft: Hook nic_libvirt_migration_destination, proposal 2
..
draft: Hook nic_libvirt_migration_destination, proposal 2
A quick proposal for fixing broken custo
Marcin Mirecki has uploaded a new change for review.
Change subject: draft: Hook before_nic_libvirt_migration_destination, proposal 1
..
draft: Hook before_nic_libvirt_migration_destination, proposal 1
Change-Id: I38363bd36f5580
Marcin Mirecki has uploaded a new change for review.
Change subject: virt net: Disable special OVS handling for exteranal network
..
virt net: Disable special OVS handling for exteranal network
Exteranal network rely of changes
Marcin Mirecki has posted comments on this change.
Change subject: net libvirt hook: Adjust hook to vmList report change.
..
Patch Set 1: Code-Review+1 Verified+1
--
To view, visit https://gerrit.ovirt.org/63542
To unsubscribe
Marcin Mirecki has abandoned this change.
Change subject: hooks: Initial commit for the ovn vif driver
..
Abandoned
Moving to ovirt-provider-ovn repo
--
To view, visit https://gerrit.ovirt.org/62958
To unsubscribe, visit http
Marcin Mirecki has uploaded a new change for review.
Change subject: hooks: Initial commit for the ovn vif driver
..
hooks: Initial commit for the ovn vif driver
Adds the POC code (from github) into vdsm.
This provides the basic
Marcin Mirecki has posted comments on this change.
Change subject: vdsm: removing txRate and rxRate from code
..
Patch Set 6:
Verified on 3.6 engine and 4.0 host.
--
To view, visit https://gerrit.ovirt.org/59544
To unsubscrib
Marcin Mirecki has posted comments on this change.
Change subject: vdsm: removing txRate and rxRate from code
..
Patch Set 6:
Verified with:
-master, vdsm with changes applied
-4.0, vdsm with changes applied (to verify compatib
Marcin Mirecki has posted comments on this change.
Change subject: vdsm: removing txRate and rxRate from code
..
Patch Set 6: Verified+1
--
To view, visit https://gerrit.ovirt.org/59544
To unsubscribe, visit https://gerrit.ovi
Marcin Mirecki has posted comments on this change.
Change subject: vdsm: removing txRate and rxRate from code
..
Patch Set 6:
The engine code which receives the stats looks to be immune to missing
rx/txRate.
The incoming value
Marcin Mirecki has posted comments on this change.
Change subject: hooks: openstack hook should wait a while for nic activation
..
Patch Set 1: Verified+1
--
To view, visit https://gerrit.ovirt.org/60035
To unsubscribe, visit
Hello Dan Kenigsberg, Francesco Romani,
I'd like you to do a code review. Please visit
https://gerrit.ovirt.org/60035
to review the following change.
Change subject: hooks: openstack hook should wait a while for nic activation
...
Marcin Mirecki has posted comments on this change.
Change subject: hooks: openstack hook should wait a while for nic activation
..
Patch Set 1:
The hooks are exactly the same as master, verified along with the master version
-
Marcin Mirecki has posted comments on this change.
Change subject: hooks: openstack hook should wait a while for nic activation
..
Patch Set 1: Verified+1
--
To view, visit https://gerrit.ovirt.org/59919
To unsubscribe, visit
Marcin Mirecki has posted comments on this change.
Change subject: vdsm: removing txRate and rxRate from code
..
Patch Set 5: Code-Review-1 Verified-1
The value is required by engine 4.0, which is already out.
The patch needs t
Marcin Mirecki has posted comments on this change.
Change subject: vdsm: removing txRate and rxRate from code
..
Patch Set 5:
There is no plan so far to backport to 4.0
--
To view, visit https://gerrit.ovirt.org/59544
To unsu
Marcin Mirecki has posted comments on this change.
Change subject: vdsm: removing txRate and rxRate from code
..
Patch Set 5:
Yes, rx/tx rate are still used on the engine.
But they are not received from vdsm anymore, being inst
Hello Dan Kenigsberg, Francesco Romani,
I'd like you to do a code review. Please visit
https://gerrit.ovirt.org/59919
to review the following change.
Change subject: hooks: openstack hook should wait a while for nic activation
...
Marcin Mirecki has posted comments on this change.
Change subject: hooks: openstack hook should wait a while for nic activation
..
Patch Set 5: Verified+1
--
To view, visit https://gerrit.ovirt.org/58917
To unsubscribe, visit
Marcin Mirecki has posted comments on this change.
Change subject: openstacknet: add MidoNet support
..
Patch Set 2:
Verified up to the point where the xml passed to libvirt is correct.
It still needs verification to see if the
Marcin Mirecki has uploaded a new change for review.
Change subject: vdsm: removing txRate and rxRate from code
..
vdsm: removing txRate and rxRate from code
Vdsm should no longer send rxRate and txRate to the engine.
Change-Id
Marcin Mirecki has posted comments on this change.
Change subject: hooks: openstack hook should wait a while for nic activation
..
Patch Set 2:
(5 comments)
https://gerrit.ovirt.org/#/c/58917/2/vdsm_hooks/openstacknet/after_vm
Marcin Mirecki has posted comments on this change.
Change subject: openstacknet: add MidoNet support
..
Patch Set 2:
The patch is ok for me for now.
In the next iteration, I would like to make the main body of the hook to be
i
Marcin Mirecki has uploaded a new change for review.
Change subject: draft: proposed refactoring of openstack hook to move provider
data to a config file
..
draft: proposed refactoring of openstack hook to move provider data to
Marcin Mirecki has posted comments on this change.
Change subject: hooks: openstack hook should wait a while for nic activation
..
Patch Set 1:
(3 comments)
https://gerrit.ovirt.org/#/c/58917/1/vdsm_hooks/openstacknet/after_vm
Marcin Mirecki has posted comments on this change.
Change subject: hooks: openstack hook should wait a while for nic activation
..
Patch Set 2: Verified+1
--
To view, visit https://gerrit.ovirt.org/58917
To unsubscribe, visit
Marcin Mirecki has posted comments on this change.
Change subject: openstacknet: add MidoNet support
..
Patch Set 2: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/59255
To unsubscribe, visit https://gerrit.ovirt.org
Marcin Mirecki has uploaded a new change for review.
Change subject: virt: Alternative proposal for passing flags in/from vm/device
hooks
..
virt: Alternative proposal for passing flags in/from vm/device hooks
Change-Id: I5f0f1
Marcin Mirecki has posted comments on this change.
Change subject: virt: Collect vm start flags from device hooks when running vm
..
Patch Set 5:
(3 comments)
https://gerrit.ovirt.org/#/c/57538/5/lib/vdsm/hooks.py
File lib/vds
Marcin Mirecki has abandoned this change.
Change subject: virt: Adding 'delayedLaunch' to vm start
..
Abandoned
The patch is to monstrous to allow it to go in. Abandoning
--
To view, visit https://gerrit.ovirt.org/57395
To un
Marcin Mirecki has uploaded a new change for review.
Change subject: virt: Collect vm start flags from device hooks when running vm
..
virt: Collect vm start flags from device hooks when running vm
Change-Id: I554e304027ea253406
Marcin Mirecki has uploaded a new change for review.
Change subject: virt: Temporary fix resolving race condition when adding
external network to vm
..
virt: Temporary fix resolving race condition when adding external network to
Marcin Mirecki has posted comments on this change.
Change subject: net: Network speed reported as -1 if it can not be determined
..
Patch Set 1: Verified+1
--
To view, visit https://gerrit.ovirt.org/57108
To unsubscribe, visit
Marcin Mirecki has uploaded a new change for review.
Change subject: net: Network speed reported as -1 if it can not be determined
..
net: Network speed reported as -1 if it can not be determined
If network speed can not be dete
Marcin Mirecki has posted comments on this change.
Change subject: net: Removing 'link' scoped addresses from the ip address list
..
Patch Set 3: Verified+1
--
To view, visit https://gerrit.ovirt.org/54211
To unsubscribe, visi
Marcin Mirecki has posted comments on this change.
Change subject: net: Removing 'link' scoped addresses from the ip address list
..
Patch Set 2:
(3 comments)
https://gerrit.ovirt.org/#/c/54211/2/tests/network/netinfo_test.py
Marcin Mirecki has posted comments on this change.
Change subject: net: Removing cfg entry from get capabilities
..
Patch Set 3:
ovirt-hosted-engine-setup will be adapting to our changes:
https://bugzilla.redhat.com/show_bug.cg
Marcin Mirecki has posted comments on this change.
Change subject: net: Removing cfg entry from get capabilities
..
Patch Set 3: Code-Review-1
--
To view, visit https://gerrit.ovirt.org/53746
To unsubscribe, visit https://gerr
Marcin Mirecki has uploaded a new change for review.
Change subject: net: Removing 'link' scoped addresses from the ip address list
..
net: Removing 'link' scoped addresses from the ip address list
This method should not report
Marcin Mirecki has posted comments on this change.
Change subject: net: Removing cfg entry from get capabilities
..
Patch Set 2: Verified+1
--
To view, visit https://gerrit.ovirt.org/53746
To unsubscribe, visit https://gerrit.
Marcin Mirecki has uploaded a new change for review.
Change subject: net: Removing cfg entry from get capabilities
..
net: Removing cfg entry from get capabilities
Cfg entry in capabilities report is no longer needed as of 3.6,
Marcin Mirecki has posted comments on this change.
Change subject: setupNetworks: moving nics between bonds
..
Patch Set 11: Verified+1
--
To view, visit https://gerrit.ovirt.org/50596
To unsubscribe, visit https://gerrit.ovir
Marcin Mirecki has posted comments on this change.
Change subject: setupNetworks: moving nics between bonds
..
Patch Set 9:
(3 comments)
https://gerrit.ovirt.org/#/c/50596/9/lib/vdsm/network/api.py
File lib/vdsm/network/api.py
Marcin Mirecki has posted comments on this change.
Change subject: setupNetworks: moving nics between bonds
..
Patch Set 9: Verified+1
--
To view, visit https://gerrit.ovirt.org/50596
To unsubscribe, visit https://gerrit.ovirt
Marcin Mirecki has posted comments on this change.
Change subject: supervdsm: moving nics between bonds
..
Patch Set 8:
(5 comments)
https://gerrit.ovirt.org/#/c/50596/8//COMMIT_MSG
Commit Message:
Line 7: supervdsm:
> setup
Marcin Mirecki has abandoned this change.
Change subject: vm: nic hotunplug, perform libvirt operation before modyfing
vdsm nic objects
..
Abandoned
This was an alternative solution to:
https://gerrit.ovirt.org/#/c/51187/
whic
Marcin Mirecki has posted comments on this change.
Change subject: hooks: ovs: enable auto-attach mapping
..
Patch Set 1: Code-Review+1 -Verified
--
To view, visit https://gerrit.ovirt.org/51859
To unsubscribe, visit https://g
Marcin Mirecki has posted comments on this change.
Change subject: hooks: ovs: enable auto-attach mapping
..
Patch Set 1: Verified+1
--
To view, visit https://gerrit.ovirt.org/51859
To unsubscribe, visit https://gerrit.ovirt.o
Marcin Mirecki has posted comments on this change.
Change subject: hooks: ovs: enable auto-attach mapping
..
Patch Set 1:
(1 comment)
https://gerrit.ovirt.org/#/c/51859/1/vdsm_hooks/ovs/ovs_before_network_setup_ovs.py
File vds
Marcin Mirecki has posted comments on this change.
Change subject: hooks: ovs: enable auto-attach mapping
..
Patch Set 1:
(1 comment)
https://gerrit.ovirt.org/#/c/51859/1/vdsm_hooks/ovs/ovs_before_network_setup_ovs.py
File vds
Marcin Mirecki has posted comments on this change.
Change subject: vm: restoring correct vm nic device after HotunplugTimeout
..
Patch Set 1: Verified+1
--
To view, visit https://gerrit.ovirt.org/51339
To unsubscribe, visit ht
Marcin Mirecki has uploaded a new change for review.
Change subject: vm: restoring correct vm nic device after HotunplugTimeout
..
vm: restoring correct vm nic device after HotunplugTimeout
When a nic is hotunpluged, it is first
Marcin Mirecki has posted comments on this change.
Change subject: vm: restoring correct vm nic device after HotunplugTimeout
..
Patch Set 3: Verified+1
--
To view, visit https://gerrit.ovirt.org/51187
To unsubscribe, visit ht
Marcin Mirecki has abandoned this change.
Change subject: vm: nic hotunplug exception handling - refactoring
..
Abandoned
squashed into: https://gerrit.ovirt.org/#/c/51187/
--
To view, visit https://gerrit.ovirt.org/51190
To
Marcin Mirecki has posted comments on this change.
Change subject: vm: restoring correct vm nic device after HotunplugTimeout
..
Patch Set 1:
(1 comment)
This problem can also be solved by switching the order of removing the n
Marcin Mirecki has uploaded a new change for review.
Change subject: vm: nic hotunplug, perform libvirt operation before modyfing
vdsm nic objects
..
vm: nic hotunplug, perform libvirt operation before modyfing vdsm nic objects
Marcin Mirecki has uploaded a new change for review.
Change subject: vm: nic hotunplug exception handling - refactoring
..
vm: nic hotunplug exception handling - refactoring
Pulling some common code to a helper function
Change-
Marcin Mirecki has uploaded a new change for review.
Change subject: vm: restoring correct vm nic device after HotunplugTimeout
..
vm: restoring correct vm nic device after HotunplugTimeout
When a nic is hotunpluged, it is first
Marcin Mirecki has posted comments on this change.
Change subject: supervdsm: moving nics between bonds
..
Patch Set 6:
(5 comments)
https://gerrit.ovirt.org/#/c/50596/6/lib/vdsm/network/api.py
File lib/vdsm/network/api.py:
L
Marcin Mirecki has posted comments on this change.
Change subject: supervdsm: moving nics between bonds
..
Patch Set 6:
Another version where we don't objectivize the bonds, but just remove all the
unwanted nics.
More efficien
Marcin Mirecki has posted comments on this change.
Change subject: supervdsm: moving nics between bonds
..
Patch Set 5:
We objectivize bonds, with only the remaining slaves (original slaves - removed
slaves), and pass them to
Marcin Mirecki has posted comments on this change.
Change subject: supervdsm: moving nics between bonds
..
Patch Set 5:
(1 comment)
https://gerrit.ovirt.org/#/c/50596/5/lib/vdsm/network/models.py
File lib/vdsm/network/models.p
Marcin Mirecki has posted comments on this change.
Change subject: supervdsm: moving nics between bonds
..
Patch Set 2:
(3 comments)
https://gerrit.ovirt.org/#/c/50596/2/lib/vdsm/network/api.py
File lib/vdsm/network/api.py:
L
Marcin Mirecki has posted comments on this change.
Change subject: supervdsm: moving nics between bonds
..
Patch Set 1:
(7 comments)
https://gerrit.ovirt.org/#/c/50596/1/lib/vdsm/network/api.py
File lib/vdsm/network/api.py:
L
Marcin Mirecki has uploaded a new change for review.
Change subject: supervdsm: moving nics between bonds
..
supervdsm: moving nics between bonds
This patch fixes an problem where a slave removed from
one bond could sometimes no
Marcin Mirecki has posted comments on this change.
Change subject: supervdsm: moving nics between bonds
..
Patch Set 1: Verified+1
--
To view, visit https://gerrit.ovirt.org/50596
To unsubscribe, visit https://gerrit.ovirt.org
Marcin Mirecki has posted comments on this change.
Change subject: vm: move device attached check to device itself
..
Patch Set 2: Verified+1
--
To view, visit https://gerrit.ovirt.org/49670
To unsubscribe, visit https://gerri
Marcin Mirecki has posted comments on this change.
Change subject: vm: add test for nic unplug wait
..
Patch Set 2: Verified+1
--
To view, visit https://gerrit.ovirt.org/49671
To unsubscribe, visit https://gerrit.ovirt.org/set
Marcin Mirecki has posted comments on this change.
Change subject: vm: check operation result for vm nic hotunplug
..
Patch Set 1: Verified+1
--
To view, visit https://gerrit.ovirt.org/49669
To unsubscribe, visit https://gerri
Marcin Mirecki has posted comments on this change.
Change subject: vm: unit test for vm._waitForDriveRemoval
..
Patch Set 1: Verified+1
--
To view, visit https://gerrit.ovirt.org/49668
To unsubscribe, visit https://gerrit.ovir
Marcin Mirecki has abandoned this change.
Change subject: vm: always return bond mode in Host.getCapabilities
..
Abandoned
Duplicated:
https://gerrit.ovirt.org/#/c/49580/
--
To view, visit https://gerrit.ovirt.org/49550
To u
Marcin Mirecki has posted comments on this change.
Change subject: vm: add test for nic unplug wait
..
Patch Set 2:
Reordered.
The order in master was first moving the device_attached, and then the nic
tests.
--
To view, vi
Marcin Mirecki has abandoned this change.
Change subject: vm: adding xpath property to device Base class
..
Abandoned
No longer needed.
--
To view, visit https://gerrit.ovirt.org/49554
To unsubscribe, visit https://gerrit.ovi
Hello Ido Barkan, Francesco Romani,
I'd like you to do a code review. Please visit
https://gerrit.ovirt.org/49670
to review the following change.
Change subject: vm: move device attached check to device itself
..
vm: move
Marcin Mirecki has uploaded a new change for review.
Change subject: vm: add test for nic unplug wait
..
vm: add test for nic unplug wait
Change-Id: I4603efa0739c9bd50777a157c946da3ba8544729
Signed-off-by: Marcin Mirecki
Bug-Ur
Hello Francesco Romani,
I'd like you to do a code review. Please visit
https://gerrit.ovirt.org/49668
to review the following change.
Change subject: vm: unit test for vm._waitForDriveRemoval
..
vm: unit test for vm._wait
Hello Francesco Romani,
I'd like you to do a code review. Please visit
https://gerrit.ovirt.org/49669
to review the following change.
Change subject: vm: check operation result for vm nic hotunplug
..
vm: check operation
Marcin Mirecki has posted comments on this change.
Change subject: vm: move device attached check to device itself
..
Patch Set 15: Verified+1
--
To view, visit https://gerrit.ovirt.org/48881
To unsubscribe, visit https://gerr
Marcin Mirecki has posted comments on this change.
Change subject: vm: unit test for vm._waitForDriveRemoval
..
Patch Set 12: Verified+1
--
To view, visit https://gerrit.ovirt.org/48880
To unsubscribe, visit https://gerrit.ovi
Marcin Mirecki has posted comments on this change.
Change subject: vm: adding xpath property to device Base class
..
Patch Set 1: Verified+1
--
To view, visit https://gerrit.ovirt.org/49554
To unsubscribe, visit https://gerrit
Marcin Mirecki has posted comments on this change.
Change subject: vm: add test for nic unplug wait
..
Patch Set 11: Verified+1
--
To view, visit https://gerrit.ovirt.org/49104
To unsubscribe, visit https://gerrit.ovirt.org/se
Marcin Mirecki has posted comments on this change.
Change subject: vm: adding xpath property to device Base class
..
Patch Set 1:
(1 comment)
https://gerrit.ovirt.org/#/c/49554/1/vdsm/virt/vmdevices/core.py
File vdsm/virt/vmde
Marcin Mirecki has posted comments on this change.
Change subject: vm: always return bond mode in Host.getCapabilities
..
Patch Set 1:
(1 comment)
https://gerrit.ovirt.org/#/c/49550/1/lib/vdsm/netinfo.py
File lib/vdsm/netinfo.
Marcin Mirecki has posted comments on this change.
Change subject: vm: always return bond mode in Host.getCapabilities
..
Patch Set 1: Verified+1
--
To view, visit https://gerrit.ovirt.org/49550
To unsubscribe, visit https://g
Marcin Mirecki has posted comments on this change.
Change subject: vm: check operation result for vm nic hotunplug
..
Patch Set 20:
xpath property added to base class in:
https://gerrit.ovirt.org/49554
--
To view, visit https
Marcin Mirecki has uploaded a new change for review.
Change subject: vm: adding xpath property to device Base class
..
vm: adding xpath property to device Base class
Change-Id: I29a7989cde44da0f756d48ae139fba47e524a40b
Bug-Url:
Marcin Mirecki has uploaded a new change for review.
Change subject: vm: always return bond mode in Host.getCapabilities
..
vm: always return bond mode in Host.getCapabilities
The 'mode' attribute in bonding options should alway
Marcin Mirecki has posted comments on this change.
Change subject: vm: check operation result for vm nic hotunplug
..
Patch Set 17: Verified+1
--
To view, visit https://gerrit.ovirt.org/48473
To unsubscribe, visit https://gerr
1 - 100 of 207 matches
Mail list logo
