Marcin Mirecki has posted comments on this change. Change subject: vm: always return bond mode in Host.getCapabilities ......................................................................
Patch Set 1: (1 comment) https://gerrit.ovirt.org/#/c/49550/1/lib/vdsm/netinfo.py File lib/vdsm/netinfo.py: Line 445: """ Line 446: opts = bondOpts(bond) Line 447: mode = opts['mode'][-1] if 'mode' in opts else None Line 448: defaults = getDefaultBondingOptions(mode) Line 449: defaults.pop('mode', None) optionaly: if 'key' in myDict: del myDict['key'] but pop is shorter Line 450: Line 451: return dict(((opt, val[-1]) for (opt, val) in opts.iteritems() Line 452: if val and val != defaults.get(opt))) Line 453: -- To view, visit https://gerrit.ovirt.org/49550 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I697af1c895db5ece99b3f940242b77f623caa8b9 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Marcin Mirecki <mmire...@redhat.com> Gerrit-Reviewer: Francesco Romani <from...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Marcin Mirecki <mmire...@redhat.com> Gerrit-Reviewer: gerrit-hooks <automat...@ovirt.org> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
