Martin Polednik has posted comments on this change.
Change subject: virt: move XML processing in a module
..
Patch Set 3: Code-Review+1
I'd say the name itself sounds better, I'm only afraid not to start naming
everything vm*
Martin Polednik has posted comments on this change.
Change subject: vdsm: initial split of vm devices
..
Patch Set 1:
I'd consider moving whole DeviceMapping and *_DEVICES to devices.py in future,
the meantime split will unfor
Martin Polednik has uploaded a new change for review.
Change subject: vdsm: move sound device to devices.py
..
vdsm: move sound device to devices.py
No real code changes
Change-Id: I42b8ae3475373d39c7d6375ccbc23a85437e19d0
Sign
Martin Polednik has uploaded a new change for review.
Change subject: vdsm: move video device to devices.py
..
vdsm: move video device to devices.py
No real code changes
Change-Id: I40ba700e6223490251af86189196f189ae4bad39
Sign
Martin Polednik has uploaded a new change for review.
Change subject: vdsm: move controller device to devices.py
..
vdsm: move controller device to devices.py
No real code changes
Change-Id: I941a76230fd5cc3c28495c5fa8526f8735b
Martin Polednik has uploaded a new change for review.
Change subject: vdsm: initial split of vm devices
..
vdsm: initial split of vm devices
initial boostrapping of VmDevice and GeneralDevice from devices.py
Change-Id: I63b6028
Martin Polednik has uploaded a new change for review.
Change subject: vdsm: isolate VmDevice xml generation method
..
vdsm: isolate VmDevice xml generation method
VmDevice class uses helper function 'createXmlElem' to ease gener
Martin Polednik has posted comments on this change.
Change subject: vdsm: disable virtio-rng on rhel < 7.1
..
Patch Set 2:
still not using distutils as libvirt returns the version in format friendly for
simple >= relation
--
Martin Polednik has posted comments on this change.
Change subject: virt: move XML processing in a module
..
Patch Set 2:
i myself find the name quite ok - kinda intuitive and autocomplete friendly
--
To view, visit http://ge
Martin Polednik has posted comments on this change.
Change subject: sampling: allow window=1 in AdvancedStatsFunction
..
Patch Set 3: Code-Review+1
as long as invalid values are properly tested, i see no problem with this (and
Martin Polednik has posted comments on this change.
Change subject: vdsm: add support for hot(un)plug of host devices
..
Patch Set 4:
(1 comment)
http://gerrit.ovirt.org/#/c/22523/4/vdsm/rpc/vdsmapi-schema.json
File vdsm/rpc/v
Martin Polednik has uploaded a new change for review.
Change subject: vdsm hostdev: add support for SCSI devices
..
vdsm hostdev: add support for SCSI devices
Libvirt allows passthrough of SCSI devices - this patch
exposes the f
Martin Polednik has uploaded a new change for review.
Change subject: vdsm hostdev: add support for USB devices
..
vdsm hostdev: add support for USB devices
Libvirt allows passthrough of USB devices (not busses) - this patch
exp
Martin Polednik has posted comments on this change.
Change subject: vdsm: add support for hostdev passthrough
..
Patch Set 15:
(2 comments)
http://gerrit.ovirt.org/#/c/22462/15/vdsm/caps.py
File vdsm/caps.py:
Line 505:
Martin Polednik has uploaded a new change for review.
Change subject: vdsm: disable virtio-rng on rhel < 7.1
..
vdsm: disable virtio-rng on rhel < 7.1
Virtio-rng support was added in libvirt 1.0.3, which is unavailable in
rhel v
Martin Polednik has posted comments on this change.
Change subject: faqemu hook: move memory limitation to config
..
Patch Set 5: Verified+1
--
To view, visit http://gerrit.ovirt.org/28320
To unsubscribe, visit http://gerrit.o
Martin Polednik has posted comments on this change.
Change subject: vdsm: add support for hostdev passthrough
..
Patch Set 15: Verified+1
Verification warning: I could only verify XML generation and correct function
calls, but
Martin Polednik has posted comments on this change.
Change subject: vdsmapi-schema: fix typo in tpm device
..
Patch Set 1: Verified+1
--
To view, visit http://gerrit.ovirt.org/28393
To unsubscribe, visit http://gerrit.ovirt.or
Martin Polednik has posted comments on this change.
Change subject: faqemu hook: move memory limitation to config
..
Patch Set 3: -Verified
(1 comment)
http://gerrit.ovirt.org/#/c/28320/3/vdsm_hooks/faqemu/before_vm_start.py
F
Martin Polednik has posted comments on this change.
Change subject: faqemu hook: move memory limitation to config
..
Patch Set 3: Verified+1
--
To view, visit http://gerrit.ovirt.org/28320
To unsubscribe, visit http://gerrit.o
Martin Polednik has posted comments on this change.
Change subject: faqemu hook: move memory limitation to config
..
Patch Set 3:
(1 comment)
http://gerrit.ovirt.org/#/c/28320/3/vdsm_hooks/faqemu/before_vm_start.py
File vdsm_h
Martin Polednik has uploaded a new change for review.
Change subject: vdsmapi-schema: fix typo in tpm device
..
vdsmapi-schema: fix typo in tpm device
Small typo in documentation, VmTpmDeviceType is in no way related
to smartcar
Martin Polednik has posted comments on this change.
Change subject: faqemu hook: move memory limitation to config
..
Patch Set 1: Verified+1
--
To view, visit http://gerrit.ovirt.org/28320
To unsubscribe, visit http://gerrit.o
Martin Polednik has posted comments on this change.
Change subject: vdsm: add support for hostdev passthrough
..
Patch Set 10:
No, we realized that the libvirt device XML is not usable as hostdev XML,
therefore adding the need
Martin Polednik has uploaded a new change for review.
Change subject: faqemu hook: move memory limitation to config
..
faqemu hook: move memory limitation to config
Qemu supports more than 20 MB memory[1], removing the need for
Martin Polednik has posted comments on this change.
Change subject: vdsm: add support for hostdev passthrough
..
Patch Set 7:
(2 comments)
http://gerrit.ovirt.org/#/c/22462/7/vdsm/caps.py
File vdsm/caps.py:
Line 325:
Martin Polednik has posted comments on this change.
Change subject: vm: added missing diskReplicate slot in Drive class
..
Patch Set 2: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/28131
To unsubscribe, visit http:/
Martin Polednik has posted comments on this change.
Change subject: tests: virt: retry to connect to VDSM at startup
..
Patch Set 3: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/26638
To unsubscribe, visit http://ge
Martin Polednik has posted comments on this change.
Change subject: vdsm: add support for S3/S4 suspend calls
..
Patch Set 8:
(2 comments)
http://gerrit.ovirt.org/#/c/19389/8/vdsm/virt/vm.py
File vdsm/virt/vm.py:
Line 2304:
Martin Polednik has posted comments on this change.
Change subject: vdsm: add support for hot(un)plug of pci-passthrough devices
..
Patch Set 3:
waiting for http://gerrit.ovirt.org/#/c/22462/ in case of changes
--
To view, vi
Martin Polednik has posted comments on this change.
Change subject: tests: validate cdrom path sent to/received from vdsm
..
Patch Set 4: Verified+1
Addresed Francesco's comments.
--
To view, visit http://gerrit.ovirt.org/221
Martin Polednik has posted comments on this change.
Change subject: vdsm: add support for TPM device passthrough
..
Patch Set 4: Verified+1
--
To view, visit http://gerrit.ovirt.org/20649
To unsubscribe, visit http://gerrit.ov
Martin Polednik has posted comments on this change.
Change subject: tests: add initial tests for timeOffset handling
..
Patch Set 4: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/24252
To unsubscribe, visit http://ge
Martin Polednik has posted comments on this change.
Change subject: vdsm: add support for hostdev passthrough
..
Patch Set 6: Verified+1
Verified through supplied functional test (XML being passed to libvirt
correctly, caps be
Martin Polednik has posted comments on this change.
Change subject: vmDevices: add __slots__ to devices
..
Patch Set 6: Verified+1
Tested by functional tests and on oVirt setup, creating VMs with various
(exotic) device combin
Martin Polednik has posted comments on this change.
Change subject: vmDevices: add __slots__ to devices
..
Patch Set 6:
Only the suggested cleanup (removed the unneeded pass; changed order of
variable initialization in __init_
Martin Polednik has posted comments on this change.
Change subject: vmDevices: add __slots__ to devices
..
Patch Set 5:
(1 comment)
http://gerrit.ovirt.org/#/c/21036/5//COMMIT_MSG
Commit Message:
Line 8:
Line 9: VDSM devices
Martin Polednik has posted comments on this change.
Change subject: clientIF: prepareVolumePath payload cleanup
..
Patch Set 7: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/22928
To unsubscribe, visit http://gerrit.
Martin Polednik has abandoned this change.
Change subject: tests: test virt_functional tests
..
Abandoned
--
To view, visit http://gerrit.ovirt.org/24325
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageTy
Martin Polednik has posted comments on this change.
Change subject: tests: add initial tests for timeOffset handling
..
Patch Set 3: Code-Review-1
You could also add test that would issue multiple _rtcUpdate calls and check
th
Martin Polednik has uploaded a new change for review.
Change subject: tests: test virt_functional tests
..
tests: test virt_functional tests
Change-Id: I96a702579fdad5ff81bf1f525eaadbe3095b4ebf
Signed-off-by: Martin Polednik
--
Martin Polednik has posted comments on this change.
Change subject: sd: fix volume path returned by linkBCImage
..
Patch Set 1: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/24315
To unsubscribe, visit http://gerrit.
Martin Polednik has posted comments on this change.
Change subject: vdsm: add support for S3/S4 suspend calls
..
Patch Set 7: Verified+1
Jenkins messages seem unrelated; tested by functional test and on oVirt setup
with GA ins
Martin Polednik has posted comments on this change.
Change subject: tests: validate cdrom path sent to/received from vdsm
..
Patch Set 3: Verified+1
--
To view, visit http://gerrit.ovirt.org/22194
To unsubscribe, visit http://
Martin Polednik has posted comments on this change.
Change subject: vdsm: fix RTC offset
..
Patch Set 1: Verified+1
Time reported correctly (fortunately no modification required).
--
To view, visit http://gerrit.ovirt.org/242
Martin Polednik has posted comments on this change.
Change subject: vdsm: fix RTC offset
..
Patch Set 1: Verified+1
Behaves same as master.
--
To view, visit http://gerrit.ovirt.org/24196
To unsubscribe, visit http://gerrit.o
Hello Dan Kenigsberg, Peter V. Saveliev,
I'd like you to do a code review. Please visit
http://gerrit.ovirt.org/24260
to review the following change.
Change subject: vdsm: fix RTC offset
..
vdsm: fix RTC offset
Upon RTC
Martin Polednik has posted comments on this change.
Change subject: vm: discover volume path from xml definition
..
Patch Set 1: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/24202
To unsubscribe, visit http://gerrit
Martin Polednik has posted comments on this change.
Change subject: tests: add initial tests for timeOffset handling
..
Patch Set 1: Code-Review+1
Definitely +1 on the code if the test itself is desired.
--
To view, visit htt
Martin Polednik has posted comments on this change.
Change subject: tests: add initial tests for timeOffset handling
..
Patch Set 1:
I'm not sure we need to test it at this moment: according to Michal, timeOffset
is mostly leg
Martin Polednik has posted comments on this change.
Change subject: vdsm: fix RTC offset
..
Patch Set 1: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/24196
To unsubscribe, visit http://gerrit.ovirt.org/settings
Ger
Martin Polednik has posted comments on this change.
Change subject: vdsm: add support for S3/S4 suspend calls
..
Patch Set 6:
considered as a code preview, still needs functional tests added
--
To view, visit http://gerrit.ov
Martin Polednik has posted comments on this change.
Change subject: guestIF: Adding guest agent API versioning support
..
Patch Set 14: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/17004
To unsubscribe, visit http:/
Martin Polednik has posted comments on this change.
Change subject: vmDevices: add __slots__ to devices
..
Patch Set 4:
(1 comment)
http://gerrit.ovirt.org/#/c/21036/4/vdsm/vm.py
File vdsm/vm.py:
Line 1253: se
Martin Polednik has posted comments on this change.
Change subject: tests: validate cdrom path sent to/received from vdsm
..
Patch Set 2: Verified+1
--
To view, visit http://gerrit.ovirt.org/22194
To unsubscribe, visit http://
Martin Polednik has posted comments on this change.
Change subject: vdsm: [wip] modeling graphics as a device
..
Patch Set 4:
(3 comments)
Also try to add functional test for multiple graphics devices configurations.
http://g
Martin Polednik has posted comments on this change.
Change subject: vmDevices: add __slots__ to devices
..
Patch Set 4:
(1 comment)
The change does not change any functionality, only preserves it.
http://gerrit.ovirt.org/#/c/
Martin Polednik has posted comments on this change.
Change subject: vm: implement recommended clock settings
..
Patch Set 2: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/23663
To unsubscribe, visit http://gerrit.ovi
Martin Polednik has posted comments on this change.
Change subject: tests: fix possible test failure due to reboot event
..
Patch Set 1: Verified+1
tested multiple runs on 256mb fedora with 1 vcpu, no failure
--
To view, visi
Martin Polednik has posted comments on this change.
Change subject: vdsm: add support for S3/S4 suspend calls
..
Patch Set 5:
(2 comments)
http://gerrit.ovirt.org/#/c/19389/5/vdsm/API.py
File vdsm/API.py:
Line 357: st
Martin Polednik has posted comments on this change.
Change subject: vdsm: add support for PCI passthrough
..
Patch Set 5:
(2 comments)
http://gerrit.ovirt.org/#/c/22462/5//COMMIT_MSG
Commit Message:
Line 3: AuthorDate: 2013-1
Martin Polednik has posted comments on this change.
Change subject: vmDevices: add __slots__ to devices
..
Patch Set 4:
(2 comments)
http://gerrit.ovirt.org/#/c/21036/4/vdsm/vm.py
File vdsm/vm.py:
Line 1253: s
Martin Polednik has posted comments on this change.
Change subject: vdsm: fix RTC offset
..
Patch Set 5: Verified+1
verified using running oVirt and checking logfile rtc differences; changed log
message to reflect real RTC (in
Martin Polednik has posted comments on this change.
Change subject: vm: add boot menu support
..
Patch Set 2: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/23558
To unsubscribe, visit http://gerrit.ovirt.org/settings
Martin Polednik has posted comments on this change.
Change subject: vm: add boot menu support
..
Patch Set 1: Code-Review+1
code itself seems fine, only lacks the "missing option" test
--
To view, visit http://gerrit.ovirt.or
Martin Polednik has posted comments on this change.
Change subject: vmDevices: introduce VmDeviceContainer
..
Patch Set 7:
currently outdated but still relevant, will get to it as this branch progresses
--
To view, visit http
Martin Polednik has posted comments on this change.
Change subject: Move virt things into vdsm/virt
..
Patch Set 7: Code-Review+1
much needed patch, seems okay
--
To view, visit http://gerrit.ovirt.org/21792
To unsubscribe, v
Martin Polednik has uploaded a new change for review.
Change subject: tests: fix possible test failure due to reboot event
..
tests: fix possible test failure due to reboot event
Virt tests currently have a chance of failing eve
Martin Polednik has posted comments on this change.
Change subject: vdsm: fix RTC offset
..
Patch Set 3: Verified+1
--
To view, visit http://gerrit.ovirt.org/14750
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit
Martin Polednik has posted comments on this change.
Change subject: vdsm: fix RTC offset
..
Patch Set 2:
(1 comment)
File vdsm/vm.py
Line 2264:
Line 2265: def _rtcUpdat
Martin Polednik has posted comments on this change.
Change subject: vdsm: add support for PCI passthrough
..
Patch Set 5: Verified+1
Verified by manually starting devices with passthrough hardware assigned and
checking logs fo
Martin Polednik has posted comments on this change.
Change subject: vdsm: add support for hot(un)plug of pci-passthrough devices
..
Patch Set 2:
(1 comment)
File client/vdsC
Martin Polednik has uploaded a new change for review.
Change subject: vdsm: add support for hot(un)plug of pci-passthrough devices
..
vdsm: add support for hot(un)plug of pci-passthrough devices
Hot(un)plug ability for pci-passt
Martin Polednik has uploaded a new change for review.
Change subject: [WIP] vdsm: add support for PCI passthrough
..
[WIP] vdsm: add support for PCI passthrough
required functionality:
* report PCI devices available on host [x]
Martin Polednik has posted comments on this change.
Change subject: vdsm: add support for S3/S4 suspend calls
..
Patch Set 5: Verified+1
Verified by testing on real VMs with QGA installed
--
To view, visit http://gerrit.ovirt
Martin Polednik has posted comments on this change.
Change subject: vdsm: prepareVolumePath correct path handling for cdrom
..
Patch Set 1: Verified+1
--
To view, visit http://gerrit.ovirt.org/22324
To unsubscribe, visit http:
Hello Federico Simoncelli, Dan Kenigsberg, Michal Skrivanek,
I'd like you to do a code review. Please visit
http://gerrit.ovirt.org/22324
to review the following change.
Change subject: vdsm: prepareVolumePath correct path handling for cdrom
Martin Polednik has posted comments on this change.
Change subject: tests: validate cdrom path sent to/received from vdsm
..
Patch Set 1:
(2 comments)
File tests/functional/
Martin Polednik has posted comments on this change.
Change subject: add xmlrpcTests for cpu pinning
..
Patch Set 6:
This patch in its current form without rebase and a bit of work wouldn't test
anything: we would only see if t
Martin Polednik has posted comments on this change.
Change subject: vdsm: prepareVolumePath correct path handling for cdrom
..
Patch Set 6:
Test added in http://gerrit.ovirt.org/#/c/22194/
--
To view, visit http://gerrit.ovir
Martin Polednik has posted comments on this change.
Change subject: tests: validate cdrom path sent to/received from vdsm
..
Patch Set 1: Verified+1
correctly detects failure without the fix applied / success with fix applied
Martin Polednik has uploaded a new change for review.
Change subject: tests: validate cdrom path sent to/received from vdsm
..
tests: validate cdrom path sent to/received from vdsm
related to http://gerrit.ovirt.org/#/c/20074/
Martin Polednik has posted comments on this change.
Change subject: vdsm: add support for virtio-rng devices
..
Patch Set 15: Verified+1
Implemented caps suggestion, fixed API, functional test is now robust in a way
that it de
Martin Polednik has posted comments on this change.
Change subject: vdsm: migration progress: count memRemaining also
..
Patch Set 9: Verified+1
--
To view, visit http://gerrit.ovirt.org/15124
To unsubscribe, visit http://gerr
Martin Polednik has posted comments on this change.
Change subject: clientIF: Fix use of getConfDevices
..
Patch Set 2: Verified+1
manually verified that the function is passed the same parameters as before
using log messages
Martin Polednik has posted comments on this change.
Change subject: Revert "vdsm: refactor buildConfDevices and getConfDevices into
single function"
..
Patch Set 1: Code-Review-1
the only caller should be fixed by http://gerri
Martin Polednik has posted comments on this change.
Change subject: tests/functional/virt: drop testInitramfsReadable
..
Patch Set 2: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/21854
To unsubscribe, visit http://g
Martin Polednik has posted comments on this change.
Change subject: vdsm: prepareVolumePath correct path handling for cdrom
..
Patch Set 6: Verified+1
fixed wrong specParams handling, verified XML against standard cdrom, empty
Martin Polednik has posted comments on this change.
Change subject: tests/functional/virt: drop ever-failing test
..
Patch Set 1: Code-Review-1
The previous test implementation always required that the system initramfs will
ha
Martin Polednik has posted comments on this change.
Change subject: clientIF: Fix use of getConfDevices
..
Patch Set 2: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/21832
To unsubscribe, visit http://gerrit.ovirt.or
Martin Polednik has posted comments on this change.
Change subject: vdsm: add logging to _getUnderlyingDriveInfo
..
Patch Set 7: Verified+1
--
To view, visit http://gerrit.ovirt.org/19928
To unsubscribe, visit http://gerrit.ov
Martin Polednik has posted comments on this change.
Change subject: vdsm: add support for virtio-rng devices
..
Patch Set 14: Verified+1
--
To view, visit http://gerrit.ovirt.org/19091
To unsubscribe, visit http://gerrit.ovirt
Martin Polednik has posted comments on this change.
Change subject: vdsm: refactor buildConfDevices and getConfDevices into single
function
..
Patch Set 5: Verified+1
(1 comment)
..
Martin Polednik has posted comments on this change.
Change subject: vm: drop unused MigrationSourceThreadClass abstraction
..
Patch Set 1: Code-Review+1
exactly what Tony said
--
To view, visit http://gerrit.ovirt.org/21560
T
Martin Polednik has uploaded a new change for review.
Change subject: vdsm: handle migration abort before semaphore acquiration
..
vdsm: handle migration abort before semaphore acquiration
If cancelMigration is called before mig
Martin Polednik has posted comments on this change.
Change subject: vdsm: prepareVolumePath correct path handling for cdrom
..
Patch Set 5: Verified+1
cdrom path is always passed in specParams when starting VM from template wit
Martin Polednik has posted comments on this change.
Change subject: vdsm: prepareVolumePath correct path handling for cdrom
..
Patch Set 5:
(1 comment)
File vdsm/clientIF.py
Martin Polednik has posted comments on this change.
Change subject: vdsm: change network sampling interval to 15 seconds
..
Patch Set 2: Verified+1
--
To view, visit http://gerrit.ovirt.org/21257
To unsubscribe, visit http://g
Martin Polednik has uploaded a new change for review.
Change subject: vdsm: change network sampling interval to 15 seconds
..
vdsm: change network sampling interval to 15 seconds
Change-Id: I6c1763c1cc228791e8fa969f05d5bfcf80e2c
Martin Polednik has uploaded a new change for review.
Change subject: vmDevices: replace self.conf['devices'] by VmDeviceContainer
..
vmDevices: replace self.conf['devices'] by VmDeviceContainer
This patch servers as an implemen
1 - 100 of 173 matches
Mail list logo
