Martin Polednik has posted comments on this change.
Change subject: vdsm: fix RTC offset
......................................................................
Patch Set 2:
(1 comment)
....................................................
File vdsm/vm.py
Line 2264:
Line 2265: def _rtcUpdate(self, timeOffset):
Line 2266: self.log.debug('new rtc offset %s', timeOffset)
Line 2267: with self._confLock:
Line 2268: self.conf['timeOffset'] = self._initTimeRTC +
long(timeOffset)
We actually need initTimeRTC in order to avoid multiple syncs adding up the
time diff (because the difference will always be absolute to qemu start, not
previous sync).
Saving the config is not needed due to timeOffset being propagated to engine in
next poll interval: should crash occur before it is propagated, we can treat it
same as missed event (not making any difference to previous offset).
Line 2269:
Line 2270: def extendDriveVolume(self, vmDrive):
Line 2271: if not vmDrive.blockDev:
Line 2272: return
--
To view, visit http://gerrit.ovirt.org/14750
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I27c70a53f64fb05607e93bffbac25fdee7d1cd2a
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Peter V. Saveliev <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: Federico Simoncelli <[email protected]>
Gerrit-Reviewer: Martin Polednik <[email protected]>
Gerrit-Reviewer: Michal Skrivanek <[email protected]>
Gerrit-Reviewer: Peter V. Saveliev <[email protected]>
Gerrit-Reviewer: Vinzenz Feenstra <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
