Piotr Kliczewski has posted comments on this change.
Change subject: Dynamic load of supervdsm_api funcs
..
Patch Set 13: Code-Review-1
(4 comments)
https://gerrit.ovirt.org/#/c/52875/13/vdsm/supervdsmServer
File vdsm
Piotr Kliczewski has posted comments on this change.
Change subject: Kill and report asyncProc if fails on first write to stdin
..
Patch Set 6: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/51763
To unsubscribe
Piotr Kliczewski has posted comments on this change.
Change subject: ssl: common name different than host info from socket during
tests
..
Patch Set 1:
(1 comment)
https://gerrit.ovirt.org/#/c/53231/1/tests/integration
Piotr Kliczewski has posted comments on this change.
Change subject: ssl: common name differences on f23
..
Patch Set 1:
(1 comment)
https://gerrit.ovirt.org/#/c/53231/1/tests/integration/jsonRpcHelper.py
File tests
Piotr Kliczewski has posted comments on this change.
Change subject: ssl: common name differences on f23
..
Patch Set 1: Verified+1
Verified on both f23 and f22. After the change there are no issues with
commonName during
Piotr Kliczewski has uploaded a new change for review.
Change subject: ssl: common name differences on f23
..
ssl: common name differences on f23
When we introduced 186c8574 changed common name in our tests
certificates to ::1
Piotr Kliczewski has posted comments on this change.
Change subject: xmlrpc: retry when flushing socket
..
Patch Set 6:
(1 comment)
https://gerrit.ovirt.org/#/c/47637/6/vdsm/rpc/bindingxmlrpc.py
File vdsm/rpc/bindingxmlrpc.py
Piotr Kliczewski has posted comments on this change.
Change subject: contrib: schema converter
..
Patch Set 4:
Once we finalize conversion the code from this patch is not needed. I just
wanted people to play with generated
Piotr Kliczewski has posted comments on this change.
Change subject: xmlrpc: retry when flushing socket
..
Patch Set 7: Verified+1
--
To view, visit https://gerrit.ovirt.org/47637
To unsubscribe, visit https
Piotr Kliczewski has posted comments on this change.
Change subject: xmlrpc: retry when flushing socket
..
Patch Set 6:
(1 comment)
https://gerrit.ovirt.org/#/c/47637/6/vdsm/rpc/bindingxmlrpc.py
File vdsm/rpc/bindingxmlrpc.py
Piotr Kliczewski has posted comments on this change.
Change subject: contrib: schema converter
..
Patch Set 2:
(1 comment)
https://gerrit.ovirt.org/#/c/52864/2//COMMIT_MSG
Commit Message:
Line 3: AuthorDate: 2016-01-28 15:10
Piotr Kliczewski has posted comments on this change.
Change subject: contrib: schema converter
..
Patch Set 3: Verified+1
Comments fixed. Script verified with python3 (it requires python3-PyYAML).
--
To view, visit https
Piotr Kliczewski has posted comments on this change.
Change subject: xmlrpc: retry when flushing socket
..
Patch Set 6: Verified+1
Fixed Yaniv's comments + rebase.
--
To view, visit https://gerrit.ovirt.org/476
Piotr Kliczewski has posted comments on this change.
Change subject: Dynamic load of supervdsm_api funcs
..
Patch Set 8: Code-Review-1
(1 comment)
Please provide tests to cover to logic that you introduce here.
https
Piotr Kliczewski has posted comments on this change.
Change subject: Adding vdsm functional tests
..
Patch Set 51: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/48268
To unsubscribe, visit https://gerrit.ovirt.org
Piotr Kliczewski has posted comments on this change.
Change subject: contrib: schema converter
..
Patch Set 2:
(1 comment)
https://gerrit.ovirt.org/#/c/52864/2//COMMIT_MSG
Commit Message:
Line 3: AuthorDate: 2016-01-28 15:10
Piotr Kliczewski has posted comments on this change.
Change subject: contrib: schema converter
..
Patch Set 2:
(3 comments)
https://gerrit.ovirt.org/#/c/52864/2//COMMIT_MSG
Commit Message:
Line 3: AuthorDate: 2016-01-28 15
Piotr Kliczewski has posted comments on this change.
Change subject: contrib: schema converter
..
Patch Set 2: Verified+1
Converter performs initial conversion from json to yaml formats. During
development I noticed many
Piotr Kliczewski has posted comments on this change.
Change subject: xmlrpc: retry when flushing socket
..
Patch Set 5:
(1 comment)
https://gerrit.ovirt.org/#/c/47637/5//COMMIT_MSG
Commit Message:
Line 8:
Line 9: m2crypto
Piotr Kliczewski has posted comments on this change.
Change subject: xmlrpc: retry when flushing socket
..
Patch Set 5:
(2 comments)
https://gerrit.ovirt.org/#/c/47637/5//COMMIT_MSG
Commit Message:
Line 8:
Line 9: m2crypto
Piotr Kliczewski has posted comments on this change.
Change subject: Adding vdsm functional tests
..
Patch Set 48:
(1 comment)
https://gerrit.ovirt.org/#/c/48268/48/automation/check-patch.repos.fc22
File automation/check
Piotr Kliczewski has posted comments on this change.
Change subject: xmlrpc: retry when flushing socket
..
Patch Set 5: Verified+1
Rebase only
--
To view, visit https://gerrit.ovirt.org/47637
To unsubscribe, visit https
Piotr Kliczewski has posted comments on this change.
Change subject: build: enforce abs_import check
..
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/53050
To unsubscribe, visit https
Piotr Kliczewski has posted comments on this change.
Change subject: vdsm: Remove unreachable code
..
Patch Set 2: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/52980
To unsubscribe, visit https://gerrit.ovirt.org
Piotr Kliczewski has posted comments on this change.
Change subject: hooks: make sure to handle vdsm exception in the bridge
..
Patch Set 1:
jenkins failure not related to this change.
--
To view, visit https
Piotr Kliczewski has posted comments on this change.
Change subject: hooks: make sure to handle vdsm exception in the bridge
..
Patch Set 1: Verified+1
Verified using latest engine and checking that hook error properly
Piotr Kliczewski has posted comments on this change.
Change subject: hooks: moving hook error to exception module
..
Patch Set 1: Verified+1
Verified using latest engine and checking that hook error properly propagates
to the
Piotr Kliczewski has posted comments on this change.
Change subject: exception: Make VdsmException reusable
..
Patch Set 1: Verified+1
Verified using latest engine and checking that hook error properly propagates
to the
this issue by overriding __init__.
Required-For: https://bugzilla.redhat.com/1295778
Change-Id: Icd6643d9670cb9b067e372bf5a1a6c57ced41954
Signed-off-by: Nir Soffer
Reviewed-on: https://gerrit.ovirt.org/48875
Reviewed-by: Francesco Romani
Reviewed-by: Piotr Kliczewski
Continuous-Integration: Je
Piotr Kliczewski has uploaded a new change for review.
Change subject: hooks: make sure to handle vdsm exception in the bridge
..
hooks: make sure to handle vdsm exception in the bridge
We need to make sure to handle hook
Piotr Kliczewski has uploaded a new change for review.
Change subject: hooks: moving hook error to exception module
..
hooks: moving hook error to exception module
Required-For: https://bugzilla.redhat.com/1295778
Change-Id
Piotr Kliczewski has posted comments on this change.
Change subject: untested: notify Engine when host connectivity changes
..
Patch Set 2: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/51135
To unsubscribe, visit
Piotr Kliczewski has posted comments on this change.
Change subject: net: When IPv6 is not enabled, fallback to IPv4
..
Patch Set 2: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/52366
To unsubscribe, visit https
Piotr Kliczewski has posted comments on this change.
Change subject: [wip] contrib: schema converter
..
Patch Set 1:
(1 comment)
https://gerrit.ovirt.org/#/c/52864/1/contrib/schema-converter
File contrib/schema-converter
Piotr Kliczewski has posted comments on this change.
Change subject: tests: lib: add tests for utils.weakmethod
..
Patch Set 3: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/52408
To unsubscribe, visit https
Piotr Kliczewski has posted comments on this change.
Change subject: service: change vdsm KillMode to mixed
..
Patch Set 8:
We need to verify it first.
--
To view, visit https://gerrit.ovirt.org/45038
To unsubscribe, visit
Piotr Kliczewski has posted comments on this change.
Change subject: hooks: make sure to handle vdsm exception in the bridge
..
Patch Set 7:
Rebase only
--
To view, visit https://gerrit.ovirt.org/51549
To unsubscribe, visit
Piotr Kliczewski has posted comments on this change.
Change subject: hooks: moving hook error to exception module
..
Patch Set 3:
Rebase only.
--
To view, visit https://gerrit.ovirt.org/52413
To unsubscribe, visit https
Piotr Kliczewski has posted comments on this change.
Change subject: concurrent: Introduce concurrent.thread() utility
..
Patch Set 2: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/52699
To unsubscribe, visit https
Piotr Kliczewski has posted comments on this change.
Change subject: health: Report resource usage
..
Patch Set 2: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/52701
To unsubscribe, visit https://gerrit.ovirt.org
Piotr Kliczewski has posted comments on this change.
Change subject: health: Introduce Vdsm health monitoring
..
Patch Set 2: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/52700
To unsubscribe, visit https
Piotr Kliczewski has posted comments on this change.
Change subject: migration: set timeout to 10 mins
..
Patch Set 2:
Francesco are you ok with merging this patch?
--
To view, visit https://gerrit.ovirt.org/52548
To
Piotr Kliczewski has posted comments on this change.
Change subject: Kill and report asyncProc if fails on first write to stdin
..
Patch Set 5:
(1 comment)
Will fix the test
https://gerrit.ovirt.org/#/c/51763/5/lib/vdsm
Piotr Kliczewski has posted comments on this change.
Change subject: concurrent: Introduce concurrent.thread() utility
..
Patch Set 2: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/52624
To unsubscribe, visit https
Piotr Kliczewski has posted comments on this change.
Change subject: health: Introduce Vdsm health monitoring
..
Patch Set 2: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/52625
To unsubscribe, visit https
Piotr Kliczewski has posted comments on this change.
Change subject: health: Report resource usage
..
Patch Set 2: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/52626
To unsubscribe, visit https://gerrit.ovirt.org
Piotr Kliczewski has posted comments on this change.
Change subject: Kill and report asyncProc if fails on first write to stdin
..
Patch Set 5:
(1 comment)
https://gerrit.ovirt.org/#/c/51763/5/lib/vdsm/commands.py
File lib
Piotr Kliczewski has posted comments on this change.
Change subject: Introducing context manager to terminate async processes on
internal fail
..
Patch Set 18: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/51407
Piotr Kliczewski has posted comments on this change.
Change subject: Move hooking.py to vdsm/lib
..
Patch Set 1:
This patch looks like good time that we could fix it.
--
To view, visit https://gerrit.ovirt.org/52647
To
Piotr Kliczewski has posted comments on this change.
Change subject: Move hooking.py to vdsm/lib
..
Patch Set 1: Code-Review-1
(3 comments)
https://gerrit.ovirt.org/#/c/52647/1/vdsm_hooks/ovs/ovs_after_get_caps.py
File
Piotr Kliczewski has posted comments on this change.
Change subject: resourceManager: Fix ResourceRef leak
..
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/52629
To unsubscribe, visit https
Piotr Kliczewski has posted comments on this change.
Change subject: health: Report resource usage
..
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/52626
To unsubscribe, visit https://gerrit.ovirt.org
Piotr Kliczewski has posted comments on this change.
Change subject: health: Introduce Vdsm health monitoring
..
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/52625
To unsubscribe, visit https
Piotr Kliczewski has posted comments on this change.
Change subject: concurrent: Introduce concurrent.thread() utility
..
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/52624
To unsubscribe, visit https
Piotr Kliczewski has posted comments on this change.
Change subject: migration: set timeout to 10 mins
..
Patch Set 2:
(1 comment)
https://gerrit.ovirt.org/#/c/52548/2/lib/vdsm/config.py.in
File lib/vdsm/config.py.in:
Line
Piotr Kliczewski has posted comments on this change.
Change subject: migration: set timeout to 10 mins
..
Patch Set 2:
(1 comment)
https://gerrit.ovirt.org/#/c/52548/2/lib/vdsm/config.py.in
File lib/vdsm/config.py.in:
Line
Piotr Kliczewski has posted comments on this change.
Change subject: tests: JsonRpcClient tests suite
..
Patch Set 4:
ping
--
To view, visit https://gerrit.ovirt.org/43582
To unsubscribe, visit https://gerrit.ovirt.org
Piotr Kliczewski has posted comments on this change.
Change subject: tests: JsonRpcServer tests suite
..
Patch Set 4:
ping
--
To view, visit https://gerrit.ovirt.org/43581
To unsubscribe, visit https://gerrit.ovirt.org
Piotr Kliczewski has posted comments on this change.
Change subject: terminating tests - verify process death
..
Patch Set 7: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/52362
To unsubscribe, visit https
Piotr Kliczewski has posted comments on this change.
Change subject: resourceManager: Fix ResourceRef leak
..
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/52563
To unsubscribe, visit https
Piotr Kliczewski has posted comments on this change.
Change subject: lib: use weakmethod to break reference cycles
..
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/52558
To unsubscribe, visit https
Piotr Kliczewski has posted comments on this change.
Change subject: net: When IPv6 is not enabled, fallback to IPv4
..
Patch Set 1:
(1 comment)
https://gerrit.ovirt.org/#/c/52366/1/vdsm/clientIF.py
File vdsm/clientIF.py
Piotr Kliczewski has posted comments on this change.
Change subject: health: Warn about delays in monitor threads
..
Patch Set 1:
(1 comment)
I like the idea, hopefully it would help use solve the issue.
Please update
Piotr Kliczewski has posted comments on this change.
Change subject: Due to systemd we don't require to use deathSignal to kill
fence scripts
..
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/524
Piotr Kliczewski has posted comments on this change.
Change subject: hooks: make sure to handle vdsm exception in the bridge
..
Patch Set 5:
(1 comment)
https://gerrit.ovirt.org/#/c/51549/5/tests/bridgeTests.py
File tests
Piotr Kliczewski has posted comments on this change.
Change subject: hooks: make sure to handle vdsm exception in the bridge
..
Patch Set 6: Verified+1
Verified by testing with engine knowing nothing about code 1500.
--
To
Piotr Kliczewski has posted comments on this change.
Change subject: hooks: moving hook error to exception module
..
Patch Set 2:
Verified with the engine not knowing about code 1500. Here is the exception
hierarchy on the
Piotr Kliczewski has posted comments on this change.
Change subject: exception: Add exceptions for vdsm.define errors
..
Patch Set 13: -Code-Review
Let's have it finished
--
To view, visit https://gerrit.ovirt.org/488
Piotr Kliczewski has posted comments on this change.
Change subject: migration: set timeout to 10 mins
..
Patch Set 2: Verified+1
Run migration using 2 hosts on f22. The migration was successful and correct
timeout was used
Piotr Kliczewski has uploaded a new change for review.
Change subject: migration: set timeout to 10 mins
..
migration: set timeout to 10 mins
On heavily loaded environments createMigration call can take a lot of
time so we want
Piotr Kliczewski has posted comments on this change.
Change subject: [wip] build: assumptions about the path do not work for
distcheck
..
Patch Set 1:
(1 comment)
https://gerrit.ovirt.org/#/c/52508/1//COMMIT_MSG
Commit
Piotr Kliczewski has posted comments on this change.
Change subject: build: make lib/api directory writable
..
Patch Set 1: Verified+1
Verified by running make distcheck and make rpm. There is still issue with make
distcheck
Piotr Kliczewski has uploaded a new change for review.
Change subject: build: make lib/api directory writable
..
build: make lib/api directory writable
During make distcheck generation of vdsm-api.html file fails due to
missing
Piotr Kliczewski has posted comments on this change.
Change subject: terminating tests - verify process death
..
Patch Set 3: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/52362
To unsubscribe, visit https
Piotr Kliczewski has posted comments on this change.
Change subject: hooks: moving hook error to exception module
..
Patch Set 1:
Not yet, will do
--
To view, visit https://gerrit.ovirt.org/52413
To unsubscribe, visit https
Piotr Kliczewski has posted comments on this change.
Change subject: net: Cleanup _create_socket from dead code
..
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/52462
To unsubscribe, visit https
Piotr Kliczewski has posted comments on this change.
Change subject: hooks: make sure to handle vdsm exception in the bridge
..
Patch Set 5:
(2 comments)
https://gerrit.ovirt.org/#/c/51549/5/tests/bridgeTests.py
File tests
Piotr Kliczewski has posted comments on this change.
Change subject: hooks: moving hook error to exception module
..
Patch Set 1:
New error code will be handled by 3.6+. Older engines would go with default
case which is
Piotr Kliczewski has posted comments on this change.
Change subject: lib: use weakmethod to break reference cycles
..
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/52423
To unsubscribe, visit https
Piotr Kliczewski has posted comments on this change.
Change subject: Introducing context manager to terminate async processes on
internal fail
..
Patch Set 14: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/51407
Piotr Kliczewski has posted comments on this change.
Change subject: net: When IPv6 is not enabled, fallback to IPv4
..
Patch Set 1:
(1 comment)
https://gerrit.ovirt.org/#/c/52366/1/vdsm/clientIF.py
File vdsm/clientIF.py
Piotr Kliczewski has posted comments on this change.
Change subject: health: Introduce Vdsm health monitoring
..
Patch Set 7: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/51708
To unsubscribe, visit https
Piotr Kliczewski has posted comments on this change.
Change subject: health: Report resource usage
..
Patch Set 4: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/51916
To unsubscribe, visit https://gerrit.ovirt.org
Piotr Kliczewski has posted comments on this change.
Change subject: net: When IPv6 is not enabled, fallback to IPv4
..
Patch Set 1:
(1 comment)
https://gerrit.ovirt.org/#/c/52366/1/vdsm/clientIF.py
File vdsm/clientIF.py
Piotr Kliczewski has posted comments on this change.
Change subject: hooks: make sure to handle vdsm exception in the bridge
..
Patch Set 5: Verified+1
Verified by deploying vdsm and seeing that there are no implication of
Piotr Kliczewski has posted comments on this change.
Change subject: tests: simplify bridge tests
..
Patch Set 1: Verified+1
--
To view, visit https://gerrit.ovirt.org/52414
To unsubscribe, visit https://gerrit.ovirt.org
Piotr Kliczewski has posted comments on this change.
Change subject: hooks: moving hook error to exception module
..
Patch Set 1: Verified+1
Verified by deploying vdsm and seeing that there are no implication of this
change
Piotr Kliczewski has posted comments on this change.
Change subject: tests: simplify bridge tests
..
Patch Set 1:
build failure not related to this patch
--
To view, visit https://gerrit.ovirt.org/52414
To unsubscribe, visit
Piotr Kliczewski has uploaded a new change for review.
Change subject: hooks: moving hook error to exception module
..
hooks: moving hook error to exception module
Change-Id: I920a7ecff2f5e0b604f8c13dce2e59bdeef30056
Signed
Piotr Kliczewski has uploaded a new change for review.
Change subject: tests: simplify bridge tests
..
tests: simplify bridge tests
Change-Id: I02f9fb60898b49f63915ac6a26b6e62d5e09a4d0
Signed-off-by: pkliczewski
---
M tests
Piotr Kliczewski has posted comments on this change.
Change subject: lib: use weakmethod to break reference cycles
..
Patch Set 15: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/51630
To unsubscribe, visit https
Piotr Kliczewski has posted comments on this change.
Change subject: health: Introduce Vdsm health monitoring
..
Patch Set 6:
What I mean is that there is an effort to improve amount of data that we
collect about vdsm/engine
Piotr Kliczewski has uploaded a new change for review.
Change subject: schema: introduction of yaml schema format
..
schema: introduction of yaml schema format
The vdsm-api file contains potential format of new schema. There
Piotr Kliczewski has posted comments on this change.
Change subject: utils: add weakmethod helper
..
Patch Set 11: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/51865
To unsubscribe, visit https://gerrit.ovirt.org
Piotr Kliczewski has posted comments on this change.
Change subject: net: When IPv6 is not enabled, fallback to IPv4
..
Patch Set 1: Code-Review-1
(1 comment)
https://gerrit.ovirt.org/#/c/52366/1/vdsm/clientIF.py
File vdsm
Piotr Kliczewski has posted comments on this change.
Change subject: contrib: Simple jsonrpc client
..
Patch Set 7:
(8 comments)
https://gerrit.ovirt.org/#/c/35181/7/contrib/jsonrpc
File contrib/jsonrpc:
Line 25: methods and
Piotr Kliczewski has posted comments on this change.
Change subject: supervdsm: failed validateAccess leaves pipes open
..
Patch Set 1: Verified+1
Verified on prod env using master branch.
--
To view, visit https
Piotr Kliczewski has posted comments on this change.
Change subject: supervdsm: failed validateAccess leaves pipes open
..
Patch Set 1:
Rerun-Hooks: all
--
To view, visit https://gerrit.ovirt.org/52365
To unsubscribe, visit
Piotr Kliczewski has uploaded a new change for review.
Change subject: supervdsm: failed validateAccess leaves pipes open
..
supervdsm: failed validateAccess leaves pipes open
Whenever we run validateAccess and it fails with
Piotr Kliczewski has posted comments on this change.
Change subject: untested: notify Engine when host connectivity changes
..
Patch Set 2:
Subscription id looks good.
--
To view, visit https://gerrit.ovirt.org/51135
To
1101 - 1200 of 2910 matches
Mail list logo
