Change in vdsm[master]: storage: Add inplace virt-sparsify support

Shmuel Leib Melamud has posted comments on this change. Change subject: storage: Add inplace virt-sparsify support .. Patch Set 13: (3 comments) https://gerrit.ovirt.org/#/c/57347/13/lib/vdsm/virtsparsify.py File lib/vdsm/virt

Change in vdsm[master]: storage: Add inplace virt-sparsify support

Shmuel Leib Melamud has posted comments on this change. Change subject: storage: Add inplace virt-sparsify support .. Patch Set 13: (1 comment) https://gerrit.ovirt.org/#/c/57347/13/vdsm/storage/sdm/api/sparsify_volume.py File

Change in vdsm[master]: storage: Add inplace virt-sparsify support

Shmuel Leib Melamud has posted comments on this change. Change subject: storage: Add inplace virt-sparsify support .. Patch Set 13: Verified+1 (1 comment) https://gerrit.ovirt.org/#/c/57347/12/vdsm/storage/sdm/api/sparsify_vol

Change in vdsm[master]: storage: Add inplace virt-sparsify support

Shmuel Leib Melamud has posted comments on this change. Change subject: storage: Add inplace virt-sparsify support .. Patch Set 12: (1 comment) https://gerrit.ovirt.org/#/c/57347/12/vdsm/storage/sdm/api/sparsify_volume.py File

Change in vdsm[master]: storage: Add inplace virt-sparsify support

Shmuel Leib Melamud has posted comments on this change. Change subject: storage: Add inplace virt-sparsify support .. Patch Set 12: Verified+1 (14 comments) https://gerrit.ovirt.org/#/c/57347/11/lib/api/vdsm-api.yml File lib/a

Change in vdsm[master]: storage: Add inplace virt-sparsify support

Shmuel Leib Melamud has posted comments on this change. Change subject: storage: Add inplace virt-sparsify support .. Patch Set 11: (2 comments) https://gerrit.ovirt.org/#/c/57347/10/lib/api/vdsm-api.yml File lib/api/vdsm-api.

Change in vdsm[master]: storage: Add inplace virt-sparsify support

Shmuel Leib Melamud has posted comments on this change. Change subject: storage: Add inplace virt-sparsify support .. Patch Set 10: (1 comment) https://gerrit.ovirt.org/#/c/57347/10/lib/vdsm/virtsparsify.py File lib/vdsm/virts

Change in vdsm[master]: storage: Add inplace virt-sparsify support

Shmuel Leib Melamud has posted comments on this change. Change subject: storage: Add inplace virt-sparsify support .. Patch Set 10: (1 comment) https://gerrit.ovirt.org/#/c/57347/10/lib/api/vdsm-api.yml File lib/api/vdsm-api.y

Change in vdsm[master]: storage: Add inplace virt-sparsify support

Shmuel Leib Melamud has posted comments on this change. Change subject: storage: Add inplace virt-sparsify support .. Patch Set 10: > looks good to me, but it seems one comment from Nir about > vol.isSparse(0 was not handled.

Change in vdsm[master]: storage: Add inplace virt-sparsify support

Shmuel Leib Melamud has posted comments on this change. Change subject: storage: Add inplace virt-sparsify support .. Patch Set 9: (5 comments) https://gerrit.ovirt.org/#/c/57347/8/lib/api/vdsm-api.yml File lib/api/vdsm-api.ym

Change in vdsm[master]: storage: Add inplace virt-sparsify support

Shmuel Leib Melamud has posted comments on this change. Change subject: storage: Add inplace virt-sparsify support .. Patch Set 6: (18 comments) https://gerrit.ovirt.org/#/c/57347/5/client/vdsClient.py File client/vdsClient.py

Change in vdsm[master]: virt: Move VM status check from vm.cont() to API level

Shmuel Leib Melamud has posted comments on this change. Change subject: virt: Move VM status check from vm.cont() to API level .. Patch Set 4: (1 comment) https://gerrit.ovirt.org/#/c/47527/4//COMMIT_MSG Commit Message: Line

Change in vdsm[master]: storage: Add inplace virt-sparsify support

Hello Shmuel Melamud, I'd like you to do a code review. Please visit https://gerrit.ovirt.org/57347 to review the following change. Change subject: storage: Add inplace virt-sparsify support .. storage: Add inplace virt-s

Change in vdsm[master]: virt: Move VM status check from vm.cont() to API level

Shmuel Leib Melamud has posted comments on this change. Change subject: virt: Move VM status check from vm.cont() to API level .. Patch Set 4: Verified+1 As discussed, moved VM status check from vm.cont() to the API level. --

Change in vdsm[master]: virt: Allow vm.cont() to resume VM in SAVING_STATE

Shmuel Leib Melamud has posted comments on this change. Change subject: virt: Allow vm.cont() to resume VM in SAVING_STATE .. Patch Set 3: (1 comment) https://gerrit.ovirt.org/#/c/47527/3/vdsm/virt/vm.py File vdsm/virt/vm.py:

Change in vdsm[master]: virt: Allow vm.cont() to resume VM in SAVING_STATE

Shmuel Leib Melamud has posted comments on this change. Change subject: virt: Allow vm.cont() to resume VM in SAVING_STATE .. Patch Set 3: ping -- To view, visit https://gerrit.ovirt.org/47527 To unsubscribe, visit https://ge

Change in vdsm[master]: virt: Allow vm.cont() to resume VM in SAVING_STATE

Shmuel Leib Melamud has posted comments on this change. Change subject: virt: Allow vm.cont() to resume VM in SAVING_STATE .. Patch Set 3: Verified+1 -- To view, visit https://gerrit.ovirt.org/47527 To unsubscribe, visit https

Change in vdsm[master]: virt: Correct VM state before vm.cont() in _recover()

Shmuel Leib Melamud has posted comments on this change. Change subject: virt: Correct VM state before vm.cont() in _recover() .. Patch Set 2: ping -- To view, visit https://gerrit.ovirt.org/47527 To unsubscribe, visit https:/

Change in vdsm[master]: vm: devices: drop support for ancient Engines

Shmuel Leib Melamud has posted comments on this change. Change subject: vm: devices: drop support for ancient Engines .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/49173 To unsubscribe, visit https:/

Change in vdsm[ovirt-3.6]: vm: Remove empty RNG devices left after 3.5->3.6 upgrade

Shmuel Leib Melamud has posted comments on this change. Change subject: vm: Remove empty RNG devices left after 3.5->3.6 upgrade .. Patch Set 1: Verified+1 -- To view, visit https://gerrit.ovirt.org/49087 To unsubscribe, visit

Change in vdsm[ovirt-3.6]: vm: Remove empty RNG devices left after 3.5->3.6 upgrade

Shmuel Leib Melamud has uploaded a new change for review. Change subject: vm: Remove empty RNG devices left after 3.5->3.6 upgrade .. vm: Remove empty RNG devices left after 3.5->3.6 upgrade Clean out unknown devices that are cr

Change in vdsm[master]: vm: Remove empty RNG devices left after 3.5->3.6 upgrade

Shmuel Leib Melamud has posted comments on this change. Change subject: vm: Remove empty RNG devices left after 3.5->3.6 upgrade .. Patch Set 3: Verified+1 -- To view, visit https://gerrit.ovirt.org/48621 To unsubscribe, visit

Change in vdsm[master]: vm: Remove empty RNG devices left after 3.5->3.6 upgrade

Shmuel Leib Melamud has posted comments on this change. Change subject: vm: Remove empty RNG devices left after 3.5->3.6 upgrade .. Patch Set 2: Verified+1 -- To view, visit https://gerrit.ovirt.org/48621 To unsubscribe, visit

Change in vdsm[master]: vm: Remove empty RNG devices left after 3.5->3.6 upgrade

Shmuel Leib Melamud has posted comments on this change. Change subject: vm: Remove empty RNG devices left after 3.5->3.6 upgrade .. Patch Set 1: (4 comments) https://gerrit.ovirt.org/#/c/48621/1//COMMIT_MSG Commit Message: Li

Change in vdsm[master]: Remove vdsm/vdsm-logrotate.conf from .gitignore

Shmuel Leib Melamud has uploaded a new change for review. Change subject: Remove vdsm/vdsm-logrotate.conf from .gitignore .. Remove vdsm/vdsm-logrotate.conf from .gitignore vdsm/vdsm-logrotate.conf is no more generated, so remov

Change in vdsm[master]: Remove vdsm/vdsm-logrotate.conf from .gitignore

Shmuel Leib Melamud has posted comments on this change. Change subject: Remove vdsm/vdsm-logrotate.conf from .gitignore .. Patch Set 1: Verified+1 -- To view, visit https://gerrit.ovirt.org/48629 To unsubscribe, visit https://

Change in vdsm[master]: vm: Remove empty RNG devices left after 3.5->3.6 upgrade

Shmuel Leib Melamud has uploaded a new change for review. Change subject: vm: Remove empty RNG devices left after 3.5->3.6 upgrade .. vm: Remove empty RNG devices left after 3.5->3.6 upgrade Clean out unknown devices that are cr

Change in vdsm[master]: vm: Remove empty RNG devices left after 3.5->3.6 upgrade

Shmuel Leib Melamud has posted comments on this change. Change subject: vm: Remove empty RNG devices left after 3.5->3.6 upgrade .. Patch Set 1: Verified+1 -- To view, visit https://gerrit.ovirt.org/48621 To unsubscribe, visit

Change in vdsm[master]: virt: Correct VM state before vm.cont() in _recover()

Shmuel Leib Melamud has posted comments on this change. Change subject: virt: Correct VM state before vm.cont() in _recover() .. Patch Set 2: Verified+1 -- To view, visit https://gerrit.ovirt.org/47527 To unsubscribe, visit ht

Change in vdsm[master]: virt: Correct VM state before vm.cont() in _recover()

Shmuel Leib Melamud has posted comments on this change. Change subject: virt: Correct VM state before vm.cont() in _recover() .. Patch Set 1: (1 comment) https://gerrit.ovirt.org/#/c/47527/1/vdsm/virt/migration.py File vdsm/vi

Change in vdsm[master]: virt: Correct VM state before vm.cont() in _recover()

Shmuel Leib Melamud has posted comments on this change. Change subject: virt: Correct VM state before vm.cont() in _recover() .. Patch Set 1: Verified+1 -- To view, visit https://gerrit.ovirt.org/47527 To unsubscribe, visit ht

Change in vdsm[master]: virt: Correct VM state before vm.cont() in _recover()

Shmuel Leib Melamud has uploaded a new change for review. Change subject: virt: Correct VM state before vm.cont() in _recover() .. virt: Correct VM state before vm.cont() in _recover() In SourceThread._recover(), if error occure

Change in vdsm[ovirt-3.6]: tests: Fix and simplify cleanup after failures

Shmuel Leib Melamud has posted comments on this change. Change subject: tests: Fix and simplify cleanup after failures .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/47342 To unsubscribe, visit https:

Change in vdsm[master]: tests: Fix and simplify cleanup after failures

Shmuel Leib Melamud has posted comments on this change. Change subject: tests: Fix and simplify cleanup after failures .. Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/46387 To unsubscribe, visit https:

Change in vdsm[master]: api: 'device' property for RNG device

Shmuel Leib Melamud has posted comments on this change. Change subject: api: 'device' property for RNG device .. Patch Set 2: Verified+1 -- To view, visit https://gerrit.ovirt.org/43166 To unsubscribe, visit https://gerrit.ovi

Change in vdsm[master]: api: 'device' property for RNG device

Shmuel Leib Melamud has posted comments on this change. Change subject: api: 'device' property for RNG device .. Patch Set 1: > how this would affect new vdsm on old (not fixed) engine? AFAIK, vdsmapi-schema.json is used only

Change in vdsm[master]: virt: Safe device type check for console device

Shmuel Leib Melamud has abandoned this change. Change subject: virt: Safe device type check for console device .. Abandoned Needs to be fixed in Engine and API spec corrected. -- To view, visit https://gerrit.ovirt.org/42881

Change in vdsm[master]: api: 'device' property for RNG device

Shmuel Leib Melamud has posted comments on this change. Change subject: api: 'device' property for RNG device .. Patch Set 1: Verified+1 -- To view, visit https://gerrit.ovirt.org/43166 To unsubscribe, visit https://gerrit.ovi

Change in vdsm[master]: api: 'device' property for RNG device

Hello Shmuel Melamud, I'd like you to do a code review. Please visit https://gerrit.ovirt.org/43166 to review the following change. Change subject: api: 'device' property for RNG device .. api: 'device' property for RNG d

Change in vdsm[master]: virt: Safe device type check for console device

Shmuel Leib Melamud has posted comments on this change. Change subject: virt: Safe device type check for console device .. Patch Set 1: (1 comment) https://gerrit.ovirt.org/#/c/42881/1/vdsm/virt/vm.py File vdsm/virt/vm.py: Li

Change in vdsm[master]: virt: Safe device type check for console device

Shmuel Leib Melamud has posted comments on this change. Change subject: virt: Safe device type check for console device .. Patch Set 1: (1 comment) https://gerrit.ovirt.org/#/c/42881/1/vdsm/virt/vm.py File vdsm/virt/vm.py: Li

Change in vdsm[master]: virt: Safe device type check for console device

Shmuel Leib Melamud has posted comments on this change. Change subject: virt: Safe device type check for console device .. Patch Set 1: Verified+1 The fix is easy, but the question is how many places exist elsewhere that have

Change in vdsm[master]: virt: Safe device type check for console device

Hello Shmuel Melamud, I'd like you to do a code review. Please visit https://gerrit.ovirt.org/42881 to review the following change. Change subject: virt: Safe device type check for console device .. virt: Safe device type

Change in vdsm[master]: vm: Detect smartcard device by type

Shmuel Leib Melamud has posted comments on this change. Change subject: vm: Detect smartcard device by type .. Patch Set 1: Verified+1 -- To view, visit https://gerrit.ovirt.org/41479 To unsubscribe, visit https://gerrit.ovirt

Change in vdsm[master]: vm: Detect smartcard device by type

Hello Shmuel Melamud, I'd like you to do a code review. Please visit https://gerrit.ovirt.org/41479 to review the following change. Change subject: vm: Detect smartcard device by type .. vm: Detect smartcard device by typ

Change in vdsm[master]: tests: Typo in TestVmDevicesXmlParsing

Shmuel Leib Melamud has posted comments on this change. Change subject: tests: Typo in TestVmDevicesXmlParsing .. Patch Set 1: Verified+1 -- To view, visit https://gerrit.ovirt.org/40813 To unsubscribe, visit https://gerrit.ov

Change in vdsm[master]: tests: Typo in TestVmDevicesXmlParsing

Hello Shmuel Melamud, I'd like you to do a code review. Please visit https://gerrit.ovirt.org/40813 to review the following change. Change subject: tests: Typo in TestVmDevicesXmlParsing .. tests: Typo in TestVmDevicesXml

Change in vdsm[master]: vm: Detect RNG device by type

Shmuel Leib Melamud has posted comments on this change. Change subject: vm: Detect RNG device by type .. Patch Set 1: (1 comment) https://gerrit.ovirt.org/#/c/40095/1/vdsm/virt/vm.py File vdsm/virt/vm.py: Line 4174:

Change in vdsm[master]: vm: Detect RNG device by type

Shmuel Leib Melamud has posted comments on this change. Change subject: vm: Detect RNG device by type .. Patch Set 1: Verified+1 -- To view, visit https://gerrit.ovirt.org/40095 To unsubscribe, visit https://gerrit.ovirt.org/s

Change in vdsm[master]: vm: Detect RNG device by type

Shmuel Leib Melamud has uploaded a new change for review. Change subject: vm: Detect RNG device by type .. vm: Detect RNG device by type In Vm._getUnderlyingRngDeviceInfo() method the RNG device must be detected in self.conf['de

Change in vdsm[master]: virt: configurable sampling interval for HostStatsThread

Shmuel Leib Melamud has posted comments on this change. Change subject: virt: configurable sampling interval for HostStatsThread .. Patch Set 2: > please describe how you verified this patch (it is required by the > review pro

Change in vdsm[master]: virt: configurable sampling interval for HostStatsThread

Shmuel Leib Melamud has posted comments on this change. Change subject: virt: configurable sampling interval for HostStatsThread .. Patch Set 2: Verified+1 -- To view, visit https://gerrit.ovirt.org/39191 To unsubscribe, visit

Change in vdsm[master]: virt: configurable sampling interval for HostStatsThread

Shmuel Leib Melamud has posted comments on this change. Change subject: virt: configurable sampling interval for HostStatsThread .. Patch Set 1: (1 comment) https://gerrit.ovirt.org/#/c/39191/1/lib/vdsm/config.py.in File lib/v

Change in vdsm[master]: virt: configurable sampling interval for HostStatsThread

Shmuel Leib Melamud has posted comments on this change. Change subject: virt: configurable sampling interval for HostStatsThread .. Patch Set 1: Verified+1 -- To view, visit https://gerrit.ovirt.org/39191 To unsubscribe, visit

Change in vdsm[master]: virt: configurable sampling interval for HostStatsThread

Shmuel Leib Melamud has uploaded a new change for review. Change subject: virt: configurable sampling interval for HostStatsThread .. virt: configurable sampling interval for HostStatsThread Sampling interval and averaging windo