Shmuel Leib Melamud has posted comments on this change. Change subject: virt: Safe device type check for console device ......................................................................
Patch Set 1: (1 comment) https://gerrit.ovirt.org/#/c/42881/1/vdsm/virt/vm.py File vdsm/virt/vm.py: Line 3907: if not hasattr(dev, 'alias'): Line 3908: dev.alias = alias Line 3909: Line 3910: for dev in self.conf['devices']: Line 3911: if dev.get('device') == hwclass.CONSOLE and \ > we hit this one time for rng devices, but now I'm starting to see one patte From my point of view - yes - the Engine should send both 'device' and 'type' fields for every device. Line 3912: not dev.get('alias'): Line 3913: dev['alias'] = alias Line 3914: Line 3915: def _getUnderlyingSmartcardDeviceInfo(self): -- To view, visit https://gerrit.ovirt.org/42881 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6a0c1adc6c3b2ab8d50b6e3ac712ce2dcf04cc6c Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Shmuel Leib Melamud <smela...@redhat.com> Gerrit-Reviewer: Arik Hadas <aha...@redhat.com> Gerrit-Reviewer: Francesco Romani <from...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Polednik <mpoled...@redhat.com> Gerrit-Reviewer: Michal Skrivanek <mskri...@redhat.com> Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com> Gerrit-Reviewer: Shmuel Leib Melamud <smela...@redhat.com> Gerrit-Reviewer: Shmuel Melamud <smela...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
