Change in vdsm[master]: virt: Memory hotunplug

2015-05-21 Thread vdelima
Vitor de Lima has uploaded a new change for review. Change subject: virt: Memory hotunplug .. virt: Memory hotunplug Support for unplugging virtual memory modules, this can be used with memory hotplug to dynamically set the VM m

Change in vdsm[master]: vm: Allow to use 'serial' or 'virtio' type consoles

2014-12-16 Thread vdelima
Vitor de Lima has posted comments on this change. Change subject: vm: Allow to use 'serial' or 'virtio' type consoles .. Patch Set 10: I don't know if it worth the effort, but ppc64 has another kind of paravirtualized console,

Change in vdsm[master]: build: Added link flags for safelease

2014-12-11 Thread vdelima
Vitor de Lima has posted comments on this change. Change subject: build: Added link flags for safelease .. Patch Set 2: Just a small problem, the patch is not signed off by you. -- To view, visit http://gerrit.ovirt.org/36093

Change in vdsm[master]: vmxml.py, vm.py: Remove QEMU passthrough hack in ppc64

2014-12-02 Thread vdelima
Vitor de Lima has posted comments on this change. Change subject: vmxml.py, vm.py: Remove QEMU passthrough hack in ppc64 .. Patch Set 4: (1 comment) http://gerrit.ovirt.org/#/c/33871/4/vdsm.spec.in File vdsm.spec.in: Line 160

Change in vdsm[master]: caps: Do not use lscpu on ppc64

2014-12-02 Thread vdelima
Vitor de Lima has posted comments on this change. Change subject: caps: Do not use lscpu on ppc64 .. Patch Set 5: Verified+1 (1 comment) http://gerrit.ovirt.org/#/c/33872/5/vdsm.spec.in File vdsm.spec.in: Line 197: Requires:

Change in vdsm[master]: caps: Do not use lscpu on ppc64

2014-11-27 Thread vdelima
Vitor de Lima has posted comments on this change. Change subject: caps: Do not use lscpu on ppc64 .. Patch Set 4: (1 comment) http://gerrit.ovirt.org/#/c/33872/4//COMMIT_MSG Commit Message: Line 7: caps: Do not use lscpu on p

Change in vdsm[master]: cache: Add caching decorator with invalidation

2014-11-26 Thread vdelima
Vitor de Lima has posted comments on this change. Change subject: cache: Add caching decorator with invalidation .. Patch Set 6: Verified+1 Verified using the unit tests. -- To view, visit http://gerrit.ovirt.org/34709 To uns

Change in vdsm[master]: cache: Add caching decorator with invalidation

2014-11-26 Thread vdelima
Vitor de Lima has posted comments on this change. Change subject: cache: Add caching decorator with invalidation .. Patch Set 5: (3 comments) http://gerrit.ovirt.org/#/c/34709/5/lib/vdsm/cache.py File lib/vdsm/cache.py: Line

Change in vdsm[master]: cache: Add caching decorator with invalidation

2014-11-26 Thread vdelima
Vitor de Lima has posted comments on this change. Change subject: cache: Add caching decorator with invalidation .. Patch Set 5: (3 comments) http://gerrit.ovirt.org/#/c/34709/5/lib/vdsm/cache.py File lib/vdsm/cache.py: Line

Change in vdsm[master]: cache: Add caching decorator with invalidation

2014-11-26 Thread vdelima
Vitor de Lima has posted comments on this change. Change subject: cache: Add caching decorator with invalidation .. Patch Set 4: (3 comments) http://gerrit.ovirt.org/#/c/34709/4/lib/vdsm/cache.py File lib/vdsm/cache.py: Line

Change in vdsm[master]: caps: Do not memoize CPU topology

2014-11-25 Thread vdelima
Vitor de Lima has posted comments on this change. Change subject: caps: Do not memoize CPU topology .. Patch Set 5: Verified+1 -- To view, visit http://gerrit.ovirt.org/34189 To unsubscribe, visit http://gerrit.ovirt.org/setti

Change in vdsm[master]: Add missing version comment in onlineCpus

2014-11-18 Thread vdelima
Vitor de Lima has posted comments on this change. Change subject: Add missing version comment in onlineCpus .. Patch Set 2: Verified+1 -- To view, visit http://gerrit.ovirt.org/35100 To unsubscribe, visit http://gerrit.ovirt.o

Change in vdsm[ovirt-3.5]: caps: Report online logical CPUs

2014-11-18 Thread vdelima
Vitor de Lima has posted comments on this change. Change subject: caps: Report online logical CPUs .. Patch Set 3: Verified+1 -- To view, visit http://gerrit.ovirt.org/34768 To unsubscribe, visit http://gerrit.ovirt.org/settin

Change in vdsm[master]: Memory Hotplug

2014-11-12 Thread vdelima
Vitor de Lima has posted comments on this change. Change subject: Memory Hotplug .. Patch Set 1: (2 comments) http://gerrit.ovirt.org/#/c/35080/1/vdsm/rpc/vdsmapi-schema.json File vdsm/rpc/vdsmapi-schema.json: Line : # Se

Change in vdsm[master]: Add missing version comment in onlineCpus

2014-11-12 Thread vdelima
Vitor de Lima has uploaded a new change for review. Change subject: Add missing version comment in onlineCpus .. Add missing version comment in onlineCpus The onlineCpus property of the capabilities command was missing a comment

Change in vdsm[master]: caps: Do not memoize CPU topology

2014-11-12 Thread vdelima
Vitor de Lima has posted comments on this change. Change subject: caps: Do not memoize CPU topology .. Patch Set 4: Verified+1 Used the vdsClient getVdsCaps command to check if the counts were correct, then disabled some logic

Change in vdsm[master]: Memory Hotplug

2014-11-12 Thread vdelima
Vitor de Lima has uploaded a new change for review. Change subject: Memory Hotplug .. Memory Hotplug Introduces a new method to increase the amount of memory of a guest and exposes it in the XML-RPC and JSON-RPC. Change-Id: I82

Change in vdsm[ovirt-3.5]: caps: Report online logical CPUs

2014-11-03 Thread vdelima
Vitor de Lima has posted comments on this change. Change subject: caps: Report online logical CPUs .. Patch Set 1: Verified+1 -- To view, visit http://gerrit.ovirt.org/34768 To unsubscribe, visit http://gerrit.ovirt.org/settin

Change in vdsm[ovirt-3.5]: caps: Report online logical CPUs

2014-11-03 Thread vdelima
Hello Dan Kenigsberg, Francesco Romani, I'd like you to do a code review. Please visit http://gerrit.ovirt.org/34768 to review the following change. Change subject: caps: Report online logical CPUs .. caps: Report online

Change in vdsm[ovirt-3.5]: caps: Additional ppc64 hardware information

2014-10-30 Thread vdelima
Vitor de Lima has posted comments on this change. Change subject: caps: Additional ppc64 hardware information .. Patch Set 1: Verified+1 -- To view, visit http://gerrit.ovirt.org/34617 To unsubscribe, visit http://gerrit.ovirt

Change in vdsm[ovirt-3.5]: caps: Additional ppc64 hardware information

2014-10-29 Thread vdelima
Hello Antoni Segura Puimedon, Dan Kenigsberg, I'd like you to do a code review. Please visit http://gerrit.ovirt.org/34617 to review the following change. Change subject: caps: Additional ppc64 hardware information .. cap

Change in vdsm[master]: caps: Do not memoize CPU topology

2014-10-29 Thread vdelima
Vitor de Lima has posted comments on this change. Change subject: caps: Do not memoize CPU topology .. Patch Set 3: Verified+1 Used the vdsClient getVdsCaps command to check if the counts were correct, then disabled some logic

Change in vdsm[master]: caps: Do not use lscpu on ppc64

2014-10-28 Thread vdelima
Vitor de Lima has posted comments on this change. Change subject: caps: Do not use lscpu on ppc64 .. Patch Set 3: I updated the commit message with the needed info. -- To view, visit http://gerrit.ovirt.org/33872 To unsubscri

Change in vdsm[master]: tests: move more fakes into vmfakelib

2014-10-28 Thread vdelima
Vitor de Lima has posted comments on this change. Change subject: tests: move more fakes into vmfakelib .. Patch Set 2: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/32821 To unsubscribe, visit http://gerrit.ovirt.or

Change in vdsm[master]: caps: Do not memoize CPU topology

2014-10-27 Thread vdelima
Vitor de Lima has posted comments on this change. Change subject: caps: Do not memoize CPU topology .. Patch Set 2: Losing the unit test is pretty bad, what do you suggest in order to fake the /sys entries that are needed by t

Change in vdsm[master]: caps: Additional ppc64 hardware information

2014-10-23 Thread vdelima
Vitor de Lima has posted comments on this change. Change subject: caps: Additional ppc64 hardware information .. Patch Set 4: Verified+1 -- To view, visit http://gerrit.ovirt.org/33857 To unsubscribe, visit http://gerrit.ovirt

Change in vdsm[master]: caps: Additional ppc64 hardware information

2014-10-23 Thread vdelima
Vitor de Lima has posted comments on this change. Change subject: caps: Additional ppc64 hardware information .. Patch Set 3: (1 comment) http://gerrit.ovirt.org/#/c/33857/3/vdsm/ppc64HardwareInfo.py File vdsm/ppc64HardwareInf

Change in vdsm[ovirt-3.5]: vm: Fix error with missing cdrom in conf

2014-10-21 Thread vdelima
Vitor de Lima has abandoned this change. Change subject: vm: Fix error with missing cdrom in conf .. Abandoned This just reduces log noise, so I am abandoning it. -- To view, visit http://gerrit.ovirt.org/33472 To unsubscribe

Change in vdsm[master]: vmxml.py, vm.py: Remove QEMU passthrough hack in ppc64

2014-10-21 Thread vdelima
Vitor de Lima has posted comments on this change. Change subject: vmxml.py, vm.py: Remove QEMU passthrough hack in ppc64 .. Patch Set 2: (1 comment) http://gerrit.ovirt.org/#/c/33871/2//COMMIT_MSG Commit Message: Line 5: Comm

Change in vdsm[master]: caps: Additional ppc64 hardware information

2014-10-21 Thread vdelima
Vitor de Lima has posted comments on this change. Change subject: caps: Additional ppc64 hardware information .. Patch Set 2: (3 comments) http://gerrit.ovirt.org/#/c/33857/2/vdsm/ppc64HardwareInfo.py File vdsm/ppc64HardwareIn

Change in vdsm[master]: caps: Additional ppc64 hardware information

2014-10-21 Thread vdelima
Vitor de Lima has posted comments on this change. Change subject: caps: Additional ppc64 hardware information .. Patch Set 3: Verified+1 -- To view, visit http://gerrit.ovirt.org/33857 To unsubscribe, visit http://gerrit.ovirt

Change in vdsm[master]: caps: Do not memoize CPU topology

2014-10-15 Thread vdelima
Vitor de Lima has posted comments on this change. Change subject: caps: Do not memoize CPU topology .. Patch Set 1: Verified+1 Used the vdsClient getVdsCaps command to check if the counts were correct, then disabled some logic

Change in vdsm[master]: caps: Do not memoize CPU topology

2014-10-15 Thread vdelima
Vitor de Lima has uploaded a new change for review. Change subject: caps: Do not memoize CPU topology .. caps: Do not memoize CPU topology This patch prevents the CPU topology from being memoized and implements a fast way to ret

Change in vdsm[master]: caps: Additional ppc64 hardware information

2014-10-10 Thread vdelima
Vitor de Lima has posted comments on this change. Change subject: caps: Additional ppc64 hardware information .. Patch Set 2: Verified+1 Verified by running the python module on a PowerKVM host and checking the returned data.

Change in vdsm[master]: caps: Report online logical CPUs

2014-10-09 Thread vdelima
Vitor de Lima has posted comments on this change. Change subject: caps: Report online logical CPUs .. Patch Set 2: (2 comments) http://gerrit.ovirt.org/#/c/33789/2/vdsm/caps.py File vdsm/caps.py: Line 221: def _getCapsXMLStr(

Change in vdsm[master]: vmxml.py, vm.py: Remove QEMU passthrough hack in ppc64

2014-10-08 Thread vdelima
Vitor de Lima has posted comments on this change. Change subject: vmxml.py, vm.py: Remove QEMU passthrough hack in ppc64 .. Patch Set 2: Verified+1 Verified by successfully running a ppc64 VM with only one keyboard and one mou

Change in vdsm[master]: vmxml.py, vm.py: Remove QEMU passthrough hack in ppc64

2014-10-08 Thread vdelima
Vitor de Lima has posted comments on this change. Change subject: vmxml.py, vm.py: Remove QEMU passthrough hack in ppc64 .. Patch Set 1: (2 comments) http://gerrit.ovirt.org/#/c/33871/1//COMMIT_MSG Commit Message: Line 5: Com

Change in vdsm[master]: caps: Report online logical CPUs

2014-10-08 Thread vdelima
Vitor de Lima has posted comments on this change. Change subject: caps: Report online logical CPUs .. Patch Set 2: Verified this patch by creating a fake Host with three cores, disabling the core with id 1 and trying to pin a

Change in vdsm[master]: caps: Report online logical CPUs

2014-10-08 Thread vdelima
Vitor de Lima has posted comments on this change. Change subject: caps: Report online logical CPUs .. Patch Set 2: Verified+1 -- To view, visit http://gerrit.ovirt.org/33789 To unsubscribe, visit http://gerrit.ovirt.org/settin

Change in vdsm[master]: virt: sampling: use getLastSample

2014-10-07 Thread vdelima
Vitor de Lima has posted comments on this change. Change subject: virt: sampling: use getLastSample .. Patch Set 1: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/33780 To unsubscribe, visit http://gerrit.ovirt.org/se

Change in vdsm[master]: vm: sampling: use collections.deque

2014-10-07 Thread vdelima
Vitor de Lima has posted comments on this change. Change subject: vm: sampling: use collections.deque .. Patch Set 2: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/33781 To unsubscribe, visit http://gerrit.ovirt.org/

Change in vdsm[master]: caps: Do not use lscpu on ppc64

2014-10-06 Thread vdelima
Vitor de Lima has uploaded a new change for review. Change subject: caps: Do not use lscpu on ppc64 .. caps: Do not use lscpu on ppc64 Recent libvirt versions correctly show the topology of ppc64 hosts, so it is not required the

Change in vdsm[master]: vmxml.py, vm.py: Remove QEMU passthrough hack in ppc64

2014-10-06 Thread vdelima
Vitor de Lima has uploaded a new change for review. Change subject: vmxml.py, vm.py: Remove QEMU passthrough hack in ppc64 .. vmxml.py, vm.py: Remove QEMU passthrough hack in ppc64 Recent libvirt versions already include a virtu

Change in vdsm[master]: caps: Report online logical CPUs

2014-10-06 Thread vdelima
Vitor de Lima has posted comments on this change. Change subject: caps: Report online logical CPUs .. Patch Set 1: (3 comments) http://gerrit.ovirt.org/#/c/33789/1//COMMIT_MSG Commit Message: Line 7: caps: Report online logic

Change in vdsm[master]: vdsm: Additional ppc64 hardware information

2014-10-06 Thread vdelima
Vitor de Lima has uploaded a new change for review. Change subject: vdsm: Additional ppc64 hardware information .. vdsm: Additional ppc64 hardware information Includes extra information (manufacturer and product name) about ppc6

Change in vdsm[master]: caps: Report online logical CPUs

2014-10-03 Thread vdelima
Vitor de Lima has uploaded a new change for review. Change subject: caps: Report online logical CPUs .. caps: Report online logical CPUs Introduces a new information in the capabilities command which reports the list of logical

Change in vdsm[ovirt-3.5]: vm: Fix error with missing cdrom in conf

2014-10-01 Thread vdelima
Vitor de Lima has posted comments on this change. Change subject: vm: Fix error with missing cdrom in conf .. Patch Set 2: Verified+1 -- To view, visit http://gerrit.ovirt.org/33472 To unsubscribe, visit http://gerrit.ovirt.or

Change in vdsm[master]: vm: Fix error with missing cdrom in conf

2014-10-01 Thread vdelima
Vitor de Lima has posted comments on this change. Change subject: vm: Fix error with missing cdrom in conf .. Patch Set 1: Verified+1 (1 comment) http://gerrit.ovirt.org/#/c/33501/1//COMMIT_MSG Commit Message: Line 5: CommitD

Change in vdsm[master]: vm: Fix error with missing cdrom in conf

2014-09-29 Thread vdelima
Vitor de Lima has uploaded a new change for review. Change subject: vm: Fix error with missing cdrom in conf .. vm: Fix error with missing cdrom in conf Avoids referencing the cdrom parameter in conf in case it is missing. Chan

Change in vdsm[master]: vm: Fix error with missing cdrom in conf

2014-09-29 Thread vdelima
Vitor de Lima has abandoned this change. Change subject: vm: Fix error with missing cdrom in conf .. Abandoned Sent it with the wrong Change-Id. -- To view, visit http://gerrit.ovirt.org/33495 To unsubscribe, visit http://ger

Change in vdsm[master]: vm: Fix error with missing cdrom in conf

2014-09-29 Thread vdelima
Vitor de Lima has posted comments on this change. Change subject: vm: Fix error with missing cdrom in conf .. Patch Set 1: (2 comments) http://gerrit.ovirt.org/#/c/33495/1//COMMIT_MSG Commit Message: Line 5: CommitDate: 2014-

Change in vdsm[master]: vm: Fix error with missing cdrom in conf

2014-09-29 Thread vdelima
Vitor de Lima has uploaded a new change for review. Change subject: vm: Fix error with missing cdrom in conf .. vm: Fix error with missing cdrom in conf Avoids referencing the cdrom parameter in conf in case it is missing. Chan

Change in vdsm[ovirt-3.5]: vm: Fix error with missing cdrom in conf

2014-09-29 Thread vdelima
Vitor de Lima has posted comments on this change. Change subject: vm: Fix error with missing cdrom in conf .. Patch Set 1: (2 comments) http://gerrit.ovirt.org/#/c/33472/1//COMMIT_MSG Commit Message: Line 5: CommitDate: 2014-

Change in vdsm[ovirt-3.5]: vm: Fix error with missing cdrom in conf

2014-09-29 Thread vdelima
Vitor de Lima has uploaded a new change for review. Change subject: vm: Fix error with missing cdrom in conf .. vm: Fix error with missing cdrom in conf Avoids referencing the cdrom parameter in conf in case it is missing. Chan