Vitor de Lima has posted comments on this change. Change subject: caps: Additional ppc64 hardware information ......................................................................
Patch Set 3: (1 comment) http://gerrit.ovirt.org/#/c/33857/3/vdsm/ppc64HardwareInfo.py File vdsm/ppc64HardwareInfo.py: Line 50: infoStructure['systemSerialNumber'] = value Line 51: elif key == 'machine': Line 52: infoStructure['systemVersion'] = value Line 53: Line 54: _updateFromDeviceTree(infoStructure, 'systemUUID', 'system-id') > I have to say, that I find much more pythonic and simple the following: Done Line 55: Line 56: _updateFromDeviceTree(infoStructure, 'systemProductName', 'model-name') Line 57: Line 58: _updateFromDeviceTree(infoStructure, 'systemManufacturer', 'vendor') -- To view, visit http://gerrit.ovirt.org/33857 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8f67a830740b64bc246f680f2c7a18a4293f4cc2 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Vitor de Lima <[email protected]> Gerrit-Reviewer: Antoni Segura Puimedon <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Francesco Romani <[email protected]> Gerrit-Reviewer: Vinzenz Feenstra <[email protected]> Gerrit-Reviewer: Vitor de Lima <[email protected]> Gerrit-Reviewer: Yaniv Bronhaim <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
