Dan Kenigsberg has posted comments on this change.
Change subject: Deactivate libvirtVM.Drives()
..
Patch Set 3: I would prefer that you didn't submit this
(3 inline comments)
Michal Skrivanek has posted comments on this change.
Change subject: Deactivate libvirtVM.Drives()
..
Patch Set 3: I would prefer that you didn't submit this
I think we should rather address the issue in
Michal Skrivanek has posted comments on this change.
Change subject: Deactivate libvirtVM.Drives()
..
Patch Set 3: No score
maybe not:-)
--
To view, visit http://gerrit.ovirt.org/14869
To unsubscribe, visit
Peter V. Saveliev has posted comments on this change.
Change subject: Deactivate libvirtVM.Drives()
..
Patch Set 3:
Michal, you're not right — there each dict, passed as a parameter, is treated
as separated object. It is not
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Deactivate libvirtVM.Drives()
..
Patch Set 4:
Build Started http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/2369/ (1/3)
--
To view, visit
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Deactivate libvirtVM.Drives()
..
Patch Set 4:
Build Started http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/1534/ (2/3)
--
To view, visit
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Deactivate libvirtVM.Drives()
..
Patch Set 4:
Build Started http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/2436/ (3/3)
--
To view, visit
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Deactivate libvirtVM.Drives()
..
Patch Set 4:
Build Successful
http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/2369/ : SUCCESS
Yeela Kaplan has posted comments on this change.
Change subject: Deactivate libvirtVM.Drives()
..
Patch Set 4: Verified
windows vm was started and shutdown successfully. Could see that volume was
deactivated.
--
To view,
Ayal Baron has posted comments on this change.
Change subject: Deactivate libvirtVM.Drives()
..
Patch Set 4: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/14869
To unsubscribe, visit
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Deactivate libvirtVM.Drives()
..
Patch Set 5:
Build Started http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/2373/ (2/3)
--
To view, visit
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Deactivate libvirtVM.Drives()
..
Patch Set 5:
Build Started http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/2440/ (1/3)
--
To view, visit
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Deactivate libvirtVM.Drives()
..
Patch Set 5:
Build Started http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/1538/ (3/3)
--
To view, visit
Dan Kenigsberg has posted comments on this change.
Change subject: Deactivate libvirtVM.Drives()
..
Patch Set 5: Verified; Looks good to me, approved
Copying score; only changed commit message.
--
To view, visit
Dan Kenigsberg has submitted this change and it was merged.
Change subject: Deactivate libvirtVM.Drives()
..
Deactivate libvirtVM.Drives()
Change I8d310f216987b7 has introduced teardownVolumePath() calls with a
Drive object
Ayal Baron has posted comments on this change.
Change subject: Deactivate libvirtVM.Drives()
..
Patch Set 2: (1 inline comment)
File vdsm/clientIF.py
Line 343:
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Deactivate libvirtVM.Drives()
..
Patch Set 3:
Build Started http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/2361/ (1/3)
--
To view, visit
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Deactivate libvirtVM.Drives()
..
Patch Set 3:
Build Started http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/1526/ (2/3)
--
To view, visit
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Deactivate libvirtVM.Drives()
..
Patch Set 3:
Build Started http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/2428/ (3/3)
--
To view, visit
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Deactivate libvirtVM.Drives()
..
Patch Set 3:
Build Successful
http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/2361/ : SUCCESS
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Deactivate libvirtVM.Drives()
..
Patch Set 1:
Build Started http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/2336/ (2/3)
--
To view, visit
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Deactivate libvirtVM.Drives()
..
Patch Set 1:
Build Started http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/2403/ (3/3)
--
To view, visit
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Deactivate libvirtVM.Drives()
..
Patch Set 1:
Build Successful
http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/2336/ : SUCCESS
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Deactivate libvirtVM.Drives()
..
Patch Set 2:
Build Started http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/2404/ (1/3)
--
To view, visit
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Deactivate libvirtVM.Drives()
..
Patch Set 2:
Build Started http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/2337/ (2/3)
--
To view, visit
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Deactivate libvirtVM.Drives()
..
Patch Set 2:
Build Started http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/1502/ (3/3)
--
To view, visit
Yeela Kaplan has posted comments on this change.
Change subject: Deactivate libvirtVM.Drives()
..
Patch Set 2: Verified; Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/14869
To
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Deactivate libvirtVM.Drives()
..
Patch Set 2: Fails
Build Failed
http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/2337/ : SUCCESS
Dan Kenigsberg has posted comments on this change.
Change subject: Deactivate libvirtVM.Drives()
..
Patch Set 2: I would prefer that you didn't submit this
(1 inline comment)
Eduardo has posted comments on this change.
Change subject: Deactivate libvirtVM.Drives()
..
Patch Set 2: (1 inline comment)
File vdsm/clientIF.py
Line 343:
30 matches
Mail list logo