Change in vdsm[master]: Make networking API endpoints match schema

2013-06-30 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: Make networking API endpoints match schema .. Patch Set 2: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/15482 To unsubscribe, visit htt

Change in vdsm[master]: Make networking API endpoints match schema

2013-06-30 Thread danken
Dan Kenigsberg has submitted this change and it was merged. Change subject: Make networking API endpoints match schema .. Make networking API endpoints match schema There used to be non-optional parameters with default values.

Change in vdsm[master]: Make networking API endpoints match schema

2013-06-28 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: Make networking API endpoints match schema .. Patch Set 2: Build Successful http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/2984/ : SUCCESS http://jen

Change in vdsm[master]: Make networking API endpoints match schema

2013-06-27 Thread asegurap
Antoni Segura Puimedon has posted comments on this change. Change subject: Make networking API endpoints match schema .. Patch Set 2: Verified Rebased on top of master and it passed all the tests I threw at it. -- To view, vi

Change in vdsm[master]: Make networking API endpoints match schema

2013-06-27 Thread asegurap
Antoni Segura Puimedon has posted comments on this change. Change subject: Make networking API endpoints match schema .. Patch Set 2: @Dan: The bug I encountered earlier and Meni's are unrelated to this patch. They are caused

Change in vdsm[master]: Make networking API endpoints match schema

2013-06-27 Thread gvallare
Giuseppe Vallarelli has posted comments on this change. Change subject: Make networking API endpoints match schema .. Patch Set 2: Looks good to me, but someone else must approve This is cool thanks -- To view, visit http://g

Change in vdsm[master]: Make networking API endpoints match schema

2013-06-27 Thread wudxw
Mark Wu has posted comments on this change. Change subject: Make networking API endpoints match schema .. Patch Set 1: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/15482 To unsubscr

Change in vdsm[master]: Make networking API endpoints match schema

2013-06-27 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: Make networking API endpoints match schema .. Patch Set 1: Meni's bug: https://bugzilla.redhat.com/show_bug.cgi?id=978214 -- To view, visit http://gerrit.ovir

Change in vdsm[master]: Make networking API endpoints match schema

2013-06-26 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: Make networking API endpoints match schema .. Patch Set 1: I second Mark's comment: Meni Yakove reported the other day about a "None" string sneaking into the

Change in vdsm[master]: Make networking API endpoints match schema

2013-06-26 Thread wudxw
Mark Wu has posted comments on this change. Change subject: Make networking API endpoints match schema .. Patch Set 1: It looks for some reason 'MTU=None' went into the ifcfg file before this test. You could cleanup the ifcfg

Change in vdsm[master]: Make networking API endpoints match schema

2013-06-26 Thread asegurap
Antoni Segura Puimedon has posted comments on this change. Change subject: Make networking API endpoints match schema .. Patch Set 1: Fails Traceback (most recent call last):

Change in vdsm[master]: Make networking API endpoints match schema

2013-06-26 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: Make networking API endpoints match schema .. Patch Set 1: Looks good to me, approved mea culpa. mutable default args are a beautiful trick to leak information.

Change in vdsm[master]: Make networking API endpoints match schema

2013-06-09 Thread gvallare
Giuseppe Vallarelli has posted comments on this change. Change subject: Make networking API endpoints match schema .. Patch Set 1: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/15482

Change in vdsm[master]: Make networking API endpoints match schema

2013-06-09 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: Make networking API endpoints match schema .. Patch Set 1: Build Successful http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/2706/ : SUCCESS http://jen

Change in vdsm[master]: Make networking API endpoints match schema

2013-06-09 Thread asegurap
Antoni Segura Puimedon has uploaded a new change for review. Change subject: Make networking API endpoints match schema .. Make networking API endpoints match schema There used to be non-optional parameters with default values.