Nir Soffer has submitted this change and it was merged.
Change subject: Modify reports to metrics
..
Modify reports to metrics
Reports is more about the output graphs. The idea behind this module is
to send metrics information.
gerrit-hooks has posted comments on this change.
Change subject: Modify reports to metrics
..
Patch Set 5:
* Update tracker: IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no Bug-Url found.
--
To view, visit https://gerrit.
Nir Soffer has posted comments on this change.
Change subject: Modify reports to metrics
..
Patch Set 4: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/60450
To unsubscribe, visit https://gerrit.ovirt.org/settings
G
Yaniv Bronhaim has posted comments on this change.
Change subject: Modify reports to metrics
..
Patch Set 4: Verified+1
--
To view, visit https://gerrit.ovirt.org/60450
To unsubscribe, visit https://gerrit.ovirt.org/settings
Francesco Romani has posted comments on this change.
Change subject: Modify reports to metrics
..
Patch Set 4: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/60450
To unsubscribe, visit https://gerrit.ovirt.org/setti
Irit Goihman has posted comments on this change.
Change subject: Modify reports to metrics
..
Patch Set 4: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/60450
To unsubscribe, visit https://gerrit.ovirt.org/settings
gerrit-hooks has posted comments on this change.
Change subject: Modify reports to metrics
..
Patch Set 4:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: '
Francesco Romani has posted comments on this change.
Change subject: Modify reports to metrics
..
Patch Set 3: -Code-Review
(1 comment)
https://gerrit.ovirt.org/#/c/60450/3/lib/vdsm/config.py.in
File lib/vdsm/config.py.in:
Li
Yaniv Bronhaim has posted comments on this change.
Change subject: Modify reports to metrics
..
Patch Set 3:
(1 comment)
https://gerrit.ovirt.org/#/c/60450/3/lib/vdsm/config.py.in
File lib/vdsm/config.py.in:
Line 449:
Nir Soffer has posted comments on this change.
Change subject: Modify reports to metrics
..
Patch Set 3:
(1 comment)
https://gerrit.ovirt.org/#/c/60450/3/lib/vdsm/config.py.in
File lib/vdsm/config.py.in:
Line 449: ('c
Francesco Romani has posted comments on this change.
Change subject: Modify reports to metrics
..
Patch Set 3: Code-Review-1
(2 comments)
looks fine to me. I don't +1 this because of naming issues in config.py.in.
Since this
Francesco Romani has posted comments on this change.
Change subject: Modify reports to metrics
..
Patch Set 3:
ok with the concept, will have a proper review later
--
To view, visit https://gerrit.ovirt.org/60450
To unsubscri
Yaniv Bronhaim has posted comments on this change.
Change subject: Modify reports to metrics
..
Patch Set 3: Verified+1
Thanks Nir
--
To view, visit https://gerrit.ovirt.org/60450
To unsubscribe, visit https://gerrit.ovirt.or
Nir Soffer has posted comments on this change.
Change subject: Modify reports to metrics
..
Patch Set 3: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/60450
To unsubscribe, visit https://gerrit.ovirt.org/settings
G
gerrit-hooks has posted comments on this change.
Change subject: Modify reports to metrics
..
Patch Set 3:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: '
Yaniv Bronhaim has posted comments on this change.
Change subject: Modify reports to metrics
..
Patch Set 2:
(1 comment)
https://gerrit.ovirt.org/#/c/60450/2/lib/vdsm/config.py.in
File lib/vdsm/config.py.in:
Line 450:
Nir Soffer has posted comments on this change.
Change subject: Modify reports to metrics
..
Patch Set 2:
(1 comment)
https://gerrit.ovirt.org/#/c/60450/2/lib/vdsm/config.py.in
File lib/vdsm/config.py.in:
Line 450:
Oved Ourfali has posted comments on this change.
Change subject: Modify reports to metrics
..
Patch Set 2: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/60450
To unsubscribe, visit https://gerrit.ovirt.org/settings
Oved Ourfali has posted comments on this change.
Change subject: Modify reports to metrics
..
Patch Set 2:
We don't want to use the terminology "reports" at all here, as it confused with
other reports mechanism we used to have
Yaniv Bronhaim has posted comments on this change.
Change subject: Modify reports to metrics
..
Patch Set 2:
(1 comment)
https://gerrit.ovirt.org/#/c/60450/2/lib/vdsm/config.py.in
File lib/vdsm/config.py.in:
Line 450:
Nir Soffer has posted comments on this change.
Change subject: Modify reports to metrics
..
Patch Set 2:
(3 comments)
https://gerrit.ovirt.org/#/c/60450/2/lib/vdsm/config.py.in
File lib/vdsm/config.py.in:
Line 446: ('
Yaniv Bronhaim has posted comments on this change.
Change subject: Modify reports to metrics
..
Patch Set 2:
(4 comments)
https://gerrit.ovirt.org/#/c/60450/2/lib/vdsm/config.py.in
File lib/vdsm/config.py.in:
Line 446:
Nir Soffer has posted comments on this change.
Change subject: Modify reports to metrics
..
Patch Set 2:
(3 comments)
Looks good, just few minor issues in the help text.
https://gerrit.ovirt.org/#/c/60450/2/lib/vdsm/config.py
gerrit-hooks has posted comments on this change.
Change subject: Modify reports to metrics
..
Patch Set 2:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: '
Yaniv Kaul has posted comments on this change.
Change subject: Modify reports to metrics
..
Patch Set 1:
(2 comments)
https://gerrit.ovirt.org/#/c/60450/1/lib/vdsm/config.py.in
File lib/vdsm/config.py.in:
Line 443: ('
gerrit-hooks has posted comments on this change.
Change subject: Modify reports to metrics
..
Patch Set 1:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: '
Yaniv Bronhaim has uploaded a new change for review.
Change subject: Modify reports to metrics
..
Modify reports to metrics
Reports is more about the output graphs. The idea behind this module is
to send metrics information. Thi
27 matches
Mail list logo
