Change in vdsm[master]: Separate libvirt network configuration from ifcfg

2013-06-18 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: Separate libvirt network configuration from ifcfg .. Patch Set 9: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/15178 To unsubscribe,

Change in vdsm[master]: Separate libvirt network configuration from ifcfg

2013-06-12 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: Separate libvirt network configuration from ifcfg .. Patch Set 9: Looks good to me, but someone else must approve (1 inline comment)

Change in vdsm[master]: Separate libvirt network configuration from ifcfg

2013-06-09 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: Separate libvirt network configuration from ifcfg .. Patch Set 9: Build Successful http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/2703/ : SUCCESS

Change in vdsm[master]: Separate libvirt network configuration from ifcfg

2013-06-09 Thread wudxw
Mark Wu has posted comments on this change. Change subject: Separate libvirt network configuration from ifcfg .. Patch Set 9: Verified -- To view, visit http://gerrit.ovirt.org/15178 To unsubscribe, visit

Change in vdsm[master]: Separate libvirt network configuration from ifcfg

2013-06-09 Thread asegurap
Antoni Segura Puimedon has posted comments on this change. Change subject: Separate libvirt network configuration from ifcfg .. Patch Set 9: Verified; Looks good to me, but someone else must approve r+1 cause it's just a

Change in vdsm[master]: Separate libvirt network configuration from ifcfg

2013-06-07 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: Separate libvirt network configuration from ifcfg .. Patch Set 7: Build Successful http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/2676/ : SUCCESS

Change in vdsm[master]: Separate libvirt network configuration from ifcfg

2013-06-07 Thread asegurap
Antoni Segura Puimedon has posted comments on this change. Change subject: Separate libvirt network configuration from ifcfg .. Patch Set 7: Looks good to me, but someone else must approve -- To view, visit

Change in vdsm[master]: Separate libvirt network configuration from ifcfg

2013-06-07 Thread wudxw
Mark Wu has posted comments on this change. Change subject: Separate libvirt network configuration from ifcfg .. Patch Set 7: Verified -- To view, visit http://gerrit.ovirt.org/15178 To unsubscribe, visit

Change in vdsm[master]: Separate libvirt network configuration from ifcfg

2013-06-07 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: Separate libvirt network configuration from ifcfg .. Patch Set 8: Build Successful http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/2685/ : SUCCESS

Change in vdsm[master]: Separate libvirt network configuration from ifcfg

2013-06-07 Thread wudxw
Mark Wu has posted comments on this change. Change subject: Separate libvirt network configuration from ifcfg .. Patch Set 8: Verified -- To view, visit http://gerrit.ovirt.org/15178 To unsubscribe, visit

Change in vdsm[master]: Separate libvirt network configuration from ifcfg

2013-06-07 Thread asegurap
Antoni Segura Puimedon has posted comments on this change. Change subject: Separate libvirt network configuration from ifcfg .. Patch Set 8: Looks good to me, but someone else must approve -- To view, visit

Change in vdsm[master]: Separate libvirt network configuration from ifcfg

2013-06-07 Thread asegurap
Antoni Segura Puimedon has posted comments on this change. Change subject: Separate libvirt network configuration from ifcfg .. Patch Set 8: Verified -- To view, visit http://gerrit.ovirt.org/15178 To unsubscribe, visit

Change in vdsm[master]: Separate libvirt network configuration from ifcfg

2013-06-06 Thread asegurap
Antoni Segura Puimedon has posted comments on this change. Change subject: Separate libvirt network configuration from ifcfg .. Patch Set 4: I would prefer that you didn't submit this (1 inline comment)

Change in vdsm[master]: Separate libvirt network configuration from ifcfg

2013-06-06 Thread asegurap
Antoni Segura Puimedon has posted comments on this change. Change subject: Separate libvirt network configuration from ifcfg .. Patch Set 4: (1 inline comment) Nice idea. I like the increasing separation of responsibilities.

Change in vdsm[master]: Separate libvirt network configuration from ifcfg

2013-06-06 Thread wudxw
Mark Wu has posted comments on this change. Change subject: Separate libvirt network configuration from ifcfg .. Patch Set 4: (2 inline comments) File

Change in vdsm[master]: Separate libvirt network configuration from ifcfg

2013-06-06 Thread wudxw
Mark Wu has posted comments on this change. Change subject: Separate libvirt network configuration from ifcfg .. Patch Set 4: (1 inline comment) File vdsm.spec.in Line 907:

Change in vdsm[master]: Separate libvirt network configuration from ifcfg

2013-06-06 Thread wudxw
Mark Wu has posted comments on this change. Change subject: Separate libvirt network configuration from ifcfg .. Patch Set 5: Verified -- To view, visit http://gerrit.ovirt.org/15178 To unsubscribe, visit

Change in vdsm[master]: Separate libvirt network configuration from ifcfg

2013-06-06 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: Separate libvirt network configuration from ifcfg .. Patch Set 5: Build Successful http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/2631/ : SUCCESS

Change in vdsm[master]: Separate libvirt network configuration from ifcfg

2013-06-06 Thread asegurap
Antoni Segura Puimedon has posted comments on this change. Change subject: Separate libvirt network configuration from ifcfg .. Patch Set 5: Looks good to me, but someone else must approve Thanks for the class - module! -- To

Change in vdsm[master]: Separate libvirt network configuration from ifcfg

2013-06-04 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: Separate libvirt network configuration from ifcfg .. Patch Set 4: Build Successful http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/2562/ : SUCCESS

Change in vdsm[master]: Separate libvirt network configuration from ifcfg

2013-06-03 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: Separate libvirt network configuration from ifcfg .. Patch Set 3: Fails Build Failed http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/2514/ : SUCCESS

Change in vdsm[master]: Separate libvirt network configuration from ifcfg

2013-05-30 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: Separate libvirt network configuration from ifcfg .. Patch Set 1: Build Started http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/2485/ (2/3) -- To view,

Change in vdsm[master]: Separate libvirt network configuration from ifcfg

2013-05-30 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: Separate libvirt network configuration from ifcfg .. Patch Set 1: Build Started http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/1657/ (1/3) --

Change in vdsm[master]: Separate libvirt network configuration from ifcfg

2013-05-30 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: Separate libvirt network configuration from ifcfg .. Patch Set 1: Build Started http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/2556/ (3/3) -- To

Change in vdsm[master]: Separate libvirt network configuration from ifcfg

2013-05-30 Thread wudxw
Mark Wu has uploaded a new change for review. Change subject: Separate libvirt network configuration from ifcfg .. Separate libvirt network configuration from ifcfg The libvirt network configuration code could be reused by non

Change in vdsm[master]: Separate libvirt network configuration from ifcfg

2013-05-30 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: Separate libvirt network configuration from ifcfg .. Patch Set 1: Fails Build Failed http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/2485/ : SUCCESS

Change in vdsm[master]: Separate libvirt network configuration from ifcfg

2013-05-30 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: Separate libvirt network configuration from ifcfg .. Patch Set 2: Build Started http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/1658/ (3/3) --

Change in vdsm[master]: Separate libvirt network configuration from ifcfg

2013-05-30 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: Separate libvirt network configuration from ifcfg .. Patch Set 2: Build Started http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/2486/ (1/3) -- To view,

Change in vdsm[master]: Separate libvirt network configuration from ifcfg

2013-05-30 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: Separate libvirt network configuration from ifcfg .. Patch Set 2: Build Started http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/2557/ (2/3) -- To

Change in vdsm[master]: Separate libvirt network configuration from ifcfg

2013-05-30 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: Separate libvirt network configuration from ifcfg .. Patch Set 2: Fails Build Failed http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/2486/ : SUCCESS

Change in vdsm[master]: Separate libvirt network configuration from ifcfg

2013-05-30 Thread wudxw
Mark Wu has posted comments on this change. Change subject: Separate libvirt network configuration from ifcfg .. Patch Set 2: The test failure is caused by the cpopen bug. -- To view, visit http://gerrit.ovirt.org/15178 To