Change in vdsm[master]: bridge: obtain method

2016-03-13 Thread automation
gerrit-hooks has posted comments on this change. Change subject: bridge: obtain method .. Patch Set 13: * Update tracker: IGNORE, no Bug-Url found * Set MODIFIED::IGNORE, no Bug-Url found. -- To view, visit https://gerrit.ovi

Change in vdsm[master]: bridge: obtain method

2016-03-13 Thread danken
Dan Kenigsberg has submitted this change and it was merged. Change subject: bridge: obtain method .. bridge: obtain method We used to change ClassName.MethodName to ClassName_MethodName due restrictions of parameter when using

Change in vdsm[master]: bridge: obtain method

2016-03-13 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: bridge: obtain method .. Patch Set 12: Code-Review+2 raising -- To view, visit https://gerrit.ovirt.org/53472 To unsubscribe, visit https://gerrit.ovirt.org/s

Change in vdsm[master]: bridge: obtain method

2016-03-12 Thread ybronhei
Yaniv Bronhaim has posted comments on this change. Change subject: bridge: obtain method .. Patch Set 12: Code-Review+1 I agree with Nir that we can make _serveRequest prettier -- To view, visit https://gerrit.ovirt.org/53472

Change in vdsm[master]: bridge: obtain method

2016-03-11 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: bridge: obtain method .. Patch Set 12: (6 comments) Looks good, need to fix the filtered methods set. https://gerrit.ovirt.org/#/c/53472/12/lib/yajsonrpc/__init__

Change in vdsm[master]: bridge: obtain method

2016-03-10 Thread automation
gerrit-hooks has posted comments on this change. Change subject: bridge: obtain method .. Patch Set 12: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' a

Change in vdsm[master]: bridge: obtain method

2016-03-09 Thread automation
gerrit-hooks has posted comments on this change. Change subject: bridge: obtain method .. Patch Set 11: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' a

Change in vdsm[master]: bridge: obtain method

2016-03-09 Thread automation
gerrit-hooks has posted comments on this change. Change subject: bridge: obtain method .. Patch Set 10: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' a

Change in vdsm[master]: bridge: obtain method

2016-03-09 Thread automation
gerrit-hooks has posted comments on this change. Change subject: bridge: obtain method .. Patch Set 9: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' an

Change in vdsm[master]: bridge: obtain method

2016-03-03 Thread piotr . kliczewski
Piotr Kliczewski has posted comments on this change. Change subject: bridge: obtain method .. Patch Set 8: Verified+1 Verified by host deploying vdsm and seeing that there are no issues. -- To view, visit https://gerrit.ovirt

Change in vdsm[master]: bridge: obtain method

2016-03-03 Thread automation
gerrit-hooks has posted comments on this change. Change subject: bridge: obtain method .. Patch Set 8: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' an

Change in vdsm[master]: bridge: obtain method

2016-02-29 Thread piotr . kliczewski
Piotr Kliczewski has posted comments on this change. Change subject: bridge: obtain method .. Patch Set 7: (1 comment) https://gerrit.ovirt.org/#/c/53472/7/tests/stompTests.py File tests/stompTests.py: Line 55: def unregi

Change in vdsm[master]: bridge: obtain method

2016-02-29 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: bridge: obtain method .. Patch Set 7: (1 comment) https://gerrit.ovirt.org/#/c/53472/7/tests/stompTests.py File tests/stompTests.py: Line 55: def unregister_s

Change in vdsm[master]: bridge: obtain method

2016-02-29 Thread piotr . kliczewski
Piotr Kliczewski has posted comments on this change. Change subject: bridge: obtain method .. Patch Set 7: Verified+1 Verified by host deploying the host and seeing no issues. -- To view, visit https://gerrit.ovirt.org/53472

Change in vdsm[master]: bridge: obtain method

2016-02-29 Thread automation
gerrit-hooks has posted comments on this change. Change subject: bridge: obtain method .. Patch Set 7: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' an

Change in vdsm[master]: bridge: obtain method

2016-02-28 Thread piotr . kliczewski
Piotr Kliczewski has posted comments on this change. Change subject: bridge: obtain method .. Patch Set 6: (3 comments) https://gerrit.ovirt.org/#/c/53472/6/lib/yajsonrpc/__init__.py File lib/yajsonrpc/__init__.py: Line 509 L

Change in vdsm[master]: bridge: obtain method

2016-02-27 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: bridge: obtain method .. Patch Set 6: (3 comments) https://gerrit.ovirt.org/#/c/53472/6/lib/yajsonrpc/__init__.py File lib/yajsonrpc/__init__.py: Line 509 Line 51

Change in vdsm[master]: bridge: obtain method

2016-02-26 Thread automation
gerrit-hooks has posted comments on this change. Change subject: bridge: obtain method .. Patch Set 6: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' an

Change in vdsm[master]: bridge: obtain method

2016-02-23 Thread automation
gerrit-hooks has posted comments on this change. Change subject: bridge: obtain method .. Patch Set 5: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' an

Change in vdsm[master]: bridge: obtain method

2016-02-18 Thread automation
gerrit-hooks has posted comments on this change. Change subject: bridge: obtain method .. Patch Set 4: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' an

Change in vdsm[master]: bridge: obtain method

2016-02-17 Thread piotr . kliczewski
Piotr Kliczewski has posted comments on this change. Change subject: bridge: obtain method .. Patch Set 3: (1 comment) https://gerrit.ovirt.org/#/c/53472/3/vdsm/rpc/Bridge.py File vdsm/rpc/Bridge.py: Line 96: try: Lin

Change in vdsm[master]: bridge: obtain method

2016-02-17 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: bridge: obtain method .. Patch Set 3: (1 comment) https://gerrit.ovirt.org/#/c/53472/3/vdsm/rpc/Bridge.py File vdsm/rpc/Bridge.py: Line 96: try: Line 97:

Change in vdsm[master]: bridge: obtain method

2016-02-17 Thread automation
gerrit-hooks has posted comments on this change. Change subject: bridge: obtain method .. Patch Set 3: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' an

Change in vdsm[master]: bridge: obtain method

2016-02-16 Thread piotr . kliczewski
Piotr Kliczewski has posted comments on this change. Change subject: bridge: obtain method .. Patch Set 2: (2 comments) https://gerrit.ovirt.org/#/c/53472/2/vdsm/rpc/Bridge.py File vdsm/rpc/Bridge.py: Line 68 Line 69 Line 70

Change in vdsm[master]: bridge: obtain method

2016-02-16 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: bridge: obtain method .. Patch Set 2: (2 comments) https://gerrit.ovirt.org/#/c/53472/2/vdsm/rpc/Bridge.py File vdsm/rpc/Bridge.py: Line 68 Line 69 Line 70 Line 7

Change in vdsm[master]: bridge: obtain method

2016-02-16 Thread piotr . kliczewski
Piotr Kliczewski has posted comments on this change. Change subject: bridge: obtain method .. Patch Set 2: (4 comments) https://gerrit.ovirt.org/#/c/53472/2/vdsm/rpc/Bridge.py File vdsm/rpc/Bridge.py: Line 68 Line 69 Line 70

Change in vdsm[master]: bridge: obtain method

2016-02-16 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: bridge: obtain method .. Patch Set 2: Code-Review-1 (5 comments) https://gerrit.ovirt.org/#/c/53472/2/tests/bridgeTests.py File tests/bridgeTests.py: Line 138:

Change in vdsm[master]: bridge: obtain method

2016-02-15 Thread piotr . kliczewski
Piotr Kliczewski has posted comments on this change. Change subject: bridge: obtain method .. Patch Set 2: Verified+1 Verified by deploying vdsm and creating a data domain, importing cirros as template and running a vm. -- T

Change in vdsm[master]: bridge: obtain method

2016-02-15 Thread automation
gerrit-hooks has posted comments on this change. Change subject: bridge: obtain method .. Patch Set 2: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' an

Change in vdsm[master]: bridge: obtain method

2016-02-15 Thread piotr . kliczewski
Piotr Kliczewski has posted comments on this change. Change subject: bridge: obtain method .. Patch Set 1: (4 comments) https://gerrit.ovirt.org/#/c/53472/1/vdsm/rpc/Bridge.py File vdsm/rpc/Bridge.py: Line 108: re

Change in vdsm[master]: bridge: obtain method

2016-02-14 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: bridge: obtain method .. Patch Set 1: Code-Review-1 (4 comments) Nice change, abusing __getattr__ was bad. https://gerrit.ovirt.org/#/c/53472/1/vdsm/rpc/Bridge.py

Change in vdsm[master]: bridge: obtain method

2016-02-12 Thread automation
gerrit-hooks has posted comments on this change. Change subject: bridge: obtain method .. Patch Set 1: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' an

Change in vdsm[master]: bridge: obtain method

2016-02-12 Thread piotr . kliczewski
Piotr Kliczewski has uploaded a new change for review. Change subject: bridge: obtain method .. bridge: obtain method We used to change ClassName.MethodName to ClassName_MethodName due restrictions of parameter when using getatt