Change in vdsm[master]: compat: Use simplejson instead of json

2015-11-17 Thread automation
gerrit-hooks has posted comments on this change. Change subject: compat: Use simplejson instead of json .. Patch Set 5: * #1281940::Update tracker: OK -- To view, visit https://gerrit.ovirt.org/48565 To unsubscribe, visit htt

Change in vdsm[master]: compat: Use simplejson instead of json

2015-11-17 Thread nsoffer
Nir Soffer has abandoned this change. Change subject: compat: Use simplejson instead of json .. Abandoned https://gerrit.ovirt.org/48661 is a better approach. -- To view, visit https://gerrit.ovirt.org/48565 To unsubscribe, v

Change in vdsm[master]: compat: Use simplejson instead of json

2015-11-16 Thread piotr . kliczewski
Piotr Kliczewski has posted comments on this change. Change subject: compat: Use simplejson instead of json .. Patch Set 5: (1 comment) https://gerrit.ovirt.org/#/c/48565/5/lib/vdsm/compat.py File lib/vdsm/compat.py: Line 29:

Change in vdsm[master]: compat: Use simplejson instead of json

2015-11-16 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: compat: Use simplejson instead of json .. Patch Set 5: (1 comment) https://gerrit.ovirt.org/#/c/48565/5/lib/vdsm/compat.py File lib/vdsm/compat.py: Line 29: # We

Change in vdsm[master]: compat: Use simplejson instead of json

2015-11-16 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: compat: Use simplejson instead of json .. Patch Set 5: Code-Review-1 I discussed this with Dan, and we agree that this is not the right direction. While this works

Change in vdsm[master]: compat: Use simplejson instead of json

2015-11-16 Thread fromani
Francesco Romani has posted comments on this change. Change subject: compat: Use simplejson instead of json .. Patch Set 5: (1 comment) codewise, I'm fine. From packaging point of view, this can give us some headaches. Please

Change in vdsm[master]: compat: Use simplejson instead of json

2015-11-16 Thread fromani
Francesco Romani has posted comments on this change. Change subject: compat: Use simplejson instead of json .. Patch Set 5: Code-Review-1 -1 for visibility and discussion -- To view, visit https://gerrit.ovirt.org/48565 To un

Change in vdsm[master]: compat: Use simplejson instead of json

2015-11-16 Thread piotr . kliczewski
Piotr Kliczewski has posted comments on this change. Change subject: compat: Use simplejson instead of json .. Patch Set 5: Code-Review-1 (1 comment) https://gerrit.ovirt.org/#/c/48565/5/lib/vdsm/compat.py File lib/vdsm/compat

Change in vdsm[master]: compat: Use simplejson instead of json

2015-11-14 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: compat: Use simplejson instead of json .. Patch Set 5: Verified+1 Verified on rhel 7. Example json arguments (no more u'...'): 2015-11-14 15:14:54,016 INFO [dispa

Change in vdsm[master]: compat: Use simplejson instead of json

2015-11-13 Thread automation
gerrit-hooks has posted comments on this change. Change subject: compat: Use simplejson instead of json .. Patch Set 5: * #1281940::Update tracker: OK * Check Bug-Url::OK * Check Public Bug::#1281940::OK, public bug * Check Pro

Change in vdsm[master]: compat: Use simplejson instead of json

2015-11-13 Thread automation
gerrit-hooks has posted comments on this change. Change subject: compat: Use simplejson instead of json .. Patch Set 4: * #1281940::Update tracker: OK * Check Bug-Url::OK * Check Public Bug::#1281940::OK, public bug * Check Pro

Change in vdsm[master]: compat: Use simplejson instead of json

2015-11-13 Thread automation
gerrit-hooks has posted comments on this change. Change subject: compat: Use simplejson instead of json .. Patch Set 3: * #1281940::Update tracker: OK * Check Bug-Url::OK * Check Public Bug::#1281940::OK, public bug * Check Pro

Change in vdsm[master]: compat: Use simplejson instead of json

2015-11-13 Thread automation
gerrit-hooks has posted comments on this change. Change subject: compat: Use simplejson instead of json .. Patch Set 2: * #1281940::Update tracker: OK * Check Bug-Url::OK * Check Public Bug::#1281940::OK, public bug * Check Pro

Change in vdsm[master]: compat: Use simplejson instead of json

2015-11-13 Thread automation
gerrit-hooks has posted comments on this change. Change subject: compat: Use simplejson instead of json .. Patch Set 1: * #1281940::Update tracker: OK * Check Bug-Url::OK * Check Public Bug::#1281940::OK, public bug * Check Pro

Change in vdsm[master]: compat: Use simplejson instead of json

2015-11-13 Thread nsoffer
Nir Soffer has uploaded a new change for review. Change subject: compat: Use simplejson instead of json .. compat: Use simplejson instead of json We use to require simplejson when using Python 2.6 since the built-in json library