Change in vdsm[master]: compat: mock CPopen for Python 3 testing

2016-03-30 Thread danken
Dan Kenigsberg has submitted this change and it was merged. Change subject: compat: mock CPopen for Python 3 testing .. compat: mock CPopen for Python 3 testing I would like to run Vdsm unit tests in Python 3, but many tests

Change in vdsm[master]: compat: mock CPopen for Python 3 testing

2016-03-30 Thread automation
gerrit-hooks has posted comments on this change. Change subject: compat: mock CPopen for Python 3 testing .. Patch Set 3: * Update tracker: IGNORE, no Bug-Url found * Set MODIFIED::IGNORE, no Bug-Url found. -- To view, visit

Change in vdsm[master]: compat: mock CPopen for Python 3 testing

2016-03-30 Thread piotr . kliczewski
Piotr Kliczewski has posted comments on this change. Change subject: compat: mock CPopen for Python 3 testing .. Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/55379 To unsubscribe, visit

Change in vdsm[master]: compat: mock CPopen for Python 3 testing

2016-03-30 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: compat: mock CPopen for Python 3 testing .. Patch Set 2: Verified+1 unit tests pass -- To view, visit https://gerrit.ovirt.org/55379 To unsubscribe, visit

Change in vdsm[master]: compat: mock CPopen for Python 3 testing

2016-03-30 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: compat: mock CPopen for Python 3 testing .. Patch Set 2: (1 comment) https://gerrit.ovirt.org/#/c/55379/2/lib/vdsm/compat.py File lib/vdsm/compat.py: Line 41:

Change in vdsm[master]: compat: mock CPopen for Python 3 testing

2016-03-30 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: compat: mock CPopen for Python 3 testing .. Patch Set 1: (1 comment) https://gerrit.ovirt.org/#/c/55379/1/lib/vdsm/compat.py File lib/vdsm/compat.py: Line

Change in vdsm[master]: compat: mock CPopen for Python 3 testing

2016-03-30 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: compat: mock CPopen for Python 3 testing .. Patch Set 2: Code-Review+1 Sorry, wrong patch :-) -- To view, visit https://gerrit.ovirt.org/55379 To unsubscribe,

Change in vdsm[master]: compat: mock CPopen for Python 3 testing

2016-03-30 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: compat: mock CPopen for Python 3 testing .. Patch Set 2: Code-Review-1 I'm against these hacks. If you want to run this code with Python, fix the real issue - get

Change in vdsm[master]: compat: mock CPopen for Python 3 testing

2016-03-30 Thread automation
gerrit-hooks has posted comments on this change. Change subject: compat: mock CPopen for Python 3 testing .. Patch Set 2: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header

Change in vdsm[master]: compat: mock CPopen for Python 3 testing

2016-03-30 Thread piotr . kliczewski
Piotr Kliczewski has posted comments on this change. Change subject: compat: mock CPopen for Python 3 testing .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/55379 To unsubscribe, visit

Change in vdsm[master]: compat: mock CPopen for Python 3 testing

2016-03-29 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: compat: mock CPopen for Python 3 testing .. Patch Set 1: Verified+1 Passes all tests on f23 and el7 -- To view, visit https://gerrit.ovirt.org/55379 To

Change in vdsm[master]: compat: mock CPopen for Python 3 testing

2016-03-29 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: compat: mock CPopen for Python 3 testing .. Patch Set 1: (7 comments) https://gerrit.ovirt.org/#/c/55379/1//COMMIT_MSG Commit Message: Line 8: Line 9: I would

Change in vdsm[master]: compat: mock CPopen for Python 3 testing

2016-03-29 Thread ybronhei
Yaniv Bronhaim has posted comments on this change. Change subject: compat: mock CPopen for Python 3 testing .. Patch Set 1: Code-Review+1 simple and cool. lets do that :) -- To view, visit https://gerrit.ovirt.org/55379 To

Change in vdsm[master]: compat: mock CPopen for Python 3 testing

2016-03-29 Thread ybronhei
Yaniv Bronhaim has posted comments on this change. Change subject: compat: mock CPopen for Python 3 testing .. Patch Set 1: just reminding that we started this https://gerrit.ovirt.org/#/c/48384/2 - let me know if to abandon

Change in vdsm[master]: compat: mock CPopen for Python 3 testing

2016-03-29 Thread automation
gerrit-hooks has posted comments on this change. Change subject: compat: mock CPopen for Python 3 testing .. Patch Set 1: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header

Change in vdsm[master]: compat: mock CPopen for Python 3 testing

2016-03-29 Thread danken
Dan Kenigsberg has uploaded a new change for review. Change subject: compat: mock CPopen for Python 3 testing .. compat: mock CPopen for Python 3 testing I would like to run Vdsm unit tests in Python 3, but many tests