Dan Kenigsberg has submitted this change and it was merged.
Change subject: concurrent: Add Barrier class
..
concurrent: Add Barrier class
Barrier synchronizes multiple threads. The barrier is created in closed
state, blocking
automat...@ovirt.org has posted comments on this change.
Change subject: concurrent: Add Barrier class
..
Patch Set 15:
* Update tracker::IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no Bug-Url found.
--
To view, visit ht
Dan Kenigsberg has posted comments on this change.
Change subject: concurrent: Add Barrier class
..
Patch Set 14: Code-Review+2
(1 comment)
https://gerrit.ovirt.org/#/c/42927/14/lib/vdsm/concurrent.py
File lib/vdsm/concurrent.
Ido Barkan has posted comments on this change.
Change subject: concurrent: Add Barrier class
..
Patch Set 14: Code-Review+1
looks good.
--
To view, visit https://gerrit.ovirt.org/42927
To unsubscribe, visit https://gerrit.ovi
Nir Soffer has posted comments on this change.
Change subject: concurrent: Add Barrier class
..
Patch Set 14: Verified+1
This version add the missing test for wait without a timeout.
--
To view, visit https://gerrit.ovirt.org
automat...@ovirt.org has posted comments on this change.
Change subject: concurrent: Add Barrier class
..
Patch Set 14:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matche
Nir Soffer has posted comments on this change.
Change subject: concurrent: Add Barrier class
..
Patch Set 13: Verified+1
This version improve readability and correctness, by using enums for barrier
state, instead of boolean va
automat...@ovirt.org has posted comments on this change.
Change subject: concurrent: Add Barrier class
..
Patch Set 13:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matche
Nir Soffer has posted comments on this change.
Change subject: concurrent: Add Barrier class
..
Patch Set 12: Verified+1
This version improve readability and documentation.
--
To view, visit https://gerrit.ovirt.org/42927
To
Nir Soffer has posted comments on this change.
Change subject: concurrent: Add Barrier class
..
Patch Set 11:
(1 comment)
https://gerrit.ovirt.org/#/c/42927/11/lib/vdsm/concurrent.py
File lib/vdsm/concurrent.py:
Line 73:
Nir Soffer has posted comments on this change.
Change subject: concurrent: Add Barrier class
..
Patch Set 11:
(2 comments)
https://gerrit.ovirt.org/#/c/42927/11/tests/concurrentTests.py
File tests/concurrentTests.py:
Line 60:
automat...@ovirt.org has posted comments on this change.
Change subject: concurrent: Add Barrier class
..
Patch Set 12:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matche
Ido Barkan has posted comments on this change.
Change subject: concurrent: Add Barrier class
..
Patch Set 11:
(1 comment)
https://gerrit.ovirt.org/#/c/42927/11/lib/vdsm/concurrent.py
File lib/vdsm/concurrent.py:
Line 73:
Nir Soffer has posted comments on this change.
Change subject: concurrent: Add Barrier class
..
Patch Set 11:
(2 comments)
https://gerrit.ovirt.org/#/c/42927/11/lib/vdsm/concurrent.py
File lib/vdsm/concurrent.py:
Line 57:
Li
Ido Barkan has posted comments on this change.
Change subject: concurrent: Add Barrier class
..
Patch Set 11: Code-Review-1
(4 comments)
cool.
-1 just for visibility. mostly nits.
https://gerrit.ovirt.org/#/c/42927/11/lib/vds
automat...@ovirt.org has posted comments on this change.
Change subject: concurrent: Add Barrier class
..
Patch Set 11:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matche
automat...@ovirt.org has posted comments on this change.
Change subject: concurrent: Add Barrier class
..
Patch Set 10:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matche
Nir Soffer has posted comments on this change.
Change subject: concurrent: Add Barrier class
..
Patch Set 9: Verified+1
--
To view, visit https://gerrit.ovirt.org/42927
To unsubscribe, visit https://gerrit.ovirt.org/settings
automat...@ovirt.org has posted comments on this change.
Change subject: concurrent: Add Barrier class
..
Patch Set 9:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches
Adam Litke has posted comments on this change.
Change subject: concurrent: Add Barrier class
..
Patch Set 8: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/42927
To unsubscribe, visit https://gerrit.ovirt.org/setting
automat...@ovirt.org has posted comments on this change.
Change subject: concurrent: Add Barrier class
..
Patch Set 8:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches
Dima Kuznetsov has posted comments on this change.
Change subject: concurrent: Add Barrier class
..
Patch Set 7: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/42927
To unsubscribe, visit https://gerrit.ovirt.org/set
Nir Soffer has posted comments on this change.
Change subject: concurrent: Add Barrier class
..
Patch Set 6:
(1 comment)
https://gerrit.ovirt.org/#/c/42927/6/tests/concurrentTests.py
File tests/concurrentTests.py:
Line 80:
automat...@ovirt.org has posted comments on this change.
Change subject: concurrent: Add Barrier class
..
Patch Set 7:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches
Francesco Romani has posted comments on this change.
Change subject: concurrent: Add Barrier class
..
Patch Set 6:
(1 comment)
https://gerrit.ovirt.org/#/c/42927/6/tests/concurrentTests.py
File tests/concurrentTests.py:
Line
Francesco Romani has posted comments on this change.
Change subject: concurrent: Add Barrier class
..
Patch Set 6: Code-Review+1
seems OK and nicely tested
--
To view, visit https://gerrit.ovirt.org/42927
To unsubscribe, visi
Nir Soffer has posted comments on this change.
Change subject: concurrent: Add Barrier class
..
Patch Set 6: Verified+1
--
To view, visit https://gerrit.ovirt.org/42927
To unsubscribe, visit https://gerrit.ovirt.org/settings
Nir Soffer has posted comments on this change.
Change subject: concurrent: Add Barrier class
..
Patch Set 5:
(1 comment)
https://gerrit.ovirt.org/#/c/42927/5/lib/vdsm/concurrent.py
File lib/vdsm/concurrent.py:
Line 58:
automat...@ovirt.org has posted comments on this change.
Change subject: concurrent: Add Barrier class
..
Patch Set 6:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches
Fabian Deutsch has posted comments on this change.
Change subject: concurrent: Add Barrier class
..
Patch Set 5:
(2 comments)
https://gerrit.ovirt.org/#/c/42927/5/lib/vdsm/concurrent.py
File lib/vdsm/concurrent.py:
Line 62: b
Adam Litke has posted comments on this change.
Change subject: concurrent: Add Barrier class
..
Patch Set 5: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/42927
To unsubscribe, visit https://gerrit.ovirt.org/setting
Nir Soffer has posted comments on this change.
Change subject: concurrent: Add Barrier class
..
Patch Set 5: Verified+1
--
To view, visit https://gerrit.ovirt.org/42927
To unsubscribe, visit https://gerrit.ovirt.org/settings
automat...@ovirt.org has posted comments on this change.
Change subject: concurrent: Add Barrier class
..
Patch Set 5:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches
Nir Soffer has posted comments on this change.
Change subject: concurrent: Add Barrier class
..
Patch Set 4:
(3 comments)
https://gerrit.ovirt.org/#/c/42927/4/lib/vdsm/concurrent.py
File lib/vdsm/concurrent.py:
Line 29:
Line
Adam Litke has posted comments on this change.
Change subject: concurrent: Add Barrier class
..
Patch Set 4:
(3 comments)
https://gerrit.ovirt.org/#/c/42927/4/lib/vdsm/concurrent.py
File lib/vdsm/concurrent.py:
Line 29:
Line
automat...@ovirt.org has posted comments on this change.
Change subject: concurrent: Add Barrier class
..
Patch Set 4:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches
automat...@ovirt.org has posted comments on this change.
Change subject: concurrent: Add Barrier class
..
Patch Set 3:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches
Nir Soffer has posted comments on this change.
Change subject: concurrent: Add Barrier class
..
Patch Set 2: Verified+1
This version replace the CountedEvent with a Barrier, which has a simpler
interface but is more useful.
-
automat...@ovirt.org has posted comments on this change.
Change subject: concurrent: Add Barrier class
..
Patch Set 2:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches
39 matches
Mail list logo
