Change in vdsm[master]: coverage: Add vdsm-coverage sub package

2016-10-29 Thread automation
gerrit-hooks has posted comments on this change. Change subject: coverage: Add vdsm-coverage sub package .. Patch Set 5: * update_tracker: OK -- To view, visit https://gerrit.ovirt.org/49807 To unsubscribe, visit https://gerr

Change in vdsm[master]: coverage: Add vdsm-coverage sub package

2016-10-29 Thread Jenkins CI RO
Jenkins CI RO has abandoned this change. Change subject: coverage: Add vdsm-coverage sub package .. Abandoned Abandoned due to no activity - please restore if still relevant -- To view, visit https://gerrit.ovirt.org/49807 To

Change in vdsm[master]: coverage: Add vdsm-coverage sub package

2016-05-17 Thread pbalogh
Petr Balogh has posted comments on this change. Change subject: coverage: Add vdsm-coverage sub package .. Patch Set 5: Hi, we are using coverage in vdsm for our QE coverage job. But we don't need extra package for it as this

Change in vdsm[master]: coverage: Add vdsm-coverage sub package

2016-05-17 Thread ybronhei
Yaniv Bronhaim has posted comments on this change. Change subject: coverage: Add vdsm-coverage sub package .. Patch Set 5: do you actually need it ? ... most of the time coverage is more relevant for checking if your unit test

Change in vdsm[master]: coverage: Add vdsm-coverage sub package

2016-05-15 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: coverage: Add vdsm-coverage sub package .. Patch Set 5: ping -- To view, visit https://gerrit.ovirt.org/49807 To unsubscribe, visit https://gerrit.ovirt.org/setti

Change in vdsm[master]: coverage: Add vdsm-coverage sub package

2016-02-19 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: coverage: Add vdsm-coverage sub package .. Patch Set 5: (2 comments) https://gerrit.ovirt.org/#/c/49807/5/coverage/coverage.conf.in File coverage/coverage.conf.in:

Change in vdsm[master]: coverage: Add vdsm-coverage sub package

2016-02-19 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: coverage: Add vdsm-coverage sub package .. Patch Set 5: Yaniv, build flags cannot help here - the purpose of this package is to make it easy to enable coverage *wi

Change in vdsm[master]: coverage: Add vdsm-coverage sub package

2016-02-15 Thread piotr . kliczewski
Piotr Kliczewski has posted comments on this change. Change subject: coverage: Add vdsm-coverage sub package .. Patch Set 5: (2 comments) https://gerrit.ovirt.org/#/c/49807/5/coverage/coverage.conf.in File coverage/coverage.co

Change in vdsm[master]: coverage: Add vdsm-coverage sub package

2016-02-14 Thread ybronhei
Yaniv Bronhaim has posted comments on this change. Change subject: coverage: Add vdsm-coverage sub package .. Patch Set 5: Code-Review-1 why adding conf file in separate package? it got no sense.. build flag is much more appro

Change in vdsm[master]: coverage: Add vdsm-coverage sub package

2016-02-14 Thread sbonazzo
Sandro Bonazzola has posted comments on this change. Change subject: coverage: Add vdsm-coverage sub package .. Patch Set 5: (1 comment) https://gerrit.ovirt.org/#/c/49807/5/vdsm.spec.in File vdsm.spec.in: Line 1499: %{_datad

Change in vdsm[master]: coverage: Add vdsm-coverage sub package

2016-02-14 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: coverage: Add vdsm-coverage sub package .. Patch Set 5: Code-Review-1 - Update copyright years - Check if spec defattr is needed - Check debian packaging -- To vi

Change in vdsm[master]: coverage: Add vdsm-coverage sub package

2016-02-14 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: coverage: Add vdsm-coverage sub package .. Patch Set 5: Yaniv, this package helps to enable coverage in vdsm itself, for checking functional, system or manual flow

Change in vdsm[master]: coverage: Add vdsm-coverage sub package

2016-02-14 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: coverage: Add vdsm-coverage sub package .. Patch Set 5: (7 comments) https://gerrit.ovirt.org/#/c/49807/5/Makefile.am File Makefile.am: Line 1: # > 2008-2016 Will

Change in vdsm[master]: coverage: Add vdsm-coverage sub package

2016-02-12 Thread ybronhei
Yaniv Bronhaim has posted comments on this change. Change subject: coverage: Add vdsm-coverage sub package .. Patch Set 5: do we still need NOSE_WITH_COVERAGE with that ? -- To view, visit https://gerrit.ovirt.org/49807 To un

Change in vdsm[master]: coverage: Add vdsm-coverage sub package

2016-02-11 Thread sbonazzo
Sandro Bonazzola has posted comments on this change. Change subject: coverage: Add vdsm-coverage sub package .. Patch Set 5: (7 comments) https://gerrit.ovirt.org/#/c/49807/5/Makefile.am File Makefile.am: Line 1: # 2008-2016

Change in vdsm[master]: coverage: Add vdsm-coverage sub package

2015-12-07 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: coverage: Add vdsm-coverage sub package .. Patch Set 5: (2 comments) https://gerrit.ovirt.org/#/c/49807/5/coverage/Makefile.am File coverage/Makefile.am: Line 27:

Change in vdsm[master]: coverage: Add vdsm-coverage sub package

2015-12-07 Thread piotr . kliczewski
Piotr Kliczewski has posted comments on this change. Change subject: coverage: Add vdsm-coverage sub package .. Patch Set 5: (2 comments) https://gerrit.ovirt.org/#/c/49807/5/coverage/Makefile.am File coverage/Makefile.am: Li

Change in vdsm[master]: coverage: Add vdsm-coverage sub package

2015-12-06 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: coverage: Add vdsm-coverage sub package .. Patch Set 5: Verified+1 README changes, not code change. -- To view, visit https://gerrit.ovirt.org/49807 To unsubscrib

Change in vdsm[master]: coverage: Add vdsm-coverage sub package

2015-12-06 Thread automation
gerrit-hooks has posted comments on this change. Change subject: coverage: Add vdsm-coverage sub package .. Patch Set 5: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header match

Change in vdsm[master]: coverage: Add vdsm-coverage sub package

2015-12-06 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: coverage: Add vdsm-coverage sub package .. Patch Set 4: (5 comments) https://gerrit.ovirt.org/#/c/49807/4/coverage/README.md File coverage/README.md: Line 25: Run

Change in vdsm[master]: coverage: Add vdsm-coverage sub package

2015-12-06 Thread sbonazzo
Sandro Bonazzola has posted comments on this change. Change subject: coverage: Add vdsm-coverage sub package .. Patch Set 4: (5 comments) See inline comments https://gerrit.ovirt.org/#/c/49807/4/coverage/README.md File covera

Change in vdsm[master]: coverage: Add vdsm-coverage sub package

2015-12-05 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: coverage: Add vdsm-coverage sub package .. Patch Set 4: Verified+1 Tested installing the package, collecting coverage data and generating html and xml reports, as

Change in vdsm[master]: coverage: Add vdsm-coverage sub package

2015-12-05 Thread automation
gerrit-hooks has posted comments on this change. Change subject: coverage: Add vdsm-coverage sub package .. Patch Set 4: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header match

Change in vdsm[master]: coverage: Add vdsm-coverage sub package

2015-12-05 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: coverage: Add vdsm-coverage sub package .. Patch Set 3: Petr, you commented in line 13, but gerrit new ui does not show this comment, since the file has only 12 li

Change in vdsm[master]: coverage: Add vdsm-coverage sub package

2015-12-05 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: coverage: Add vdsm-coverage sub package .. Patch Set 3: (2 comments) https://gerrit.ovirt.org/#/c/49807/3/coverage/README.md File coverage/README.md: Line 13: Li

Change in vdsm[master]: coverage: Add vdsm-coverage sub package

2015-12-05 Thread pbalogh
Petr Balogh has posted comments on this change. Change subject: coverage: Add vdsm-coverage sub package .. Patch Set 3: (3 comments) https://gerrit.ovirt.org/#/c/49807/3/coverage/README.md File coverage/README.md: Line 17: Re

Change in vdsm[master]: coverage: Add vdsm-coverage sub package

2015-12-05 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: coverage: Add vdsm-coverage sub package .. Patch Set 3: (1 comment) https://gerrit.ovirt.org/#/c/49807/3/coverage/README.md File coverage/README.md: Line 4: Line

Change in vdsm[master]: coverage: Add vdsm-coverage sub package

2015-12-05 Thread automation
gerrit-hooks has posted comments on this change. Change subject: coverage: Add vdsm-coverage sub package .. Patch Set 3: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header match

Change in vdsm[master]: coverage: Add vdsm-coverage sub package

2015-12-05 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: coverage: Add vdsm-coverage sub package .. Patch Set 2: (1 comment) https://gerrit.ovirt.org/#/c/49807/2/coverage/README.md File coverage/README.md: Line 1: # Vds

Change in vdsm[master]: coverage: Add vdsm-coverage sub package

2015-12-05 Thread automation
gerrit-hooks has posted comments on this change. Change subject: coverage: Add vdsm-coverage sub package .. Patch Set 2: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header match

Change in vdsm[master]: coverage: Add vdsm-coverage sub package

2015-12-04 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: coverage: Add vdsm-coverage sub package .. Patch Set 1: Verified+1 Tested on rhel 7.2. Debian build not updated yet, planned for future patch. -- To view, visit

Change in vdsm[master]: coverage: Add vdsm-coverage sub package

2015-12-04 Thread automation
gerrit-hooks has posted comments on this change. Change subject: coverage: Add vdsm-coverage sub package .. Patch Set 1: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header match

Change in vdsm[master]: coverage: Add vdsm-coverage sub package

2015-12-04 Thread nsoffer
Nir Soffer has uploaded a new change for review. Change subject: coverage: Add vdsm-coverage sub package .. coverage: Add vdsm-coverage sub package Add vdsm-coverage package installing support files for creating code coverage re