automat...@ovirt.org has posted comments on this change.
Change subject: events: vm status notifications
..
Patch Set 13:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matc
automat...@ovirt.org has posted comments on this change.
Change subject: events: vm status notifications
..
Patch Set 14:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matc
Nir Soffer has posted comments on this change.
Change subject: events: vm status notifications
..
Patch Set 1:
(1 comment)
https://gerrit.ovirt.org/#/c/38937/1/vdsm/virt/vm.py
File vdsm/virt/vm.py:
Line 866: def _set_last
Piotr Kliczewski has posted comments on this change.
Change subject: events: vm status notifications
..
Patch Set 1:
(1 comment)
https://gerrit.ovirt.org/#/c/38937/1/vdsm/virt/vm.py
File vdsm/virt/vm.py:
Line 866: def _se
Michal Skrivanek has posted comments on this change.
Change subject: events: vm status notifications
..
Patch Set 12:
(1 comment)
https://gerrit.ovirt.org/#/c/38937/12/vdsm/virt/vm.py
File vdsm/virt/vm.py:
Line 392:
automat...@ovirt.org has posted comments on this change.
Change subject: events: vm status notifications
..
Patch Set 15:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matc
Piotr Kliczewski has posted comments on this change.
Change subject: events: vm status notifications
..
Patch Set 15: Verified+1
Verified by running vdsm with the latest engine change. Tested vm status
changes:
- starting a vm
Michal Skrivanek has posted comments on this change.
Change subject: events: vm status notifications
..
Patch Set 15:
(2 comments)
https://gerrit.ovirt.org/#/c/38937/15/vdsm/virt/vm.py
File vdsm/virt/vm.py:
Line 382:
Piotr Kliczewski has posted comments on this change.
Change subject: events: vm status notifications
..
Patch Set 15:
(2 comments)
https://gerrit.ovirt.org/#/c/38937/15/vdsm/virt/vm.py
File vdsm/virt/vm.py:
Line 382:
Piotr Kliczewski has posted comments on this change.
Change subject: events: vm status notifications
..
Patch Set 15:
(1 comment)
https://gerrit.ovirt.org/#/c/38937/15/vdsm/virt/vm.py
File vdsm/virt/vm.py:
Line 390:
Michal Skrivanek has posted comments on this change.
Change subject: events: vm status notifications
..
Patch Set 15:
(1 comment)
https://gerrit.ovirt.org/#/c/38937/15/vdsm/virt/vm.py
File vdsm/virt/vm.py:
Line 390:
automat...@ovirt.org has posted comments on this change.
Change subject: events: vm status notifications
..
Patch Set 16:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matc
Piotr Kliczewski has posted comments on this change.
Change subject: events: vm status notifications
..
Patch Set 16: Verified+1
Verified with latest engine changes containing events.
--
To view, visit https://gerrit.ovirt.or
automat...@ovirt.org has posted comments on this change.
Change subject: events: vm status notifications
..
Patch Set 17:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matc
automat...@ovirt.org has posted comments on this change.
Change subject: events: vm status notifications
..
Patch Set 18:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matc
automat...@ovirt.org has posted comments on this change.
Change subject: events: vm status notifications
..
Patch Set 19:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matc
Piotr Kliczewski has posted comments on this change.
Change subject: events: vm status notifications
..
Patch Set 19: Verified+1
Verified with the engine containing event changes to see that events are send
on vm status change
Piotr Kliczewski has posted comments on this change.
Change subject: events: vm status notifications
..
Patch Set 19:
(1 comment)
https://gerrit.ovirt.org/#/c/38937/19/vdsm/virt/vm.py
File vdsm/virt/vm.py:
Line 1181:
Piotr Kliczewski has posted comments on this change.
Change subject: events: vm status notifications
..
Patch Set 19:
(1 comment)
https://gerrit.ovirt.org/#/c/38937/19/vdsm/virt/vm.py
File vdsm/virt/vm.py:
Line 393:
automat...@ovirt.org has posted comments on this change.
Change subject: events: vm status notifications
..
Patch Set 20:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matc
Piotr Kliczewski has posted comments on this change.
Change subject: events: vm status notifications
..
Patch Set 20: Verified+1
Rebased and fixed 2 comments (removals). Copying verify flag from previous
patch set.
--
To vie
automat...@ovirt.org has posted comments on this change.
Change subject: events: vm status notifications
..
Patch Set 21:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matc
Yaniv Bronhaim has posted comments on this change.
Change subject: events: vm status notifications
..
Patch Set 21:
(2 comments)
https://gerrit.ovirt.org/#/c/38937/21/vdsm/virt/vm.py
File vdsm/virt/vm.py:
Line 303: el
Piotr Kliczewski has posted comments on this change.
Change subject: events: vm status notifications
..
Patch Set 21:
(2 comments)
https://gerrit.ovirt.org/#/c/38937/21/vdsm/virt/vm.py
File vdsm/virt/vm.py:
Line 303:
Michal Skrivanek has posted comments on this change.
Change subject: events: vm status notifications
..
Patch Set 21:
(3 comments)
https://gerrit.ovirt.org/#/c/38937/21/tests/vmfakelib.py
File tests/vmfakelib.py:
Line 57:
Piotr Kliczewski has posted comments on this change.
Change subject: events: vm status notifications
..
Patch Set 21:
(1 comment)
https://gerrit.ovirt.org/#/c/38937/21/tests/vmfakelib.py
File tests/vmfakelib.py:
Line 57:
automat...@ovirt.org has posted comments on this change.
Change subject: events: vm status notifications
..
Patch Set 22:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matc
Michal Skrivanek has posted comments on this change.
Change subject: events: vm status notifications
..
Patch Set 22: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/38937
To unsubscribe, visit https://gerrit.ovirt.or
Piotr Kliczewski has posted comments on this change.
Change subject: events: vm status notifications
..
Patch Set 22:
Build failure not related to this change.
--
To view, visit https://gerrit.ovirt.org/38937
To unsubscribe,
Michal Skrivanek has posted comments on this change.
Change subject: events: vm status notifications
..
Patch Set 21:
(1 comment)
https://gerrit.ovirt.org/#/c/38937/21/tests/vmfakelib.py
File tests/vmfakelib.py:
Line 57:
automat...@ovirt.org has posted comments on this change.
Change subject: events: vm status notifications
..
Patch Set 23:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matc
Vinzenz Feenstra has posted comments on this change.
Change subject: events: vm status notifications
..
Patch Set 23: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/38937
To unsubscribe, visit https://gerrit.ovirt.or
automat...@ovirt.org has posted comments on this change.
Change subject: events: vm status notifications
..
Patch Set 24:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matc
automat...@ovirt.org has posted comments on this change.
Change subject: events: vm status notifications
..
Patch Set 25:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matc
automat...@ovirt.org has posted comments on this change.
Change subject: events: vm status notifications
..
Patch Set 26:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matc
automat...@ovirt.org has posted comments on this change.
Change subject: events: vm status notifications
..
Patch Set 27:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matc
Dan Kenigsberg has posted comments on this change.
Change subject: events: vm status notifications
..
Patch Set 27:
(1 comment)
https://gerrit.ovirt.org/#/c/38937/27/vdsm/virt/vm.py
File vdsm/virt/vm.py:
Line 377:
Piotr Kliczewski has posted comments on this change.
Change subject: events: vm status notifications
..
Patch Set 27:
(1 comment)
https://gerrit.ovirt.org/#/c/38937/27/vdsm/virt/vm.py
File vdsm/virt/vm.py:
Line 377:
automat...@ovirt.org has posted comments on this change.
Change subject: events: vm status notifications
..
Patch Set 28:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matc
Piotr Kliczewski has posted comments on this change.
Change subject: events: vm status notifications
..
Patch Set 28: Verified+1
Added comment in the code. Copying verification flag.
--
To view, visit https://gerrit.ovirt.org
automat...@ovirt.org has posted comments on this change.
Change subject: events: vm status notifications
..
Patch Set 29:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matc
automat...@ovirt.org has posted comments on this change.
Change subject: events: vm status notifications
..
Patch Set 30:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matc
Francesco Romani has posted comments on this change.
Change subject: events: vm status notifications
..
Patch Set 30: Code-Review-1
(5 comments)
-1 for visibility. I'm way too late, so mostly suggestions. Feel free to ignore
Dan Kenigsberg has posted comments on this change.
Change subject: events: vm status notifications
..
Patch Set 30:
(1 comment)
https://gerrit.ovirt.org/#/c/38937/30/vdsm/virt/vm.py
File vdsm/virt/vm.py:
Line 396:
Piotr Kliczewski has posted comments on this change.
Change subject: events: vm status notifications
..
Patch Set 30:
(4 comments)
https://gerrit.ovirt.org/#/c/38937/30/tests/vmApiTests.py
File tests/vmApiTests.py:
Line 67:
Piotr Kliczewski has posted comments on this change.
Change subject: events: vm status notifications
..
Patch Set 30:
(1 comment)
https://gerrit.ovirt.org/#/c/38937/30/vdsm/virt/vm.py
File vdsm/virt/vm.py:
Line 377:
Piotr Kliczewski has posted comments on this change.
Change subject: events: vm status notifications
..
Patch Set 30:
(1 comment)
https://gerrit.ovirt.org/#/c/38937/30/tests/vmApiTests.py
File tests/vmApiTests.py:
Line 67:
L
automat...@ovirt.org has posted comments on this change.
Change subject: events: vm status notifications
..
Patch Set 31:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matc
Piotr Kliczewski has posted comments on this change.
Change subject: events: vm status notifications
..
Patch Set 31: Verified+1
Rebased and comments fixed. Verified by updating existing vdsm and starting,
suspending and resto
Francesco Romani has posted comments on this change.
Change subject: events: vm status notifications
..
Patch Set 31: Code-Review+1
Can't think of anything else, hence +1
--
To view, visit https://gerrit.ovirt.org/38937
To un
automat...@ovirt.org has posted comments on this change.
Change subject: events: vm status notifications
..
Patch Set 32:
* Update tracker::IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no Bug-Url found.
--
To view, visit
Dan Kenigsberg has posted comments on this change.
Change subject: events: vm status notifications
..
Patch Set 31: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/38937
To unsubscribe, visit https://gerrit.ovirt.org/
Dan Kenigsberg has submitted this change and it was merged.
Change subject: events: vm status notifications
..
events: vm status notifications
Whenever vm changes status we send notification to an engine with vmid
and new statu
Piotr Kliczewski has uploaded a new change for review.
Change subject: events: vm status notifications
..
events: vm status notifications
Whenever vm changes status we send notification to an engine with vmid
and new status.
C
automat...@ovirt.org has posted comments on this change.
Change subject: events: vm status notifications
..
Patch Set 1:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header match
Piotr Kliczewski has posted comments on this change.
Change subject: events: vm status notifications
..
Patch Set 1:
Verified with engine containing vm status updates via events. I tested creation
of a vm and suspending it. I
oVirt Jenkins CI Server has posted comments on this change.
Change subject: events: vm status notifications
..
Patch Set 1:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/16875/ : SUCCESS
http://jenkins.ov
Francesco Romani has posted comments on this change.
Change subject: events: vm status notifications
..
Patch Set 1:
(5 comments)
Surprisingly simple, but I need to think a bit more about the API (from the
client perspective
Piotr Kliczewski has posted comments on this change.
Change subject: events: vm status notifications
..
Patch Set 1:
(5 comments)
https://gerrit.ovirt.org/#/c/38937/1/tests/jsonRpcTests.py
File tests/jsonRpcTests.py:
Line 59:
oVirt Jenkins CI Server has posted comments on this change.
Change subject: events: vm status notifications
..
Patch Set 2:
Build Started (1/2) ->
http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/16952/
--
To view, visit
automat...@ovirt.org has posted comments on this change.
Change subject: events: vm status notifications
..
Patch Set 2:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header match
Piotr Kliczewski has posted comments on this change.
Change subject: events: vm status notifications
..
Patch Set 2:
Communication verified with latest engine (master). VM status changes are sent
very fast and sometimes db sta
oVirt Jenkins CI Server has posted comments on this change.
Change subject: events: vm status notifications
..
Patch Set 2:
Build Started (2/2) ->
http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/17125/
--
To view
oVirt Jenkins CI Server has posted comments on this change.
Change subject: events: vm status notifications
..
Patch Set 2:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/16952/ : SUCCESS
http://jenkins.ov
Michal Skrivanek has posted comments on this change.
Change subject: events: vm status notifications
..
Patch Set 2: Code-Review-1
(2 comments)
+1 for the direction this patch takes is good
-1 for visibility as we dont' want t
Piotr Kliczewski has posted comments on this change.
Change subject: events: vm status notifications
..
Patch Set 2:
(2 comments)
https://gerrit.ovirt.org/#/c/38937/2/vdsm/virt/vm.py
File vdsm/virt/vm.py:
Line 1578:
Michal Skrivanek has posted comments on this change.
Change subject: events: vm status notifications
..
Patch Set 2:
(2 comments)
https://gerrit.ovirt.org/#/c/38937/2/vdsm/virt/vm.py
File vdsm/virt/vm.py:
Line 1578:
Piotr Kliczewski has posted comments on this change.
Change subject: events: vm status notifications
..
Patch Set 2:
(1 comment)
https://gerrit.ovirt.org/#/c/38937/2/vdsm/virt/vm.py
File vdsm/virt/vm.py:
Line 1578:
Michal Skrivanek has posted comments on this change.
Change subject: events: vm status notifications
..
Patch Set 3:
(1 comment)
https://gerrit.ovirt.org/#/c/38937/3/vdsm/virt/vm.py
File vdsm/virt/vm.py:
Line 1524: if
oVirt Jenkins CI Server has posted comments on this change.
Change subject: events: vm status notifications
..
Patch Set 3:
Build Successful
http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/17572/ : SUCCESS
http://jenkin
automat...@ovirt.org has posted comments on this change.
Change subject: events: vm status notifications
..
Patch Set 3:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header match
oVirt Jenkins CI Server has posted comments on this change.
Change subject: events: vm status notifications
..
Patch Set 3:
Build Started (1/2) ->
http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/17572/
--
To view, visit
Piotr Kliczewski has posted comments on this change.
Change subject: events: vm status notifications
..
Patch Set 3:
(1 comment)
https://gerrit.ovirt.org/#/c/38937/3/vdsm/virt/vm.py
File vdsm/virt/vm.py:
Line 1524: if
oVirt Jenkins CI Server has posted comments on this change.
Change subject: events: vm status notifications
..
Patch Set 3:
Build Started (2/2) ->
http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/17746/
--
To view
automat...@ovirt.org has posted comments on this change.
Change subject: events: vm status notifications
..
Patch Set 5:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header match
oVirt Jenkins CI Server has posted comments on this change.
Change subject: events: vm status notifications
..
Patch Set 5:
Build Started (1/2) ->
http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/17944/
--
To view
oVirt Jenkins CI Server has posted comments on this change.
Change subject: events: vm status notifications
..
Patch Set 6:
Build Started (1/2) ->
http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/18038/
--
To view, visit
automat...@ovirt.org has posted comments on this change.
Change subject: events: vm status notifications
..
Patch Set 6:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header match
oVirt Jenkins CI Server has posted comments on this change.
Change subject: events: vm status notifications
..
Patch Set 6:
Build Started (2/2)
0 -> http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/1267/
--
To vie
oVirt Jenkins CI Server has posted comments on this change.
Change subject: events: vm status notifications
..
Patch Set 6:
Build Successful
http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/18038/ : SUCCESS
http://jenkin
Piotr Kliczewski has posted comments on this change.
Change subject: events: vm status notifications
..
Patch Set 3:
(1 comment)
https://gerrit.ovirt.org/#/c/38937/3/vdsm/virt/vm.py
File vdsm/virt/vm.py:
Line 1524: if
Piotr Kliczewski has posted comments on this change.
Change subject: events: vm status notifications
..
Patch Set 2:
(1 comment)
https://gerrit.ovirt.org/#/c/38937/2/vdsm/virt/vm.py
File vdsm/virt/vm.py:
Line 1578:
Michal Skrivanek has posted comments on this change.
Change subject: events: vm status notifications
..
Patch Set 3:
(1 comment)
another idea to explore. Not suggesting to change it right away.
https://gerrit.ovirt.org/#/c/38
Francesco Romani has posted comments on this change.
Change subject: events: vm status notifications
..
Patch Set 3:
(1 comment)
https://gerrit.ovirt.org/#/c/38937/3/vdsm/virt/vm.py
File vdsm/virt/vm.py:
Line 1524: if
automat...@ovirt.org has posted comments on this change.
Change subject: events: vm status notifications
..
Patch Set 7:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header match
oVirt Jenkins CI Server has posted comments on this change.
Change subject: events: vm status notifications
..
Patch Set 7:
Build Started (1/2) ->
http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/18082/
--
To view, visit
oVirt Jenkins CI Server has posted comments on this change.
Change subject: events: vm status notifications
..
Patch Set 7:
Build Started (2/2)
0 -> http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/1311/
--
To vie
Michal Skrivanek has posted comments on this change.
Change subject: events: vm status notifications
..
Patch Set 2:
(1 comment)
https://gerrit.ovirt.org/#/c/38937/2/vdsm/virt/vm.py
File vdsm/virt/vm.py:
Line 1578:
oVirt Jenkins CI Server has posted comments on this change.
Change subject: events: vm status notifications
..
Patch Set 7:
Build Successful
http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/18082/ : SUCCESS
http://jenkin
automat...@ovirt.org has posted comments on this change.
Change subject: events: vm status notifications
..
Patch Set 8:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header match
Piotr Kliczewski has posted comments on this change.
Change subject: events: vm status notifications
..
Patch Set 8: Verified+1
Verified by installing a host, creating vm and seeing events being processed by
the engine.
There
oVirt Jenkins CI Server has posted comments on this change.
Change subject: events: vm status notifications
..
Patch Set 8:
Build Started (1/2) ->
http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/18268/
--
To view, visit
oVirt Jenkins CI Server has posted comments on this change.
Change subject: events: vm status notifications
..
Patch Set 8:
Build Started (2/2)
0 -> http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/1498/
--
To vie
oVirt Jenkins CI Server has posted comments on this change.
Change subject: events: vm status notifications
..
Patch Set 8:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/18268/ : SUCCESS
http://jenkins.ov
automat...@ovirt.org has posted comments on this change.
Change subject: events: vm status notifications
..
Patch Set 9:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header match
automat...@ovirt.org has posted comments on this change.
Change subject: events: vm status notifications
..
Patch Set 10:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matc
Michal Skrivanek has posted comments on this change.
Change subject: events: vm status notifications
..
Patch Set 10:
(3 comments)
https://gerrit.ovirt.org/#/c/38937/10/vdsm/virt/vm.py
File vdsm/virt/vm.py:
Line 357:
Line 35
automat...@ovirt.org has posted comments on this change.
Change subject: events: vm status notifications
..
Patch Set 11:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matc
automat...@ovirt.org has posted comments on this change.
Change subject: events: vm status notifications
..
Patch Set 12:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matc
Piotr Kliczewski has posted comments on this change.
Change subject: events: vm status notifications
..
Patch Set 12: Verified+1
Verified by installing a host and running a vm to see sent events.
--
To view, visit https://ger
1 - 100 of 103 matches
Mail list logo