gerrit-hooks has posted comments on this change.
Change subject: hostdev: add is_assignable flag
..
Patch Set 6:
* Update tracker: IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no Bug-Url found.
--
To view, visit
Dan Kenigsberg has submitted this change and it was merged.
Change subject: hostdev: add is_assignable flag
..
hostdev: add is_assignable flag
is_assignable is new flag that uses underlying PCI_HEADER_TYPE.
We can only assign
Martin Polednik has posted comments on this change.
Change subject: hostdev: add is_assignable flag
..
Patch Set 5: Verified+1
tested on my host, reports
* true for non-pci devices
* true for pci endpoints
* false for pci
Francesco Romani has posted comments on this change.
Change subject: hostdev: add is_assignable flag
..
Patch Set 5: Code-Review+2
I think this is clear as it could be if we need to do this ourselves, without
libvirt aid.
--
gerrit-hooks has posted comments on this change.
Change subject: hostdev: add is_assignable flag
..
Patch Set 5:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches
Milan Zamazal has posted comments on this change.
Change subject: hostdev: add is_assignable flag
..
Patch Set 4: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/56291
To unsubscribe, visit
Martin Polednik has posted comments on this change.
Change subject: hostdev: add is_assignable flag
..
Patch Set 4:
(1 comment)
https://gerrit.ovirt.org/#/c/56291/4/lib/vdsm/hostdev.py
File lib/vdsm/hostdev.py:
Line 152:
Milan Zamazal has posted comments on this change.
Change subject: hostdev: add is_assignable flag
..
Patch Set 3:
(1 comment)
I can't judge the technical side, but codewise fine, except for wondering about
one style issue.
Francesco Romani has posted comments on this change.
Change subject: hostdev: add is_assignable flag
..
Patch Set 4: Code-Review+1
(1 comment)
we still need a readability aid, besides that looks OK. +2 on hold
gerrit-hooks has posted comments on this change.
Change subject: hostdev: add is_assignable flag
..
Patch Set 4:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches
Francesco Romani has posted comments on this change.
Change subject: hostdev: add is_assignable flag
..
Patch Set 3: Code-Review+1
(2 comments)
minor style nit, +2 on hold.
Martin Polednik has posted comments on this change.
Change subject: hostdev: add is_assignable flag
..
Patch Set 3: Verified+1
works as expected, reports 'false' for bridges (don't have cardbus available)
--
To view, visit
Martin Polednik has posted comments on this change.
Change subject: hostdev: add is_assignable flag
..
Patch Set 3:
BTW the tests should be improved as it seems that we won't get rid of config
space path easily, but as they
gerrit-hooks has posted comments on this change.
Change subject: hostdev: add is_assignable flag
..
Patch Set 3:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches
Martin Polednik has posted comments on this change.
Change subject: hostdev: add is_assignable flag
..
Patch Set 2:
(1 comment)
https://gerrit.ovirt.org/#/c/56291/2/lib/vdsm/hostdev.py
File lib/vdsm/hostdev.py:
PS2, Line
Francesco Romani has posted comments on this change.
Change subject: hostdev: add is_assignable flag
..
Patch Set 2: Code-Review+1
(1 comment)
partial ACK, one question inside.
gerrit-hooks has posted comments on this change.
Change subject: hostdev: add is_assignable flag
..
Patch Set 2:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches
Martin Polednik has uploaded a new change for review.
Change subject: hostdev: add is_assignable flag
..
hostdev: add is_assignable flag
is_assignable is new flag that uses underlying PCI_HEADER_TYPE.
We can only assign devices
gerrit-hooks has posted comments on this change.
Change subject: hostdev: add is_assignable flag
..
Patch Set 1:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches
19 matches
Mail list logo
